sr-dev March 2017

sr-dev@lists.kamailio.org

31 participants
270 discussions

git:master:a9d2cbc5: topos: removed unused ftag variable
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

Module: kamailio Branch: master Commit: a9d2cbc591f7e1da8743b3598576ef7753c5f32c URL: https://github.com/kamailio/kamailio/commit/a9d2cbc591f7e1da8743b3598576ef7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-03-13T15:16:23+01:00 topos: removed unused ftag variable - code was moved to a function --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/a9d2cbc591f7e1da8743b3598576ef7… Patch: https://github.com/kamailio/kamailio/commit/a9d2cbc591f7e1da8743b3598576ef7… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index f60867d..014ffc1 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -718,7 +718,6 @@ int tps_request_received(sip_msg_t *msg, int dialog) tps_data_t mtsd; tps_data_t stsd; str lkey; - str ftag; str nuri; uint32_t direction = TPS_DIR_DOWNSTREAM; int ret; @@ -807,7 +806,6 @@ int tps_response_received(sip_msg_t *msg) tps_data_t stsd; tps_data_t btsd; str lkey; - str ftag; uint32_t direction = TPS_DIR_DOWNSTREAM; LM_DBG("handling incoming response\n"); @@ -872,7 +870,6 @@ int tps_request_sent(sip_msg_t *msg, int dialog, int local) tps_data_t stsd; tps_data_t *ptsd; str lkey; - str ftag; str xuuid; uint32_t direction = TPS_DIR_DOWNSTREAM;

1 0

git:master:1980c2c3: db_text: rpc command query requires linux for open_memstream()
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

Module: kamailio Branch: master Commit: 1980c2c302f1dfd577391cafcc2849db7ff35a29 URL: https://github.com/kamailio/kamailio/commit/1980c2c302f1dfd577391cafcc2849d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-03-13T15:14:05+01:00 db_text: rpc command query requires linux for open_memstream() - use the os define to enable/disable it at compile time --- Modified: src/modules/db_text/db_text.c --- Diff: https://github.com/kamailio/kamailio/commit/1980c2c302f1dfd577391cafcc2849d… Patch: https://github.com/kamailio/kamailio/commit/1980c2c302f1dfd577391cafcc2849d… --- diff --git a/src/modules/db_text/db_text.c b/src/modules/db_text/db_text.c index eaeb408..96d3212 100644 --- a/src/modules/db_text/db_text.c +++ b/src/modules/db_text/db_text.c @@ -164,6 +164,7 @@ static const char *rpc_query_doc[2] = { /* rpc function implementations */ static void rpc_query(rpc_t *rpc, void *ctx) { +#ifdef __OS_linux str sql; db1_con_t *con; db1_res_t* _r; @@ -226,6 +227,9 @@ static void rpc_query(rpc_t *rpc, void *ctx) { end: dbt_close(con); +#else + rpc->fault(ctx, 500, "Command available on Linux only"); +#endif } static rpc_export_t rpc_methods[] = {

1 0

Re: [sr-dev] [kamailio/kamailio] db_text : add rpc command for live query (650858b)
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

@lazedo - yhe function open_memstream() seems to be unavailable for various *BSDs, MacOSX, Unix'es versions: * https://www.gnu.org/software/gnulib/manual/html_node/open_005fmemstream.html A solution would be to include an alternative implementation, like: * http://piumarta.com/software/memstream/ As a quick solution I am going to disable it for non-Linux. You can choose another variant and push into the git repo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/650858ba246eee589876ffb257b7312…

1 0

[kamailio/kamailio] kamailio segmentation fault - dialog RPC (#1032)
by pars3c1 13 Mar '17

13 Mar '17

Dear all, many times, when i call dialog_list on dialog module with jsonrpc, kamailio crash. The version i use is: 4.4.2 Thanks for any suggestion. ################################################## gdb list: (gdb) list 1661 lock_get( &profile->lock ); 1662 for ( i=0 ; i< profile->size ; i++ ) { 1663 ph = profile->entries[i].first; 1664 if(ph) { 1665 do { 1666 if ((!value || (STR_EQ(*value, ph->value))) && ph->dlg) { 1667 /* print dialog */ 1668 internal_rpc_print_dlg(rpc, c, ph->dlg, 0); 1669 } 1670 /* next */ ################################################## gdb info locals: (gdb) info locals profile = 0x7f2a5098fb40 ph = 0x0 i = 10 ################################################## #0 0x00007f2a706eb00a in internal_rpc_profile_print_dlgs (rpc=0x7f2a4fdf99a0, c=0x7f2a4fdf9940, profile_name=0x7fffb9fa8b10, value=0x0) at dialog.c:1666 1666 if ((!value || (STR_EQ(*value, ph->value))) && ph->dlg) { ################################################## The dump , with bt full is this : #0 0x00007f2a706eb00a in internal_rpc_profile_print_dlgs (rpc=0x7f2a4fdf99a0, c=0x7f2a4fdf9940, profile_name=0x7fffb9fa8b10, value=0x0) at dialog.c:1666 profile = 0x7f2a5098fb40 ph = 0x0 i = 10 #1 0x00007f2a706eb6e4 in rpc_profile_print_dlgs (rpc=0x7f2a4fdf99a0, c=0x7f2a4fdf9940) at dialog.c:1772 profile_name = {s = 0x1c78b00 "outbound", len = 8} value = {s = 0x0, len = 0} #2 0x00007f2a4fbe45c6 in jsonrpc_dispatch (msg=0x7fffb9fa9f10, s1=0x0, s2=0x0) at jsonrpc-s_mod.c:1091 rpce = 0x7f2a75609360 ctx = 0x7f2a4fdf9940 ret = 0 nj = 0x1c76af0 val = {s = 0x1c77b20 "dlg.profile_list", len = 16} __FUNCTION__ = "jsonrpc_dispatch" #3 0x000000000041f4ad in do_action (h=0x7fffb9fa9e30, a=0x7f2a75584700, msg=0x7fffb9fa9f10) at action.c:1054 ret = -5 v = 4288256 dst = {send_sock = 0x1b9fa9b23, to = {s = {sa_family = 14080, sa_data = "Xu*\177\000\000\b7Xu*\177\000"}, sin = { sin_family = 14080, sin_port = 30040, sin_addr = {s_addr = 32554}, sin_zero = "\b7Xu*\177\000"}, sin6 = { sin6_family = 14080, sin6_port = 30040, sin6_flowinfo = 32554, sin6_addr = {__in6_u = { __u6_addr8 = "\b7Xu*\177\000\000S \205\000\060\000\000", __u6_addr16 = {14088, 30040, 32554, 0, 8275, 133, 48, 0}, __u6_addr32 = {1968715528, 32554, 8724563, 48}}}, sin6_scope_id = 26}}, id = 0, proto = 16 '\020', send_flags = { f = 155 '\233', blst_imask = 250 '\372'}} tmp = 0x7fffb9fab700 "\t" new_uri = 0x0 end = 0x0 crt = 0x7fffb9fa92d0 "" cmd = 0x7f2a754adcc0 len = 0 user = 0 uri = {user = {s = 0x12c <Address 0x12c out of bounds>, len = 0}, passwd = {s = 0x7fffb9fa92d0 "", len = 1969341184}, host = { s = 0x7f2a75475010 "\001", len = 4742114}, port = {s = 0x0, len = 0}, params = { s = 0x98206f7473 <Address 0x98206f7473 out of bounds>, len = 1969341256}, sip_params = { s = 0x7fffb9fa91e0 "`\222\372\271\377\177", len = 6538286}, headers = {s = 0x1c2b6f0 "\300\300\302\001", len = 0}, port_no = 50838, proto = 30049, type = 32554, flags = 0, transport = {s = 0x0, len = -940795965}, ttl = {s = 0x0, len = 0}, user_param = {s = 0x6222286e00000000 <Address 0x6222286e00000000 out of bounds>, len = 577270895}, maddr = { s = 0x3a746e65696c6309 <Address 0x3a746e65696c6309 out of bounds>, len = 0}, method = {s = 0x75c5f0 "core", len = -1174760864}, lr = {s = 0x764661 "rval_destroy", len = 7718524}, r2 = {s = 0x7f2a7561c348 "\002", len = 1967607824}, gr = {s = 0x7fffb9fa91b8 "H\303au*\177", len = 1967607824}, transport_val = {s = 0x7f2a7561c300 "\300\004", len = 1969341256}, ttl_val = {s = 0x7f2a7557e200 "\020", len = -1174760316}, user_param_val = {s = 0x7f2a75583700 "\002", len = 1969341256}, maddr_val = {s = 0x416f00 "1\355I\211\321^H\211\342H\203\344\360PTI\307\300\060\336q", len = -1174751488}, method_val = { ---Type <return> to continue, or q <return> to quit--- s = 0x0, len = 0}, lr_val = {s = 0x7fffb9fa9260 "Ð’\372\271\377\177", len = 5581478}, r2_val = {s = 0x0, len = 0}, gr_val = { s = 0x3a28d <Address 0x3a28d out of bounds>, len = 1969177728}} next_hop = {user = {s = 0x1c2b6f0 "\300\300\302\001", len = 1969330344}, passwd = { s = 0x69692c22 <Address 0x69692c22 out of bounds>, len = 29537760}, host = { s = 0x400000000 <Address 0x400000000 out of bounds>, len = -1174761304}, port = { s = 0x71657228 <Address 0x71657228 out of bounds>, len = 1969342102}, params = {s = 0x0, len = 1}, sip_params = {s = 0x0, len = -1174761328}, headers = {s = 0x1 <Address 0x1 out of bounds>, len = 2}, port_no = 40672, proto = 47610, type = 32767, flags = 3120206016, transport = {s = 0x7a6563697220616c <Address 0x7a6563697220616c out of bounds>, len = 1701736297}, ttl = { s = 0x7f2a75580848 "\001", len = -1174760828}, user_param = {s = 0x7fffb9fa9f10 "\b\005", len = -1174757840}, maddr = { s = 0x65722e2e223a7069 <Address 0x65722e2e223a7069 out of bounds>, len = 1702129517}, method = {s = 0x7f2a7561c696 "/sip", len = 29855024}, lr = {s = 0x0, len = 0}, r2 = {s = 0x0, len = 0}, gr = {s = 0x500000004 <Address 0x500000004 out of bounds>, len = 4}, transport_val = {s = 0x400000004 <Address 0x400000004 out of bounds>, len = 6552774}, ttl_val = { s = 0x7fffb9fa9060 "", len = 1967607824}, user_param_val = {s = 0x1000001 <Address 0x1000001 out of bounds>, len = 1967607824}, maddr_val = {s = 0x7fffb9fa90b0 "\020PGu*\177", len = 1956545302}, method_val = {s = 0x0, len = 0}, lr_val = {s = 0x1000000 <Address 0x1000000 out of bounds>, len = 14985000}, r2_val = { s = 0x165e80 <Address 0x165e80 out of bounds>, len = 1792216}, gr_val = {s = 0x1ed710 <Address 0x1ed710 out of bounds>, len = 8}} u = 0x7f2a75583f30 port = 0 dst_host = 0x7f2a75583700 i = 32767 flags = 0 avp = 0x7fffb9fa9e30 st = {flags = 151652617, id = 29193, name = {n = 0, s = {s = 0x6e65090a00000000 <Address 0x6e65090a00000000 out of bounds>, len = -1174761256}, re = 0x6e65090a00000000}, avp = 0x7fffb9fa9000} sct = 0x7fffb9fa94d0 sjt = 0x7fffb9fa9f10 rve = 0x416f00 mct = 0x7fffb9fab700 rv = 0x92922726f727265 rv1 = 0x0 c1 = {cache_type = 3120205776, val_type = 32767, c = {avp_val = {n = -940803561, s = { s = 0x31c7ec7a17 "\213D$8H\201\304\070\002", len = -1174757616}, re = 0x31c7ec7a17}, pval = {rs = { s = 0x31c7ec7a17 "\213D$8H\201\304\070\002", len = -1174757616}, ri = -1174757840, flags = 32767}}, i2s = "vp(s:inserver_erPor)\","} s = {s = 0x1c2b6f0 "\300\300\302\001", len = 0} srevp = {0x0, 0x0} mod_f_params = {{type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, ---Type <return> to continue, or q <return> to quit--- select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}} __FUNCTION__ = "do_action" #4 0x000000000042c218 in run_actions (h=0x7fffb9fa9e30, a=0x7f2a75584700, msg=0x7fffb9fa9f10) at action.c:1549 t = 0x7f2a75584700 ret = -1 mod = 0x0 ms = 0 __FUNCTION__ = "run_actions" #5 0x000000000041f416 in do_action (h=0x7fffb9fa9e30, a=0x7f2a75585b10, msg=0x7fffb9fa9f10) at action.c:1045 ret = 1 v = 1 dst = {send_sock = 0x7fffb9fa9b50, to = {s = {sa_family = 64710, sa_data = "c\000\000\000\000\000\060\233\372\271\377\177\000"}, sin = {sin_family = 64710, sin_port = 99, sin_addr = {s_addr = 0}, sin_zero = "0\233\372\271\377\177\000"}, sin6 = { sin6_family = 64710, sin6_port = 99, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = "0\233\372\271\377\177\000\000Ù¨bu*\177\000", __u6_addr16 = {39728, 47610, 32767, 0, 43225, 30050, 32554, 0}, __u6_addr32 = {3120208688, 32767, 1969400025, 32554}}}, sin6_scope_id = 366}}, id = 10, proto = -24 '\350', send_flags = {f = 234 '\352', blst_imask = 98 'b'}} tmp = 0x1467562aa20 <Address 0x1467562aa20 out of bounds> new_uri = 0x7a0a02 "parse_headers" end = 0x79db5c "core: parser/msg_parser.c" crt = 0x40 <Address 0x40 out of bounds> cmd = 0x7f2a75475010 len = 1967607824 user = 32554 uri = {user = {s = 0x0, len = 0}, passwd = {s = 0x7fffb9fa9b70 "@\234\372\271\004", len = 6529985}, host = { s = 0x416f00 "1\355I\211\321^H\211\342H\203\344\360PTI\307\300\060\336q", len = -1174751488}, port = {s = 0x0, len = 0}, params = {s = 0x7fffb9fa9ba0 "p\234\372\271\377\177", len = 6661320}, sip_params = {s = 0x7fffb9fa99f0 "", len = 1967607824}, headers = {s = 0x0, len = 1967607824}, port_no = 39488, proto = 47610, type = 32767, flags = 6552774, transport = { s = 0x7fffb9fa9a20 "", len = 1967607824}, ttl = {s = 0x1000000 <Address 0x1000000 out of bounds>, len = 1967607824}, user_param = {s = 0x7fffb9fa9a70 "\240\232\372\271\377\177", len = 1956545302}, maddr = { s = 0x1ed710 <Address 0x1ed710 out of bounds>, len = 0}, method = {s = 0x1000000 <Address 0x1000000 out of bounds>, len = 14986448}, lr = {s = 0x1658d8 <Address 0x1658d8 out of bounds>, len = 1790768}, r2 = { s = 0x1ed710 <Address 0x1ed710 out of bounds>, len = 8}, gr = {s = 0x12e <Address 0x12e out of bounds>, len = 1967607824}, transport_val = {s = 0x14600000000 <Address 0x14600000000 out of bounds>, len = 1969417808}, ttl_val = { s = 0x7fffb9fa9aa0 "\240\233\372\271\377\177", len = 4742114}, user_param_val = {s = 0x0, len = 1967607824}, maddr_val = { s = 0x0, len = 0}, method_val = {s = 0x7fffb9fa9ba0 "p\234\372\271\377\177", len = 6534031}, lr_val = {s = 0x79d630 "core", len = 6552774}, r2_val = {s = 0x7fffb9fa9b00 "n\001", len = 1969417880}, gr_val = {s = 0x7f2a7562aa20 "", len = 1969399988}} next_hop = {user = {s = 0x7fffb9fa9820 "", len = 1967607824}, passwd = {s = 0x1000000 <Address 0x1000000 out of bounds>, len = 1967607824}, host = {s = 0x7fffb9fa9870 "\240\230", <incomplete sequence \372\271>, len = 1956545302}, port = { ---Type <return> to continue, or q <return> to quit--- s = 0x1c588e1 "\311\305\001", len = 0}, params = {s = 0x1000000 <Address 0x1000000 out of bounds>, len = 14986216}, sip_params = {s = 0x1659c0 <Address 0x1659c0 out of bounds>, len = 1969416936}, headers = {s = 0x7f2a7562aa20 "", len = 1969399993}, port_no = 301, proto = 0, type = ERROR_URI_T, flags = 0, transport = { s = 0x7f2a7562a8d9 "Content-Type: application/json-rpc\r\nCache-Control: no-cache\r\nPragma: no-cache\r\nUser-Agent: Java/1.8.0_121\r\nHost: \r\nAccept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2\r\nConn"..., len = 0}, ttl = { s = 0xb9fa98a0 <Address 0xb9fa98a0 out of bounds>, len = 1969416936}, user_param = {s = 0x0, len = 1967607824}, maddr = { s = 0x0, len = 0}, method = {s = 0x7fffb9fa99a0 "\240\233\372\271\377\177", len = 6534031}, lr = {s = 0x79d630 "core", len = 0}, r2 = {s = 0x0, len = 0}, gr = {s = 0x7fffb9fa9e7c "\260\f\222\017", len = -1174757736}, transport_val = { s = 0x79d630 "core", len = -1174757704}, ttl_val = {s = 0x7a0a10 "get_hdr_field", len = 7986012}, user_param_val = { s = 0xe8 <Address 0xe8 out of bounds>, len = 1967607824}, maddr_val = {s = 0x79d630 "core", len = 1969416864}, method_val = { s = 0x7a0a10 "get_hdr_field", len = 7986012}, lr_val = {s = 0xe8 <Address 0xe8 out of bounds>, len = 1967607824}, r2_val = { s = 0x7f2a75475010 "\001", len = 1969416864}, gr_val = {s = 0x7f2a7562eaa0 <incomplete sequence \350>, len = 1969399988}} u = 0x7f2a7562ee50 port = 0 dst_host = 0x80067e961 i = 0 flags = 0 avp = 0x7f2a75475010 st = {flags = 3120207856, id = 32767, name = {n = 1967607824, s = {s = 0x7f2a75475010 "\001", len = 1969239958}, re = 0x7f2a75475010}, avp = 0x7f2a75475010} sct = 0x4b9fa9c40 sjt = 0x79d630 rve = 0x7f2a75582f20 mct = 0x7fffb9fab700 rv = 0x63fcc6 rv1 = 0x0 c1 = {cache_type = 43, val_type = RV_NONE, c = {avp_val = {n = 0, s = {s = 0x0, len = 7718384}, re = 0x0}, pval = {rs = {s = 0x0, len = 7718384}, ri = 26, flags = 0}}, i2s = "\t\000\000\000\000\000\000\000huTu*\177\000\000\000\000\000\000\000"} s = {s = 0x7fffb9fa99f0 "", len = 1969239512} srevp = {0x3000000018, 0x7fffb9fa9ab0} mod_f_params = {{type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}, {type = NOSUBTYPE, u = {number = 0, string = 0x0, str = {s = 0x0, len = 0}, data = 0x0, attr = 0x0, select = 0x0}}} __FUNCTION__ = "do_action" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1032

2 2

git:4.4:f2b6cb7f: dialog: fix for rpc list dialogs release of the profile locks
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

Module: kamailio Branch: 4.4 Commit: f2b6cb7f94acd6fa3f9b802e86b09cde0903cd68 URL: https://github.com/kamailio/kamailio/commit/f2b6cb7f94acd6fa3f9b802e86b09cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-03-13T14:53:33+01:00 dialog: fix for rpc list dialogs release of the profile locks - reported by GH #1032 (cherry picked from commit c986a820042764fd7025be0a0766991181a0b0ea) (cherry picked from commit 28672ebc9dceb09221c720bdd052ac23f274580f) --- Modified: modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/f2b6cb7f94acd6fa3f9b802e86b09cd… Patch: https://github.com/kamailio/kamailio/commit/f2b6cb7f94acd6fa3f9b802e86b09cd… --- diff --git a/modules/dialog/dialog.c b/modules/dialog/dialog.c index 7d56cfc..ceaf08a 100644 --- a/modules/dialog/dialog.c +++ b/modules/dialog/dialog.c @@ -1676,8 +1676,8 @@ static void internal_rpc_profile_print_dlgs(rpc_t *rpc, void *c, str *profile_na ph=ph->next; }while(ph!=profile->entries[i].first); } - lock_release(&profile->lock); } + lock_release(&profile->lock); } /*

1 0

git:5.0:28672ebc: dialog: fix for rpc list dialogs release of the profile locks
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

Module: kamailio Branch: 5.0 Commit: 28672ebc9dceb09221c720bdd052ac23f274580f URL: https://github.com/kamailio/kamailio/commit/28672ebc9dceb09221c720bdd052ac2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-03-13T14:50:54+01:00 dialog: fix for rpc list dialogs release of the profile locks - reported by GH #1032 (cherry picked from commit c986a820042764fd7025be0a0766991181a0b0ea) --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/28672ebc9dceb09221c720bdd052ac2… Patch: https://github.com/kamailio/kamailio/commit/28672ebc9dceb09221c720bdd052ac2… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4879a48..c572deb 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1616,8 +1616,8 @@ static void internal_rpc_profile_print_dlgs(rpc_t *rpc, void *c, str *profile_na ph=ph->next; }while(ph!=profile->entries[i].first); } - lock_release(&profile->lock); } + lock_release(&profile->lock); } /*

1 0

git:master:c986a820: dialog: fix for rpc list dialogs release of the profile locks
by Daniel-Constantin Mierla 13 Mar '17

13 Mar '17

Module: kamailio Branch: master Commit: c986a820042764fd7025be0a0766991181a0b0ea URL: https://github.com/kamailio/kamailio/commit/c986a820042764fd7025be0a0766991… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-03-13T14:43:16+01:00 dialog: fix for rpc list dialogs release of the profile locks - reported by GH #1032 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/c986a820042764fd7025be0a0766991… Patch: https://github.com/kamailio/kamailio/commit/c986a820042764fd7025be0a0766991… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 4879a48..c572deb 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1616,8 +1616,8 @@ static void internal_rpc_profile_print_dlgs(rpc_t *rpc, void *c, str *profile_na ph=ph->next; }while(ph!=profile->entries[i].first); } - lock_release(&profile->lock); } + lock_release(&profile->lock); } /*

1 0

[kamailio/kamailio] 4.4 dmqfix backport (#1028)
by Julien Chavanton 10 Mar '17

10 Mar '17

Test in my lab You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1028 -- Commit Summary -- * dmq_usrloc: Use ruid for saving/updating contacts * dmq_usrloc: adjust locking sequence to avoid dead-lock -- File Changes -- M modules/dmq_usrloc/usrloc_sync.c (70) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1028.patch https://github.com/kamailio/kamailio/pull/1028.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1028

1 2

[kamailio/kamailio] topos inserts comma separated Via in OK (#1005)
by dryvoip 10 Mar '17

10 Mar '17

### Description When using topos, Kamailio corrupts the Via header in the OK packet sent when responding to an INVITE. For example, the following is observed in the OK: Via: SIP/2.0/UDP 1.2.3.4:5065;rport=5065;branch=abc,SIP/2.0/UDP 2.3.4.5:5060;branch=bcd Expected behaviour is to correctly insert two separate Via headers, as in the original INVITE: Via: SIP/2.0/UDP 1.2.3.4:5065;rport=5065;branch=abc Via: SIP/2.0/UDP 2.3.4.5:5060;branch=bcd ### Troubleshooting When not loading topos.so, OK packet is passed as expected. #### Reproduction Place a call with a dialog where multiple Via headers are present with topos.so loaded. Fully reproducible every time. ### Possible Solutions topos.so should reconstruct the Via header properly by inserting a separate Via header for each comma separated value it stores in the database. ### Additional Information ``` version: kamailio 4.4.5 (x86_64/linux) f98162 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f98162 compiled on 16:48:08 Jan 18 2017 with gcc 4.4.7 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1005

3 31

git:master:2812b693: rabbitmq: cleanup obsolete connection parameters
by Stefan Mititelu 09 Mar '17

09 Mar '17

Module: kamailio Branch: master Commit: 2812b693b0ef97e3d720ff0b8a2982eeae566d71 URL: https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e… Author: Stefan Mititelu <stefan.mititelu(a)onem.com> Committer: Stefan Mititelu <stefan.mititelu(a)onem.com> Date: 2017-03-09T10:47:00+02:00 rabbitmq: cleanup obsolete connection parameters REVERT ME if you really need the old module parameters and are not able to update to 'url'. --- Modified: src/modules/rabbitmq/README Modified: src/modules/rabbitmq/doc/rabbitmq_admin.xml Modified: src/modules/rabbitmq/rabbitmq.c --- Diff: https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e… Patch: https://github.com/kamailio/kamailio/commit/2812b693b0ef97e3d720ff0b8a2982e…

2 2

← Newer
1
...
15
16
17
18
19
20
21
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2017