sr-dev February 2017

sr-dev@lists.kamailio.org

29 participants
364 discussions

git:master:504699b6: pua_usrloc: free memory in case of failire in pua send_publish()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 504699b6c2f34fbf7db02f57909eefdffc6b8180 URL: https://github.com/kamailio/kamailio/commit/504699b6c2f34fbf7db02f57909eefd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T19:25:40+01:00 pua_usrloc: free memory in case of failire in pua send_publish() - related to GH #1001 --- Modified: src/modules/pua_usrloc/ul_publish.c --- Diff: https://github.com/kamailio/kamailio/commit/504699b6c2f34fbf7db02f57909eefd… Patch: https://github.com/kamailio/kamailio/commit/504699b6c2f34fbf7db02f57909eefd… --- diff --git a/src/modules/pua_usrloc/ul_publish.c b/src/modules/pua_usrloc/ul_publish.c index af135a8..59417c2 100644 --- a/src/modules/pua_usrloc/ul_publish.c +++ b/src/modules/pua_usrloc/ul_publish.c @@ -321,7 +321,7 @@ void ul_publish(ucontact_t* c, int type, void* param) print_publ(publ); if((error=_pu_pua.send_publish(publ))< 0) { - LM_ERR("while sending publish for ul event %d\n", type); + LM_ERR("failed sending publish for ul event %d\n", type); if((type & UL_CONTACT_UPDATE) && error == ERR_PUBLISH_NO_BODY) { /* This error can occur if Kamailio was restarted/stopped and for any reason couldn't store a pua * entry in 'pua' DB table. It can also occur if 'pua' table is cleaned externally while Kamailio @@ -334,19 +334,16 @@ void ul_publish(ucontact_t* c, int type, void* param) * previous one expires), but this is a minor issue. */ LM_ERR("UPDATE action generated a PUBLISH without body -> invoking INSERT action\n"); ul_publish(c, UL_CONTACT_INSERT, param); - return; + goto error; } } - pua_ul_publish= 0; - error: - + pua_ul_publish = 0; if(publ) pkg_free(publ); - if(body) - { + if(body) { if(body->s) xmlFree(body->s); pkg_free(body); @@ -354,7 +351,6 @@ void ul_publish(ucontact_t* c, int type, void* param) if(uri.s) pkg_free(uri.s); - pua_ul_publish= 0; return; }

7 years, 10 months

git:master:c027c6d3: pua_usrloc: removed old svn ids

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c027c6d32f1c0add72ab00c14885d46bd1b7d485 URL: https://github.com/kamailio/kamailio/commit/c027c6d32f1c0add72ab00c14885d46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T19:25:40+01:00 pua_usrloc: removed old svn ids --- Modified: src/modules/pua_usrloc/api.h Modified: src/modules/pua_usrloc/pua_usrloc.c Modified: src/modules/pua_usrloc/pua_usrloc.h Modified: src/modules/pua_usrloc/ul_publish.c --- Diff: https://github.com/kamailio/kamailio/commit/c027c6d32f1c0add72ab00c14885d46… Patch: https://github.com/kamailio/kamailio/commit/c027c6d32f1c0add72ab00c14885d46…

7 years, 10 months

[kamailio/kamailio] websocket: X-Forwarded-For and X-Real-IP support (#1002)

by Michael Ricordeau

New feature to get the real source IP when kamailio websocket is behind a load balancer transmitting X-Forwarded-For and/or X-Real-IP headers: Detect HTTP headers X-Forwarded-For and X-Real-IP during the Websocket handshake. The pseudo variables $ws_real_src_ip is populated during ws_handshake() or null if not set. $ws_real_src_ip is indeed readonly. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1002 -- Commit Summary -- * websocket: X-Forwarded-For and X-Real-IP support -- File Changes -- M src/modules/websocket/websocket.c (40) M src/modules/websocket/ws_conn.h (2) M src/modules/websocket/ws_handshake.c (51) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1002.patch https://github.com/kamailio/kamailio/pull/1002.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1002

7 years, 10 months

git:master:304d1cf1: ndb_redis: export functions via inter-module api

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 304d1cf1babdb6925731f6974edf84d3796753c5 URL: https://github.com/kamailio/kamailio/commit/304d1cf1babdb6925731f6974edf84d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T15:34:44+01:00 ndb_redis: export functions via inter-module api - allow other modules to work with same pool of connections managed by this module --- Added: src/modules/ndb_redis/api.h Modified: src/modules/ndb_redis/ndb_redis_mod.c Modified: src/modules/ndb_redis/redis_client.c Modified: src/modules/ndb_redis/redis_client.h --- Diff: https://github.com/kamailio/kamailio/commit/304d1cf1babdb6925731f6974edf84d… Patch: https://github.com/kamailio/kamailio/commit/304d1cf1babdb6925731f6974edf84d…

7 years, 10 months

git:master:9ac5de5e: ndb_redis: removed svn ids

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9ac5de5e1d8bec9efa3c7325200fda69b3d2e3e9 URL: https://github.com/kamailio/kamailio/commit/9ac5de5e1d8bec9efa3c7325200fda6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T14:26:43+01:00 ndb_redis: removed svn ids - some bits of formatting --- Modified: src/modules/ndb_redis/ndb_redis_mod.c Modified: src/modules/ndb_redis/redis_client.c Modified: src/modules/ndb_redis/redis_client.h --- Diff: https://github.com/kamailio/kamailio/commit/9ac5de5e1d8bec9efa3c7325200fda6… Patch: https://github.com/kamailio/kamailio/commit/9ac5de5e1d8bec9efa3c7325200fda6…

7 years, 10 months

git:master:12a93645: tm: funcs - updated log messages to new macros

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 12a9364526053734f97792d540503d9b66e4b85b URL: https://github.com/kamailio/kamailio/commit/12a9364526053734f97792d540503d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T13:13:03+01:00 tm: funcs - updated log messages to new macros --- Modified: src/modules/tm/t_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/12a9364526053734f97792d540503d9… Patch: https://github.com/kamailio/kamailio/commit/12a9364526053734f97792d540503d9…

7 years, 10 months

git:master:4020ced0: kamctl: regenerated the dbschema scripts

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4020ced0d5802da0bc90114c885a8449c6f83607 URL: https://github.com/kamailio/kamailio/commit/4020ced0d5802da0bc90114c885a844… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-02-20T12:50:35+01:00 kamctl: regenerated the dbschema scripts --- Modified: utils/kamctl/db_sqlite/dialplan-create.sql Modified: utils/kamctl/mysql/dialplan-create.sql Modified: utils/kamctl/oracle/dialplan-create.sql Modified: utils/kamctl/postgres/dialplan-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/4020ced0d5802da0bc90114c885a844… Patch: https://github.com/kamailio/kamailio/commit/4020ced0d5802da0bc90114c885a844… --- diff --git a/utils/kamctl/db_sqlite/dialplan-create.sql b/utils/kamctl/db_sqlite/dialplan-create.sql index 0d96200..e6a6b0a 100644 --- a/utils/kamctl/db_sqlite/dialplan-create.sql +++ b/utils/kamctl/db_sqlite/dialplan-create.sql @@ -6,7 +6,7 @@ CREATE TABLE dialplan ( match_exp VARCHAR(64) NOT NULL, match_len INTEGER NOT NULL, subst_exp VARCHAR(64) NOT NULL, - repl_exp VARCHAR(64) NOT NULL, + repl_exp VARCHAR(256) NOT NULL, attrs VARCHAR(64) NOT NULL ); diff --git a/utils/kamctl/mysql/dialplan-create.sql b/utils/kamctl/mysql/dialplan-create.sql index 41c7675..e9198a4 100644 --- a/utils/kamctl/mysql/dialplan-create.sql +++ b/utils/kamctl/mysql/dialplan-create.sql @@ -6,7 +6,7 @@ CREATE TABLE `dialplan` ( `match_exp` VARCHAR(64) NOT NULL, `match_len` INT(11) NOT NULL, `subst_exp` VARCHAR(64) NOT NULL, - `repl_exp` VARCHAR(64) NOT NULL, + `repl_exp` VARCHAR(256) NOT NULL, `attrs` VARCHAR(64) NOT NULL ); diff --git a/utils/kamctl/oracle/dialplan-create.sql b/utils/kamctl/oracle/dialplan-create.sql index 2a1226c..24d70cd 100644 --- a/utils/kamctl/oracle/dialplan-create.sql +++ b/utils/kamctl/oracle/dialplan-create.sql @@ -6,7 +6,7 @@ CREATE TABLE dialplan ( match_exp VARCHAR2(64), match_len NUMBER(10), subst_exp VARCHAR2(64), - repl_exp VARCHAR2(64), + repl_exp VARCHAR2(256), attrs VARCHAR2(64) ); diff --git a/utils/kamctl/postgres/dialplan-create.sql b/utils/kamctl/postgres/dialplan-create.sql index 72ff00b..584779e 100644 --- a/utils/kamctl/postgres/dialplan-create.sql +++ b/utils/kamctl/postgres/dialplan-create.sql @@ -6,7 +6,7 @@ CREATE TABLE dialplan ( match_exp VARCHAR(64) NOT NULL, match_len INTEGER NOT NULL, subst_exp VARCHAR(64) NOT NULL, - repl_exp VARCHAR(64) NOT NULL, + repl_exp VARCHAR(256) NOT NULL, attrs VARCHAR(64) NOT NULL );

7 years, 10 months

Cleaning wiki accounts

by Daniel-Constantin Mierla

Hello, I noticed a lot of random usernames for the accounts created to edit the wiki. Apart of several which did some which did some edits to add spam, most of them are inactive. Not sure what would be the real purpose behind them, but I am going to remove anything that doesn't look as a community user. Shall I remove an account with random id, but for a good user, let me know, it can be readded/account recreated. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com

7 years, 10 months

[kamailio/kamailio] dialog: crash when trying to print error info (#807)

by Victor Seva

``` Reading symbols from kamailio...Reading symbols from /usr/lib/debug/.build-id/10/824757bd1066806f2e19310929e17a9009a991.debug...done. done. [New LWP 5578] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -f /etc/kamailio/proxy/kamailio.cfg -P /var/run/kamailio/kam'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f4871c9adcc in vfprintf () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) bt #0 0x00007f4871c9adcc in vfprintf () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007f4871d34466 in __vsyslog_chk () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007f4871d345bf in syslog () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007f485b71d796 in dlg_onroute (req=0x7f4866d8e5f0, route_params=0x7fffff82, param=0x7ffceb21fd60) at dlg_handlers.c:1336 #4 0x00007f48632aa2cd in run_rr_callbacks (req=0x7f4866d8e5f0, rr_param=0x7f48634bd8d0 <routed_params>) at rr_cb.c:96 #5 0x00007f486329e051 in after_loose (_m=0x7f4866d8e5f0, preloaded=2) at loose.c:914 #6 0x0000000000446700 in do_action (h=0x7ffceb220830, a=0x7f4865d1f1a0, msg=0x7f4866d8e5f0) at action.c:1060 #7 0x00000000004451c5 in run_actions (h=0x6, h@entry=0x7ffceb220830, a=0x7fffff82, msg=0x7ffceb21fd60) at action.c:1549 #8 0x0000000000451b97 in run_actions_safe (h=0x7ffceb221b00, a=<optimized out>, msg=<optimized out>) at action.c:1614 #9 0x0000000000426d20 in rval_get_int (h=0x7ffceb221b00, msg=0x6, i=0x7ffceb220b60, rv=0xffffffffffffffff, cache=0x6) at rvalue.c:912 #10 0x000000000042caac in rval_expr_eval_int (h=0x7ffceb221b00, msg=0x7f4866d8e5f0, res=0x7ffceb220b60, rve=0x7f4865d1f2d0) at rvalue.c:1910 #11 0x0000000000446bd7 in do_action (h=0x7ffceb221b00, a=0x7f4865d6c508, msg=0x7f4866d8e5f0) at action.c:1030 #12 0x00000000004451c5 in run_actions (h=0x6, a=0x7fffff82, msg=0x7ffceb21fd60) at action.c:1549 #13 0x0000000000446df0 in do_action (h=0x7ffceb221b00, a=0x7f4866624370, msg=0x7f4866d8e5f0) at action.c:678 #14 0x00000000004451c5 in run_actions (h=0x6, a=0x7fffff82, msg=0x7ffceb21fd60) at action.c:1549 #15 0x0000000000446c28 in do_action (h=0x7ffceb221b00, a=0x7f4866cbbe10, msg=0x7f4866d8e5f0) at action.c:1049 #16 0x00000000004451c5 in run_actions (h=0x6, h@entry=0x7ffceb221b00, a=0x7fffff82, a@entry=0x7f4866c6a758, msg=0x7ffceb21fd60, msg@entry=0x7f4866d8e5f0) at action.c:1549 #17 0x0000000000451c35 in run_top_route (a=0x7f4866c6a758, msg=0x7f4866d8e5f0, c=<optimized out>) at action.c:1635 #18 0x000000000055b4ae in receive_msg (buf=0x0, len=1725490672, rcv_info=0x7ffceb221de0) at receive.c:240 #19 0x000000000047abe0 in udp_rcv_loop () at udp_server.c:495 #20 0x000000000050360e in main_loop () at main.c:1600 #21 0x000000000041cdbc in main (argc=0, argv=0x0) at main.c:2616 (gdb) f 3 #3 0x00007f485b71d796 in dlg_onroute (req=0x7f4866d8e5f0, route_params=0x7fffff82, param=0x7ffceb21fd60) at dlg_handlers.c:1336 1336 dlg_handlers.c: No such file or directory. ``` relevant code: https://github.com/kamailio/kamailio/blob/4.4/modules/dialog/dlg_handlers.c… ``` /* run actions for the transition */ if (event==DLG_EVENT_REQBYE && new_state==DLG_STATE_DELETED && old_state!=DLG_STATE_DELETED) { LM_DBG("BYE successfully processed\n"); /* remove from timer */ ret = remove_dialog_timer(&dlg->tl); if (ret < 0) { LM_CRIT("unable to unlink the timer on dlg %p [%u:%u] " "with clid '%.*s' and tags '%.*s' '%.*s'\n", dlg, dlg->h_entry, dlg->h_id, dlg->callid.len, dlg->callid.s, dlg->tag[DLG_CALLER_LEG].len, dlg->tag[DLG_CALLER_LEG].s, dlg->tag[DLG_CALLEE_LEG].len, dlg->tag[DLG_CALLEE_LEG].s); } else if (ret > 0) { ``` ``` (gdb) p dlg $1 = (dlg_cell_t *) 0x7f47c4c7d560 (gdb) p *dlg $2 = {ref = -419086585, next = 0x7f47c4c7d598, prev = 0xa, h_id = 2, h_entry = 0, state = 3301430691, lifetime = 32583, init_ts = 3, start_ts = 0, end_ts = 1475139409, dflags = 32583, iflags = 1601467251, sflags = 1650552421, toroute = 2030069100, toroute_name = {s = 0x58 <error: Cannot access memory at address 0x58>, len = 0}, from_rr_nb = 0, tl = {next = 0x0, prev = 0x6eaf61, timeout = 7257938}, callid = {s = 0x6acfa0 "core", len = 94}, from_uri = {s = 0x7f47f0f0f0f0 "", len = -1005795570}, to_uri = { s = 0x7f47c4c7d628 "sst_refresh_method", len = 18}, req_uri = {s = 0x2 <error: Cannot access memory at address 0x2>, len = -993536453}, tag = {{ s = 0x6 <error: Cannot access memory at address 0x6>, len = -993536672}, {s = 0x726665725f747373 <error: Cannot access memory at address 0x726665725f747373>, len = 1600680805}}, cseq = {{s = 0x5449564e4900646f <error: Cannot access memory at address 0x5449564e4900646f>, len = 69}, { s = 0xc0 <error: Cannot access memory at address 0xc0>, len = 0}}, route_set = {{s = 0x0, len = 0}, {s = 0x6eaf61 "core: xavp.c", len = 7257938}}, contact = {{ s = 0x6acfa0 "core", len = 94}, {s = 0x7f47f0f0f0f0 "", len = 2060094989}}, bind_addr = {0x7f47c4c7d6c8, 0x12}, cbs = {first = 0x2, types = -993536293}, profile_links = 0x3, vars = 0x7f47c4c7d5f0} (gdb) p dlg->callid $3 = {s = 0x6acfa0 "core", len = 94} (gdb) p dlg->tag[0] $4 = {s = 0x6 <error: Cannot access memory at address 0x6>, len = -993536672} (gdb) p dlg->tag[1] $5 = {s = 0x726665725f747373 <error: Cannot access memory at address 0x726665725f747373>, len = 1600680805} ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/807

7 years, 10 months

[kamailio/kamailio] siptrace: sip_trace() a modified packet (#965)

by Jared Hull

http://www.kamailio.org/docs/modules/4.2.x/modules/siptrace.html#siptrace.f… "Store or forward the current processed SIP message in database. **It is stored in the form prior applying changes made to it.**" Could the functionality of sip_trace be extended to trace a packet again after it has been modified? My setup is a bit like this: Remote device -> Kamailio -> containerised Asterisk I am sip_trace'ing all packets, but then modifying them a bit before forwarding them to Asterisk. Yet only the original packet is sent to HOMER. Because of this, I can only see the the Remote device -> Kamailio bits of the sequence diagram showing the SIP transaction. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/965

7 years, 10 months

← Newer
1
...
10
11
12
13
14
15
16
...
37
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2017