sr-dev December 2017

sr-dev@lists.kamailio.org

26 participants
475 discussions

git:5.1:cd8a9d42: pkg/kamailio/deb: version set to 5.1.0~rc3
by Victor Seva 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: cd8a9d4225d95a358fc901ebec58ee0aa83aecbb URL: https://github.com/kamailio/kamailio/commit/cd8a9d4225d95a358fc901ebec58ee0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-12-04T11:40:36+01:00 pkg/kamailio/deb: version set to 5.1.0~rc3 --- Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/cd8a9d4225d95a358fc901ebec58ee0… Patch: https://github.com/kamailio/kamailio/commit/cd8a9d4225d95a358fc901ebec58ee0… --- diff --git a/pkg/kamailio/deb/buster/changelog b/pkg/kamailio/deb/buster/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/buster/changelog +++ b/pkg/kamailio/deb/buster/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/debian/changelog b/pkg/kamailio/deb/debian/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/debian/changelog +++ b/pkg/kamailio/deb/debian/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/jessie/changelog b/pkg/kamailio/deb/jessie/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/jessie/changelog +++ b/pkg/kamailio/deb/jessie/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/precise/changelog b/pkg/kamailio/deb/precise/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/precise/changelog +++ b/pkg/kamailio/deb/precise/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/sid/changelog b/pkg/kamailio/deb/sid/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/sid/changelog +++ b/pkg/kamailio/deb/sid/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/stretch/changelog b/pkg/kamailio/deb/stretch/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/stretch/changelog +++ b/pkg/kamailio/deb/stretch/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/trusty/changelog b/pkg/kamailio/deb/trusty/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/trusty/changelog +++ b/pkg/kamailio/deb/trusty/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/wheezy/changelog b/pkg/kamailio/deb/wheezy/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/wheezy/changelog +++ b/pkg/kamailio/deb/wheezy/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2 diff --git a/pkg/kamailio/deb/xenial/changelog b/pkg/kamailio/deb/xenial/changelog index ffe4d96e9a..5e3dfe07e0 100644 --- a/pkg/kamailio/deb/xenial/changelog +++ b/pkg/kamailio/deb/xenial/changelog @@ -1,3 +1,9 @@ +kamailio (5.1.0~rc3) unstable; urgency=medium + + * version set to 5.1.0~rc3 + + -- Victor Seva <vseva(a)debian.org> Mon, 04 Dec 2017 11:38:41 +0100 + kamailio (5.1.0~rc2) unstable; urgency=medium * version set to 5.1.0~rc2

1 0

Multiple memleaks and segfauts in Kamailio v5.0.4
by M S 04 Dec '17

04 Dec '17

Hi, I have kamailio v5.0.4 git rev. 5f26a4e8c55cdf5a5a7eaf6864c4f5213d321293 installed on 32bit Debian Wheezy virtual machine (1GB RAM and 1 vCPU) for development and testing of a project. We need to inspect sip traces to / from webrtc endpoint on kamailio side, for which we use siptrace module with following config, # ----- siptrace params ----- modparam("siptrace", "trace_on", 1) modparam("siptrace", "hep_mode_on", 0) modparam("siptrace", "xheaders_write", 1) modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_flag", FLT_SIP_TRACE) modparam("siptrace", "traced_user_avp", "$avp(traced_user)") modparam("siptrace", "duplicate_uri", "WEBRTC_SIP_TRACE_ADDRESS") We observed multiple problems of memleaks and segfaults, here is a summary, 1. Calling sip_trace method without any arguements or with only one arguement (duplicate uri) crashes kamailio with segfault. https://kamailio.org/docs/modules/5.0.x/modules/siptrace.html#siptrace.f.si… 2. To avoid segfault, either I have to specify both args (i am not sure what to set as 2nd arg, so i used "$ci" for it) OR disable "xheaders_write" module param. However, this causes slow memory leak and in about 48 hours kamailio runs out of memory (sip traffic is less then 10 concurrent users) https://kamailio.org/docs/modules/5.0.x/modules/siptrace.html#siptrace.p.xh… 3. If we remove siptrace module and use "network:msg" event route in corex module with "send_data" method then we ran in to PV buffer overflow problem (webrtc invites are very big > 10KB). So, I increased "pv_buffer_size" to 16K and "pv_buffer_slots" to 12. Which again crashes kamailio with segfault. https://kamailio.org/docs/modules/5.0.x/modules/corex.html#async.evr.networ… https://kamailio.org/docs/modules/5.0.x/modules/corex.html#corex.f.send_data http://www.kamailio.org/wiki/cookbooks/4.1.x/core#pv_buffer_size http://www.kamailio.org/wiki/cookbooks/4.1.x/core#pv_buffer_slots Removing "pv_buffer_slots" from config fixes the crash problem, and right now we are observing kamailio if stays stable. Thank you.

3 6

git:5.0:2ad024fb: core: pv - use active values for pv buffer slots and size
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.0 Commit: 2ad024fb3e38823af8668d73d0a64be1f18697f3 URL: https://github.com/kamailio/kamailio/commit/2ad024fb3e38823af8668d73d0a64be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:42:37+01:00 core: pv - use active values for pv buffer slots and size - during startup, param value and active can be different, up to the moment when the config is completely loaded (cherry picked from commit a156c625b434dc0bc19c43ece524f90b1179d881) (cherry picked from commit 3929986622b502660b870916bcd7f015282a6a1c) --- Modified: src/core/pvapi.c --- Diff: https://github.com/kamailio/kamailio/commit/2ad024fb3e38823af8668d73d0a64be… Patch: https://github.com/kamailio/kamailio/commit/2ad024fb3e38823af8668d73d0a64be… --- diff --git a/src/core/pvapi.c b/src/core/pvapi.c index 7e3d7b9b4b..97c23df539 100644 --- a/src/core/pvapi.c +++ b/src/core/pvapi.c @@ -2032,7 +2032,8 @@ char* pv_get_buffer(void) char *p; p = _pv_print_buffer[_pv_print_buffer_index]; - _pv_print_buffer_index = (_pv_print_buffer_index+1)%_pv_print_buffer_slots; + _pv_print_buffer_index = (_pv_print_buffer_index+1) + % _pv_print_buffer_slots_active; return p; } @@ -2042,7 +2043,7 @@ char* pv_get_buffer(void) */ int pv_get_buffer_size(void) { - return _pv_print_buffer_size; + return _pv_print_buffer_size_active; } /** @@ -2050,7 +2051,7 @@ int pv_get_buffer_size(void) */ int pv_get_buffer_slots(void) { - return _pv_print_buffer_slots; + return _pv_print_buffer_slots_active; } /**

1 0

git:5.1:cc11eac3: Makefile.defs: version set to 5.1.0-rc3
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: cc11eac314b6611285665dd5d15310b56a61e28c URL: https://github.com/kamailio/kamailio/commit/cc11eac314b6611285665dd5d15310b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:33:01+01:00 Makefile.defs: version set to 5.1.0-rc3 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/cc11eac314b6611285665dd5d15310b… Patch: https://github.com/kamailio/kamailio/commit/cc11eac314b6611285665dd5d15310b… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 4ad22ca7ff..df5ad7b8ff 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 1 SUBLEVEL = 0 -EXTRAVERSION = -rc2 +EXTRAVERSION = -rc3 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:5.1:39299866: core: pv - use active values for pv buffer slots and size
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: 3929986622b502660b870916bcd7f015282a6a1c URL: https://github.com/kamailio/kamailio/commit/3929986622b502660b870916bcd7f01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:27:09+01:00 core: pv - use active values for pv buffer slots and size - during startup, param value and active can be different, up to the moment when the config is completely loaded (cherry picked from commit a156c625b434dc0bc19c43ece524f90b1179d881) --- Modified: src/core/pvapi.c --- Diff: https://github.com/kamailio/kamailio/commit/3929986622b502660b870916bcd7f01… Patch: https://github.com/kamailio/kamailio/commit/3929986622b502660b870916bcd7f01… --- diff --git a/src/core/pvapi.c b/src/core/pvapi.c index 0e4d4d326f..64b9fd96ff 100644 --- a/src/core/pvapi.c +++ b/src/core/pvapi.c @@ -2105,7 +2105,8 @@ char* pv_get_buffer(void) char *p; p = _pv_print_buffer[_pv_print_buffer_index]; - _pv_print_buffer_index = (_pv_print_buffer_index+1)%_pv_print_buffer_slots; + _pv_print_buffer_index = (_pv_print_buffer_index+1) + % _pv_print_buffer_slots_active; return p; } @@ -2115,7 +2116,7 @@ char* pv_get_buffer(void) */ int pv_get_buffer_size(void) { - return _pv_print_buffer_size; + return _pv_print_buffer_size_active; } /** @@ -2123,7 +2124,7 @@ int pv_get_buffer_size(void) */ int pv_get_buffer_slots(void) { - return _pv_print_buffer_slots; + return _pv_print_buffer_slots_active; } /**

1 0

git:5.1:5aff4422: core: fix setting pv_cache_limit param
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: 5aff4422815f6842d8ecfd028451a13be22d7374 URL: https://github.com/kamailio/kamailio/commit/5aff4422815f6842d8ecfd028451a13… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:26:58+01:00 core: fix setting pv_cache_limit param (cherry picked from commit ef7398589aaff02d6521171ff569726db6996c6a) --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/5aff4422815f6842d8ecfd028451a13… Patch: https://github.com/kamailio/kamailio/commit/5aff4422815f6842d8ecfd028451a13… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index 4548d321f9..85105120b7 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -1556,11 +1556,11 @@ assign_stm: | MAX_WLOOPS EQUAL error { yyerror("number expected"); } | PVBUFSIZE EQUAL NUMBER { pv_set_buffer_size($3); } | PVBUFSIZE EQUAL error { yyerror("number expected"); } - | PVBUFSLOTS EQUAL NUMBER { default_core_cfg.pv_cache_limit=$3; } + | PVBUFSLOTS EQUAL NUMBER { pv_set_buffer_slots($3); } | PVBUFSLOTS EQUAL error { yyerror("number expected"); } - | PVCACHELIMIT EQUAL NUMBER { default_core_cfg.pv_cache_action=$3; } + | PVCACHELIMIT EQUAL NUMBER { default_core_cfg.pv_cache_limit=$3; } | PVCACHELIMIT EQUAL error { yyerror("number expected"); } - | PVCACHEACTION EQUAL NUMBER { pv_set_buffer_slots($3); } + | PVCACHEACTION EQUAL NUMBER { default_core_cfg.pv_cache_action=$3; } | PVCACHEACTION EQUAL error { yyerror("number expected"); } | HTTP_REPLY_PARSE EQUAL NUMBER { http_reply_parse=$3; } | HTTP_REPLY_PARSE EQUAL error { yyerror("boolean value expected"); }

1 0

git:5.1:83612695: test/unit: 3.sh - updates for using db root password with kamdbctl
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: 83612695acc49fae39d0abf8376747618a694012 URL: https://github.com/kamailio/kamailio/commit/83612695acc49fae39d0abf83767476… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:26:43+01:00 test/unit: 3.sh - updates for using db root password with kamdbctl (cherry picked from commit f5ea35bc424f34c64ee71a745db93326f597c4a1) --- Modified: test/unit/3.sh --- Diff: https://github.com/kamailio/kamailio/commit/83612695acc49fae39d0abf83767476… Patch: https://github.com/kamailio/kamailio/commit/83612695acc49fae39d0abf83767476… --- diff --git a/test/unit/3.sh b/test/unit/3.sh index 03c98b04fb..4b039ba9b0 100755 --- a/test/unit/3.sh +++ b/test/unit/3.sh @@ -20,10 +20,10 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Needs a mysql database, the root user password must be assigned to -# the 'PW' variable in the file 'dbrootpw' in the test directory, e.g.: -# PW=sql_root_passwd +# the 'DBROOTPW' variable in the file 'dbrootpw' in the test directory, e.g.: +# DBROOTPW=sql_root_passwd # If MySQL root password is empty, add in the file the line: -# PWSKIP=yes +# DBROOTPWSKIP=yes . include/common @@ -50,13 +50,13 @@ sed -i '' -e "s/TEST=\"false\"/TEST=\"true\"/g" $DBCTL # set the mysql root password cp $DBCTL.mysql $DBCTL.mysql.bak -sed -i '' -e "s/#PW=\"\"/PW=\"$PW\"/g" $DBCTL.mysql +sed -i '' -e "s/#DBROOTPW=\"\"/DBROOTPW=\"$DBROOTPW\"/g" $DBCTL.mysql -PWSKIP="$PWSKIP" CHARSET="latin1" ./$DBCTL create $tmp_name > /dev/null +DBROOTPWSKIP="$DBROOTPWSKIP" CHARSET="latin1" ./$DBCTL create $tmp_name > /dev/null ret=$? if [ "$ret" -eq 0 ] ; then - PWSKIP="$PWSKIP" ./$DBCTL drop $tmp_name > /dev/null + DBROOTPWSKIP="$DBROOTPWSKIP" ./$DBCTL drop $tmp_name > /dev/null ret=$? fi ;

1 0

git:5.1:ec7d89da: kamctl: expose db root password variable used by kamdbctl.mysql in kamctlrc
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: ec7d89da1cce4060969b4a7bd7db64ffa23c1b3d URL: https://github.com/kamailio/kamailio/commit/ec7d89da1cce4060969b4a7bd7db64f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:26:33+01:00 kamctl: expose db root password variable used by kamdbctl.mysql in kamctlrc - DBROOTPW can be now set in kamctlrc - targeting use for automatic testing (cherry picked from commit 313805136d22ed79d1c4900753247032240d5a5b) --- Modified: utils/kamctl/kamctlrc Modified: utils/kamctl/kamdbctl.mysql --- Diff: https://github.com/kamailio/kamailio/commit/ec7d89da1cce4060969b4a7bd7db64f… Patch: https://github.com/kamailio/kamailio/commit/ec7d89da1cce4060969b4a7bd7db64f… --- diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 6ac3cd4c2e..46fcdf5664 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -47,6 +47,11 @@ ## database super user (for ORACLE this is 'scheme-creator' user) # DBROOTUSER="root" +## password for database super user +## - important: this is insecure, targeting the use only for automatic testing +## - known to work for: mysql +# DBROOTPW="dbrootpw" + ## database character set (used by MySQL when creating database) #CHARSET="latin1" diff --git a/utils/kamctl/kamdbctl.mysql b/utils/kamctl/kamdbctl.mysql index 8d090fc7fe..422eed8beb 100644 --- a/utils/kamctl/kamdbctl.mysql +++ b/utils/kamctl/kamdbctl.mysql @@ -32,10 +32,10 @@ if [ -z "$DBROOTUSER" ]; then DBROOTUSER="root" fi -# Uncomment this to set the database root password if you want to run this -# script without any user prompt. This is unsafe, but useful e.g. for -# automatic testing. -#PW="" +# Set DBROOTPW in kamctlrc or via next line to set the database +# root password if you want to run this script without any user prompt. +# This is unsafe, but useful e.g. for automatic testing. +#DBROOTPW="" if [ -z "$DBPORT" ] ; then @@ -55,13 +55,13 @@ prompt_pw() savetty=`stty -g` echo -n "MySQL password for $DBROOTUSER: " stty -echo - read PW + read DBROOTPW stty $savetty echo - export PW + export DBROOTPW } -# execute sql command with optional db name +# execute sql command with optional db name # and password parameters given sql_query() { @@ -72,14 +72,14 @@ sql_query() DB="" fi shift - if [ -n "$PW" ]; then - $CMD "-p$PW" $DB -e "$@" + if [ -n "$DBROOTPW" ]; then + $CMD "-p$DBROOTPW" $DB -e "$@" else $CMD $DB -e "$@" fi else - if [ -n "$PW" ]; then - $CMD "-p$PW" "$@" + if [ -n "$DBROOTPW" ]; then + $CMD "-p$DBROOTPW" "$@" else $CMD "$@" fi @@ -106,9 +106,9 @@ kamailio_drop() # pars: <database name> db_charset_test() { - if [ -n "$PW" ]; then - CURRCHARSET=`echo "show variables like '%character_set_server%'" | $CMD "-p$PW" | $AWK '{print $2}' | $SED -e 1d` - ALLCHARSETS=`echo "show character set" | $CMD "-p$PW" | $AWK '{print $1}' | $SED -e 1d | $GREP -iv -e "utf8\|ucs2"` + if [ -n "$DBROOTPW" ]; then + CURRCHARSET=`echo "show variables like '%character_set_server%'" | $CMD "-p$DBROOTPW" | $AWK '{print $2}' | $SED -e 1d` + ALLCHARSETS=`echo "show character set" | $CMD "-p$DBROOTPW" | $AWK '{print $1}' | $SED -e 1d | $GREP -iv -e "utf8\|ucs2"` else CURRCHARSET=`echo "show variables like '%character_set_server%'" | $CMD | $AWK '{print $2}' | $SED -e 1d` ALLCHARSETS=`echo "show character set" | $CMD | $AWK '{print $1}' | $SED -e 1d | $GREP -iv -e "utf8\|ucs2"` @@ -386,7 +386,7 @@ migrate_table () # 4 paremeters (dst_table, dst_cols, src_table, src_cols) if [ $? -ne 0 ] ; then echo $X | $GREP "ERROR 1146" > /dev/null - if [ $? -eq 0 ] ; then + if [ $? -eq 0 ] ; then echo " -- Migrating $3 to $1.....SKIPPED (no source)" return 0 fi @@ -540,9 +540,9 @@ fi } #end migrate_db() -export PW -if [ "$#" -ne 0 ] && [ "$PW" = "" ]; then - if [ "$PWSKIP" = "" ]; then +export DBROOTPW +if [ "$#" -ne 0 ] && [ "$DBROOTPW" = "" ]; then + if [ "$DBROOTPWSKIP" = "" ]; then prompt_pw fi fi

1 0

git:5.1:b243f760: test/unit: 24.sh - removed invalid comment about mysql
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: b243f7605e25b4467c72f85bb10159af5bfa38ed URL: https://github.com/kamailio/kamailio/commit/b243f7605e25b4467c72f85bb10159a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:26:23+01:00 test/unit: 24.sh - removed invalid comment about mysql (cherry picked from commit ebe117cae681c373a3e9f32e3fb392e31605039f) --- Modified: test/unit/24.sh --- Diff: https://github.com/kamailio/kamailio/commit/b243f7605e25b4467c72f85bb10159a… Patch: https://github.com/kamailio/kamailio/commit/b243f7605e25b4467c72f85bb10159a… --- diff --git a/test/unit/24.sh b/test/unit/24.sh index 196bb9df2a..cc85017493 100755 --- a/test/unit/24.sh +++ b/test/unit/24.sh @@ -19,9 +19,6 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# Needs a mysql database, the root user password must be given -# in the file 'dbrootpw' in the test directory - . include/common if [ ! -f ~/.pgpass ] ; then

1 0

git:5.1:26bd009c: mtree: use cast to unsigned char for accessing _mt_char_table array
by Daniel-Constantin Mierla 04 Dec '17

04 Dec '17

Module: kamailio Branch: 5.1 Commit: 26bd009c4963e4acb1e0eb52d0f5c9f17096d412 URL: https://github.com/kamailio/kamailio/commit/26bd009c4963e4acb1e0eb52d0f5c9f… Author: Timo Teras <timo.teras(a)iki.fi> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-12-04T09:26:12+01:00 mtree: use cast to unsigned char for accessing _mt_char_table array - switched the index from unsigned int to unsigned char - simplifies the code by avoiding the tests for exceeding the size of the array - error message extended to print the full string - slightly modified version of PR #1343 (cherry picked from commit ae18e409d71d2d4eccb4604bb6f29a121309b54e) --- Modified: src/modules/mtree/mtree.c --- Diff: https://github.com/kamailio/kamailio/commit/26bd009c4963e4acb1e0eb52d0f5c9f… Patch: https://github.com/kamailio/kamailio/commit/26bd009c4963e4acb1e0eb52d0f5c9f…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2017