sr-dev November 2017

sr-dev@lists.kamailio.org

26 participants
481 discussions

Start a nNew thread

Jenkins build became unstable: kamailio50-nightly-source » xenial,master #99
by jenkins＠sipwise.com 23 Nov '17

23 Nov '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-source/distribution=xen…>

1 1

Jenkins build became unstable: kamailio50-nightly-source » wheezy,master #99
by jenkins＠sipwise.com 23 Nov '17

23 Nov '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-source/distribution=whe…>

1 1

Jenkins build became unstable: kamailio50-nightly-source » precise,master #99
by jenkins＠sipwise.com 23 Nov '17

23 Nov '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-source/distribution=pre…>

1 1

Jenkins build became unstable: kamailio50-nightly-source » trusty,master #99
by jenkins＠sipwise.com 23 Nov '17

23 Nov '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-source/distribution=tru…>

1 1

Jenkins build became unstable: kamailio50-nightly-source » jessie,master #99
by jenkins＠sipwise.com 23 Nov '17

23 Nov '17

See <https://kamailio.sipwise.com/job/kamailio50-nightly-source/distribution=jes…>

1 1

git:master:35985c78: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 22 Nov '17

22 Nov '17

Module: kamailio Branch: master Commit: 35985c78a502731bc8005688a1cc50af348aec71 URL: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-11-22T19:31:36+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a… Patch: https://github.com/kamailio/kamailio/commit/35985c78a502731bc8005688a1cc50a… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 0b4e3c1acb..03d531fb3c 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -1386,16 +1386,16 @@ unset_dlg_profile("caller","$fu"); 7.3. is_in_profile(profile,[value]) - Checks if the current dialog belongs to a profile. If the profile - supports values, the check can be reinforced to take into account a - specific value, if the dialog was inserted into the profile for a - specific value. If no value is passed, only the membership of the - dialog in the profile per se is checked. Note that if the profile does - not support values, the value parameter will be silently discarded. + Checks if the current dialog belongs to a profile. If the profile is + defined with values, then the check is also matching with the specific + value provided as parameter. + + Note that if the profile is not defined with support for values, the + value parameter will be silently discarded. Meaning of the parameters is as follows: * profile - name of the profile to be checked against; - * value (optional) - string value to further restrict the check. + * value (optional) - string value to be matched during the check. Pseudo-variables are supported. This function can be used from REQUEST_ROUTE, BRANCH_ROUTE, REPLY_ROUTE

1 0

[kamailio/kamailio] dialog doc does not match code (#1320)
by dryvoip 22 Nov '17

22 Nov '17

Documentation: 7.3. is_in_profile(profile,[value]) Checks if the current dialog belongs to a profile. If the profile supports values, the check can be reinforced to take into account a specific value, if the dialog was inserted into the profile for a specific value. **If no value is passed, only the membership of the dialog in the profile per se is checked.** Note that if the profile does not support values, the value parameter will be silently discarded. Code: ``` static int w_is_in_profile_helper(sip_msg_t *msg, struct dlg_profile_table *profile, str *value) { if (profile->has_value) { if (value==NULL || value->len<=0) { LM_ERR("invalid value parameter\n"); return -1; } return is_dlg_in_profile( msg, profile, value); } else { return is_dlg_in_profile( msg, profile, NULL); } } ``` Expected result: Documentation should be corrected, or even better, code should be updated to perform as documented. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1320

2 2

git:master:d319c449: dialog: proper description of is_in_profile() to match the code
by Daniel-Constantin Mierla 22 Nov '17

22 Nov '17

Module: kamailio Branch: master Commit: d319c449c8c15334ed913633cfece869a7d955aa URL: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-11-22T19:15:16+01:00 dialog: proper description of is_in_profile() to match the code - reported by GH #1320 --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86… Patch: https://github.com/kamailio/kamailio/commit/d319c449c8c15334ed913633cfece86… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index e0041f75ed..4e7a654b2f 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -1608,11 +1608,12 @@ unset_dlg_profile("caller","$fu"); </title> <para> Checks if the current dialog belongs to a profile. If the profile - supports values, the check can be reinforced to take into account a - specific value, if the dialog was inserted into the profile for a - specific value. If no value is passed, only the membership of - the dialog in the profile per se is checked. Note that if the profile does - not support values, the value parameter will be silently discarded. + is defined with values, then the check is also matching with the + specific value provided as parameter. + </para> + <para> + Note that if the profile is not defined with support for values, the + value parameter will be silently discarded. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -1623,13 +1624,13 @@ unset_dlg_profile("caller","$fu"); </listitem> <listitem> <para><emphasis>value</emphasis> (optional) - string value to - further restrict the check. Pseudo-variables are supported. + be matched during the check. Pseudo-variables are supported. </para> </listitem> </itemizedlist> <para> This function can be used from REQUEST_ROUTE, BRANCH_ROUTE, - REPLY_ROUTE and FAILURE_ROUTE. + REPLY_ROUTE and FAILURE_ROUTE. </para> <example> <title><function>is_in_profile</function> usage</title>

1 0

[kamailio/kamailio] fix typo in function ksr_branch_manage (#1324)
by Karsten Horsmann 22 Nov '17

22 Nov '17

Typo of "$T_branch_idx]" returns always nil - Error then "attempt to concatenate a nil value" from lua. Reorder the ] into a string.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1324 -- Commit Summary -- * fix typo in function ksr_branch_manage -- File Changes -- M misc/examples/kemi/kamailio-basic-kemi-lua.lua (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1324.patch https://github.com/kamailio/kamailio/pull/1324.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1324

2 3

[kamailio/kamailio] core: removing the condition for second record_route ipv6 header (#1315)
by Surendra Tiwari 22 Nov '17

22 Nov '17

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1315 -- Commit Summary -- * core: removing the condition for second record_route ipv6 header -- File Changes -- M src/core/msg_translator.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1315.patch https://github.com/kamailio/kamailio/pull/1315.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1315

2 10

← Newer
1
...
23
24
25
26
27
28
29
...
49
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2017