sr-dev October 2017

sr-dev@lists.kamailio.org

33 participants
301 discussions

git:master:fab551a8: sl: fix typos and format in documentation and code
by Mikko Lehto 27 Oct '17

27 Oct '17

Module: kamailio Branch: master Commit: fab551a87b40b35ca99845df52071980458cdd51 URL: https://github.com/kamailio/kamailio/commit/fab551a87b40b35ca99845df5207198… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-10-27T10:20:25+03:00 sl: fix typos and format in documentation and code --- Modified: src/modules/sl/doc/sl.xml Modified: src/modules/sl/sl.c Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/fab551a87b40b35ca99845df5207198… Patch: https://github.com/kamailio/kamailio/commit/fab551a87b40b35ca99845df5207198… --- diff --git a/src/modules/sl/doc/sl.xml b/src/modules/sl/doc/sl.xml index c5f96e82be..1bd05b7c0b 100644 --- a/src/modules/sl/doc/sl.xml +++ b/src/modules/sl/doc/sl.xml @@ -49,7 +49,7 @@ </para> <para> To speed up the filtering process, the module uses a timeout - mechanism. When a reply is sent, a timer us set. As long as the + mechanism. When a reply is sent, a timer is set. As long as the timer is valid, the incoming ACK requests will be checked using TO tag value. Once the timer expires, all the ACK messages are let through - a long time passed till it sent a reply, so it does not @@ -63,7 +63,7 @@ re-INVITE) and the server want to reply to it. Then, it will keep the current to-tag, which will be mirrored in ACK. SER will not see its signature and forward the ACK downstream. Caused harm is not - bad--just a useless ACK is forwarded. + bad, just a useless ACK is forwarded. </para> </section> diff --git a/src/modules/sl/sl.c b/src/modules/sl/sl.c index ab50db3649..c523e8913b 100644 --- a/src/modules/sl/sl.c +++ b/src/modules/sl/sl.c @@ -194,7 +194,7 @@ static void mod_destroy() /** * @brief Small wrapper around sl_send_reply * - * Warapper around sl_send_rply() which accepts parameters that include + * Wrapper around sl_send_reply() which accepts parameters that include * config variables * */ diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 6dbd754539..dbc5105d2c 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -384,7 +384,7 @@ int sl_filter_ACK(struct sip_msg *msg, unsigned int flags, void *bar ) /*check the timeout value*/ if ( *(sl_timeout)<= get_ticks_raw() ) { - LM_DBG("to late to be a local ACK!\n"); + LM_DBG("too late to be a local ACK!\n"); goto pass_it; }

1 0

git:master:e875863f: acc: documentation typo
by Mikko Lehto 27 Oct '17

27 Oct '17

Module: kamailio Branch: master Commit: e875863f1b23217454061f61b90e82ce4ff7be8b URL: https://github.com/kamailio/kamailio/commit/e875863f1b23217454061f61b90e82c… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-10-27T10:19:25+03:00 acc: documentation typo --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/e875863f1b23217454061f61b90e82c… Patch: https://github.com/kamailio/kamailio/commit/e875863f1b23217454061f61b90e82c… --- diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index 0bbda1a4a4..1e174705ec 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -1541,7 +1541,7 @@ acc_db_request("$var(code) Error: $avp(reason)", "SomeTable"); <function moreinfo="none">acc_request(comment, table)</function> </title> <para> - Warapper around <function moreinfo="none">acc_log_request</function> + Wrapper around <function moreinfo="none">acc_log_request</function> and <function moreinfo="none">acc_db_request</function> functions, writing the accounting record to LOG and DATABASE backends. If <quote>db_url</quote> parameter is not set, the acc record is written

1 0

git:master:41aa50ae: dialog: documentation text format
by Mikko Lehto 27 Oct '17

27 Oct '17

Module: kamailio Branch: master Commit: 41aa50ae4ee31657f8eb61fcb949d188cda8cff4 URL: https://github.com/kamailio/kamailio/commit/41aa50ae4ee31657f8eb61fcb949d18… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-10-27T10:19:25+03:00 dialog: documentation text format --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/41aa50ae4ee31657f8eb61fcb949d18… Patch: https://github.com/kamailio/kamailio/commit/41aa50ae4ee31657f8eb61fcb949d18… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index d01ea69cff..e0041f75ed 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -2550,7 +2550,7 @@ if(has_totag() and is_present_hf("Route") and uri==myself ) { <section> <title>event_route[dialog:start]</title> <para> - Executed when 200OK reply for INVITE is processed. + Executed when 200 OK reply for INVITE is processed. </para> </section> <section>

1 0

git:master:dee1dc34: mtree: doc typo
by Mikko Lehto 27 Oct '17

27 Oct '17

Module: kamailio Branch: master Commit: dee1dc349a5aad9c84a22701d88e2eafa6a22b5c URL: https://github.com/kamailio/kamailio/commit/dee1dc349a5aad9c84a22701d88e2ea… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Mikko Lehto <mslehto(a)iki.fi> Date: 2017-10-27T10:16:52+03:00 mtree: doc typo --- Modified: src/modules/mtree/doc/mtree_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/dee1dc349a5aad9c84a22701d88e2ea… Patch: https://github.com/kamailio/kamailio/commit/dee1dc349a5aad9c84a22701d88e2ea… --- diff --git a/src/modules/mtree/doc/mtree_admin.xml b/src/modules/mtree/doc/mtree_admin.xml index 0162e32dfa..86effcd73f 100644 --- a/src/modules/mtree/doc/mtree_admin.xml +++ b/src/modules/mtree/doc/mtree_admin.xml @@ -141,7 +141,7 @@ modparam("mtree", "db_table", "mtrees") <para> type - the type of tree elements (0 = string, 2 = integer). It is valid only when the (tprefix, tvalue) pairs are loaded - (not for muti-column values). + (not for multi-column values). </para> </listitem> <listitem> @@ -149,7 +149,7 @@ modparam("mtree", "db_table", "mtrees") multi - tells if dbtable can contain more than one tree (0 = one tree, 1 = more than one tree identified by tname column). It is valid only when the (tprefix, tvalue) pairs - are loaded (not for muti-column values). + are loaded (not for multi-column values). </para> </listitem> </itemizedlist>

1 0

Kamailio v5.0.4 Released
by Daniel-Constantin Mierla 26 Oct '17

26 Oct '17

Hello, Kamailio SIP Server v5.0.4 stable release is out! This is a maintenance release of the latest stable branch, 5.0, that includes fixes since the release of v5.0.3. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.0.x. Deployments running previous 5.0.x versions are strongly recommended to be upgraded to v5.0.4. For more details about version 5.0.4 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2017/10/kamailio-v5-0-4-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda

2 3

git:master:3f1f706b: kex: setdsturi() hanldes vars params
by Daniel-Constantin Mierla 26 Oct '17

26 Oct '17

Module: kamailio Branch: master Commit: 3f1f706b8b1fa5da9da56420d069fc231dd9d784 URL: https://github.com/kamailio/kamailio/commit/3f1f706b8b1fa5da9da56420d069fc2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-10-26T21:16:36+02:00 kex: setdsturi() hanldes vars params --- Modified: src/modules/kex/kex_mod.c Modified: src/modules/kex/km_core.c --- Diff: https://github.com/kamailio/kamailio/commit/3f1f706b8b1fa5da9da56420d069fc2… Patch: https://github.com/kamailio/kamailio/commit/3f1f706b8b1fa5da9da56420d069fc2… --- diff --git a/src/modules/kex/kex_mod.c b/src/modules/kex/kex_mod.c index 46bc97a90e..f58cf189b6 100644 --- a/src/modules/kex/kex_mod.c +++ b/src/modules/kex/kex_mod.c @@ -88,8 +88,8 @@ static cmd_export_t cmds[]={ 0, ANY_ROUTE }, {"isbflagset", (cmd_function)w_isbflagset, 2,fixup_igp_igp, 0, ANY_ROUTE }, - {"setdsturi", (cmd_function)w_setdsturi, 1, 0, - 0, ANY_ROUTE }, + {"setdsturi", (cmd_function)w_setdsturi, 1, fixup_spve_null, + fixup_free_spve_null, ANY_ROUTE }, {"resetdsturi", (cmd_function)w_resetdsturi, 0, 0, 0, ANY_ROUTE }, {"isdsturiset", (cmd_function)w_isdsturiset, 0, 0, @@ -279,4 +279,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_kex_exports); return 0; -} \ No newline at end of file +} diff --git a/src/modules/kex/km_core.c b/src/modules/kex/km_core.c index 428e620d7b..f0d97f1af9 100644 --- a/src/modules/kex/km_core.c +++ b/src/modules/kex/km_core.c @@ -33,16 +33,17 @@ int w_setdsturi(struct sip_msg *msg, char *uri, str *s2) { - str s; + str suri; - /* todo: fixup */ - s.s = uri; - s.len = strlen(uri); + if(fixup_get_svalue(msg, (gparam_t*)uri, &suri)!=0) { + LM_ERR("cannot get the URI parameter\n"); + return -1; + } - if(set_dst_uri(msg, &s)!=0) + if(set_dst_uri(msg, &suri)!=0) return -1; - /* dst_uri changes, so it makes sense to re-use the current uri for - forking */ + /* dst_uri changed, so it makes sense to re-use the current uri + * for forking */ ruri_mark_new(); /* re-use uri for serial forking */ return 1;

1 0

git:master:a6efe6d7: app_python: safety checks for self var pointer
by Daniel-Constantin Mierla 26 Oct '17

26 Oct '17

Module: kamailio Branch: master Commit: a6efe6d7e1a205a9d0c2d5c6c165fe337c4de814 URL: https://github.com/kamailio/kamailio/commit/a6efe6d7e1a205a9d0c2d5c6c165fe3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-10-25T22:56:47+02:00 app_python: safety checks for self var pointer --- Modified: src/modules/app_python/python_msgobj.c --- Diff: https://github.com/kamailio/kamailio/commit/a6efe6d7e1a205a9d0c2d5c6c165fe3… Patch: https://github.com/kamailio/kamailio/commit/a6efe6d7e1a205a9d0c2d5c6c165fe3… --- diff --git a/src/modules/app_python/python_msgobj.c b/src/modules/app_python/python_msgobj.c index 33ddd8db3a..a9dd51d52f 100644 --- a/src/modules/app_python/python_msgobj.c +++ b/src/modules/app_python/python_msgobj.c @@ -70,6 +70,12 @@ static PyObject *msg_rewrite_ruri(msgobject *self, PyObject *args) { str nuri; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -99,6 +105,12 @@ static PyObject *msg_set_dst_uri(msgobject *self, PyObject *args) { str ruri; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -133,6 +145,12 @@ static PyObject *msg_getHeader(msgobject *self, PyObject *args) struct hdr_field *hf; str hname, *hbody; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -172,6 +190,12 @@ PyObject *msg_call_function(msgobject *self, PyObject *args) struct run_act_ctx ra_ctx; unsigned mod_ver; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -281,6 +305,12 @@ static PyObject *msg_getType(msgobject *self, PyObject *unused) { const char *rval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -309,6 +339,12 @@ static PyObject *msg_getMethod(msgobject *self, PyObject *unused) { str *rval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -328,6 +364,12 @@ static PyObject *msg_getStatus(msgobject *self, PyObject *unused) { str *rval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -348,6 +390,12 @@ static PyObject *msg_getRURI(msgobject *self, PyObject *unused) { str *rval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -368,6 +416,12 @@ static PyObject *msg_get_src_address(msgobject *self, PyObject *unused) { PyObject *src_ip, *src_port, *pyRval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None); @@ -402,6 +456,12 @@ static PyObject *msg_get_dst_address(msgobject *self, PyObject *unused) { PyObject *dst_ip, *dst_port, *pyRval; + if (self == NULL) { + PyErr_SetString(PyExc_RuntimeError, "self is NULL"); + Py_INCREF(Py_None); + return Py_None; + } + if (self->msg == NULL) { PyErr_SetString(PyExc_RuntimeError, "self->msg is NULL"); Py_INCREF(Py_None);

1 0

MAX_FLAG
by Juha Heinanen 26 Oct '17

26 Oct '17

I'm running out of flags. Is there some good reason why flag_t is unsigned int instead of unsigned long? -- Juha

1 0

Planning Kamailio v5.0.4
by Daniel-Constantin Mierla 25 Oct '17

25 Oct '17

Hello, I am considering to release Kamailio v5.0.4 later this week, likely on Wednesday or Tuesday. If you are aware of any issue in branch 5.0 which is not yet reported on github.com/kamailio/kamailio issues tracker, then do it as soon as possible to have a chance to look at it. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Nov 13-15, 2017, in Berlin - www.asipto.com Kamailio World Conference - www.kamailioworld.com

3 5

Errored: kamailio/kamailio#4970 (master - 384a533)
by Travis CI 25 Oct '17

25 Oct '17

Build Update for kamailio/kamailio ------------------------------------- Build: #4970 Status: Errored Duration: 21 minutes and 34 seconds Commit: 384a533 (master) Author: Daniel-Constantin Mierla Message: Merge pull request #1283 from dunst0/patch-1 dispatcher: undeclared UINT32_MAX on FreeBSD missing header View the changeset: https://github.com/kamailio/kamailio/compare/cafabcf658c2...384a5338762f View the full build log and details: https://travis-ci.org/kamailio/kamailio/builds/292597174?utm_source=email&u… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2017