sr-dev January 2017

sr-dev@lists.kamailio.org

33 participants
539 discussions

git:master:04ffb3b1: presence: update delete_subscription documentation
by GitHub 22 Jan '17

22 Jan '17

Module: kamailio Branch: master Commit: 04ffb3b1d13483534e724820c231fa6e18112ba3 URL: https://github.com/kamailio/kamailio/commit/04ffb3b1d13483534e724820c231fa6… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: GitHub <noreply(a)github.com> Date: 2017-01-22T14:27:23Z presence: update delete_subscription documentation --- Modified: src/modules/presence/doc/presence_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/04ffb3b1d13483534e724820c231fa6… Patch: https://github.com/kamailio/kamailio/commit/04ffb3b1d13483534e724820c231fa6… --- diff --git a/src/modules/presence/doc/presence_admin.xml b/src/modules/presence/doc/presence_admin.xml index 2f68df8..6abcc72 100644 --- a/src/modules/presence/doc/presence_admin.xml +++ b/src/modules/presence/doc/presence_admin.xml @@ -785,8 +785,8 @@ modparam("presence", "subs_remove_match", 1) give extra control of deleting the subscription after processing of event_route[presence:notify-reply]. If value = 1, it deletes the subscription. If xavp_cfg parameter is set but this attribute is not in the avp, - the subscription is not deleted. this does apply for code 404 and 481 - where subscription is deleted.</para> + the subscription is not deleted. this does not apply for codes 404, 481 + and 408 (when timeout_rm_subs = 1) where subscription is deleted.</para> </listitem> </itemizedlist> <para>

1 0

git:master:d89d643a: core: print cfg line and column inside fix_rval() if resolve select fails
by Daniel-Constantin Mierla 21 Jan '17

21 Jan '17

Module: kamailio Branch: master Commit: d89d643ab144a7a72aebd59c34df011f77dc4e34 URL: https://github.com/kamailio/kamailio/commit/d89d643ab144a7a72aebd59c34df011… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-21T19:54:31+01:00 core: print cfg line and column inside fix_rval() if resolve select fails --- Modified: src/core/rvalue.c --- Diff: https://github.com/kamailio/kamailio/commit/d89d643ab144a7a72aebd59c34df011… Patch: https://github.com/kamailio/kamailio/commit/d89d643ab144a7a72aebd59c34df011… --- diff --git a/src/core/rvalue.c b/src/core/rvalue.c index 2861207..a38a524 100644 --- a/src/core/rvalue.c +++ b/src/core/rvalue.c @@ -2839,7 +2839,7 @@ static int rve_can_optimize_str(struct rval_expr* rve) return 0; if (rve->op == RVE_RVAL_OP) return 0; - LM_DBG("left %d, right %d\n", + LM_DBG("left %d, right %d\n", rve->left.rve->op, rve->right.rve?rve->right.rve->op:0); if (rve->left.rve->op != RVE_RVAL_OP) return 0; @@ -2848,7 +2848,7 @@ static int rve_can_optimize_str(struct rval_expr* rve) if (rve->right.rve){ if (rve->right.rve->op != RVE_RVAL_OP) return 0; - if ((rve->right.rve->left.rval.type!=RV_STR) && + if ((rve->right.rve->left.rval.type!=RV_STR) && (rve->right.rve->left.rval.type!=RV_INT)) return 0; } @@ -2858,7 +2858,7 @@ static int rve_can_optimize_str(struct rval_expr* rve) -static int fix_rval(struct rvalue* rv) +static int fix_rval(struct rvalue* rv, struct rval_expr* rve) { LM_DBG("RV fixing type %d\n", rv->type); switch(rv->type){ @@ -2876,8 +2876,13 @@ static int fix_rval(struct rvalue* rv) return fix_actions(rv->v.action); case RV_SEL: if (resolve_select(&rv->v.sel)<0){ - ERR("Unable to resolve select\n"); - print_select(&rv->v.sel); + if(rve==NULL) { + ERR("Unable to resolve select\n"); + } else { + ERR("Unable to resolve select in cfg at line: %d col: %d\n", + rve->fpos.s_line, rve->fpos.s_col); + } + err_select(&rv->v.sel); } return 0; case RV_AVP: @@ -3794,7 +3799,7 @@ int fix_rval_expr(void* p) BUG("empty rval expr\n"); break; case RVE_RVAL_OP: - ret = fix_rval(&rve->left.rval); + ret = fix_rval(&rve->left.rval, rve); if (ret<0) goto error; return ret; case RVE_UMINUS_OP: /* unary operators */

1 0

git:master:77bf2478: core: select - added function to print select for error purposes
by Daniel-Constantin Mierla 21 Jan '17

21 Jan '17

Module: kamailio Branch: master Commit: 77bf2478893bb935e0ca09d93df75b404417d3bd URL: https://github.com/kamailio/kamailio/commit/77bf2478893bb935e0ca09d93df75b4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-21T19:49:47+01:00 core: select - added function to print select for error purposes --- Modified: src/core/select.c Modified: src/core/select.h --- Diff: https://github.com/kamailio/kamailio/commit/77bf2478893bb935e0ca09d93df75b4… Patch: https://github.com/kamailio/kamailio/commit/77bf2478893bb935e0ca09d93df75b4… --- diff --git a/src/core/select.c b/src/core/select.c index 1bf1e6a..bf3e567 100644 --- a/src/core/select.c +++ b/src/core/select.c @@ -428,18 +428,28 @@ int run_select(str* res, select_t* s, struct sip_msg* msg) return ret; } -void print_select(select_t* s) +void log_select(select_t* s, int level) { int i; - DBG("select("); + LOG(level, "select("); for(i = 0; i < s->n; i++) { if (s->params[i].type == SEL_PARAM_INT) { - DBG("%d,", s->params[i].v.i); + LOG(level, "%d,", s->params[i].v.i); } else { - DBG("%.*s,", s->params[i].v.s.len, s->params[i].v.s.s); + LOG(level, "%.*s,", s->params[i].v.s.len, s->params[i].v.s.s); } } - DBG(")\n"); + LOG(level, ")\n"); +} + +void print_select(select_t* s) +{ + log_select(s, L_DBG); +} + +void err_select(select_t* s) +{ + log_select(s, L_ERR); } int register_select_table(select_row_t* mod_tab) diff --git a/src/core/select.h b/src/core/select.h index 5d639d6..74c68e4 100644 --- a/src/core/select.h +++ b/src/core/select.h @@ -13,8 +13,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * */ @@ -26,7 +26,7 @@ * Module: \ref core */ - + #ifndef _SELECT_H #define _SELECT_H @@ -36,7 +36,7 @@ #define MAX_SELECT_PARAMS 32 #define MAX_NESTED_CALLS 4 -/* Flags for parser table FLAG bitfiels +/* Flags for parser table FLAG bitfiels */ #define DIVERSION_MASK 0x00FF @@ -75,12 +75,12 @@ /* left function is noted to be called * rigth function continues in resolution - * NOTE: the parameter is not consumed for PARENT, + * NOTE: the parameter is not consumed for PARENT, * so you can leave it as ..,SEL_PARAM_INT, 0,.. * * run_select then calls all functions with PARENT flag - * in the order of resolution until the final call or - * the result is != 0 (<0 error, 1 null str) + * in the order of resolution until the final call or + * the result is != 0 (<0 error, 1 null str) * the only one parameter passed between nested calls * is the result str* */ @@ -102,13 +102,13 @@ typedef enum { SEL_PARAM_DIV, /* Integer value got from parsing table */ SEL_PARAM_PTR /* void* data got from e.g. fixup call */ } select_param_type_t; - + typedef union { int i; /* Integer value */ str s; /* String value */ void* p;/* Any data ptr */ } select_param_value_t; - + typedef struct sel_param { select_param_type_t type; select_param_value_t v; @@ -164,11 +164,16 @@ int resolve_select(select_t* s); int run_select(str* res, select_t* s, struct sip_msg* msg); /* - * Print select for debugging purposes + * Print select for debugging purposes */ void print_select(select_t* s); /* + * Print select for error purposes + */ +void err_select(select_t* s); + +/* * Register modules' own select parser table */ int register_select_table(select_row_t *table); @@ -191,7 +196,7 @@ int parse_select (char** p, select_t** s); void free_select(select_t *s); /* * Select parser, result is stored in SHARED memory - * + * * If you call this, you must ensure, that the string which * is beeing parsed MUST be at the same place for all child * processes, e.g. allocated in the shared memory as well

1 0

git:master:3e88ff56: tm: select code migrated to new log macros
by Daniel-Constantin Mierla 21 Jan '17

21 Jan '17

Module: kamailio Branch: master Commit: 3e88ff5662ccf8204206f4e6b770efaf509ad3f7 URL: https://github.com/kamailio/kamailio/commit/3e88ff5662ccf8204206f4e6b770efa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-21T19:24:57+01:00 tm: select code migrated to new log macros --- Modified: src/modules/tm/select.c Modified: src/modules/tm/select.h --- Diff: https://github.com/kamailio/kamailio/commit/3e88ff5662ccf8204206f4e6b770efa… Patch: https://github.com/kamailio/kamailio/commit/3e88ff5662ccf8204206f4e6b770efa…

1 0

[kamailio/kamailio] Contact IPv6 format error in 200OK/SUBSCRIBE (#943)
by riccardovarotto 20 Jan '17

20 Jan '17

### Description The 200OK reply to SUBSCRIBE on IPv6 has the Contact header wrong formatted, it's appear as: Contact: <sip:2222:0:0:0:0:0:0:55:4060;transport=udp> instead of Contact: <sip:[2222:0:0:0:0:0:0:55]:4060;transport=udp>  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic UBSCRIBE sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org SIP/2.0 Via: SIP/2.0/UDP [2221::5]:4060;branch=z9hG4bK-5-0-95675325205398405120;rport From: <sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org>;tag=5-0-63373794482729304064 To: <sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org> Call-ID: callid-5-0-cnt-2-23363871231378927616 Contact: <sip:+393498786882@[2221::5]:4060>;expires=80 Max-Forwards: 70 User-Agent: SIPv3 UeSIM LTE - vtrunk_C Allow: INVITE,ACK,BYE,CANCEL,NOTIFY,MESSAGE,OPTIONS,PRACK,UPDATE,REFER Expires: 80 Proxy-Authorization: Digest username="+393498786882(a)ims.mnc021.mcc292.3gppnetwork.org", realm="ims.mnc021.mcc292.3gppnetwork.org", algorithm=MD5, nonce="WIIsT1iCKyMEfQy/SmMqSl2b4P4n2vR7", uri="sip:ims.mnc021.mcc292.3gppnetwork.org", response="4e39c2ab34e4009dca083e4cbd2acebc", cnonce="59159616548176674082335766872064", qop=auth, nc=00000001 Event: presence.winfo Allow-Events: reg, presence, presence.winfo Privacy: none Accept: application/watcherinfo+xml CSeq: 76585 SUBSCRIBE Organization: Sent by UAC Transaction Layer Content-Length: 0 SIP/2.0 200 OK Via: SIP/2.0/UDP [2221::5]:4060;branch=z9hG4bK-5-0-95675325205398405120;rport=4060;received=2221:0:0:0:0:0:0:5 From: <sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org>;tag=5-0-63373794482729304064 To: <sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org>;tag=be7ce37c4413768ae7f9747982106912-651e Call-ID: callid-5-0-cnt-2-23363871231378927616 CSeq: 76585 SUBSCRIBE Expires: 80 Contact: <sip:2222:0:0:0:0:0:0:55:4060;transport=udp> Server: kamailio (4.4.5 (x86_64/linux)) Content-Length: 0 Warning: 392 [2222:0:0:0:0:0:0:55]:4060 "Noisy feedback tells: pid=27504 req_src_ip=2221:0:0:0:0:0:0:5 req_src_port=4060 in_uri=sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org out_uri=sip:+393498786882@ims.mnc021.mcc292.3gppnetwork.org via_cnt==1"  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 4.4.5 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 4.9.2 ``` (paste your output here) ``` * **Operating System**: Distributor ID: Debian Description: Debian GNU/Linux 8.7 (jessie) Release: 8.7 Codename: jessie  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/943

2 5

git:master:d62fd3e4: presence: build proper ipv6 contact when server address is not set
by Daniel-Constantin Mierla 20 Jan '17

20 Jan '17

Module: kamailio Branch: master Commit: d62fd3e4976633aa6b827d527f4e15de0b08068b URL: https://github.com/kamailio/kamailio/commit/d62fd3e4976633aa6b827d527f4e15d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-20T17:15:10+01:00 presence: build proper ipv6 contact when server address is not set - reported by GH #943 --- Modified: src/modules/presence/utils_func.h --- Diff: https://github.com/kamailio/kamailio/commit/d62fd3e4976633aa6b827d527f4e15d… Patch: https://github.com/kamailio/kamailio/commit/d62fd3e4976633aa6b827d527f4e15d… --- diff --git a/src/modules/presence/utils_func.h b/src/modules/presence/utils_func.h index ed48372..b68890f 100644 --- a/src/modules/presence/utils_func.h +++ b/src/modules/presence/utils_func.h @@ -77,7 +77,7 @@ static inline int uandd_to_uri(str user, str domain, str *out) memcpy(out->s + out->len, domain.s, domain.len); out->len += domain.len; out->s[out->len] = '\0'; - + return 0; } @@ -88,6 +88,7 @@ static inline int ps_fill_local_contact(struct sip_msg* msg, str *contact) int port; int len; int plen; + char *p; contact->s= (char*)pkg_malloc(LCONTACT_BUF_SIZE); if(contact->s== NULL) @@ -98,22 +99,22 @@ static inline int ps_fill_local_contact(struct sip_msg* msg, str *contact) memset(contact->s, 0, LCONTACT_BUF_SIZE); contact->len= 0; - + plen = 3; if(msg->rcv.proto== PROTO_NONE || msg->rcv.proto==PROTO_UDP) proto= "udp"; else if(msg->rcv.proto== PROTO_TLS ) proto= "tls"; - else + else if(msg->rcv.proto== PROTO_TCP) proto= "tcp"; - else + else if(msg->rcv.proto== PROTO_SCTP) { proto= "sctp"; plen = 4; } - else + else if(msg->rcv.proto== PROTO_WS || msg->rcv.proto== PROTO_WSS) { proto= "ws"; plen = 2; @@ -122,8 +123,8 @@ static inline int ps_fill_local_contact(struct sip_msg* msg, str *contact) { LM_ERR("unsupported proto\n"); goto error; - } - + } + if(msg->rcv.bind_address->useinfo.name.len>0) { ip = msg->rcv.bind_address->useinfo.name; } else { @@ -135,30 +136,41 @@ static inline int ps_fill_local_contact(struct sip_msg* msg, str *contact) } else { port = msg->rcv.bind_address->port_no; } - - if(strncmp(ip.s, "sip:", 4)!=0) - { - strncpy(contact->s, "sip:", 4); - contact->len+= 4; - } - strncpy(contact->s+contact->len, ip.s, ip.len); + + p = contact->s; + if(strncmp(ip.s, "sip:", 4)!=0) { + strncpy(p, "sip:", 4); + contact->len += 4; + p += 4; + } + if(msg->rcv.bind_address->address.af==AF_INET6) { + *p = '['; + contact->len += 1; + p += 1; + } + strncpy(p, ip.s, ip.len); contact->len += ip.len; - if(contact->len> LCONTACT_BUF_SIZE - 21) - { + p += ip.len; + if(msg->rcv.bind_address->address.af==AF_INET6) { + *p = ']'; + contact->len += 1; + p += 1; + } + if(contact->len > LCONTACT_BUF_SIZE - 21) { LM_ERR("buffer overflow\n"); goto error; - } - len= sprintf(contact->s+contact->len, ":%d;transport=" , port); - if(len< 0) - { + } + len= sprintf(p, ":%d;transport=" , port); + if(len< 0) { LM_ERR("unsuccessful sprintf\n"); goto error; - } - contact->len+= len; - strncpy(contact->s+ contact->len, proto, plen); + } + contact->len += len; + p += len; + strncpy(p, proto, plen); contact->len += plen; - + return 0; error: if(contact->s!=NULL)

1 0

git:master:73fc1f94: htable: split ht_reset() cfg wrapper to allow kemi export
by Daniel-Constantin Mierla 20 Jan '17

20 Jan '17

Module: kamailio Branch: master Commit: 73fc1f94919e8df5b37b3fe7cc7cebb99a3b2a4d URL: https://github.com/kamailio/kamailio/commit/73fc1f94919e8df5b37b3fe7cc7cebb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-20T16:36:41+01:00 htable: split ht_reset() cfg wrapper to allow kemi export --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/73fc1f94919e8df5b37b3fe7cc7cebb… Patch: https://github.com/kamailio/kamailio/commit/73fc1f94919e8df5b37b3fe7cc7cebb… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 3fb59c8..d04143d 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -407,9 +407,22 @@ static int ht_rm_value_re(struct sip_msg* msg, char* key, char* foo) return 1; } -static int ht_reset(struct sip_msg* msg, char* htname, char* foo) +static int ht_reset_by_name(str *hname) { ht_t *ht; + ht = ht_get_table(hname); + if(ht==NULL) { + LM_ERR("cannot get hash table [%.*s]\n", hname->len, hname->s); + return -1; + } + if(ht_reset_content(ht)<0) + return -1; + return 0; + +} + +static int ht_reset(struct sip_msg* msg, char* htname, char* foo) +{ str sname; if(fixup_get_svalue(msg, (gparam_t*)htname, &sname)<0 || sname.len<=0) @@ -417,14 +430,10 @@ static int ht_reset(struct sip_msg* msg, char* htname, char* foo) LM_ERR("cannot get hash table name\n"); return -1; } - ht = ht_get_table(&sname); - if(ht==NULL) - { - LM_ERR("cannot get hash table [%.*s]\n", sname.len, sname.s); + if(ht_reset_by_name(&sname)<0) { return -1; } - if(ht_reset_content(ht)<0) - return -1; + return 1; } @@ -1124,6 +1133,11 @@ static sr_kemi_t sr_kemi_htable_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("htable"), str_init("sht_reset"), + SR_KEMIP_INT, ht_reset_by_name, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:dcd9f97d: core: print cfg line and column for errors in fix_rval_expr()
by Daniel-Constantin Mierla 20 Jan '17

20 Jan '17

Module: kamailio Branch: master Commit: dcd9f97d63490971afd160afbf2cd00eddc39445 URL: https://github.com/kamailio/kamailio/commit/dcd9f97d63490971afd160afbf2cd00… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-20T09:07:49+01:00 core: print cfg line and column for errors in fix_rval_expr() --- Modified: src/core/rvalue.c --- Diff: https://github.com/kamailio/kamailio/commit/dcd9f97d63490971afd160afbf2cd00… Patch: https://github.com/kamailio/kamailio/commit/dcd9f97d63490971afd160afbf2cd00… --- diff --git a/src/core/rvalue.c b/src/core/rvalue.c index e4524f5..2861207 100644 --- a/src/core/rvalue.c +++ b/src/core/rvalue.c @@ -3786,15 +3786,17 @@ int fix_rval_expr(void* p) { struct rval_expr* rve; int ret; - + rve=(struct rval_expr*)p; - + switch(rve->op){ case RVE_NONE_OP: BUG("empty rval expr\n"); break; case RVE_RVAL_OP: - return fix_rval(&rve->left.rval); + ret = fix_rval(&rve->left.rval); + if (ret<0) goto error; + return ret; case RVE_UMINUS_OP: /* unary operators */ case RVE_BOOL_OP: case RVE_LNOT_OP: @@ -3806,7 +3808,7 @@ int fix_rval_expr(void* p) case RVE_INT_OP: case RVE_STR_OP: ret=fix_rval_expr((void*)rve->left.rve); - if (ret<0) return ret; + if (ret<0) goto error; break; case RVE_MUL_OP: case RVE_DIV_OP: @@ -3833,18 +3835,24 @@ int fix_rval_expr(void* p) case RVE_STRDIFF_OP: case RVE_CONCAT_OP: ret=fix_rval_expr((void*)rve->left.rve); - if (ret<0) return ret; + if (ret<0) goto error; ret=fix_rval_expr((void*)rve->right.rve); - if (ret<0) return ret; + if (ret<0) goto error; break; case RVE_MATCH_OP: ret=fix_match_rve(rve); - if (ret<0) return ret; + if (ret<0) goto error; break; default: - BUG("unsupported op type %d\n", rve->op); + BUG("unsupported op type %d (cfg line: %d col: %d)\n", rve->op, + rve->fpos.s_line, rve->fpos.s_col); } /* try to optimize */ rve_optimize(rve); return 0; + +error: + LM_ERR("failure in cfg at line: %d col: %d\n", + rve->fpos.s_line, rve->fpos.s_col); + return ret; }

1 0

git:master:2287ab6e: tm: hooks related code updated to print log messages without hardcoded prefix
by Daniel-Constantin Mierla 19 Jan '17

19 Jan '17

Module: kamailio Branch: master Commit: 2287ab6e649bf09fa38ce31c662ea9698411b0ac URL: https://github.com/kamailio/kamailio/commit/2287ab6e649bf09fa38ce31c662ea96… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-19T16:57:35+01:00 tm: hooks related code updated to print log messages without hardcoded prefix --- Modified: src/modules/tm/t_hooks.c Modified: src/modules/tm/t_hooks.h --- Diff: https://github.com/kamailio/kamailio/commit/2287ab6e649bf09fa38ce31c662ea96… Patch: https://github.com/kamailio/kamailio/commit/2287ab6e649bf09fa38ce31c662ea96…

1 0

Pull request development workflow
by Luis Martin Gil 19 Jan '17

19 Jan '17

Hi, A couple of _PRs_ were merged into the master branch back in June 2016, see [this](https://github.com/kamailio/kamailio/pull/667) and [this](https://github.com/kamailio/kamailio/pull/664). I believed Kamailio versions released after such _PRs_ were going to include such changes, but latest Kamailio stable (version [4.4.0](https://www.kamailio.org/w/kamailio-v4-4-0-release-notes/)) doesn't include them. This assumption is wrong and I was wondering how this works in the actual Kamailio developement workflow: when can I expect to have such _PRs_ included? Thanks! Luis

2 2

← Newer
1
...
12
13
14
15
16
17
18
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2017