sr-dev August 2016

sr-dev@lists.kamailio.org

25 participants
197 discussions

VUC - SER-Kamailio At 15 Years - On Friday, Sep 2, 2016

by Daniel-Constantin Mierla

Hello, on September 3, 2001, the first line of code was committed to SIP Express Router (SER) project, since 2008 turning into Kamailio project. >From pioneering large scale deployments of using SIP for Voice over IP in early 2000s, the project impacted the evolution of real time communications, disrupted the telecom vendors with its open source model and enabled many businesses to grow and innovate. Let's get together to a VUC session later this week, on Friday, Sep2, 2016, to share the good or bad stories while using SER or Kamailio during the past 15 years. If it made your life easy or a nightmare, it's time to tell it. If you have a funny photo or video, no matter is old or recent, join us and show it. More details about VUC and how one can join or watch the session are available at: - https://vuc.me If you want to actively participate during the session, email me shortly to coordinate a bit. If you cannot participate but you have something interesting to share (story, media files, etc...) email me as well and I will present it. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com - http://www.kamailio.org http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

7 years, 7 months

[kamailio/kamailio] Kamailio does not update CSeq from 200OK on (#752)

by vinzens

We've installed latest kamailio from master branch and we see an issue with CSeq numbers. Scenario is as follow: A <-> Kamailio <-> B We do use uacreg to register to B from kamailio. If there is an call from A to B via Kamailio, B challenge DA and from that point the CSeq is not equal on both sides. We do use dlg_manage to track the Difference. While establishing the call it works until the ACK as reply to 200 OK. The ACK is the first message the CSeq is not updated anymore. In X_log I can see the $dlg_var(cseq_diff) is still there and gives the correct difference. It seems it is not used anymore. All following requests / responses do have this issue e.G. Bye. I can provide a wireshark trace, Logs and I can reproduce it in our test lab. Let me know if you need anything. We do use the latest master version because we had this issue: https://github.com/kamailio/kamailio/issues/679 unfortunately we were not able to find any commit in 4.4 branch, so we tried master. (would be fine for us, if we would get it run) cheers Jöran -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/752

7 years, 7 months

[kamailio/kamailio] sca: terminate all error and debug messages with a new line (#762)

by Kevin Scott Adams

Reported by oej GH #580. Includes whitespace cleanup and normalizing. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/762 -- Commit Summary -- * Merge remote-tracking branch 'refs/remotes/kamailio/master' * sca: terminate all error and debug messages with a new line -- File Changes -- M modules/sca/sca.c (554) M modules/sca/sca.h (36) M modules/sca/sca_appearance.c (2239) M modules/sca/sca_appearance.h (188) M modules/sca/sca_call_info.c (3557) M modules/sca/sca_call_info.h (42) M modules/sca/sca_common.h (13) M modules/sca/sca_db.c (251) M modules/sca/sca_db.h (71) M modules/sca/sca_dialog.c (151) M modules/sca/sca_dialog.h (22) M modules/sca/sca_event.c (73) M modules/sca/sca_event.h (16) M modules/sca/sca_hash.c (451) M modules/sca/sca_hash.h (78) M modules/sca/sca_notify.c (597) M modules/sca/sca_notify.h (6) M modules/sca/sca_reply.c (54) M modules/sca/sca_reply.h (2) M modules/sca/sca_rpc.c (820) M modules/sca/sca_rpc.h (44) M modules/sca/sca_subscribe.c (2668) M modules/sca/sca_subscribe.h (71) M modules/sca/sca_util.c (718) M modules/sca/sca_util.h (32) M utils/kamctl/mysql/ims_dialog-create.sql (104) -- Patch Links -- https://github.com/kamailio/kamailio/pull/762.patch https://github.com/kamailio/kamailio/pull/762.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/762

7 years, 7 months

[kamailio/kamailio] Segmentation fault when using http_hdr with http_async_client (#760)

by AlainDubois78

While using httpa_sync_client, I'm trying to retrieve the Content-Type of the body I got in a 200OK after an HTTP get using $var(my_content_type) =$ http_hdr(Content-Type); Then When I launch Kamailio, I get a seg fault at the configuration file validation step because in http_async_client_mod.c the line 'return pv_api.parse_hdr_name(sp, in)' is trying to use parse_hdr_name before it being initialized. I noticed that when I remove my previous line, the initialization is done but after the configuration file validation. Any idea if I'm doing something wrong? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/760

7 years, 7 months

git:master:48195546: core: tcp read - proper safety when priting log messages for read error case

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 48195546d7b5762be897c748bd3631f6b6a5c1d0 URL: https://github.com/kamailio/kamailio/commit/48195546d7b5762be897c748bd3631f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-08-31T15:05:51+02:00 core: tcp read - proper safety when priting log messages for read error case - related to GH #748 --- Modified: tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/48195546d7b5762be897c748bd3631f… Patch: https://github.com/kamailio/kamailio/commit/48195546d7b5762be897c748bd3631f… --- diff --git a/tcp_read.c b/tcp_read.c index 3141b67..85dd4b1 100644 --- a/tcp_read.c +++ b/tcp_read.c @@ -1338,7 +1338,7 @@ int tcp_read_req(struct tcp_connection* con, int* bytes_read, int* read_flags) * if req. is complete we might have a second unparsed * request after it, so postpone release_with_eof */ - if (unlikely((con->state==S_CONN_EOF) && + if (unlikely((con->state==S_CONN_EOF) && (! TCP_REQ_COMPLETE(req)))) { LM_DBG("EOF\n"); resp=CONN_EOF; @@ -1346,10 +1346,19 @@ int tcp_read_req(struct tcp_connection* con, int* bytes_read, int* read_flags) } } if (unlikely(req->error!=TCP_REQ_OK)){ - LM_ERR("bad request, state=%d, error=%d buf:\n%.*s\nparsed:\n%.*s\n", + if(req->buf!=NULL && req->start!=NULL && req->pos!=NULL + && req->pos>=req->buf && req->parsed>=req->start) { + LM_ERR("bad request, state=%d, error=%d buf:\n%.*s\nparsed:\n%.*s\n", req->state, req->error, (int)(req->pos-req->buf), req->buf, (int)(req->parsed-req->start), req->start); + } else { + LM_ERR("bad request, state=%d, error=%d buf:%d - %p," + " parsed:%d - %p\n", + req->state, req->error, + (int)(req->pos-req->buf), req->buf, + (int)(req->parsed-req->start), req->start); + } LM_DBG("received from: port %d\n", con->rcv.src_port); print_ip("received from: ip", &con->rcv.src_ip, "\n"); resp=CONN_ERROR;

7 years, 7 months

git:master:71b97654: core: handle return code for tcp read headers/ws before printing extra debug logs

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 71b9765462d3df1686274c4b6380c71cf02dc099 URL: https://github.com/kamailio/kamailio/commit/71b9765462d3df1686274c4b6380c71… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-08-31T14:54:13+02:00 core: handle return code for tcp read headers/ws before printing extra debug logs - reported by GH #748 --- Modified: tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/71b9765462d3df1686274c4b6380c71… Patch: https://github.com/kamailio/kamailio/commit/71b9765462d3df1686274c4b6380c71… --- diff --git a/tcp_read.c b/tcp_read.c index a31d3a2..3141b67 100644 --- a/tcp_read.c +++ b/tcp_read.c @@ -1300,7 +1300,7 @@ int tcp_read_req(struct tcp_connection* con, int* bytes_read, int* read_flags) struct dest_info dst; char c; int ret; - + bytes=-1; total_bytes=0; resp=CONN_RELEASE; @@ -1314,6 +1314,15 @@ int tcp_read_req(struct tcp_connection* con, int* bytes_read, int* read_flags) else #endif bytes=tcp_read_headers(con, read_flags); + + if (unlikely(bytes==-1)){ + LOG(cfg_get(core, core_cfg, corelog), + "ERROR: tcp_read_req: error reading - c: %p r: %p\n", + con, req); + resp=CONN_ERROR; + goto end_req; + } + #ifdef EXTRA_DEBUG /* if timeout state=0; goto end__req; */ LM_DBG("read= %d bytes, parsed=%d, state=%d, error=%d\n", @@ -1323,12 +1332,6 @@ int tcp_read_req(struct tcp_connection* con, int* bytes_read, int* read_flags) *(req->parsed-1), (int)(req->parsed-req->start), req->start); #endif - if (unlikely(bytes==-1)){ - LOG(cfg_get(core, core_cfg, corelog), - "ERROR: tcp_read_req: error reading \n"); - resp=CONN_ERROR; - goto end_req; - } total_bytes+=bytes; /* eof check: * is EOF if eof on fd and req. not complete yet,

7 years, 7 months

git:4.4:7164e5d3: http_async_client: init PV API sooner

by Camille Oudot

Module: kamailio Branch: 4.4 Commit: 7164e5d3d587149e03c7ad69feb3e9139ac30757 URL: https://github.com/kamailio/kamailio/commit/7164e5d3d587149e03c7ad69feb3e91… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: 2016-08-31T12:12:42+02:00 http_async_client: init PV API sooner fixes #760 (cherry picked from commit 597242dfbfd883d136aa49d88266fc9edb6b8e09) --- Modified: modules/http_async_client/http_async_client_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7164e5d3d587149e03c7ad69feb3e91… Patch: https://github.com/kamailio/kamailio/commit/7164e5d3d587149e03c7ad69feb3e91… --- diff --git a/modules/http_async_client/http_async_client_mod.c b/modules/http_async_client/http_async_client_mod.c index 965129d..ddbd882 100644 --- a/modules/http_async_client/http_async_client_mod.c +++ b/modules/http_async_client/http_async_client_mod.c @@ -54,6 +54,7 @@ #include "../../modules/tm/tm_load.h" #include "../../modules/pv/pv_api.h" + #include "async_http.h" MODULE_VERSION @@ -227,6 +228,18 @@ struct module_exports exports = { }; +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + pv_register_api_t pvra; + + pvra = (pv_register_api_t)find_export("pv_register_api", NO_SCRIPT, 0); + if (!pvra) { + LM_ERR("Cannot import pv functions (pv module must be loaded before this module)\n"); + return -1; + } + pvra(&pv_api); + return 0; +} /** * init module function @@ -234,7 +247,6 @@ struct module_exports exports = { static int mod_init(void) { unsigned int n; - pv_register_api_t pvra; LM_INFO("Initializing Http Async module\n"); #ifdef STATISTICS @@ -304,13 +316,6 @@ static int mod_init(void) memset(&tmb, 0, sizeof(tm_api_t)); } - pvra = (pv_register_api_t)find_export("pv_register_api", NO_SCRIPT, 0); - if (!pvra) { - LM_ERR("Cannot import pv functions (pv module must be loaded before this module)\n"); - return -1; - } - pvra(&pv_api); - /* allocate workers array */ workers = shm_malloc(num_workers * sizeof(*workers)); if(workers == NULL) {

7 years, 7 months

Kamailio 4.4.2 Crashed on receiving REGISTER

by Owais

Hi guys,I observed a crash in Kamailio IMS P-CSCF when there is an incoming REGISTER.This is Kamailio 4.4.2 installed on Debian 8.3 Jessie on X86_64. Below is the backtrace:Program terminated with signal SIGSEGV, Segmentation fault.#0 0x00007fc9bfa9b143 in unlink_unsafe_dlg (d_entry=0x7fc9b6cd7a10, dlg=0x7fc9c1371c90) at dlg_hash.h:208208 dlg->next->prev = dlg->prev;(gdb) bt#0 0x00007fc9bfa9b143 in unlink_unsafe_dlg (d_entry=0x7fc9b6cd7a10, dlg=0x7fc9c1371c90) at dlg_hash.h:208#1 0x00007fc9bfaabc1c in unref_dlg (dlg=0x7fc9c1371c90, cnt=1) at dlg_hash.c:1056#2 0x00007fc9bfab3f00 in dlg_release (dlg=0x7fc9c1371c90) at dlg_hash.c:1816#3 0x00007fc9baa81aa0 in NAT_Keepalive (msg=0x7fc9c1371c90) at nat_traversal.c:1406#4 0x0000000000573fc1 in do_action (h=0x7ffe69938980, a=0x7fc9c13008e0, msg=0x7fc9c1371c90) at action.c:1054#5 0x00000000005806a6 in run_actions (h=0x7ffe69938980, a=0x7fc9c13003c8, msg=0x7fc9c1371c90) at action.c:1549#6 0x0000000000573f30 in do_action (h=0x7ffe69938980, a=0x7fc9c1300a10, msg=0x7fc9c1371c90) at action.c:1045#7 0x00000000005806a6 in run_actions (h=0x7ffe69938980, a=0x7fc9c12ff6d0, msg=0x7fc9c1371c90) at action.c:1549#8 0x0000000000573f30 in do_action (h=0x7ffe69938980, a=0x7fc9c1300b40, msg=0x7fc9c1371c90) at action.c:1045#9 0x00000000005806a6 in run_actions (h=0x7ffe69938980, a=0x7fc9c12fdca8, msg=0x7fc9c1371c90) at action.c:1549#10 0x0000000000570ae3 in do_action (h=0x7ffe69938980, a=0x7fc9c12d6958, msg=0x7fc9c1371c90) at action.c:678#11 0x00000000005806a6 in run_actions (h=0x7ffe69938980, a=0x7fc9c12d64a0, msg=0x7fc9c1371c90) at action.c:1549#12 0x0000000000580df3 in run_top_route (a=0x7fc9c12d64a0, msg=0x7fc9c1371c90, c=0x0) at action.c:1635#13 0x0000000000588fe9 in receive_msg ( buf=0xa0efc0 "REGISTER sip:domain.com:5432 SIP/2.0\r\nTo: bob<sip:bob@domain.com>\r\nFrom: bob<sip:bob@domain.com>;tag=0e0eaf0d\r\nVia: SIP/2.0/UDP 1.2.3.4:9764;branch=z9hG4bK-d87543-56117650-1--d87543-;rpor"..., len=469, rcv_info=0x7ffe69938c60) at receive.c:240#14 0x00000000004718f8 in udp_rcv_loop () at udp_server.c:495#15 0x00000000004f4f76 in main_loop () at main.c:1600#16 0x00000000004fc4ac in main (argc=3, argv=0x7ffe69939148) at main.c:2616Let me know if any more details are required.Regards,Owais -- View this message in context: http://sip-router.1086192.n5.nabble.com/Kamailio-4-4-2-Crashed-on-receiving… Sent from the Development mailing list archive at Nabble.com.

7 years, 7 months

git:master:73dbed5c: dialog: proper refresh of cseq for requests withing dialog after an increment

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 73dbed5c33b757476e01098b957694b2344bb0a0 URL: https://github.com/kamailio/kamailio/commit/73dbed5c33b757476e01098b957694b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-08-30T17:31:17+02:00 dialog: proper refresh of cseq for requests withing dialog after an increment - reported by GH #752 --- Modified: modules/dialog/dlg_cseq.c --- Diff: https://github.com/kamailio/kamailio/commit/73dbed5c33b757476e01098b957694b… Patch: https://github.com/kamailio/kamailio/commit/73dbed5c33b757476e01098b957694b… --- diff --git a/modules/dialog/dlg_cseq.c b/modules/dialog/dlg_cseq.c index b74cb4e..7c95ce0 100644 --- a/modules/dialog/dlg_cseq.c +++ b/modules/dialog/dlg_cseq.c @@ -193,6 +193,8 @@ int dlg_cseq_update(sip_msg_t *msg) int dlg_cseq_refresh(sip_msg_t *msg, dlg_cell_t *dlg, unsigned int direction) { + unsigned int ninc = 0; + unsigned int vinc = 0; str nval; str *pval; @@ -225,7 +227,19 @@ int dlg_cseq_refresh(sip_msg_t *msg, dlg_cell_t *dlg, goto done; } - nval = *pval; + if(str2int(pval, &vinc)<0) { + LM_ERR("invalid dlg cseq diff var value: %.*s\n", + pval->len, pval->s); + goto done; + } + if(vinc==0) { + LM_DBG("nothing to increment\n"); + goto done; + } + + str2int(&get_cseq(msg)->number, &ninc); + vinc += ninc; + nval.s = int2str(vinc, &nval.len); trim(&nval); LM_DBG("adding cseq refresh header value: %.*s\n", nval.len, nval.s);

7 years, 8 months

git:master:68a0d66e: dialog: proper safety test if cseq value in via is larger than hdr

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 68a0d66e77354a9a6aaf641efe381098064bf18d URL: https://github.com/kamailio/kamailio/commit/68a0d66e77354a9a6aaf641efe38109… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-08-30T16:43:15+02:00 dialog: proper safety test if cseq value in via is larger than hdr --- Modified: modules/dialog/dlg_cseq.c --- Diff: https://github.com/kamailio/kamailio/commit/68a0d66e77354a9a6aaf641efe38109… Patch: https://github.com/kamailio/kamailio/commit/68a0d66e77354a9a6aaf641efe38109… --- diff --git a/modules/dialog/dlg_cseq.c b/modules/dialog/dlg_cseq.c index ad915bd..b74cb4e 100644 --- a/modules/dialog/dlg_cseq.c +++ b/modules/dialog/dlg_cseq.c @@ -291,9 +291,9 @@ int dlg_cseq_msg_received(void *data) } LM_DBG("via cseq cookie [%.*s] val [%.*s]\n", vcseq.len, vcseq.s, vcseq.len-3, vcseq.s+3); - if(vcseq.len-3<get_cseq(&msg)->number.len) { + if(vcseq.len-3>get_cseq(&msg)->number.len) { /* higher lenght to update - wrong */ - LM_DBG("cseq in message (%d) longer than in via (%d)\n", + LM_DBG("cseq in message (%d) shorter than in via (%d)\n", get_cseq(&msg)->number.len, vcseq.len-3); goto done; }

7 years, 8 months

← Newer
1
2
3
4
5
6
7
8
9
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2016