sr-dev June 2016

sr-dev@lists.kamailio.org

37 participants
345 discussions

git:master:26d1426c: cdp: fix compilation warnings

by Victor Seva

Module: kamailio Branch: master Commit: 26d1426cfeb926ee440542716e7365d16b627801 URL: https://github.com/kamailio/kamailio/commit/26d1426cfeb926ee440542716e7365d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 cdp: fix compilation warnings > peerstatemachine.c:97:19: warning: implicit conversion from enumeration type 'peer_state_t' to different enumeration type 'peer_event_t' [-Wenum-conversion] > next_event = I_Snd_Conn_Req(p); > ~ ^~~~~~~~~~~~~~~~~ > peerstatemachine.c:531:10: warning: implicit conversion from enumeration type 'peer_event_t' to different enumeration type 'peer_state_t' [-Wenum-conversion] > return I_Rcv_Conn_NAck; > ~~~~~~ ^~~~~~~~~~~~~~~ > peerstatemachine.c:534:9: warning: implicit conversion from enumeration type 'peer_event_t' to different enumeration type 'peer_state_t' [-Wenum-conversion] > return I_Rcv_Conn_Ack; > ~~~~~~ ^~~~~~~~~~~~~~ > 3 warnings generated. --- Modified: modules/cdp/session.c --- Diff: https://github.com/kamailio/kamailio/commit/26d1426cfeb926ee440542716e7365d… Patch: https://github.com/kamailio/kamailio/commit/26d1426cfeb926ee440542716e7365d… --- diff --git a/modules/cdp/session.c b/modules/cdp/session.c index f418204..3c904c3 100644 --- a/modules/cdp/session.c +++ b/modules/cdp/session.c @@ -73,7 +73,7 @@ unsigned int *session_id2; /**< counter for second part of the session id */ inline void AAASessionsLock(unsigned int hash) { if(destroy_modules_phase()) return; - if ( hash >=0 && hash < sessions_hash_size ){ + if ( hash < sessions_hash_size ){ lock_get(sessions[hash].lock); } else { @@ -88,7 +88,7 @@ inline void AAASessionsUnlock(unsigned int hash) { if(destroy_modules_phase()) return; - if ( hash >=0 && hash < sessions_hash_size ){ + if ( hash < sessions_hash_size ){ lock_release(sessions[hash].lock); } else { @@ -330,7 +330,7 @@ void del_session(cdp_session_t *x) if (!x) return; hash = x->hash; - if (hash < 0 || hash >= sessions_hash_size) { + if (hash >= sessions_hash_size) { LM_ERR("del_session: x->hash :%d out of range of sessions_hash_size: %d !\n",hash, sessions_hash_size); return; }

8 years, 5 months

git:master:007bd7e0: cdp: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: 007bd7e0c874f25ff73bfd36bd210b0fed2bac7a URL: https://github.com/kamailio/kamailio/commit/007bd7e0c874f25ff73bfd36bd210b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 cdp: fix compilation warning > peerstatemachine.c:97:19: warning: implicit conversion from enumeration type 'peer_state_t' to different enumeration type 'peer_event_t' [-Wenum-conversion] > next_event = I_Snd_Conn_Req(p); > ~ ^~~~~~~~~~~~~~~~~ > peerstatemachine.c:531:10: warning: implicit conversion from enumeration type 'peer_event_t' to different enumeration type 'peer_state_t' [-Wenum-conversion] > return I_Rcv_Conn_NAck; > ~~~~~~ ^~~~~~~~~~~~~~~ > peerstatemachine.c:534:9: warning: implicit conversion from enumeration type 'peer_event_t' to different enumeration type 'peer_state_t' [-Wenum-conversion] > return I_Rcv_Conn_Ack; > ~~~~~~ ^~~~~~~~~~~~~~ > 3 warnings generated. --- Modified: modules/cdp/peerstatemachine.c Modified: modules/cdp/peerstatemachine.h --- Diff: https://github.com/kamailio/kamailio/commit/007bd7e0c874f25ff73bfd36bd210b0… Patch: https://github.com/kamailio/kamailio/commit/007bd7e0c874f25ff73bfd36bd210b0… --- diff --git a/modules/cdp/peerstatemachine.c b/modules/cdp/peerstatemachine.c index b5e6dd7..c69cc99 100644 --- a/modules/cdp/peerstatemachine.c +++ b/modules/cdp/peerstatemachine.c @@ -519,7 +519,7 @@ int sm_process(peer *p,peer_event_t event,AAAMessage *msg,int peer_locked,int so * @param p - peer to send to * @returns the new state for the peer */ -peer_state_t I_Snd_Conn_Req(peer *p) +peer_event_t I_Snd_Conn_Req(peer *p) { LM_INFO("I_Snd_Conn_Req(): Peer %.*s \n", p->fqdn.len,p->fqdn.s); diff --git a/modules/cdp/peerstatemachine.h b/modules/cdp/peerstatemachine.h index 47d93f8..4b9ef8a 100644 --- a/modules/cdp/peerstatemachine.h +++ b/modules/cdp/peerstatemachine.h @@ -50,7 +50,7 @@ int sm_process(peer *p,peer_event_t event,AAAMessage *msg,int peer_locked,int sock); -peer_state_t I_Snd_Conn_Req(peer *p); +peer_event_t I_Snd_Conn_Req(peer *p); void Cleanup(peer *p,int sock); void Error(peer *p, int sock); void I_Snd_CER(peer *p);

8 years, 5 months

git:master:c3bbe6e0: pua_xmpp: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: c3bbe6e059ade56959b68e6caae2f8521734f502 URL: https://github.com/kamailio/kamailio/commit/c3bbe6e059ade56959b68e6caae2f85… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 pua_xmpp: fix compilation warning > xmpp2simple.c:372:10: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion] > slash= '\0'; > ^~~~ > 1 warning generated. --- Modified: modules/pua_xmpp/xmpp2simple.c --- Diff: https://github.com/kamailio/kamailio/commit/c3bbe6e059ade56959b68e6caae2f85… Patch: https://github.com/kamailio/kamailio/commit/c3bbe6e059ade56959b68e6caae2f85… --- diff --git a/modules/pua_xmpp/xmpp2simple.c b/modules/pua_xmpp/xmpp2simple.c index 0d14125..709351c 100644 --- a/modules/pua_xmpp/xmpp2simple.c +++ b/modules/pua_xmpp/xmpp2simple.c @@ -369,7 +369,7 @@ int build_publish(xmlNodePtr pres_node, int expires) return -1; } strcpy(resource, slash+1); - slash= '\0'; + slash= NULL; } pres_uri= euri_xmpp_sip(uri); xmlFree(uri);

8 years, 5 months

git:master:bb545d02: peering: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: bb545d02225f23e7d1d9c950f2e4645db3d33c4f URL: https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 peering: fix compilation warning > verify.c:58:30: warning: comparison of array 'vp->strvalue' equal to a null pointer is always false [-Wtautological-pointer-compare] > if (vp->lvalue==0 || vp->strvalue==0) > ~~~~^~~~~~~~ ~ > 1 warning generated. --- Modified: modules/peering/verify.c --- Diff: https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645… Patch: https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645… --- diff --git a/modules/peering/verify.c b/modules/peering/verify.c index cafd12c..743fcfe 100644 --- a/modules/peering/verify.c +++ b/modules/peering/verify.c @@ -55,7 +55,7 @@ static inline int extract_avp(VALUE_PAIR* vp, unsigned short *flags, char *end; /* empty? */ - if (vp->lvalue==0 || vp->strvalue==0) + if (vp->lvalue==0) goto error; p = vp->strvalue;

8 years, 5 months

git:master:4e2f17df: misc_radius: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: 4e2f17dfc6ae25739cb40328f3d5636ea1ab6fca URL: https://github.com/kamailio/kamailio/commit/4e2f17dfc6ae25739cb40328f3d5636… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 misc_radius: fix compilation warning > functions.c:47:27: warning: comparison of array 'vp->strvalue' equal to a null pointer is always false [-Wtautological-pointer-compare] > if (vp->lvalue==0 || vp->strvalue==0) > ~~~~^~~~~~~~ ~ > 1 warning generated. --- Modified: modules/misc_radius/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/4e2f17dfc6ae25739cb40328f3d5636… Patch: https://github.com/kamailio/kamailio/commit/4e2f17dfc6ae25739cb40328f3d5636… --- diff --git a/modules/misc_radius/functions.c b/modules/misc_radius/functions.c index fb9ec78..e171468 100644 --- a/modules/misc_radius/functions.c +++ b/modules/misc_radius/functions.c @@ -44,7 +44,7 @@ static inline int extract_avp(VALUE_PAIR* vp, unsigned short *flags, char *end; /* empty? */ - if (vp->lvalue==0 || vp->strvalue==0) + if (vp->lvalue==0) goto error; p = vp->strvalue;

8 years, 5 months

git:master:1db19f16: auth_radius: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: 1db19f1672ebebcb916f4415c59f5c820a1b0068 URL: https://github.com/kamailio/kamailio/commit/1db19f1672ebebcb916f4415c59f5c8… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 auth_radius: fix compilation warning > authorize.c:110:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_NONCE_REUSED; > ~ ^~~~~~~~~~~~~~~~~ > authorize.c:114:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_STALE_NONCE; > ~ ^~~~~~~~~~~~~~~~ > authorize.c:120:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_ERROR; > ~ ^~~~~~~~~~ > authorize.c:124:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_NO_CREDENTIALS; > ~ ^~~~~~~~~~~~~~~~~~~ > authorize.c:131:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_OK; > ~ ^~~~~~~ > authorize.c:148:9: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_ERROR; > ~ ^~~~~~~~~~ > authorize.c:153:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_ERROR; > ~ ^~~~~~~~~~ > authorize.c:159:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_ERROR;; > ~ ^~~~~~~~~~ > authorize.c:186:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_ERROR; > ~ ^~~~~~~~~~ > authorize.c:189:12: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_OK; > ~ ^~~~~~~ > authorize.c:193:8: warning: implicit conversion from enumeration type 'enum auth_cfg_result' to different enumeration type 'auth_result_t' (aka 'enum auth_result') [-Wenum-conversion] > ret = AUTH_INVALID_PASSWORD; > ~ ^~~~~~~~~~~~~~~~~~~~~ > 11 warnings generated. --- Modified: modules/auth_radius/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/1db19f1672ebebcb916f4415c59f5c8… Patch: https://github.com/kamailio/kamailio/commit/1db19f1672ebebcb916f4415c59f5c8… --- diff --git a/modules/auth_radius/authorize.c b/modules/auth_radius/authorize.c index 18dff11..36c74eb 100644 --- a/modules/auth_radius/authorize.c +++ b/modules/auth_radius/authorize.c @@ -74,7 +74,7 @@ static inline int authorize(struct sip_msg* _msg, pv_elem_t* _realm, pv_spec_t * _uri_user, hdr_types_t _hftype) { int res; - auth_result_t ret; + auth_cfg_result_t ret; struct hdr_field* h; auth_body_t* cred; str *uri_user;

8 years, 5 months

git:master:6e376ee2: db_berkeley: fix compilation warning

by Victor Seva

Module: kamailio Branch: master Commit: 6e376ee273cb95afae31b0183e3b7bf3468c4520 URL: https://github.com/kamailio/kamailio/commit/6e376ee273cb95afae31b0183e3b7bf… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2016-06-06T12:05:39+02:00 db_berkeley: fix compilation warning > km_db_berkeley.c:486:58: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] > if ((ret = bdb_get_columns(_tbc->dtp, *_r, lres, _nc)) < 0) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > km_db_berkeley.c:513:50: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] > if ((ret=bdb_append_row( *_r, dbuf, lres, i)) < 0) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > km_db_berkeley.c:567:58: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] > if ((ret = bdb_get_columns(_tbc->dtp, *_r, lres, _nc)) < 0) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > km_db_berkeley.c:572:47: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] > if ((ret=bdb_convert_row( *_r, dbuf, lres)) < 0) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ > 4 warnings generated. --- Modified: modules/db_berkeley/km_db_berkeley.c --- Diff: https://github.com/kamailio/kamailio/commit/6e376ee273cb95afae31b0183e3b7bf… Patch: https://github.com/kamailio/kamailio/commit/6e376ee273cb95afae31b0183e3b7bf… --- diff --git a/modules/db_berkeley/km_db_berkeley.c b/modules/db_berkeley/km_db_berkeley.c index 9b0806e..e7e05f5 100644 --- a/modules/db_berkeley/km_db_berkeley.c +++ b/modules/db_berkeley/km_db_berkeley.c @@ -362,9 +362,10 @@ int km_bdb_query(db1_con_t* _con, db_key_t* _k, db_op_t* _op, db_val_t* _v, table_p _tp = NULL; char kbuf[MAX_ROW_SIZE]; char dbuf[MAX_ROW_SIZE]; - u_int32_t i, len, ret; + u_int32_t i, len; int klen=MAX_ROW_SIZE; int *lkey=NULL, *lres=NULL; + int ret; DBT key, data; DB *db; DBC *dbcp;

8 years, 5 months

[kamailio/kamailio] fix compilation warnings #653 (#657)

by Victor Seva

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/657 -- Commit Summary -- * db_berkeley: fix compilation warning * auth_radius: fix compilation warning * misc_radius: fix compilation warning * peering: fix compilation warning * pua_xmpp: fix compilation warning * cdp: fix compilation warning * cdp: fix compilation warnings * cdp: fix compilation warning -- File Changes -- M modules/auth_radius/authorize.c (2) M modules/cdp/diameter_api.h (2) M modules/cdp/diameter_msg.c (2) M modules/cdp/peerstatemachine.c (2) M modules/cdp/peerstatemachine.h (2) M modules/cdp/session.c (6) M modules/db_berkeley/km_db_berkeley.c (3) M modules/misc_radius/functions.c (2) M modules/peering/verify.c (2) M modules/pua_xmpp/xmpp2simple.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/657.patch https://github.com/kamailio/kamailio/pull/657.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/657

8 years, 5 months

A: Upgrading kamailio.org os

by Daniel-Constantin Mierla

Hello, a short note to announce that the os on kamailio.org server will be upgraded in the near future, likely next week, exact date still to be decided. Hopefully there will be only very short downtime intervals. Main affected services: website (including the wiki) and mailing lists. I will send a notification once the procedure starts, but I wanted to allow enough time for this information to propagate properly within the community. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com - http://www.kamailio.org http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

8 years, 5 months

git:master:9a8db8f6: modules/ims_qos: bandiwdth only added to AAR if > 0

by jaybeepee

Module: kamailio Branch: master Commit: 9a8db8f6952ae7209a5d268a16e184a1a9979eb7 URL: https://github.com/kamailio/kamailio/commit/9a8db8f6952ae7209a5d268a16e184a… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2016-06-07T08:42:15+02:00 modules/ims_qos: bandiwdth only added to AAR if > 0 --- Modified: modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/9a8db8f6952ae7209a5d268a16e184a… Patch: https://github.com/kamailio/kamailio/commit/9a8db8f6952ae7209a5d268a16e184a… --- diff --git a/modules/ims_qos/rx_avp.c b/modules/ims_qos/rx_avp.c index 2757bad..124855c 100644 --- a/modules/ims_qos/rx_avp.c +++ b/modules/ims_qos/rx_avp.c @@ -489,7 +489,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s // Get A=RS-bandwidth from SDP-Reply: bandwidth = sdp_b_value(rpl_raw_payload, "RS"); LM_DBG("Answer: Got bandwidth %i from b=RS-Line\n", bandwidth); - if (bandwidth >= 0U) { + if (bandwidth > 0) { // Add AVP set_4bytes(x,bandwidth); rs_bw = cdpb.AAACreateAVP(AVP_EPC_RS_Bandwidth, @@ -501,7 +501,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s // Get A=RS-bandwidth from SDP-Reply: bandwidth = sdp_b_value(rpl_raw_payload, "RR"); LM_DBG("Answer: Got bandwidth %i from b=RR-Line\n", bandwidth); - if (bandwidth >= 0U) { + if (bandwidth > 0) { // Add AVP set_4bytes(x,bandwidth); rr_bw = cdpb.AAACreateAVP(AVP_EPC_RR_Bandwidth,

8 years, 5 months

← Newer
1
...
24
25
26
27
28
29
30
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2016