sr-dev June 2016

sr-dev@lists.kamailio.org

37 participants
345 discussions

IMC upgrade
by Olle E. Johansson 20 Jun '16

20 Jun '16

Hi! Just to alert you all about a few upcoming changes to the IMC - Instant messaging multiparty chat - module that I’m working on. Any feedback is welcome! - Adding RPC commands to manage rooms - create - list - list members - add member - kick member - Adding a function to disable the addition of the name into the message - Adding functionality to carry the content-type over and not adding name into the message unless it’s text This is to support iscomposing messages - Adding a function to disable rewrite of headers so you can keep the From: header and use a Reply-To: header to get messages back into the chat instead of to the author of one message. I am done with the RPC commands and am now working on the headers and new modparams. Will try to commit the RPC commands this or next week (it’s a big holiday in Sweden at the end of this week - midsummer). If you are working on the IMC module too, please get in touch with me so we can coordinate. Cheers, /O

1 0

git:master:feb195b2: db_unixodbc: do not consider SQL_NO_DATA return code as an error
by Daniel-Constantin Mierla 17 Jun '16

17 Jun '16

Module: kamailio Branch: master Commit: feb195b2d9c801bc3591b1e95de6b70956e76dfe URL: https://github.com/kamailio/kamailio/commit/feb195b2d9c801bc3591b1e95de6b70… Author: Giovanni Mele <giovanni.mele(a)nagra.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-06-17T16:57:48+02:00 db_unixodbc: do not consider SQL_NO_DATA return code as an error --- Modified: modules/db_unixodbc/dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/feb195b2d9c801bc3591b1e95de6b70… Patch: https://github.com/kamailio/kamailio/commit/feb195b2d9c801bc3591b1e95de6b70… --- diff --git a/modules/db_unixodbc/dbase.c b/modules/db_unixodbc/dbase.c index bef60e2..f322ba3 100644 --- a/modules/db_unixodbc/dbase.c +++ b/modules/db_unixodbc/dbase.c @@ -127,7 +127,9 @@ static int db_unixodbc_submit_query(const db1_con_t* _h, const str* _s) } ret=SQLExecDirect(CON_RESULT(_h), (SQLCHAR*)_s->s, _s->len); - if (!SQL_SUCCEEDED(ret)) + + /* Handle SQL_NO_DATA as a valid return code. DELETE and UPDATE statements may return this return code if nothing was deleted/updated. */ + if (!SQL_SUCCEEDED(ret) && (ret != SQL_NO_DATA)) { SQLCHAR sqlstate[7]; LM_ERR("rv=%d. Query= %.*s\n", ret, _s->len, _s->s);

1 0

git:master:f121e7c0: tm: actions triggered by t_coninue() executed as FAILURE_ROUTE type
by Daniel-Constantin Mierla 17 Jun '16

17 Jun '16

Module: kamailio Branch: master Commit: f121e7c099ebf862dedcd5bdc1652d188446aa72 URL: https://github.com/kamailio/kamailio/commit/f121e7c099ebf862dedcd5bdc1652d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-06-17T16:01:32+02:00 tm: actions triggered by t_coninue() executed as FAILURE_ROUTE type - the callback for scripting routing blocks are already those for failure route and the transaction is already created, all processing happing in the context of invalidating the "suspended" special branch - should prevent mistaken use of functions restricted for request route, such as msg_apply_changes() - following a report by Victor Seva, GH #676 --- Modified: modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/f121e7c099ebf862dedcd5bdc1652d1… Patch: https://github.com/kamailio/kamailio/commit/f121e7c099ebf862dedcd5bdc1652d1… --- diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index 828aa38..e8096bb 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -176,6 +176,7 @@ int t_continue(unsigned int hash_index, unsigned int label, int reply_status; int do_put_on_wait; struct hdr_field *hdr, *prev = 0, *tmp = 0; + int route_type_bk; if (t_lookup_ident(&t, hash_index, label) < 0) { LM_ERR("transaction not found\n"); @@ -224,9 +225,10 @@ int t_continue(unsigned int hash_index, unsigned int label, break; } - if(t->async_backup.backup_route != TM_ONREPLY_ROUTE){ - branch = t->async_backup.blind_uac; /* get the branch of the blind UAC setup - * during suspend */ + if(t->async_backup.backup_route != TM_ONREPLY_ROUTE) { + /* resume processing of a sip request */ + /* get the branch of the blind UAC setup during suspend */ + branch = t->async_backup.blind_uac; if (branch >= 0) { stop_rb_timers(&t->uac[branch].request); @@ -269,12 +271,15 @@ int t_continue(unsigned int hash_index, unsigned int label, } faked_env( t, &faked_req, 1); + route_type_bk = get_route_type(); + set_route_type(FAILURE_ROUTE); /* execute the pre/post -script callbacks based on original route block */ if (exec_pre_script_cb(&faked_req, cb_type)>0) { if (run_top_route(route, &faked_req, 0)<0) LM_ERR("failure inside run_top_route\n"); exec_post_script_cb(&faked_req, cb_type); } + set_route_type(route_type_bk); /* TODO: save_msg_lumps should clone the lumps to shm mem */ @@ -306,6 +311,7 @@ int t_continue(unsigned int hash_index, unsigned int label, } } else { + /* resume processing of a sip response */ branch = t->async_backup.backup_branch; init_cancel_info(&cancel_data);

1 0

git:master:5a7ec642: modules: readme files regenerated - textopsx ...
by Kamailio Dev 17 Jun '16

17 Jun '16

Module: kamailio Branch: master Commit: 5a7ec64237323d9bf402aacd6cb8f4e1921fdfbc URL: https://github.com/kamailio/kamailio/commit/5a7ec64237323d9bf402aacd6cb8f4e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2016-06-17T15:31:17+02:00 modules: readme files regenerated - textopsx ... --- Modified: modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/5a7ec64237323d9bf402aacd6cb8f4e… Patch: https://github.com/kamailio/kamailio/commit/5a7ec64237323d9bf402aacd6cb8f4e… --- diff --git a/modules/textopsx/README b/modules/textopsx/README index f54c8c2..b3ab14c 100644 --- a/modules/textopsx/README +++ b/modules/textopsx/README @@ -123,7 +123,12 @@ Chapter 1. Admin Guide no longer valid for config processing, like it happens when a broken message is received from network). - This function can be used from REQUEST_ROUTE or ONREPLY_ROUTE. + This function can be used from REQUEST_ROUTE or core REPLY_ROUTE. + + Note: It must be used before the transaction is created in + request_route and not inside the onreply_route[name] executed by tm + module. Also, do not used after resuming a suspended request or reply, + at that moment the transaction is already created. Example 1.1. msg_apply_changes() usage ...

1 0

git:master:474ab228: textops: more details in doc about limitations of msg_apply_changes()
by Daniel-Constantin Mierla 17 Jun '16

17 Jun '16

Module: kamailio Branch: master Commit: 474ab2280309574236f796f76e3b61251d8d23bd URL: https://github.com/kamailio/kamailio/commit/474ab2280309574236f796f76e3b612… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-06-17T15:24:48+02:00 textops: more details in doc about limitations of msg_apply_changes() --- Modified: modules/textopsx/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/474ab2280309574236f796f76e3b612… Patch: https://github.com/kamailio/kamailio/commit/474ab2280309574236f796f76e3b612… --- diff --git a/modules/textopsx/doc/functions.xml b/modules/textopsx/doc/functions.xml index 280b730..28bc7f1 100644 --- a/modules/textopsx/doc/functions.xml +++ b/modules/textopsx/doc/functions.xml @@ -24,7 +24,13 @@ broken message is received from network). </para> <para> - This function can be used from REQUEST_ROUTE or ONREPLY_ROUTE. + This function can be used from REQUEST_ROUTE or core REPLY_ROUTE. + </para> + <para> + Note: It must be used before the transaction is created in + request_route and not inside the onreply_route[name] executed by tm + module. Also, do not used after resuming a suspended request or reply, + at that moment the transaction is already created. </para> <example> <title><function>msg_apply_changes()</function> usage</title>

1 0

git:master:0fa4013b: http_client Add documentation issue for http_client_query to the list
by Olle E. Johansson 17 Jun '16

17 Jun '16

Module: kamailio Branch: master Commit: 0fa4013b70126ead21a607007033335e477b1978 URL: https://github.com/kamailio/kamailio/commit/0fa4013b70126ead21a607007033335… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-06-17T08:51:37+02:00 http_client Add documentation issue for http_client_query to the list --- Modified: modules/http_client/TODO.txt --- Diff: https://github.com/kamailio/kamailio/commit/0fa4013b70126ead21a607007033335… Patch: https://github.com/kamailio/kamailio/commit/0fa4013b70126ead21a607007033335… --- diff --git a/modules/http_client/TODO.txt b/modules/http_client/TODO.txt index 81bde1b..3a23dd8 100644 --- a/modules/http_client/TODO.txt +++ b/modules/http_client/TODO.txt @@ -89,6 +89,8 @@ Development API https://curl.haxx.se/libcurl/c/CURLOPT_CAINFO.html This can be set in the httpconf object +- Document that some options like useragent doesn't work in the + old http_query function Issues in the bug tracker

1 0

git:master:20ac0d5c: modules: readme files regenerated - http_async_client ...
by Kamailio Dev 16 Jun '16

16 Jun '16

Module: kamailio Branch: master Commit: 20ac0d5c467aa8dbd470a4a7fb5e32a90a5ca85f URL: https://github.com/kamailio/kamailio/commit/20ac0d5c467aa8dbd470a4a7fb5e32a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2016-06-16T12:31:19+02:00 modules: readme files regenerated - http_async_client ... --- Modified: modules/http_async_client/README --- Diff: https://github.com/kamailio/kamailio/commit/20ac0d5c467aa8dbd470a4a7fb5e32a… Patch: https://github.com/kamailio/kamailio/commit/20ac0d5c467aa8dbd470a4a7fb5e32a…

1 0

[kamailio/kamailio] http_async_client: Minor code and doc review (#673)
by Giacomo Vacca 16 Jun '16

16 Jun '16

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/673 -- Commit Summary -- * http_async_client Minor indentations, code duplication * http_async_client minor doc update -- File Changes -- M modules/http_async_client/doc/http_async_client_admin.xml (36) M modules/http_async_client/http_async_client_mod.c (15) M modules/http_async_client/http_multi.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/673.patch https://github.com/kamailio/kamailio/pull/673.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/673

2 2

git:master:4788ab5f: Merge pull request #673 from giavac/master
by GitHub 16 Jun '16

16 Jun '16

Module: kamailio Branch: master Commit: 4788ab5fd590edb0cde95304bec183bf7517232f URL: https://github.com/kamailio/kamailio/commit/4788ab5fd590edb0cde95304bec183b… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2016-06-16T12:30:36+02:00 Merge pull request #673 from giavac/master http_async_client: Minor code and doc review --- Modified: modules/http_async_client/doc/http_async_client_admin.xml Modified: modules/http_async_client/http_async_client_mod.c Modified: modules/http_async_client/http_multi.c --- Diff: https://github.com/kamailio/kamailio/commit/4788ab5fd590edb0cde95304bec183b… Patch: https://github.com/kamailio/kamailio/commit/4788ab5fd590edb0cde95304bec183b…

1 0

git:master:219a76af: http_async_client minor doc update
by Giacomo Vacca 16 Jun '16

16 Jun '16

Module: kamailio Branch: master Commit: 219a76af9caefbabe7adfc91594eb4efe752b97d URL: https://github.com/kamailio/kamailio/commit/219a76af9caefbabe7adfc91594eb4e… Author: Giacomo Vacca <giacomo.vacca(a)gmail.com> Committer: Giacomo Vacca <giacomo.vacca(a)gmail.com> Date: 2016-06-16T12:11:52+02:00 http_async_client minor doc update --- Modified: modules/http_async_client/doc/http_async_client_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/219a76af9caefbabe7adfc91594eb4e… Patch: https://github.com/kamailio/kamailio/commit/219a76af9caefbabe7adfc91594eb4e…

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2016