sr-dev May 2016

sr-dev@lists.kamailio.org

28 participants
350 discussions

git:master:6b23c27d: xmlrpc: user libxml function to get content of node if type not provided for param
by Daniel-Constantin Mierla 03 May '16

03 May '16

Module: kamailio Branch: master Commit: 6b23c27d8406780083a6b7bb774efa2a53aea540 URL: https://github.com/kamailio/kamailio/commit/6b23c27d8406780083a6b7bb774efa2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-03T16:59:06+02:00 xmlrpc: user libxml function to get content of node if type not provided for param - it is considered to be string according to specs - old implementation was using the pointer inside the xmlNode struct, which may not be available later to free again by xmlrpc module garbage collector - reported by Juha Heinanen --- Modified: modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/6b23c27d8406780083a6b7bb774efa2… Patch: https://github.com/kamailio/kamailio/commit/6b23c27d8406780083a6b7bb774efa2… --- diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index 8761c02..dabb526 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -1407,6 +1407,7 @@ static int get_string(char** val, struct xmlrpc_reply* reply, return -1; } type=xml_get_type(dbl); + LM_DBG("xmrpc parameter type: %d\n", type); switch(type){ case XML_T_STR: case XML_T_TXT: @@ -1423,7 +1424,7 @@ static int get_string(char** val, struct xmlrpc_reply* reply, return -1; } if (type == XML_T_TXT) - val_str = (char*)dbl->content; + val_str = (char*)xmlNodeGetContent(dbl); else val_str = (char*)xmlNodeListGetString(doc, dbl->xmlChildrenNode, 1);

1 0

git:master:cd67fbb8: sdpops: safety check if sdp pointer is null inside sdp_get()
by Daniel-Constantin Mierla 03 May '16

03 May '16

Module: kamailio Branch: master Commit: cd67fbb8ecb83944f458ec8a127adc14d5b38aeb URL: https://github.com/kamailio/kamailio/commit/cd67fbb8ecb83944f458ec8a127adc1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-03T10:18:11+02:00 sdpops: safety check if sdp pointer is null inside sdp_get() --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/cd67fbb8ecb83944f458ec8a127adc1… Patch: https://github.com/kamailio/kamailio/commit/cd67fbb8ecb83944f458ec8a127adc1… --- diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index d63cd78..5984332 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -1502,14 +1502,15 @@ static int w_sdp_get(sip_msg_t* msg, char *avp) } sdp = (sdp_info_t*)msg->body; - if (sdp_missing) { + if (sdp==NULL) { LM_DBG("No SDP\n"); return -2; - } else { - avp_val.s.s = sdp->raw_sdp.s; - avp_val.s.len = sdp->raw_sdp.len; - LM_DBG("Found SDP %.*s\n", sdp->raw_sdp.len, sdp->raw_sdp.s); } + + avp_val.s.s = sdp->raw_sdp.s; + avp_val.s.len = sdp->raw_sdp.len; + LM_DBG("Found SDP %.*s\n", sdp->raw_sdp.len, sdp->raw_sdp.s); + if (add_avp(AVP_VAL_STR | avp_type, avp_name, avp_val) != 0) { LM_ERR("Failed to add SDP avp");

1 0

git:master:1ef02bcb: sdpops: added $sdp(body) config variable
by Daniel-Constantin Mierla 03 May '16

03 May '16

Module: kamailio Branch: master Commit: 1ef02bcb83b3a770ccaaa8dbdd49c424fab929f6 URL: https://github.com/kamailio/kamailio/commit/1ef02bcb83b3a770ccaaa8dbdd49c42… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-03T10:12:59+02:00 sdpops: added $sdp(body) config variable - return the sdp body as raw string --- Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1ef02bcb83b3a770ccaaa8dbdd49c42… Patch: https://github.com/kamailio/kamailio/commit/1ef02bcb83b3a770ccaaa8dbdd49c42… --- diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 69003eb..d63cd78 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -63,6 +63,10 @@ static int w_sdp_with_ice(sip_msg_t* msg, char* foo, char *bar); static int w_sdp_get_line_startswith(sip_msg_t* msg, char *foo, char *bar); +static int pv_get_sdp(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res); +static int pv_parse_sdp_name(pv_spec_p sp, str *in); + static int mod_init(void); static cmd_export_t cmds[] = { @@ -116,11 +120,9 @@ static cmd_export_t cmds[] = { }; static pv_export_t mod_pvs[] = { -#if 0 {{"sdp", (sizeof("sdp")-1)}, /* */ PVT_OTHER, pv_get_sdp, 0, - 0, 0, 0, 0}, -#endif + pv_parse_sdp_name, 0, 0, 0}, { {0, 0}, 0, 0, 0, 0, 0, 0, 0 } }; @@ -1741,3 +1743,62 @@ int bind_sdpops(struct sdpops_binds *sob){ sob->sdp_remove_codecs_by_name = sdp_remove_codecs_by_name; return 0; } + +/** + * + */ +static int pv_get_sdp(sip_msg_t *msg, pv_param_t *param, + pv_value_t *res) +{ + sdp_info_t *sdp = NULL; + + if(msg==NULL || param==NULL) + return -1; + + if(parse_sdp(msg) < 0) { + LM_INFO("Unable to parse sdp\n"); + return pv_get_null(msg, param, res); + } + sdp = (sdp_info_t*)msg->body; + + if (sdp==NULL) { + LM_DBG("No SDP\n"); + return pv_get_null(msg, param, res); + } + + switch(param->pvn.u.isname.name.n) + { + case 0: + return pv_get_strval(msg, param, res, &sdp->raw_sdp); + default: + return pv_get_null(msg, param, res); + } +} + +/** + * + */ +static int pv_parse_sdp_name(pv_spec_p sp, str *in) +{ + if(sp==NULL || in==NULL || in->len<=0) + return -1; + + switch(in->len) + { + case 4: + if(strncmp(in->s, "body", 4)==0) + sp->pvp.pvn.u.isname.name.n = 0; + else goto error; + break; + default: + goto error; + } + sp->pvp.pvn.type = PV_NAME_INTSTR; + sp->pvp.pvn.u.isname.type = 0; + + return 0; + +error: + LM_ERR("unknown PV sdp name %.*s\n", in->len, in->s); + return -1; +}

1 0

git:master:c4299225: sdpops: removed svn $Id$ lines, coherent indentation and whitespacing
by Daniel-Constantin Mierla 03 May '16

03 May '16

Module: kamailio Branch: master Commit: c4299225989d9ccf47c18e50b0014025270c65c7 URL: https://github.com/kamailio/kamailio/commit/c4299225989d9ccf47c18e50b001402… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-03T08:48:02+02:00 sdpops: removed svn $Id$ lines, coherent indentation and whitespacing - added license header text --- Modified: modules/sdpops/api.h Modified: modules/sdpops/sdpops_data.c Modified: modules/sdpops/sdpops_data.h Modified: modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/c4299225989d9ccf47c18e50b001402… Patch: https://github.com/kamailio/kamailio/commit/c4299225989d9ccf47c18e50b001402…

1 0

[kamailio/kamailio] Kamailio system files for Oracle Enterprise Linux 6/7 (#591)
by Konstantin S. Vishnivetsky 02 May '16

02 May '16

Added Kamailio system files for Oracle Enterprise Linux 6/7 Created a directory structure under <SRCROOT>/pkg/kamailio directory for Oracle Enterprise Linux. File oracle/kamailio.spec moved to oracle/el6/kamailio.spec Added init scripts and defaults for kamailio under oracle/el6 directory. Added systemd service and sysconfig script for kamailio under oracle/el7 directory. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/591 -- Commit Summary -- * Added Oracle Enterpise Linux 6 SPEC, init script and defaults script. * Added Oracle Enterpise Linux 7 SPEC, init script and defaults script. * Added logrotate and rsyslog samples for kamailio * FIX: do not enable kamailio service after installation, only reload systmd daemon -- File Changes -- A pkg/kamailio/oracle/el6/kamailio.default (30) A pkg/kamailio/oracle/el6/kamailio.init (128) R pkg/kamailio/oracle/el6/kamailio.spec (4) A pkg/kamailio/oracle/el7/kamailio.service (17) A pkg/kamailio/oracle/el7/kamailio.spec (854) A pkg/kamailio/oracle/el7/kamailio.sysconfig (36) A pkg/kamailio/oracle/kamailio.logrotate (7) A pkg/kamailio/oracle/kamailio.rsyslog (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/591.patch https://github.com/kamailio/kamailio/pull/591.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/591

2 2

git:master:e72c7e06: pkg/rpm: added folders with rpm specs for oracle el6 and el7
by Daniel-Constantin Mierla 02 May '16

02 May '16

Module: kamailio Branch: master Commit: e72c7e068dd510a56033ce422343675aa0fdafe7 URL: https://github.com/kamailio/kamailio/commit/e72c7e068dd510a56033ce422343675… Author: Konstantin S. Vishnivetsky <voip-projects(a)vishnivetsky.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T16:03:50+02:00 pkg/rpm: added folders with rpm specs for oracle el6 and el7 --- Added: pkg/kamailio/oracle/el6/kamailio.default Added: pkg/kamailio/oracle/el6/kamailio.init Added: pkg/kamailio/oracle/el6/kamailio.spec Added: pkg/kamailio/oracle/el7/kamailio.service Added: pkg/kamailio/oracle/el7/kamailio.spec Added: pkg/kamailio/oracle/el7/kamailio.sysconfig Added: pkg/kamailio/oracle/kamailio.logrotate Added: pkg/kamailio/oracle/kamailio.rsyslog Removed: pkg/kamailio/oracle/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/e72c7e068dd510a56033ce422343675… Patch: https://github.com/kamailio/kamailio/commit/e72c7e068dd510a56033ce422343675…

1 0

[kamailio/kamailio] a single digit is a valid enum_query() request (#593)
by Jonas 02 May '16

02 May '16

We use enum_query() to dispatch calls over a set of gateways. In our case single digits (for instance "8") can be a valid direct dial number which we would like to through against our enum server. Is there any good reason to limit the request to 2 digits as minimum? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/593 -- Commit Summary -- * a single number should be a valid in function enum_query() * print out malformed enum_query() request in enum.c -- File Changes -- M modules/enum/enum.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/593.patch https://github.com/kamailio/kamailio/pull/593.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/593

2 2

git:4.4:72ddb3a7: lib/srdb1: adjust the length of str time representation for no-quotes
by Daniel-Constantin Mierla 02 May '16

02 May '16

Module: kamailio Branch: 4.4 Commit: 72ddb3a70dfc88404eacf0a878f36cc56de2e74e URL: https://github.com/kamailio/kamailio/commit/72ddb3a70dfc88404eacf0a878f36cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T11:47:48+02:00 lib/srdb1: adjust the length of str time representation for no-quotes - used only by usrloc fix done in previous commit (cherry picked from commit f54c723d9d8b8dcd0ad09c3787f3bb2e823d82b8) --- Modified: lib/srdb1/db_ut.c --- Diff: https://github.com/kamailio/kamailio/commit/72ddb3a70dfc88404eacf0a878f36cc… Patch: https://github.com/kamailio/kamailio/commit/72ddb3a70dfc88404eacf0a878f36cc… --- diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index 96ca326..6b3bad4 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -264,8 +264,10 @@ inline int db_time2str_ex(time_t _v, char* _s, int* _l, int _qmode) } *_l = l; - if(_qmode) *(_s + l) = '\''; - *_l = l + 2; + if(_qmode) { + *(_s + l) = '\''; + *_l = l + 2; + } return 0; }

1 0

git:master:f54c723d: lib/srdb1: adjust the length of str time representation for no-quotes
by Daniel-Constantin Mierla 02 May '16

02 May '16

Module: kamailio Branch: master Commit: f54c723d9d8b8dcd0ad09c3787f3bb2e823d82b8 URL: https://github.com/kamailio/kamailio/commit/f54c723d9d8b8dcd0ad09c3787f3bb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T11:46:30+02:00 lib/srdb1: adjust the length of str time representation for no-quotes - used only by usrloc fix done in previous commit --- Modified: lib/srdb1/db_ut.c --- Diff: https://github.com/kamailio/kamailio/commit/f54c723d9d8b8dcd0ad09c3787f3bb2… Patch: https://github.com/kamailio/kamailio/commit/f54c723d9d8b8dcd0ad09c3787f3bb2… --- diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index 96ca326..6b3bad4 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -264,8 +264,10 @@ inline int db_time2str_ex(time_t _v, char* _s, int* _l, int _qmode) } *_l = l; - if(_qmode) *(_s + l) = '\''; - *_l = l + 2; + if(_qmode) { + *(_s + l) = '\''; + *_l = l + 2; + } return 0; }

1 0

git: new commits in branch 4.4
by Daniel-Constantin Mierla 02 May '16

02 May '16

- URL: https://github.com/kamailio/kamailio/commit/74052b4a0f50b19d42a6fbcae3df381… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:33:13+02:00 core: declare function parameter type to get rid of compile warning (cherry picked from commit ad2f899c1ad75c2b636cb17b6c1c49cb38daab27) - URL: https://github.com/kamailio/kamailio/commit/3616af6b5f2aae383c93507563a3391… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:34:06+02:00 Makefile.rules: added target tags as alias for target TAGS (cherry picked from commit b024f5aea72f172b39dd4d8947934be52f07dbe4) - URL: https://github.com/kamailio/kamailio/commit/d8a893d45d891bc3f8d00e3e76c9cd9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:34:29+02:00 core: receive.c coherent indentation (cherry picked from commit 7de8a92fd805b73495cc929cf9ca981ecd509c9a) - URL: https://github.com/kamailio/kamailio/commit/0110a8b55ba9d48aa22123802d2a562… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:35:49+02:00 app_python: coherent indetation and whitespacing (cherry picked from commit 8d7c12ab295fdb41390dd56744cc0b012851788b) - URL: https://github.com/kamailio/kamailio/commit/2181edd60a2597a75eef7e2529faf0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:36:01+02:00 app_python: fix of buf memory allocation size for chars (cherry picked from commit 5042f309739460ad87dc9a064c43e602602da703) - URL: https://github.com/kamailio/kamailio/commit/56f5009939e058ac4a9bc356f85b32c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:36:55+02:00 htable: updated the list of exported variables (cherry picked from commit 866270a7cc45205deab5b067be68e5c6a66704e8) - URL: https://github.com/kamailio/kamailio/commit/f583f0751a7e78bc8ba5ed19ff7fbfe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:37:05+02:00 htable: coherent indentation and whitespacing (cherry picked from commit 79ad0e2d8a926e867b1f9e69a065e9b1727671ea) - URL: https://github.com/kamailio/kamailio/commit/2e179048a0ffb26719644f293cfd063… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:37:12+02:00 htable: refreshed the readme file (cherry picked from commit 6adb2fac4a59a35fb1238b4eca5fd8e93c3659c9) - URL: https://github.com/kamailio/kamailio/commit/e082fdc7e401d7f719eb6e12d6b57e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:38:07+02:00 auth: coherent indentation and white spacing (cherry picked from commit c4b6428ce71e6d1b18ba2ea6b99c369864b56710) - URL: https://github.com/kamailio/kamailio/commit/d59d68c367f17e54606e5edac22a1b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:39:26+02:00 siputils: coherent indentation and whitespacing (cherry picked from commit 5a31031e62f8872eafc79b41e9594f2f1289f8c3) - URL: https://github.com/kamailio/kamailio/commit/24c6d38f93bc033cd79b90d4a4a24c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:39:47+02:00 registrar: coherent indentation and whitespacing (cherry picked from commit 90350e2a71c86e71f81590c80ad714cec6c7ea80) - URL: https://github.com/kamailio/kamailio/commit/3fd830cfe3bea3f5dde50a26f5ae40b… Author: Mikko Lehto <mslehto(a)iki.fi> Date: 2016-05-02T10:40:31+02:00 lib/binrpc modules/ctl utils/kamcmd : set UNIX_PATH_MAX to lowest common value sockaddr_un.sun_path[] seem to be either 104 or 108 in following Unices: 104 - NetBSD, OpenBSD, FreeBSD, DragonFly BSD, MINIX, XNU(Apple OS X) 108 - illumos, Solaris, Linux (cherry picked from commit bc783befbda947a7d789eebd70c64ec736892df5) - URL: https://github.com/kamailio/kamailio/commit/3550a23ac6a5845839b114b22077978… Author: sergey-vb <sergey.v.basov(a)gmail.com> Date: 2016-05-02T10:40:49+02:00 textops: fix memory leak in when converting body to multipart with set_body_multipart() (cherry picked from commit 61435f40f0f4ca25521f7f1b8515e47954a69b2d) - URL: https://github.com/kamailio/kamailio/commit/f1fc28d0e42980dfc027b6631b1b807… Author: sergey-vb <sergey.v.basov(a)gmail.com> Date: 2016-05-02T10:40:57+02:00 core: fix leak in case of error to get boundary inside check_boundaries() - impacted setting multi-part body function (cherry picked from commit 2b427a33937c6a86ab231de39d5a4574309dbfc6) - URL: https://github.com/kamailio/kamailio/commit/d82249bb42513e9c06828cae350e01b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:41:56+02:00 core: pv - coherent indentation and whitespacing (cherry picked from commit 4ffe8b0f917ec49b3f68afa99d65e384fb011283) - URL: https://github.com/kamailio/kamailio/commit/964c05c334b4bba0c2eeac20d9b8cc1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:42:09+02:00 async: fixed list format for dependencies in docs (cherry picked from commit 4463258d5bb8cb1460f51791d2c3a367ec68e5fb) - URL: https://github.com/kamailio/kamailio/commit/ea7d88c8a857a53f071e85eb6e467b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:42:31+02:00 lib/srdb1: added helper function to convert time to unquoted string (cherry picked from commit b3da13a1025f4380c4929fd53b619ca7fdd09a9d) - URL: https://github.com/kamailio/kamailio/commit/ffbc7449e315847a43e36ceab2cdc3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-02T10:42:39+02:00 usrloc: don't quote string representation of time for fetching contacts query - the db api adds quites around string values - it results in double quotation, rising db query error - reported by Giovanni Mele (cherry picked from commit aeb85ae3d9097bfd6aaad92a1d5b0c682bf5162c)

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2016