sr-dev May 2016

sr-dev@lists.kamailio.org

28 participants
348 discussions

git:master:6a3fc200: cfgutils: proper check for return code looking up routing block in route_exists()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6a3fc200b19500ddd6ed9a2236db6e21f777564a URL: https://github.com/kamailio/kamailio/commit/6a3fc200b19500ddd6ed9a2236db6e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-12T16:52:34+02:00 cfgutils: proper check for return code looking up routing block in route_exists() - when the route block doesn't exist, route_lookup() returns -1, which was used to access routing actions due to condition expecting 0 on not found. The fix should avoid crashing by accessing invalid addresses. Reported by Alex Balashov - fixed return codes in the configuration file to follow the rules with positive being evaluated to true and negative to false - route_exists() returns the code returned by running actions, like a classic sub-route execution --- Modified: modules/cfgutils/cfgutils.c --- Diff: https://github.com/kamailio/kamailio/commit/6a3fc200b19500ddd6ed9a2236db6e2… Patch: https://github.com/kamailio/kamailio/commit/6a3fc200b19500ddd6ed9a2236db6e2… --- diff --git a/modules/cfgutils/cfgutils.c b/modules/cfgutils/cfgutils.c index 667fecd..082cfe5 100644 --- a/modules/cfgutils/cfgutils.c +++ b/modules/cfgutils/cfgutils.c @@ -97,8 +97,8 @@ static int dbg_pkg_status(struct sip_msg*, char*,char*); static int dbg_shm_status(struct sip_msg*, char*,char*); static int dbg_pkg_summary(struct sip_msg*, char*,char*); static int dbg_shm_summary(struct sip_msg*, char*,char*); -static int route_exists(struct sip_msg*, char*); -static int check_route_exists(struct sip_msg*, char*); +static int w_route_exists(struct sip_msg*, char*); +static int w_check_route_exists(struct sip_msg*, char*); static int set_gflag(struct sip_msg*, char *, char *); static int reset_gflag(struct sip_msg*, char *, char *); @@ -186,9 +186,9 @@ static cmd_export_t cmds[]={ ANY_ROUTE}, {"core_hash", (cmd_function)w_core_hash, 3, fixup_core_hash, 0, ANY_ROUTE}, - {"check_route_exists", (cmd_function)check_route_exists, 1, 0, 0, + {"check_route_exists", (cmd_function)w_check_route_exists, 1, 0, 0, ANY_ROUTE}, - {"route_if_exists", (cmd_function)route_exists, 1, 0, 0, + {"route_if_exists", (cmd_function)w_route_exists, 1, 0, 0, ANY_ROUTE}, {"bind_cfgutils", (cmd_function)bind_cfgutils, 0, 0, 0, 0}, @@ -873,29 +873,32 @@ static int w_cfg_unlock(struct sip_msg *msg, char *key, char *s2) /*! Check if a route block exists - only request routes */ -static int check_route_exists(struct sip_msg *msg, char *route) +static int w_check_route_exists(struct sip_msg *msg, char *route) { - if (route_lookup(&main_rt, route)) - return 1; - return 0; + if (route_lookup(&main_rt, route)<0) { + /* not found */ + return -1; + } + return 1; } /*! Run a request route block if it exists */ -static int route_exists(struct sip_msg *msg, char *route) +static int w_route_exists(struct sip_msg *msg, char *route) { struct run_act_ctx ctx; - int newroute, backup_rt; + int newroute, backup_rt, ret; - if (!(newroute = route_lookup(&main_rt, route))) { - return 0; + newroute = route_lookup(&main_rt, route); + if (newroute<0) { + return -1; } backup_rt = get_route_type(); set_route_type(REQUEST_ROUTE); init_run_actions_ctx(&ctx); - run_top_route(main_rt.rlist[newroute], msg, 0); + ret = run_top_route(main_rt.rlist[newroute], msg, &ctx); set_route_type(backup_rt); - return 0; + return ret; } static int mod_init(void)

8 years, 7 months

git:master:0befd685: core: contribuitions guidelines updated with reporting issues section

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0befd685ffda86a97ee639264b9e7fba7f8ab6c5 URL: https://github.com/kamailio/kamailio/commit/0befd685ffda86a97ee639264b9e7fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-12T15:02:58+02:00 core: contribuitions guidelines updated with reporting issues section --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/0befd685ffda86a97ee639264b9e7fb… Patch: https://github.com/kamailio/kamailio/commit/0befd685ffda86a97ee639264b9e7fb… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index fd4d022..1b23d8c 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -12,10 +12,12 @@ changes to this document in a pull request. ### Table Of Contents ### * [Overview](#overview) - * [Basic Rules](#basic-rules) - * [Commit Message Format](#commit-message-format) - * [Examples Of Commit Messages](#examples-of-commit-messages) - * [See Also](#see-also) + * [Contributing Code Or Content](#contributing-code-or-content) + * [Basic Rules](#basic-rules) + * [Commit Message Format](#commit-message-format) + * [Examples Of Commit Messages](#examples-of-commit-messages) + * [See Also](#see-also) + * [Reporting Issues](#reporting-issues) * [License](#license) * [License Of New Code Contributions](#license-of-new-code-contributions) * [Further Assistance](#further-assistance) @@ -28,7 +30,8 @@ contribution to code or documentation is very welcome and appreciated. In order to be easily able to track the changes and have a coherent ChangLog and commit history, there are several *rules* required for each contribution. -## Basic Rules ## +## Contributing Code Or Content ## +### Basic Rules ### * github pull requests are the favourited mechanism to submit contributions (patches) @@ -72,7 +75,7 @@ and commit history, there are several *rules* required for each contribution. regenerated in the corresponding branch. -## Commit Message Format ## +### Commit Message Format ### Please create the commit messages following the GIT convention: @@ -93,7 +96,7 @@ Please start always with the prefix of the component (subsystem) that is modifie * lib_name: critical bug fix for abc case * kamctl: added support for management of module xyz -### Examples Of Commit Messages ### +#### Examples Of Commit Messages #### * change to usrloc module from modules @@ -116,7 +119,7 @@ core: loadpath can now use a list of directories be loaded and the search will stop). ``` -### See Also ### +#### See Also #### * [Creating Good Commit Messages](http://www.kernel.org/pub/software/scm/git/docs/user-manual.html#… * http://www.tpope.net/node/106 @@ -125,6 +128,28 @@ The above content about commit message format is taken from Kamailio wiki page: * https://www.kamailio.org/wiki/devel/git-commit-guidelines * it is recommended you read that one as well. +## Reporting Issues ## + +Whenever reporting an issue, along with the description of the problems, try to +include following details: + + * kamailio version you are using + * the output of: **kamailio -v** + * the operating system being used + * the CPU architecture + +Always useful to have: + + * whenever there is a crash with a corefile, send the backtrace + * the output of **bt full** in **gbd** + * log messages printed by kamailio in syslog file + * *pcap* or *ngrep* capture of SIP packets causing the issue + * config file snippets which expose the issues + +Note: replace any sensitive information in the content you add to the issue +(e.g., passwords in modparams can be replaced with xyz, each IP address can be +replaced with tokens like a.b.c.d, f.g.h.j). + ## License ## Kamailio Main License: *GPLv2*.

8 years, 7 months

git:master:f8c63871: core: added contributing file as per github suggestions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f8c638718b52b24cd7e73f32f5ec7d46f6ee5b62 URL: https://github.com/kamailio/kamailio/commit/f8c638718b52b24cd7e73f32f5ec7d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-05-12T14:47:19+02:00 core: added contributing file as per github suggestions - to be automatically linked for each on githup pages for contributions --- Added: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/f8c638718b52b24cd7e73f32f5ec7d4… Patch: https://github.com/kamailio/kamailio/commit/f8c638718b52b24cd7e73f32f5ec7d4…

8 years, 7 months

[kamailio/kamailio] Segfault with core dump (#614)

by Phil Lavin

Kamailio 4.3 fails to start after building a previously working sourcetree/config from Debian 7 onto a new Debian 8 server. Log file is: ``` May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: INFO: tls [tls_domain.c:674]: set_verification(): TLSc<default>: Server MAY present invalid certificate May 11 16:46:19 ua-proxy-00 kernel: [12060.056386] kamailio[360]: segfault at 207 ip 00007f07d23c8cbf sp 00007fff0b92bdd8 error 4 May 11 16:46:19 ua-proxy-00 kernel: [12060.056774] kamailio[358]: segfault at 207 ip 00007f07d23c8cbf sp 00007fff0b92bdd8 error 4 in libc-2.19.so[7f07d2337000+1a2000] May 11 16:46:19 ua-proxy-00 kernel: [12060.058171] in libc-2.19.so[7f07d2337000+1a2000] May 11 16:46:19 ua-proxy-00 kernel: [12060.059921] kamailio[362]: segfault at 207 ip 00007f07d23c8cbf sp 00007fff0b92bdd8 error 4 in libc-2.19.so[7f07d2337000+1a2000] May 11 16:46:19 ua-proxy-00 kernel: [12060.094333] kamailio[367]: segfault at 207 ip 00007f07d23c8cbf sp 00007fff0b92bdd8 error 4 in libc-2.19.so[7f07d2337000+1a2000] May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[623]: INFO: ctl [io_listener.c:214]: io_listen_loop(): io_listen_loop: using epoll_lt io watch method (config) May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:728]: handle_sigs(): child process 358 exited by a signal 11 May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:731]: handle_sigs(): core was not generated May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:728]: handle_sigs(): child process 360 exited by a signal 11 May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:731]: handle_sigs(): core was not generated May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:728]: handle_sigs(): child process 362 exited by a signal 11 May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:731]: handle_sigs(): core was not generated May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:728]: handle_sigs(): child process 367 exited by a signal 11 May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: ALERT: <core> [main.c:731]: handle_sigs(): core was not generated May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[312]: INFO: <core> [main.c:743]: handle_sigs(): terminating due to SIGCHLD May 11 16:46:19 ua-proxy-00 /opt/kamailio/sbin/kamailio[681]: INFO: <core> [main.c:798]: sig_usr(): signal 15 received ``` gdb output is: ``` [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/opt/kamailio/sbin/kamailio -f /opt/kamailio/etc/kamailio/kamailio.cfg -P /var/'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f6d5f577af6 in atomic_get (v=0x14) at ../../mem/../atomic/atomic_common.h:74 74 return atomic_get_int(&(v->val)); (gdb) bt full #0 0x00007f6d5f577af6 in atomic_get (v=0x14) at ../../mem/../atomic/atomic_common.h:74 No locals. #1 0x00007f6d5f578fd7 in ht_slot_lock (ht=0x7f6d61c9fad8, idx=0) at ht_api.c:150 mypid = 17992 #2 0x00007f6d5f5719a0 in ht_db_save_table (ht=0x7f6d61c9fad8, dbtable=0x7f6d61c9faf0) at ht_db.c:443 db_cols = {0x7f6d5f79f980 <ht_db_name_column>, 0x7f6d5f79f990 <ht_db_ktype_column>, 0x7f6d5f79f9a0 <ht_db_vtype_column>, 0x7f6d5f79f9b0 <ht_db_value_column>, 0x7f6d5f79f9c0 <ht_db_expires_column>} db_vals = {{type = 16777216, nul = 50, free = 351883413, val = {int_val = 4284224, ll_val = 4284224, double_val = 2.1166878974885686e-317, time_val = 4284224, string_val = 0x415f40 <_start> "1\355I\211\321^H\211\342H\203\344\360PTI\307\300 /n", str_val = {s = 0x415f40 <_start> "1\355I\211\321^H\211\342H\203\344\360PTI\307\300 /n", len = -1839950320}, blob_val = { s = 0x415f40 <_start> "1\355I\211\321^H\211\342H\203\344\360PTI\307\300 /n", len = -1839950320}, bitmap_val = 4284224}}, {type = 2455015904, nul = 32766, free = 1786366069, val = {int_val = 1803868645, ll_val = 140107932031461, double_val = 6.9222515926605253e-310, time_val = 140107932031461, string_val = 0x7f6d6b84d9e5 <db_mysql_val2str> "UH\211\345SH\203\354XH\211}\270H\211u\260H\211U\250H\211M\240H\213M\240H\213U\250H\213u\260H\213E\270H\211\307\350\372w\376\377\211E\354\203", <incomplete sequence \354>, str_val = {s = 0x7f6d6b84d9e5 <db_mysql_val2str> "UH\211\345SH\203\354XH\211}\270H\211u\260H\211U\250H\211M\240H\213M\240H\213U\250H\213u\260H\213E\270H\211\307\350\372w\376\377\211E\354\203", <incomplete sequence \354>, len = 17}, blob_val = { s = 0x7f6d6b84d9e5 <db_mysql_val2str> "UH\211\345SH\203\354XH\211}\270H\211u\260H\211U\250H\211M\240H\213M\240H\213U\250H\213u\260H\213E\270H\211\307\350\372w\376\377\211E\354\203", <incomplete sequence \354>, len = 17}, bitmap_val = 1803868645}}, {type = DB1_INT, nul = 0, free = 0, val = {int_val = 0, ll_val = 0, double_val = 0, time_val = 0, string_val = 0x0, str_val = {s = 0x0, len = 1806418832}, blob_val = {s = 0x0, len = 1806418832}, bitmap_val = 0}}, {type = 2455016976, nul = 32766, free = 1806462152, val = {int_val = -1839951280, ll_val = 140731353436752, double_val = 6.9530527025841608e-310, time_val = 140731353436752, string_val = 0x7ffe92549250 "p\222T\222\376\177", str_val = {s = 0x7ffe92549250 "p\222T\222\376\177", len = 32}, blob_val = {s = 0x7ffe92549250 "p\222T\222\376\177", len = 32}, bitmap_val = 2455016016}}, { type = 1803893696, nul = 32621, free = 351883413, val = {int_val = -1839951312, ll_val = 140731353436720, double_val = 6.9530527025825798e-310, time_val = 140731353436720, string_val = 0x7ffe92549230 "\200\222T\222\376\177", str_val = {s = 0x7ffe92549230 "\200\222T\222\376\177", len = 1803893774}, blob_val = {s = 0x7ffe92549230 "\200\222T\222\376\177", len = 1803893774}, bitmap_val = 2455015984}}} it = 0x7f6d61c9faf0 tmp = {s = 0x3214f95095 <error: Cannot access memory at address 0x3214f95095>, len = 0} i = 0 now = 1462979679 ncols = 4284224 __FUNCTION__ = "ht_db_save_table" #3 0x00007f6d5f58155a in ht_db_sync_tables () at ht_api.c:941 ht = 0x7f6d61c9fad8 __FUNCTION__ = "ht_db_sync_tables" #4 0x00007f6d5f5876c9 in destroy () at htable.c:266 No locals. #5 0x000000000054a1a7 in destroy_modules () at sr_module.c:805 t = 0x7f6d6bad04b8 foo = 0x7f6d6bacf7c0 __FUNCTION__ = "destroy_modules" #6 0x0000000000530ef1 in cleanup (show_status=0) at main.c:513 memlog = 32766 __FUNCTION__ = "cleanup" #7 0x00000000005324d6 in shutdown_children (sig=15, show_status=0) at main.c:655 __FUNCTION__ = "shutdown_children" #8 0x0000000000542326 in main (argc=13, argv=0x7ffe92549618) at main.c:2568 cfg_stream = 0x1f5d010 c = -1 r = 1824835416 tmp = 0x7ffe92549e5e "" tmp_len = 32621 port = 1824785872 proto = 0 options = 0x727dc0 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 2855621674 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0xf63d4e2e p = 0x7f6d6cc40000 "" st = {st_dev = 15, st_ino = 77938, st_nlink = 2, st_mode = 16877, st_uid = 1008, st_gid = 1009, __pad0 = 0, st_rdev = 0, st_size = 80, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1462977193, tv_nsec = 888000000}, st_mtim = {tv_sec = 1462979531, tv_nsec = 400000000}, st_ctim = {tv_sec = 1462979531, tv_nsec = 400000000}, __glibc_reserved = {0, 0, 0}} __FUNCTION__ = "main" (gdb) ``` Feels like a race condition of some sort as enabling full debug logs (`debug=3`) actually fixes the problem... --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/614

8 years, 7 months

git:master:6da5eaad: update headers

by lazedo

Module: kamailio Branch: master Commit: 6da5eaadc2ab47f23efaec96cb2d916f4f5d67a5 URL: https://github.com/kamailio/kamailio/commit/6da5eaadc2ab47f23efaec96cb2d916… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2016-05-11T23:16:35+01:00 update headers --- Modified: modules/kazoo/const.c Modified: modules/kazoo/const.h Modified: modules/kazoo/defs.h Modified: modules/kazoo/kz_amqp.c Modified: modules/kazoo/kz_amqp.h Modified: modules/kazoo/kz_fixup.c Modified: modules/kazoo/kz_fixup.h Modified: modules/kazoo/kz_hash.c Modified: modules/kazoo/kz_hash.h Modified: modules/kazoo/kz_json.c Modified: modules/kazoo/kz_json.h Modified: modules/kazoo/kz_pua.c Modified: modules/kazoo/kz_pua.h Modified: modules/kazoo/kz_trans.c Modified: modules/kazoo/kz_trans.h --- Diff: https://github.com/kamailio/kamailio/commit/6da5eaadc2ab47f23efaec96cb2d916… Patch: https://github.com/kamailio/kamailio/commit/6da5eaadc2ab47f23efaec96cb2d916…

8 years, 7 months

git:master:b0cd09d2: dialog Make sure statistics are updated when initializing from database

by Olle E. Johansson

Module: kamailio Branch: master Commit: b0cd09d2b451005a736396e6f38eac139ec31301 URL: https://github.com/kamailio/kamailio/commit/b0cd09d2b451005a736396e6f38eac1… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2016-05-11T21:59:44+02:00 dialog Make sure statistics are updated when initializing from database Issue #424 --- Modified: modules/dialog/dlg_db_handler.c Modified: modules/dialog/dlg_handlers.c Modified: modules/dialog/dlg_hash.c Modified: modules/dialog/dlg_var.c Modified: modules/dialog/dlg_var.h --- Diff: https://github.com/kamailio/kamailio/commit/b0cd09d2b451005a736396e6f38eac1… Patch: https://github.com/kamailio/kamailio/commit/b0cd09d2b451005a736396e6f38eac1… --- diff --git a/modules/dialog/dlg_db_handler.c b/modules/dialog/dlg_db_handler.c index e27f8b2..1933849 100644 --- a/modules/dialog/dlg_db_handler.c +++ b/modules/dialog/dlg_db_handler.c @@ -37,6 +37,7 @@ #include "../../lib/srdb1/db.h" #include "../../str.h" #include "../../socket_info.h" +#include "../../lib/kcore/statistics.h" #include "dlg_hash.h" #include "dlg_var.h" #include "dlg_profile.h" @@ -377,8 +378,10 @@ static int load_dialog_info_from_db(int dlg_hash_size, int fetch_num_rows) if (dlg->state==DLG_STATE_CONFIRMED_NA || dlg->state==DLG_STATE_CONFIRMED) { active_dlgs_cnt++; + if_update_stat(dlg_enable_stats, active_dlgs, 1); } else if (dlg->state==DLG_STATE_EARLY) { early_dlgs_cnt++; + if_update_stat(dlg_enable_stats, early_dlgs, 1); } dlg->tl.timeout = (unsigned int)(VAL_INT(values+9)); diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index 36a807f..c5c748e 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -70,11 +70,6 @@ int spiral_detected = -1; extern struct rr_binds d_rrb; /*!< binding to record-routing module */ -/* statistic variables */ -extern stat_var *early_dlgs; /*!< number of early dialogs */ -extern stat_var *processed_dlgs; /*!< number of processed dialogs */ -extern stat_var *expired_dlgs; /*!< number of expired dialogs */ -extern stat_var *failed_dlgs; /*!< number of failed dialogs */ extern pv_elem_t *ruri_param_model; /*!< pv-string to get r-uri */ diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 9a96f1b..1f0470e 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -35,6 +35,7 @@ #include "../../ut.h" #include "../../hashes.h" #include "../../lib/kmi/mi.h" +#include "../../lib/kcore/statistics.h" #include "dlg_timer.h" #include "dlg_var.h" #include "dlg_hash.h" diff --git a/modules/dialog/dlg_var.c b/modules/dialog/dlg_var.c index 8d76b8f..e89ee27 100644 --- a/modules/dialog/dlg_var.c +++ b/modules/dialog/dlg_var.c @@ -29,6 +29,7 @@ #include "../../route.h" #include "../../script_cb.h" #include "../../pvapi.h" +#include "../../lib/kcore/statistics.h" #include "dlg_var.h" #include "dlg_hash.h" diff --git a/modules/dialog/dlg_var.h b/modules/dialog/dlg_var.h index 7d4c360..dbf7505 100644 --- a/modules/dialog/dlg_var.h +++ b/modules/dialog/dlg_var.h @@ -76,6 +76,13 @@ int set_dlg_variable_unsafe(dlg_cell_t *dlg, str *key, str *val); extern dlg_ctx_t _dlg_ctx; +/* statistic variables */ +extern stat_var *active_dlgs; /*!< number of active dialogs */ +extern stat_var *early_dlgs; /*!< number of early dialogs */ +extern stat_var *processed_dlgs; /*!< number of processed dialogs */ +extern stat_var *expired_dlgs; /*!< number of expired dialogs */ +extern stat_var *failed_dlgs; /*!< number of failed dialogs */ + int pv_get_dlg_ctx(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); int pv_set_dlg_ctx(sip_msg_t *msg, pv_param_t *param,

8 years, 7 months

git:master:64bab0c3: Merge pull request #613 from kamailio/NSQ/bugfix-segfault-free-topic-channel

by Emmanuel Schmidbauer

Module: kamailio Branch: master Commit: 64bab0c38596c9dea13a22a5d2a89c5e24238fe2 URL: https://github.com/kamailio/kamailio/commit/64bab0c38596c9dea13a22a5d2a89c5… Author: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Committer: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Date: 2016-05-11T11:06:26-04:00 Merge pull request #613 from kamailio/NSQ/bugfix-segfault-free-topic-channel nsq: fix segfault on module destroy --- Modified: modules/nsq/nsq_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/64bab0c38596c9dea13a22a5d2a89c5… Patch: https://github.com/kamailio/kamailio/commit/64bab0c38596c9dea13a22a5d2a89c5… --- diff --git a/modules/nsq/nsq_mod.c b/modules/nsq/nsq_mod.c index 54d50b5..fde9094 100644 --- a/modules/nsq/nsq_mod.c +++ b/modules/nsq/nsq_mod.c @@ -68,14 +68,14 @@ static param_export_t params[]= static void free_tc_list(nsq_topic_channel_t *tcl) { - nsq_topic_channel_t *tc, *prev_tc; + nsq_topic_channel_t *tc, *tc0; tc = tcl; while (tc) { - prev_tc = tc; - tc = tc->next; + tc0 = tc->next; free(tc->topic); free(tc->channel); - pkg_free(prev_tc); + pkg_free(tc); + tc = tc0; } tcl = NULL; }

8 years, 7 months

git:master:e7eb7a24: nsq: fix segfault on module destroy

by Emmanuel Schmidbauer

Module: kamailio Branch: master Commit: e7eb7a24d0ceaf77803ff2d9c798a9b3247b89ff URL: https://github.com/kamailio/kamailio/commit/e7eb7a24d0ceaf77803ff2d9c798a9b… Author: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Committer: Emmanuel Schmidbauer <emmanuel(a)getweave.com> Date: 2016-05-11T10:34:25-04:00 nsq: fix segfault on module destroy --- Modified: modules/nsq/nsq_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/e7eb7a24d0ceaf77803ff2d9c798a9b… Patch: https://github.com/kamailio/kamailio/commit/e7eb7a24d0ceaf77803ff2d9c798a9b… --- diff --git a/modules/nsq/nsq_mod.c b/modules/nsq/nsq_mod.c index 54d50b5..fde9094 100644 --- a/modules/nsq/nsq_mod.c +++ b/modules/nsq/nsq_mod.c @@ -68,14 +68,14 @@ static param_export_t params[]= static void free_tc_list(nsq_topic_channel_t *tcl) { - nsq_topic_channel_t *tc, *prev_tc; + nsq_topic_channel_t *tc, *tc0; tc = tcl; while (tc) { - prev_tc = tc; - tc = tc->next; + tc0 = tc->next; free(tc->topic); free(tc->channel); - pkg_free(prev_tc); + pkg_free(tc); + tc = tc0; } tcl = NULL; }

8 years, 7 months

Using auth module with SHA-256 instead of MD5

by Huber Andreas

Hello, We would like to adapt the "auth" module to allow digest authentication that uses a different hashing algorithm (SHA-256 instead of MD5). We use the auth module together with the "auth_db" module. I identified the following changes that would be required for this feature: 1. The field algorithm=SHA-256 must be present in the "WWW-Authenticate" and "Proxy-Authenticate" headers to indicate the custom algorithm e.g. WWW-Authenticate: Digest realm="realm.test", nonce="VzMh7lczIMKzhKh2gFjSnAnufvKupxx0B3JSSoA=", qop="auth", algorithm=SHA-256 2. The rfc2617.h/c files must be duplicated and adapted to use SHA-256 3. A SHA-256 hash value is twice as long as a MD5 hash value. So we must make sure that large enough char arrays are allocated to hold hash values. It looks like this is no problem for the auth_* modules because they use char[256] for the ha1 hash values. The HASHHEX which is char[33] seems only to be used inside the auth module itself. I thought of some possible solutions and we would like to get a feedback if any of these could make it into the official kamailio version and which one you would prefer: Solution A: Add SHA-256 capabilities to module "auth" : Add a module parameter "algorithm" that allows configuring "SHA-256" instead of "MD5" (which would be the default value). Add SHA-256 versions for the functions calc_HA1 and calc_response (similar to rfc2617.c/h) and add two function pointers that can either point to the MD5 or SHA256 implementations, depending on the config. Use the function pointers in the functions auth_s, auth_check_response and pv_authenticate where calc_HA1 or calc_response are used. In the function auth_check_response replace HASHHEX allocated on the stack by char[65] or char[256] and compare the length of the credentials provided by the client dynamically depending on the config (32 for MD5, 64 for SHA-256). Provide the configured algorithm to the two calls to get_challenge_hf to build the challenge header field with the desired algorithm. Solution B: Add a new module "auth_sha256" that 'extends' the module "auth" The idea of this solution is to put any sha256 specific code in a separate module while reusing most of the other code from the auth module. As in solution A, the auth module would use some function pointers for the calc_HA1 and calc_response functions. But instead of a configuration value, these function pointers could be initialized in mod_init depending whether the auth_sha256 module is available or not. (e.g. the module auth could call a function in the module auth_sha256 similar to bind_auth_s to replace parts of its own api by SHA-256 specific functions.) Solution C: Add a new module "auth_sha256" that is a duplicate of the module "auth", adapted for SHA-256 With this solution, no existing modules have to be modified, but more code has to be duplicated and maintained separately. Kind regards, Andreas Huber

8 years, 7 months

Spring allergy - missing return codes or simply missing documentation

by Olle E. Johansson

Friends, I have developed an allergy. It causes all kinds of weird behaviour. We have a lot of functions that are documented in README’s that have no documentation of the return codes, even though they do exist in the source code. Sometimes you can see that the developer added an example of an if() statement - proving that there is a return code, but the text doesn’t mention it. If you write new functions in *any* module please document error codes in the README. If you have written or understand from the source code that there are return codes around, please add them to the README. If you find functions that have no documentation on return codes and you can’t figure it out, file a bug report. Documentation fixes can go both in master and in 4.4. If you clean up return codes and modify the source - this needs to go only in master. I just did for the “unregister” function in REGISTRAR - there was a mixup of return codes where the same value actually had different meanings, which was hard to document. Thank you! /O

8 years, 7 months

← Newer
1
...
17
18
19
20
21
22
23
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2016