sr-dev February 2016

sr-dev@lists.kamailio.org

28 participants
302 discussions

[kamailio] module http_client - support for preemptive authentication (#515)

by filiplx

It would be nice if it was possible to configure the module to use preemptive authentication. I forked the module to add it myself in a primitive way since I needed it only for Basic Authentication, but it would be better to have it configurable. In functions.h // Before: res |= curl_easy_setopt(curl, CURLOPT_HTTPAUTH, (CURLAUTH_DIGEST|CURLAUTH_BASIC)); // After: res |= curl_easy_setopt(curl, CURLOPT_HTTPAUTH, CURLAUTH_BASIC); From: https://curl.haxx.se/libcurl/c/CURLOPT_HTTPAUTH.html "If more than one bit is set, libcurl will first query the site to see which authentication methods it supports and then pick the best one you allow it to use. For some methods, this will induce an extra network round-trip" <===== this is what I needed to avoid --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/515

8 years

[kamailio] ims_dialog: fix double free (unref early dialog) (#508)

by Dragos Oancea

Attempt fix for when an INVITE goes out and there is no 100 Trying reply to it , and then ims_dialog destroys the dialog twice via unref_dlg_unsafe() . You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/508 -- Commit Summary -- * ims_dialog: fix double free (unref early dialog) -- File Changes -- M modules/ims_dialog/dlg_handlers.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/508.patch https://github.com/kamailio/kamailio/pull/508.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/508

8 years, 1 month

[kamailio] ims_usrloc_scscf: fix link_contact_to_impu() - was crashing with maxcontact_behaviour == 2 (#512)

by Dragos Oancea

link_contact_to_impu() does not behave as intended - it will return immediately because ptr==contact . This will lead to a crash when current contact is always different than the previous. To prevent this, I set ptr to 0 as it points to a chunk of freed memory anyway. Removed call to unlink_contact_from_impu() as I believed is redundant and it leads to double free. This is an usual scenario and it happens with devices that reconnect on TCP , and they change the src port every time , and then the contact will be different. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/512 -- Commit Summary -- * ims_usrloc_scscf: fix link_contact_to_impu() (was crashing when maxcontact_behaviour == 2) -- File Changes -- M modules/ims_usrloc_scscf/impurecord.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/512.patch https://github.com/kamailio/kamailio/pull/512.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/512

8 years, 1 month

[kamailio] Invalid XAVP use causes a crash (#511)

by Hugh Waite

The following code is accepted by the cfg parser and will run: ``` $xavp(test1=>stuff) = "america"; # Good $xavp(test2->stuff) = "bahamas"; # Bad - Hyphen instead of equals $xavp(test3) = "cuba"; # Bad - No name given xlog("L_WARN", "1: $xavp(test1)\n"); xlog("L_WARN", "2: $xavp(test2)\n"); xlog("L_WARN", "3: $xavp(test3)\n"); xlog("L_WARN", "4: $xavp(test1=>stuff)\n"); xlog("L_WARN", "5: $xavp(test2=>stuff)\n"); xlog("L_WARN", "6: $xavp(test3=>stuff)\n"); ``` This prints: ``` 1: <<xavp:0x7ff16f82c898>> 2: <null> 3: cuba 4: america 5: null <null> or general protection fault/ core was generated...... ``` The crash can be fixed by checking the child node type (incoming), but could there be more validation of the (x)avp variables. I notice that $avp's can be treated as $xavps i.e. the following is accepted. `$avp(test4=>stuff) = "dominica";` Is the usage above intended to be acceptable? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/511

8 years, 1 month

[kamailio] ims_registrar_scscf: fix new_notification() so it does not crash (#506)

by Dragos Oancea

fix mishandling of impus (array of ptr) - avoid crash You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/506 -- Commit Summary -- * ims_registrar_scscf: fix new_notification() so it does not crash (with 2 or more IMPU) -- File Changes -- M modules/ims_registrar_scscf/registrar_notify.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/506.patch https://github.com/kamailio/kamailio/pull/506.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/506

8 years, 1 month

Releasing Kamailio v4.3.5

by Daniel-Constantin Mierla

Hello, it's been a while since the release of v4.3.4, therefore I am considering to release a new minor version from branch 4.3 next week, most probably on Thursday, March 3, 2016. As usual, if there you are aware of issues not reported to the tracker [1], do it as soon as possible to get a chance to be fixed before the release date. Cheers, Daniel [1] https://github.com/kamailio/kamailio/issues -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, March 7-9, 2016 - http://www.asipto.com

8 years, 1 month

[kamailio] Registrar: kamailio update contact infomation failed but it sends 200-register message to client (#497)

by szkbsgy

Hi, When client send register message that reg-id in contact is "0", kamailio failed to update contacts info， but it will send 200-register to client, this will cause one issue that no one can find this client(will always be 404 error) reg-id in message: Contact: <sip:2015@100080:5060;ob>;reg-id=0 Related logs: /usr/local/sbin/kamailio[30325]: ERROR: registrar [savec:402]: pack_ci(): invalid reg-id value /usr/local/sbin/kamailio[30325]: ERROR: registrar [savec:685]: update_contacts(): failed to pack contact specific info I think registrar should reply 4xx message when reg-id's value is 0 Best Regards, Shengy --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497

8 years, 1 month

[kamailio] PUA issue when UA is not using UDP (#509)

by Phil Lavin

A number of additional ports have been opened on Kamailio – the relevant one here is TCP 443. An INVITE comes in from a UA whose from URI is suffixed with :443. PUA generates a PUBLISH out of this. Log is at https://gist.githubusercontent.com/phil-lavin/c381d556c22fd29b4fde/raw/77c5…. The relevant bit to the issue is the last line. PUA is trying to send the PUBLISH to the address and port taken from the from URI… however it sends it over UDP. Because Kamailio is not bound to UDP 443, the PUBLISH is not received. A hacky “fix” is to make Kamailio bind to UDP 443 as well as TCP 443. I will dig into this deeper today in an attempt to find a better fix. Suggestions around what is the best solution would be appreciated. I’m thinking that sending this over TCP is not desirable in most instances – unless perhaps Kamailio is only bound to TCP ports? --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/509

8 years, 1 month

[kamailio] Fix an issue with IPv6 in the rtpproxy module (#523)

by sobomax

There is an old issue in the OpenSIPS which may result in SDP containing mismatching protocols, when processing rtpproxy_offer() on a IPv6 message with default flags. This has been revealed by the new version of the [voiptests](https://travis-ci.org/sippy/voiptests/) <MSG IN> 00:00:03.089/GLOBAL/alice_ua: SENDING message to [::1]:5060: INVITE sip:bob_6@[::1]:5060 SIP/2.0 v: SIP/2.0/UDP [::1]:5061;branch=z9hG4bKfffb7b9e25497c853146ea72a3399f5c;rport Max-Forwards: 70 f: "Alice Smith" <sip:alice_6_ipv6@[::1]>;tag=628b36c02f1d1d5a7b4305c050a3feb6 t: <sip:bob_6@[::1]> i: 759e9723cfa1bc5c9c294b2a6c816e77(a)184.71.172.86 CSeq: 200 INVITE m: Anonymous <sip:alice_6_ipv6@[::1]:5061> Expires: 300 User-Agent: Sippy cisco-GUID: 3824430197-1272056386-4229849152-47475815 h323-conf-id: 3824430197-1272056386-4229849152-47475815 c: application/sdp l: 409 v=0 o=- 986474003697 986474003697 IN IP6 ::1 s=- c=IN IP6 2001:0:0:0:7c1:0:52b8:0 t=0 0 m=audio 40534 RTP/AVP 18 0 2 4 8 96 97 98 101 a=rtpmap:18 G729a/8000 a=rtpmap:0 PCMU/8000 a=rtpmap:2 G726-32/8000 a=rtpmap:4 G723/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:96 G726-40/8000 a=rtpmap:97 G726-24/8000 a=rtpmap:98 G726-16/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=ptime:30 a=sendrecv </MSG IN> <MSG OUT> 00:00:03.090/GLOBAL/bob_ua: RECEIVED message from [::1]:5060: INVITE sip:bob_6@[::1]:5062 SIP/2.0 Record-Route: <sip:[0:0:0:0:0:0:0:1];lr;ftag=628b36c02f1d1d5a7b4305c050a3feb6> Via: SIP/2.0/UDP [0:0:0:0:0:0:0:1]:5060;branch=z9hG4bKddc6.7a0c3345.0 v: SIP/2.0/UDP [::1]:5061;received=0:0:0:0:0:0:0:1;branch=z9hG4bKfffb7b9e25497c853146ea72a3399f5c;rport=5061 Max-Forwards: 69 f: "Alice Smith" <sip:alice_6_ipv6@[::1]>;tag=628b36c02f1d1d5a7b4305c050a3feb6 t: <sip:bob_6@[::1]> i: 759e9723cfa1bc5c9c294b2a6c816e77(a)184.71.172.86 CSeq: 200 INVITE m: Anonymous <sip:alice_6_ipv6@[::1]:5061> Expires: 300 User-Agent: Sippy cisco-GUID: 3824430197-1272056386-4229849152-47475815 h323-conf-id: 3824430197-1272056386-4229849152-47475815 c: application/sdp Content-Length: 419 v=0 o=- 986474003697 986474003697 IN IP6 ::1 s=- c=IN IP4 0:0:0:0:0:0:0:1 t=0 0 m=audio 12260 RTP/AVP 18 0 2 4 8 96 97 98 101 a=rtpmap:18 G729a/8000 a=rtpmap:0 PCMU/8000 a=rtpmap:2 G726-32/8000 a=rtpmap:4 G723/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:96 G726-40/8000 a=rtpmap:97 G726-24/8000 a=rtpmap:98 G726-16/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-15 a=ptime:30 a=sendrecv a=nortpproxy:yes </MSG OUT> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/523 -- Commit Summary -- * Fix IPv6 handling with the default setup. With the current code, -- File Changes -- M modules/rtpproxy/rtpproxy.c (74) -- Patch Links -- https://github.com/kamailio/kamailio/pull/523.patch https://github.com/kamailio/kamailio/pull/523.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/523

8 years, 1 month

[kamailio] [4.3 BACKPORT] pua_dialoginfo: don't free dlginfo structure in dlg loaded callback (#518)

by Phil Lavin

I figured it was worth backporting this crash fix, before the v4.3.5 release Daniel mentioned on the mailing list - the structure will be destroyed in a later dlg callback, enabled by dlg_api.register_dlgcb(), via free_dlginfo_cell() - based and includes partial patch from GH #492, by Phil Lavin You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/518 -- Commit Summary -- * pua_dialoginfo: don't free dlginfo structure in dlg loaded callback -- File Changes -- M modules/pua_dialoginfo/pua_dialoginfo.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/518.patch https://github.com/kamailio/kamailio/pull/518.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/518

8 years, 1 month

← Newer
1
2
3
4
5
6
7
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2016