sr-dev December 2016

sr-dev@lists.kamailio.org

25 participants
332 discussions

git:master:69efe1dc: sanity: add documentation of flag 12 for sanity_check()

by Giacomo Vacca

Module: kamailio Branch: master Commit: 69efe1dc20cbd6166798862837c07cd495e7db75 URL: https://github.com/kamailio/kamailio/commit/69efe1dc20cbd6166798862837c07cd… Author: Giacomo Vacca <giacomo.vacca(a)gmail.com> Committer: Giacomo Vacca <giacomo.vacca(a)gmail.com> Date: 2016-12-20T14:45:51+01:00 sanity: add documentation of flag 12 for sanity_check() --- Modified: src/modules/sanity/doc/sanity_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/69efe1dc20cbd6166798862837c07cd… Patch: https://github.com/kamailio/kamailio/commit/69efe1dc20cbd6166798862837c07cd… --- diff --git a/src/modules/sanity/doc/sanity_admin.xml b/src/modules/sanity/doc/sanity_admin.xml index e3a1f78..3b3df34 100644 --- a/src/modules/sanity/doc/sanity_admin.xml +++ b/src/modules/sanity/doc/sanity_admin.xml @@ -107,6 +107,11 @@ </listitem> <listitem> <para> + duplicated To/From tags (4096) - checks for the presence of duplicated + tags in To/From headers. + </para> + <listitem> + <para> authorization header (8192) - checks if the Authorization is valid if the scheme is "digest" (see "digest credentials" above), always returns success for other schemes.

8 years

[kamailio/kamailio] sanity: add documentation of flag 12 for sanity_check() (#894)

by Giacomo Vacca

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/894 -- Commit Summary -- * sanity: add documentation of flag 12 for sanity_check() -- File Changes -- M src/modules/sanity/doc/sanity_admin.xml (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/894.patch https://github.com/kamailio/kamailio/pull/894.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/894

8 years

git:master:1c271b23: Merge pull request #893 from zecke/ss7-ops-json-extraction

by GitHub

Module: kamailio Branch: master Commit: 1c271b23219c8026a99c758701297c1b6a3baf97 URL: https://github.com/kamailio/kamailio/commit/1c271b23219c8026a99c758701297c1… Author: Holger Freyther <holger+github(a)freyther.de> Committer: GitHub <noreply(a)github.com> Date: 2016-12-20T12:06:57+01:00 Merge pull request #893 from zecke/ss7-ops-json-extraction ss7ops: Allow to extract ISUP fields using pvars --- Modified: src/modules/ss7ops/isup_parsed.h Modified: src/modules/ss7ops/ss7ops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1c271b23219c8026a99c758701297c1… Patch: https://github.com/kamailio/kamailio/commit/1c271b23219c8026a99c758701297c1…

8 years

git:master:4b42041b: ss7ops: Allow to extract ISUP fields using pvars

by Holger Hans Peter Freyther

Module: kamailio Branch: master Commit: 4b42041b2db32afa36583b95e3ed9365cebad276 URL: https://github.com/kamailio/kamailio/commit/4b42041b2db32afa36583b95e3ed936… Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Committer: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: 2016-12-20T11:23:12+01:00 ss7ops: Allow to extract ISUP fields using pvars For storing fields in a database the JSON needs to be extracted and instead of parsing the JSON over and over again, keep the document around and provide access to the numbers. --- Modified: src/modules/ss7ops/isup_parsed.h Modified: src/modules/ss7ops/ss7ops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4b42041b2db32afa36583b95e3ed936… Patch: https://github.com/kamailio/kamailio/commit/4b42041b2db32afa36583b95e3ed936…

8 years

[kamailio/kamailio] ss7ops: Allow to extract ISUP fields using pvars (#893)

by Holger Freyther

For storing fields in a database the JSON needs to be extracted and instead of parsing the JSON over and over again, keep the document around and provide access to the numbers. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/893 -- Commit Summary -- * ss7ops: Allow to extract ISUP fields using pvars -- File Changes -- M src/modules/ss7ops/isup_parsed.h (43) M src/modules/ss7ops/ss7ops_mod.c (325) -- Patch Links -- https://github.com/kamailio/kamailio/pull/893.patch https://github.com/kamailio/kamailio/pull/893.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/893

8 years

git:4.4:39874e41: dialplan: safe checks for match expression

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.4 Commit: 39874e415c754263e6c847bb19d89c5ef615e376 URL: https://github.com/kamailio/kamailio/commit/39874e415c754263e6c847bb19d89c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-12-20T08:36:20+01:00 dialplan: safe checks for match expression - test if null to avoid invalid use in comparison functions - reported by Julia Boudniatsky (backport of commit 3a48835cf68f583ff2fbd7cec9bd76ddc0a1b6fc) --- Modified: modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/39874e415c754263e6c847bb19d89c5… Patch: https://github.com/kamailio/kamailio/commit/39874e415c754263e6c847bb19d89c5… --- diff --git a/modules/dialplan/dp_repl.c b/modules/dialplan/dp_repl.c index 959c4bc..03727fd 100644 --- a/modules/dialplan/dp_repl.c +++ b/modules/dialplan/dp_repl.c @@ -583,7 +583,7 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, dpl_dyn_pcre_p rt = NULL; if(!input.s || !input.len) { - LM_ERR("invalid input string\n"); + LM_WARN("invalid or empty input string to be matched\n"); return -1; } @@ -635,7 +635,8 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, case DP_EQUAL_OP: LM_DBG("equal operator testing\n"); - if(rulep->match_exp.len != input.len) { + if(rulep->match_exp.s==NULL + || rulep->match_exp.len != input.len) { rez = -1; } else { rez = strncmp(rulep->match_exp.s,input.s,input.len); @@ -645,11 +646,15 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, case DP_FNMATCH_OP: LM_DBG("fnmatch operator testing\n"); - b = input.s[input.len]; - input.s[input.len] = '\0'; - rez = fnmatch(rulep->match_exp.s, input.s, 0); - input.s[input.len] = b; - rez = (rez==0)?0:-1; + if(rulep->match_exp.s!=NULL) { + b = input.s[input.len]; + input.s[input.len] = '\0'; + rez = fnmatch(rulep->match_exp.s, input.s, 0); + input.s[input.len] = b; + rez = (rez==0)?0:-1; + } else { + rez = -1; + } break; default:

8 years

git:master:3a48835c: dialoplan: safe checks for match expression

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3a48835cf68f583ff2fbd7cec9bd76ddc0a1b6fc URL: https://github.com/kamailio/kamailio/commit/3a48835cf68f583ff2fbd7cec9bd76d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-12-20T08:32:03+01:00 dialoplan: safe checks for match expression - test if null to avoid invalid use in comparison functions - reported by Julia Boudniatsky --- Modified: src/modules/dialplan/dp_repl.c --- Diff: https://github.com/kamailio/kamailio/commit/3a48835cf68f583ff2fbd7cec9bd76d… Patch: https://github.com/kamailio/kamailio/commit/3a48835cf68f583ff2fbd7cec9bd76d… --- diff --git a/src/modules/dialplan/dp_repl.c b/src/modules/dialplan/dp_repl.c index 0b16b0a..2c0d9b3 100644 --- a/src/modules/dialplan/dp_repl.c +++ b/src/modules/dialplan/dp_repl.c @@ -583,7 +583,7 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, dpl_dyn_pcre_p rt = NULL; if(!input.s || !input.len) { - LM_ERR("invalid input string\n"); + LM_WARN("invalid or empty input string to be matched\n"); return -1; } @@ -635,7 +635,8 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, case DP_EQUAL_OP: LM_DBG("equal operator testing\n"); - if(rulep->match_exp.len != input.len) { + if(rulep->match_exp.s==NULL + || rulep->match_exp.len != input.len) { rez = -1; } else { rez = strncmp(rulep->match_exp.s,input.s,input.len); @@ -645,11 +646,15 @@ int translate(sip_msg_t *msg, str input, str *output, dpl_id_p idp, case DP_FNMATCH_OP: LM_DBG("fnmatch operator testing\n"); - b = input.s[input.len]; - input.s[input.len] = '\0'; - rez = fnmatch(rulep->match_exp.s, input.s, 0); - input.s[input.len] = b; - rez = (rez==0)?0:-1; + if(rulep->match_exp.s!=NULL) { + b = input.s[input.len]; + input.s[input.len] = '\0'; + rez = fnmatch(rulep->match_exp.s, input.s, 0); + input.s[input.len] = b; + rez = (rez==0)?0:-1; + } else { + rez = -1; + } break; default:

8 years

INFO: jsonrpcs used instead of mi_fifo in the default kamailio.cfg and kamctl

by Daniel-Constantin Mierla

Hello, with MI code planned to be removed, I updated the kamctl and default kamailio.cfg to use jsonrpcs (jsonrpc server) module instead of mi_fifo to interact with kamailio at runtime. The default fifo file for rpc command is /var/run/kamailio/kamailio_rpc.fifo and expects JSONRPC commands as described at: - http://kamailio.org/docs/modules/devel/modules/jsonrpcs.html#idp31525708 Switching back to mi_fifo is still possible by loading the module and editing kamctlrc, but the module might not make it to 5.0, so for new installations and testing is better not to use it. Few rpc commands are missing in carrierroute, otherwise the kamctl commands should work just as before, but be aware that the output is now in json format. Testing of the master branch with the latest kamctl and providing feedback will be really appreciated -- I could do tests only for the modules I typically use. Cheers, Daniel -- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com

8 years

git:master:dc5a9e96: kamailio.cfg: replaced mi_fifo with jsonrpcs in the default config file

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: dc5a9e96a20c1099601ef5c6516458532da3124a URL: https://github.com/kamailio/kamailio/commit/dc5a9e96a20c1099601ef5c65164585… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-12-19T19:21:38+01:00 kamailio.cfg: replaced mi_fifo with jsonrpcs in the default config file --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/dc5a9e96a20c1099601ef5c65164585… Patch: https://github.com/kamailio/kamailio/commit/dc5a9e96a20c1099601ef5c65164585… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 0fc190d..0245f7e 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -221,7 +221,7 @@ voicemail.srv_port = "5060" desc "VoiceMail Port" loadmodule "db_mysql.so" #!endif -loadmodule "mi_fifo.so" +loadmodule "jsonrpcs.so" loadmodule "kex.so" loadmodule "corex.so" loadmodule "tm.so" @@ -291,9 +291,11 @@ loadmodule "debugger.so" # ----------------- setting module-specific parameters --------------- -# ----- mi_fifo params ----- -/* set the path to MI fifo control file */ -# modparam("mi_fifo", "fifo_name", "/var/run/kamailio/kamailio_fifo") +# ----- jsonrpcs params ----- +/* set the path to RPC fifo control file */ +# modparam("jsonrpcs", "fifo_name", "/var/run/kamailio/kamailio_rpc.fifo") +/* set the path to RPC unix socket control file */ +# modparam("jsonrpcs", "dgram_socket", "/var/run/kamailio/kamailio_rpc.sock") # ----- ctl params ----- /* set the path to RPC unix socket control file */

8 years

git:master:813507b1: kamctl: set default to use rpc fifo via jsonrpcs module

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 813507b1bc3d1ed8b847aea978883846d3b6cdd9 URL: https://github.com/kamailio/kamailio/commit/813507b1bc3d1ed8b847aea97888384… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-12-19T19:21:38+01:00 kamctl: set default to use rpc fifo via jsonrpcs module --- Modified: utils/kamctl/kamctl Modified: utils/kamctl/kamctl.rpcfifo Modified: utils/kamctl/kamctlrc --- Diff: https://github.com/kamailio/kamailio/commit/813507b1bc3d1ed8b847aea97888384… Patch: https://github.com/kamailio/kamailio/commit/813507b1bc3d1ed8b847aea97888384… --- diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index ecbb794..e36b412 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -173,7 +173,7 @@ CTLENGINELOADED=0 CTLENGINETYPE=0 if [ -z "$CTLENGINE" ] ; then - CTLENGINE="FIFO" + CTLENGINE="RPCFIFO" fi case $CTLENGINE in FIFO|fifo) diff --git a/utils/kamctl/kamctl.rpcfifo b/utils/kamctl/kamctl.rpcfifo index 0e64520..881a8bd 100644 --- a/utils/kamctl/kamctl.rpcfifo +++ b/utils/kamctl/kamctl.rpcfifo @@ -5,7 +5,7 @@ #=================================================================== ##### ----------------------------------------------- ##### -### FIFO specific variables and functions +### RPC FIFO specific variables and functions # ##### ----------------------------------------------- ##### diff --git a/utils/kamctl/kamctlrc b/utils/kamctl/kamctlrc index 7995805..ba15c2c 100644 --- a/utils/kamctl/kamctlrc +++ b/utils/kamctl/kamctlrc @@ -118,15 +118,15 @@ # ALIASES_TYPE="DB" ## control engine: FIFO, RPCFIFO or UNIXSOCK -## - default FIFO -# CTLENGINE="FIFO" +## - default RPCFIFO +# CTLENGINE="RPCFIFO" -## path to FIFO file -# FIFOPATH="/var/run/kamailio/kamailio_fifo" - -## path to RPCFIFO file +## path to FIFO file for engine RPCFIFO # RPCFIFOPATH="/var/run/kamailio/kamailio_rpc_fifo" +## path to FIFO file for engine FIFO +# FIFOPATH="/var/run/kamailio/kamailio_fifo" + ## check ACL names; default on (1); off (0) # VERIFY_ACL=1

8 years

← Newer
1
...
8
9
10
11
12
13
14
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2016