sr-dev January 2016

sr-dev@lists.kamailio.org

34 participants
295 discussions

git:master:b727c99b: core: explictely present the main process in description

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b727c99b8e74feec6ad1af0d01b2f4e46200ef46 URL: https://github.com/kamailio/kamailio/commit/b727c99b8e74feec6ad1af0d01b2f4e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-01-27T15:48:10+01:00 core: explictely present the main process in description - along with existing attendant description --- Modified: main.c --- Diff: https://github.com/kamailio/kamailio/commit/b727c99b8e74feec6ad1af0d01b2f4e… Patch: https://github.com/kamailio/kamailio/commit/b727c99b8e74feec6ad1af0d01b2f4e… --- diff --git a/main.c b/main.c index bc1e07c..51a52a7 100644 --- a/main.c +++ b/main.c @@ -1703,7 +1703,7 @@ int main_loop(void) } #endif /* main */ - strncpy(pt[0].desc, "attendant", MAX_PT_DESC ); + strncpy(pt[0].desc, "main process - attendant", MAX_PT_DESC ); #ifdef USE_TCP close_extra_socks(PROC_ATTENDANT, get_proc_no()); if(!tcp_disable){

8 years, 11 months

mem leak using dispatcher in event route

by Camille Oudot

Hi Kamailio devs, we've found a memory leak in one of our servers: the AVPs filled by the dispatcher module's `ds_select_dst()` function, called in the `usrloc:contact-epired` event route are not freed. Using this function in an event route is not encouraged by the documentation (only request/reply routes are mentioned there). However, it seems doable if we take care of the memory allocated for these AVPs. My question is: how could this be done in this case? Is there some existing cleanup function that can be used in the registrar module, after the event route have been executed? -- Camille

8 years, 11 months

git:master:b6e2dce8: rtpengine: Init and dealloc hastable locks

by Stefan Mititelu

Module: kamailio Branch: master Commit: b6e2dce80a607b12276addea310c9696c3c39ce9 URL: https://github.com/kamailio/kamailio/commit/b6e2dce80a607b12276addea310c969… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-27T14:19:21+02:00 rtpengine: Init and dealloc hastable locks Right now only alloc and destroy is done. Also do init and dealloc. --- Modified: modules/rtpengine/rtpengine_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/b6e2dce80a607b12276addea310c969… Patch: https://github.com/kamailio/kamailio/commit/b6e2dce80a607b12276addea310c969… --- diff --git a/modules/rtpengine/rtpengine_hash.c b/modules/rtpengine/rtpengine_hash.c index f8e610d..b36e93e 100644 --- a/modules/rtpengine/rtpengine_hash.c +++ b/modules/rtpengine/rtpengine_hash.c @@ -92,7 +92,7 @@ int rtpengine_hash_table_init(int size) { // init hashtable row_locks[i], row_entry_list[i] and row_totals[i] for (i = 0; i < hash_table_size; i++) { - // init hashtable row_locks[i] + // alloc hashtable row_locks[i] rtpengine_hash_table->row_locks[i] = lock_alloc(); if (!rtpengine_hash_table->row_locks[i]) { LM_ERR("no shm left to create rtpengine_hash_table->row_locks[%d]\n", i); @@ -100,6 +100,13 @@ int rtpengine_hash_table_init(int size) { return 0; } + // init hashtable row_locks[i] + if (!lock_init(rtpengine_hash_table->row_locks[i])) { + LM_ERR("fail to init rtpengine_hash_table->row_locks[%d]\n", i); + rtpengine_hash_table_destroy(); + return 0; + } + // init hashtable row_entry_list[i] rtpengine_hash_table->row_entry_list[i] = shm_malloc(sizeof(struct rtpengine_hash_entry)); if (!rtpengine_hash_table->row_entry_list[i]) { @@ -511,6 +518,7 @@ static void rtpengine_hash_table_free_row_lock(gen_lock_t *row_lock) { } lock_destroy(row_lock); + lock_dealloc(row_lock); return ; }

8 years, 11 months

git:master:fe37c011: core: Makefile.defs - renamed var CPU to CPUTYPE

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fe37c011810d563f8a7e7d1e6856d7199dd1f5d2 URL: https://github.com/kamailio/kamailio/commit/fe37c011810d563f8a7e7d1e6856d71… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2016-01-27T10:16:43+01:00 core: Makefile.defs - renamed var CPU to CPUTYPE - some operating systems (e.g., suse), sets the CPU in the environment to the cpu architecture, while the makefile uses it for cpu type provided to -mtune parameter of gcc --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/fe37c011810d563f8a7e7d1e6856d71… Patch: https://github.com/kamailio/kamailio/commit/fe37c011810d563f8a7e7d1e6856d71…

8 years, 11 months

git:master:73872420: ims_charging: Fixed setting of AVP

by Carsten Bock

Module: kamailio Branch: master Commit: 73872420188b2eb0a5adb51a03a3c17baec1a331 URL: https://github.com/kamailio/kamailio/commit/73872420188b2eb0a5adb51a03a3c17… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2016-01-27T10:16:06+01:00 ims_charging: Fixed setting of AVP --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/73872420188b2eb0a5adb51a03a3c17… Patch: https://github.com/kamailio/kamailio/commit/73872420188b2eb0a5adb51a03a3c17… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index e011036..dc36349 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -1435,12 +1435,13 @@ static int create_cca_result_code(int result) { int_str avp_val, avp_name; avp_name.s.s = RO_AVP_CCA_RESULT_CODE; avp_name.s.len = RO_AVP_CCA_RESULT_CODE_LENGTH; + char buf[10]; avp_val.n = result; - avp_val.s.s = 0; - avp_val.s.len = 0; + avp_val.s.len = snprintf(buf, 10, "%i", result); + avp_val.s.s = buf; - rc = add_avp(AVP_NAME_STR, avp_name, avp_val); + rc = add_avp(AVP_NAME_STR | AVP_VAL_STR, avp_name, avp_val); if (rc < 0) LM_ERR("Couldn't create ["RO_AVP_CCA_RESULT_CODE"] AVP\n");

8 years, 11 months

git:master:6711306d: rtpengine: Fix coredump on kamailio shutdown

by Stefan Mititelu

Module: kamailio Branch: master Commit: 6711306d48be16fcf1dff860f72d0db14cac02fc URL: https://github.com/kamailio/kamailio/commit/6711306d48be16fcf1dff860f72d0db… Author: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)1and1.ro> Date: 2016-01-27T10:41:06+02:00 rtpengine: Fix coredump on kamailio shutdown Fix release_lock leading to coredump, when kamailio shutdown. --- Modified: modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/6711306d48be16fcf1dff860f72d0db… Patch: https://github.com/kamailio/kamailio/commit/6711306d48be16fcf1dff860f72d0db… --- diff --git a/modules/rtpengine/rtpengine.c b/modules/rtpengine/rtpengine.c index 1782258..30db81a 100644 --- a/modules/rtpengine/rtpengine.c +++ b/modules/rtpengine/rtpengine.c @@ -1951,16 +1951,16 @@ static void mod_destroy(void) lock_get(rtpp_set_list->rset_head_lock); for(crt_list = rtpp_set_list->rset_first; crt_list != NULL; ){ + last_list = crt_list; if (!crt_list->rset_lock) { - last_list = crt_list; crt_list = last_list->rset_next; shm_free(last_list); last_list = NULL; continue; } - lock_get(crt_list->rset_lock); + lock_get(last_list->rset_lock); for(crt_rtpp = crt_list->rn_first; crt_rtpp != NULL; ){ if(crt_rtpp->rn_url.s) @@ -1970,9 +1970,8 @@ static void mod_destroy(void) crt_rtpp = last_rtpp->rn_next; shm_free(last_rtpp); } - last_list = crt_list; crt_list = last_list->rset_next; - lock_release(crt_list->rset_lock); + lock_release(last_list->rset_lock); lock_destroy(last_list->rset_lock); lock_dealloc((void*)last_list->rset_lock);

8 years, 11 months

[kamailio] http_request and curl_http_request cause crash in 4.3 and dev (#400)

by Olle E. Johansson

Repeated use of http_request cause a crash related to the storage of the result in a PV. Will upload backtraces and other info to this issue. If anyone else have seen this please add info to this bug report. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/400

8 years, 11 months

A new edition of Kamailio Development Workshop

by Daniel-Constantin Mierla

Hello, last edition of Kamailio Development Workshop happened about three years ago. As I got requests about it from time to time, I thought of trying to organize a new edition. Rather short term by now due to various constraints, so the plan is to do it again in Alicante, Spain, during February 15-16, 2016. I put together more details at: * http://www.kamailio.org/w/development-workshop/ Besides spending 2 days digging into Kamailio C code, such event is also good for discovering and sharing development resources among participants, as well as meeting people from community -- at the previous editions I met for first time with Victor Seva, Vicente Hernando and Seudin Kasumovic, which in turn contributed a lot of code afterwards. It will be also testing phase for upcoming major release, maybe we can plan some stress testing session on site. Right now I am looking to see if there is any interest in such event in order to nail down organizing it or not. Should anyone consider to participate, write me. Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com http://miconda.eu

8 years, 11 months

git:master:9acbdd31: Merge pull request #490 from kamailio/lazedo/db_text_buffer

by lazedo

Module: kamailio Branch: master Commit: 9acbdd31a6e797dcb9aed568726965a568ac4fb7 URL: https://github.com/kamailio/kamailio/commit/9acbdd31a6e797dcb9aed568726965a… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2016-01-26T21:16:51Z Merge pull request #490 from kamailio/lazedo/db_text_buffer db_text: add buffer size for reading text files --- Modified: modules/db_text/README Modified: modules/db_text/dbt_file.c Modified: modules/db_text/dbt_lib.h Modified: modules/db_text/dbtext.c Modified: modules/db_text/doc/db_text_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9acbdd31a6e797dcb9aed568726965a… Patch: https://github.com/kamailio/kamailio/commit/9acbdd31a6e797dcb9aed568726965a…

8 years, 11 months

git:master:98675340: db_text: add buffer size for reading text files

by lazedo

Module: kamailio Branch: master Commit: 98675340e429b752bdb8a4d7f7d6c1c5f60227d5 URL: https://github.com/kamailio/kamailio/commit/98675340e429b752bdb8a4d7f7d6c1c… Author: lazedo <luis.azedo(a)factorlusitano.com> Committer: lazedo <luis.azedo(a)factorlusitano.com> Date: 2016-01-26T19:40:51Z db_text: add buffer size for reading text files the static value of 4096 may not be enough when dealing with presence tables that have xml content --- Modified: modules/db_text/README Modified: modules/db_text/dbt_file.c Modified: modules/db_text/dbt_lib.h Modified: modules/db_text/dbtext.c Modified: modules/db_text/doc/db_text_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/98675340e429b752bdb8a4d7f7d6c1c… Patch: https://github.com/kamailio/kamailio/commit/98675340e429b752bdb8a4d7f7d6c1c…

8 years, 11 months

← Newer
1
...
4
5
6
7
8
9
10
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2016