sr-dev September 2015

sr-dev@lists.kamailio.org

37 participants
388 discussions

git: new commits in branch 4.2
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

- URL: https://github.com/kamailio/kamailio/commit/c271ba62e20993708f7f6a5089206b5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:36:21+02:00 pua: fix typo in matching presence.winfo - patch by foucse, GH #270 (cherry picked from commit 48f89ed0390a80cc760da5a7ed41dd9c5c5ffc4d) (cherry picked from commit d88f52cadb2bf6764518c89be852b0534731d82e) - URL: https://github.com/kamailio/kamailio/commit/41ebaf86883d8756cb5c07f61f34d5e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:36:56+02:00 drouting: fixed typo in reload cmd response - reported by GH#275 (cherry picked from commit 6b15a51b016c232fab6665fc03ed01dad09ac8b5) (cherry picked from commit fb9a01616b407065c318ba204889507d5e4d026b) - URL: https://github.com/kamailio/kamailio/commit/c680f2bf70b7f9cd804945f1a44b9e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:37:33+02:00 sanity: commented priting require header on error level (cherry picked from commit 9902ca145178498ff47092f0ecdd3bca6650c97c) (cherry picked from commit 60b2e3e3e66320446541ba92de239fc3f58bc79f) - URL: https://github.com/kamailio/kamailio/commit/d0617167f0aebcaf1e12e6c7f77b223… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:37:46+02:00 db_postgres: memset vars to 0 to avoid using invalid values inside db_postgres_new_connection() - reported by mading087, GH#292 (cherry picked from commit a16c6108e1f6d1a3f6b6c962bbaaedf37e57a8d2) (cherry picked from commit 65d4dae702ccd16654fa22c66522516f99751e3e) - URL: https://github.com/kamailio/kamailio/commit/8c04e7e86c99c8f8719715e66a89d8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:38:07+02:00 sanity: adjusted log messages for check_proxy_require() (cherry picked from commit 0f479b5366fae4c5ad0c78e4c91661b7a421d5e8) (cherry picked from commit a8c2c53b1175af7bd3c6020cc01e95174b2597e0) - URL: https://github.com/kamailio/kamailio/commit/993099f9eeadb2bc84d6cd9c73dd5b0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:39:15+02:00 dialog: set dlg var table as static and rename to avoid name conflicts (cherry picked from commit cbc0c720e1c239296ff3842d701f75663bead6d9) (cherry picked from commit 063a9b2a7f6ba6fe60797faa1ebf9f9dd37d2062) - URL: https://github.com/kamailio/kamailio/commit/97e97b37fce408eaf2d49d68e3875b9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:40:04+02:00 dialog: dlg var value stored as zero terminated string - easier to use in std lib operations (cherry picked from commit 0d9e4adb328dabaf2a34d926bc80e022bee65079) (cherry picked from commit 3ce973b0c20be7230baaf2cb8d8713e7fce64a06) - URL: https://github.com/kamailio/kamailio/commit/8c071fe4e5146cae1d6b014ba28e2f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:40:21+02:00 jsonrpc-c: free pipe cmd for notifications - fixes leak reported by GH#296 (cherry picked from commit 79459d3f87731309641794a2b881ee1cacc5e1f2) (cherry picked from commit bb0194aa9f0963cb77bb1275b8e0a4cae8f60909) - URL: https://github.com/kamailio/kamailio/commit/74800f2bf9a11ca138867ea6cdaaa53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:41:09+02:00 kamcmd: updated default server name references (cherry picked from commit 8db5eb2b53320d84ded36c531a00f6dfbec27a75) (cherry picked from commit ee3048e8685f54c35daff699ad64ce9ef5c71f8a) - URL: https://github.com/kamailio/kamailio/commit/ebe43e905eac23d86b7a9979a976f08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:41:23+02:00 kamcmd: lower max size for socket name - was set to 108 which is common for linux, but mac os x has it 104 - set to 100 now (cherry picked from commit 3f4c63802194cb83ffb8124e5ae38f85ee315c28) (cherry picked from commit 05242f6db6edcf32705722dcd0d9d3e3cf7a8340) - URL: https://github.com/kamailio/kamailio/commit/b1c4c1966d1b0e727405c1a58099a70… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:41:41+02:00 mem: safety prev free checks for f_malloc extract operation - following a report by Alex Balashov (cherry picked from commit a620bfec37cdcdc5c5debcdfb5219b09464065fe) (cherry picked from commit de7eb56737ca57429dd6ffcb01907b11609318f1) - URL: https://github.com/kamailio/kamailio/commit/0948e407adee998de6c820399d64907… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:41:53+02:00 jsonrpc-c: proper error handling for pipe cmd callback - credits to Hugh Waite for spotting missing return - free vars if already set when error handling is done (cherry picked from commit ec0ba37b9f2b6c60303227ea0527d69896f2930e) (cherry picked from commit 3beb4e9f524956883e2260450ea3593dc553ec6c) - URL: https://github.com/kamailio/kamailio/commit/cc1cbf6113c8536b2e6193b51c8e34e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:42:10+02:00 tmrec: more details about duration format for time recurrences (cherry picked from commit 81006ee1246b8f700ce9ce20814d4522780d7ceb) (cherry picked from commit c979b991450052f6a77238aef391dd8bb3f13f32) - URL: https://github.com/kamailio/kamailio/commit/516adfe9913391590c314561e7a5c53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:42:32+02:00 drouting: notes about the format of duration attribute (cherry picked from commit 711144a1fa3e1dfa540cc7ccd0ce1c14faeba42f) (cherry picked from commit 46af0cfb7cc1fffb22e43ebd41f07fc95947f8e5) - URL: https://github.com/kamailio/kamailio/commit/03c9fb0ca0759c58e93c0123882d2e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:42:44+02:00 tmx: err level replaced with info when getting t reply code pv (cherry picked from commit aad248fc39279f84879929772e9306fc01473860) (cherry picked from commit b7aab8f4a019e21f03b3e3323af592bc4af5857c) - URL: https://github.com/kamailio/kamailio/commit/9fbb8373ba57d30f3e088e354b159dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:43:07+02:00 parser: safer function to parse header name stored in short buffer (cherry picked from commit cbc5034b26189371c2ffb80424414aa8b1b8dea5) (cherry picked from commit 742f6fbba5b0d5d308ea0434311d811b5cb56e55) - URL: https://github.com/kamailio/kamailio/commit/fc6d22c13003fe944ae99b2427f1ba7… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-09-17T16:43:15+02:00 parser: fix overflow access when parsing Reason header stored in short buffer - it can happen for fixup functions from textops module having header name as a parameter, with critical impact when using system malloc, the internal pkg malloc does a roundup of the allocated space - the issue is caused by the word (4 bytes) read step performed by parse_hname2() - second 4-byte read in buffer "Reason:" exceeds the size by 1 - added a safe read macro that reads 1, 2 or 3 bytes if the size of the buffer is not big enough for a 4 bytes read (cherry picked from commit 964ed0a5083413eb0a70bd8a952d5a91ee9e9883) (cherry picked from commit 5425c257ff0726a310aced28282821a4e4b7911c) - URL: https://github.com/kamailio/kamailio/commit/bf9a066ec07ba4c68b55a5be9765092… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:43:29+02:00 parser: fixed the name for the new parse_hname2_short() function (cherry picked from commit ac27d053ce0d9d9295f3ca8052a320e0c0b01699) (cherry picked from commit db279576832664b5dee2c432c35030047e9e7b6f) - URL: https://github.com/kamailio/kamailio/commit/96558987d10928d883f6a70b2400f58… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:43:37+02:00 core: select framework - use safer function to parse header name in short buffer (cherry picked from commit baf90dba5c12158386e501e73daa266321d9de38) (cherry picked from commit 5cc4184e64f300319a65ce7f951510222830fbd8) - URL: https://github.com/kamailio/kamailio/commit/ff5c661cc0184fb484613b873f54d8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:43:47+02:00 pv: use safer function to parse header name in short buffer (cherry picked from commit a9dc0f738f448676b8a92818d442ca7142147f9b) (cherry picked from commit 5d97276a2586c8c312b6c56542e9b440ef006c28) - URL: https://github.com/kamailio/kamailio/commit/a9809db2f504ed8576b54ac19974444… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:43:59+02:00 textops: use safer function to parse header name in short buffer (cherry picked from commit b62492e2e25984528e4cda7f96d7afee1425ceb3) (cherry picked from commit 036c1d134e6c20e9e5e394b790abb6fd0fe47695) - URL: https://github.com/kamailio/kamailio/commit/26e0a041f3de56dfa02449b05242b09… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:44:17+02:00 textopsx: use safer function to parse header name in short buffer (cherry picked from commit 2aa013d5fb992be98fc1ec90abdf0d67625ab724) (cherry picked from commit 5f02824b9dd195a1a94ae0038d4c73aa1ea6da24) - URL: https://github.com/kamailio/kamailio/commit/108750dc552ba71b9109be2b33d0564… Author: vance-od <vance(a)ukr.net> Date: 2015-09-17T16:44:30+02:00 Update nonce.c auth: fixed issue when during registration nonce expired, after backwards time shift (cherry picked from commit 063e32a8fe81b2cfbaac0386e6b51446586e619a) (cherry picked from commit f02215971667f54c553e10593e370db8feb1aae9) - URL: https://github.com/kamailio/kamailio/commit/2df7744c340342bdd28a5cdcff4fe39… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:44:39+02:00 auth: fixed improper whitespacing (cherry picked from commit 20231f4936b5f79bcb2e3f64985953888391e570) - URL: https://github.com/kamailio/kamailio/commit/516f496bcead9785451558063e7ec1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:44:59+02:00 corex: log messages for memory status/summary rpc commands (cherry picked from commit 014a62f7546675ffc198d1c169f6bd12b3bdd87d) (cherry picked from commit 08bd04db6a71a1111e04adbbb85671544b1cd5f2) - URL: https://github.com/kamailio/kamailio/commit/7a48d3501a1281e6b6097e41cec808b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:45:09+02:00 dialog: more debug when storing vars in database (cherry picked from commit 2962852bf706692bdbc9b51419dbdc2012f34e1b) (cherry picked from commit 970ef5b844c195ad07cda15027ba99516eae645a) - URL: https://github.com/kamailio/kamailio/commit/f2ba1db3abbdedc3490088685b3ab02… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:45:29+02:00 tm: store last received response code before running onreply_route - otherwise an innapropriate cancel can happen if the current branch got before an 1xx response, and the script writer enforces another reply code with t_reply() - reported by Thomas Sevestre, GH#315 (cherry picked from commit b7c588dff06030a82f305b210573be5bbc961cec) (cherry picked from commit dca8ff16753639b1f84cd60286142fbad88335c7) - URL: https://github.com/kamailio/kamailio/commit/1332a6a3f651c47704c1423284b3fbf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:45:43+02:00 parser: fix start of search for long header names - in parse_hname2_short(), used only for mod fixups, in the case header name given as function param was greater than 250 chars (cherry picked from commit de8ba3900d6fef42e99ca9568044c7aefa44a5ea) (cherry picked from commit 262d3574790ea3a10c82cb8bc0e4a65429f25540) - URL: https://github.com/kamailio/kamailio/commit/c888bcb0040c3da36e47201916ca865… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:45:57+02:00 dialog: lock the slot if old dialog found in state deleted - no longer a spiral condition and new dialog will be created (cherry picked from commit 7f9194c416e171c2b723430eb98a55a52b7b5e38) (cherry picked from commit 061195f6d553bad5edfc30db5c8da28d74421519) - URL: https://github.com/kamailio/kamailio/commit/0ac700af6805d427d9ee409bbae3c61… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:46:07+02:00 dialog: safety check not to store dialog vars and data when state initial - acc callbacks for cdrs can trigger setting dialog vars in initial state, which then try to save in db, however, initial state might not have all required fields for a proper db reload, storing being desinged to be done when all mandatory fields are set (cherry picked from commit cecdd0817052046e634152d6e512165451b5f6d4) (cherry picked from commit a58c136c3abad48b2d01a4b54b1e56e0901b8246) - URL: https://github.com/kamailio/kamailio/commit/6bfe8156285ab4bad2a0664124ee536… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:47:25+02:00 rls: proper detection of initial subscribe to send notify with full state - use to-tag conditions, previously was sending only based on db mode - reported by GH#276 (cherry picked from commit b99e9e96592a5d708ff565343f3c810b2d264577) (cherry picked from commit 648834a64d63aed64076dacf85ec5af1a5702333) - URL: https://github.com/kamailio/kamailio/commit/b96d38944af3ae0d78b1b65255b6659… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:47:37+02:00 dialog: mark slot as lock if dialog found in state deleted for spiral detection (cherry picked from commit 6a9c892fd0a7a526ec6ced4b40479875477d96db) (cherry picked from commit 3763f689436b717b323d6d0337317ffc24d180a1) - URL: https://github.com/kamailio/kamailio/commit/9469c394f5c4694b7e72d8d7493feeb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:47:47+02:00 parse: more log messages in case of errors in parse_hname2_short() (cherry picked from commit 3913cc881030cccc9518733e18363402f2dfb18e) (cherry picked from commit 0b20349c487f9a486db7407b3f712ca06531b9d1) - URL: https://github.com/kamailio/kamailio/commit/2845d5a889ba9a22dbecc574005ff3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:47:58+02:00 textopsx: include : in the value to be parsed as header name inside fixup_hname_param() - reported by BjÃ¶rn Bylander (cherry picked from commit 5f301c9e9b3d4b67a11aeaab45c21fd8d8929695) (cherry picked from commit 637e727484affa52489ff6d7bf2fe06fd6bb1085) - URL: https://github.com/kamailio/kamailio/commit/02afaf4f6402c119922f644840eb0b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:48:09+02:00 mem/f_malloc: simplified free frags management - avoid address referencing to previous free fragments, it can get invalidated on joins - straight doubly linked list also speeds join/defrag (cherry picked from commit 2d0455d9f2266ad67867e03aa652863e37d5a8d2) (cherry picked from commit 3ddf71b943530e98ba94ad9d9ec37be3a90e1182) - URL: https://github.com/kamailio/kamailio/commit/00d5ba4713f557b7ce3d7d983c292ba… Author: jaybeepee <jason.penton(a)gmail.com> Date: 2015-09-17T16:48:26+02:00 modules/tm: precent possible seg fault if branch reply is null (cherry picked from commit aec9850491a8e8fa919396ae0e0f1d99d30c607c) (cherry picked from commit 7ac3eea0c49872a75d384e94ee0b4380caf440e0) - URL: https://github.com/kamailio/kamailio/commit/52ffab7e75274c7cfb4b2f0de8f4108… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:48:36+02:00 mem: removed unused variables - two old vars not needed anymore after previous commit (cherry picked from commit 16bcb9d257622a68eed44d6eea5e342f35dbde83) (cherry picked from commit d6d2474bbbd6a6fd08cbede42ad1cd64cc47dc64) - URL: https://github.com/kamailio/kamailio/commit/53b132e69692f8476769f84fa066a6a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:49:09+02:00 auth_db: more log messages when username checks failed (cherry picked from commit d46d008e0936a01229872df71ac26afb43122f4b) (cherry picked from commit 978e3b65c7d1d21a69a55492dc156493cc8c28bf) - URL: https://github.com/kamailio/kamailio/commit/a8b8e0694cce41a9cad285f3cfe50aa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:49:21+02:00 tmx: err to work if resuming suspended transaction fails - it can be a non-suspended transaction id or after expiration (cherry picked from commit 2682d85657d1caf96961a6153cd82c506fde7d0d) (cherry picked from commit ce43a14d701ec38276883b863cd81bbb3de3b35a) - URL: https://github.com/kamailio/kamailio/commit/f5ec0d06e09e9e73d1d40d04ec808bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:49:35+02:00 tm: reset async suspended flag when continuing via failure_route - suspended transaction can be resumed automatically on timeout, without t_continue(), ending up in failure_route (cherry picked from commit 171553ebcac2f00a015191f36f2f228c0d3e483b) (cherry picked from commit 0c6bed8779024c0c35a9c1bb82dc24255d8f08e2) - URL: https://github.com/kamailio/kamailio/commit/46aa50d61e5e8f57a29c4b76a2c1332… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:49:43+02:00 tm: test if transaction was suspended before resuming inside t_continue() (cherry picked from commit 52c4965bbb4cde5d7bddcf697aa504e7c2202ac1) (cherry picked from commit c58d4c4471f794944c60164a19ae3aa884fe2ade) - URL: https://github.com/kamailio/kamailio/commit/796013054c4c75e461ef80d504358d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:49:52+02:00 tm: warn in case of transaction is not suspended by a continue is attempted (cherry picked from commit 33c5449563becd2357b648ec469ef247a6ae2f5d) (cherry picked from commit 192294cc025f7b39efcd60c2053423ff10861d75) - URL: https://github.com/kamailio/kamailio/commit/f1b8044c0d61adc616fbf433c9e65e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T16:57:48+02:00 tm: backport of suspended flag to detect resume on a non-suspended transaction

1 0

git:master:b4afd137: parser: Fix parser error when Retry-After is last header
by Hugh Waite 17 Sep '15

17 Sep '15

Module: kamailio Branch: master Commit: b4afd1375c3958f1847d56efe38872b3a9d055e0 URL: https://github.com/kamailio/kamailio/commit/b4afd1375c3958f1847d56efe38872b… Author: Hugh Waite <hugh.waite(a)acision.com> Committer: Hugh Waite <hugh.waite(a)acision.com> Date: 2015-09-17T15:54:31+01:00 parser: Fix parser error when Retry-After is last header - Prevent off-by-one error when CRLF is followed by CRLF --- Modified: parser/parse_retry_after.c --- Diff: https://github.com/kamailio/kamailio/commit/b4afd1375c3958f1847d56efe38872b… Patch: https://github.com/kamailio/kamailio/commit/b4afd1375c3958f1847d56efe38872b… --- diff --git a/parser/parse_retry_after.c b/parser/parse_retry_after.c index a467cf2..59e52d7 100644 --- a/parser/parse_retry_after.c +++ b/parser/parse_retry_after.c @@ -72,8 +72,6 @@ char* parse_retry_after(char* const buf, const char* const end, unsigned* const /* find the end of header */ for (; t<end; t++){ if (*t=='\n'){ - if (((t+1)<end) && (*(t+1)=='\r')) - t++; if (((t+1)<end) && (*(t+1)==' ' || *(t+1)=='\t')){ t++; continue; /* line folding ... */

1 0

git:master:f83a695d: Revert "db_postgres: Fix heap use after free error in db_postgres module" (after some discussions)
by Carsten Bock 17 Sep '15

17 Sep '15

Module: kamailio Branch: master Commit: f83a695d70cfd4aea09383e8e235d4184dc1521e URL: https://github.com/kamailio/kamailio/commit/f83a695d70cfd4aea09383e8e235d41… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-09-17T16:28:59+02:00 Revert "db_postgres: Fix heap use after free error in db_postgres module" (after some discussions) This reverts commit 74c84c7cd52347fcd1c90e75dca239b5f758169b. --- Modified: modules/db_postgres/km_pg_con.c Modified: modules/db_postgres/km_res.c --- Diff: https://github.com/kamailio/kamailio/commit/f83a695d70cfd4aea09383e8e235d41… Patch: https://github.com/kamailio/kamailio/commit/f83a695d70cfd4aea09383e8e235d41… --- diff --git a/modules/db_postgres/km_pg_con.c b/modules/db_postgres/km_pg_con.c index d053c55..ec98add 100644 --- a/modules/db_postgres/km_pg_con.c +++ b/modules/db_postgres/km_pg_con.c @@ -71,6 +71,10 @@ struct pg_con* db_postgres_new_connection(struct db_id* id) memset(ptr, 0, sizeof(struct pg_con)); ptr->ref = 1; + memset(keywords, 0, (sizeof(char*) * 10)); + memset(values, 0, (sizeof(char*) * 10)); + memset(to, 0, (sizeof(char) * 16)); + if (id->port) { ports = int2str(id->port, 0); keywords[i] = "port"; diff --git a/modules/db_postgres/km_res.c b/modules/db_postgres/km_res.c index 912206b..e9aa232 100644 --- a/modules/db_postgres/km_res.c +++ b/modules/db_postgres/km_res.c @@ -126,14 +126,8 @@ int db_postgres_get_columns(const db1_con_t* _h, db1_res_t* _r) RES_NAMES(_r)[col]); /* The pointer that is here returned is part of the result structure. */ - RES_NAMES(_r)[col]->s = pkg_malloc(strlen(PQfname(CON_RESULT(_h), col))+1); - if (! RES_NAMES(_r)[col]->s) { - LM_ERR("no private memory left\n"); - db_free_columns(_r); - return -4; - } - strcpy(RES_NAMES(_r)[col]->s, PQfname(CON_RESULT(_h), col)); - RES_NAMES(_r)[col]->len = strlen(RES_NAMES(_r)[col]->s); + RES_NAMES(_r)[col]->s = PQfname(CON_RESULT(_h), col); + RES_NAMES(_r)[col]->len = strlen(PQfname(CON_RESULT(_h), col)); LM_DBG("RES_NAMES(%p)[%d]=[%.*s]\n", RES_NAMES(_r)[col], col, RES_NAMES(_r)[col]->len, RES_NAMES(_r)[col]->s);

1 0

[kamailio] kamailio 4.3 crash at run_trans_callbacks_internal (#322)
by zxcpoiu 17 Sep '15

17 Sep '15

I have two kamailio servers which is in staging area, so there are few of users on it. say 2 or 3 making some testing calls. The only difference between staging area and production area is that staging area enabled "ASYNC PUSH WAKE", similar concept and logic introduced by Danail at Kamailio World 2014. [Aynchronous Processing in Kamailio Configuration File](http://www.slideshare.net/miconda/26-danielconstantinmierlakamailiocf… These days, I experienced some crash at staging area and I can't reproduce it. But productions which has tens of thousands of users did not have this issue. Since I've tested the ASYNC PUSH WAKE and all it works well, I believed (guess) the problem may caused by two factors: 1. There are some bugs hidden in PUSH WAKE algorithm that suspend a transaction by tm module, stores it to htable, then resume when matched some conditions. 2. sip client ( compromised Linphone ) used by my client. ( Note: I've tested all official CSipSimple / Bria / Linphone and all works well ) But totally no ideas till now. I've turn on debug mode with: ``` debug=3 memlog=4 memdbg=4 corelog=3 ``` kamailio version is: ``` root@sip1:/home/pkg/kamailio/etc/kamailio# kamcmd core.info { version: kamailio 4.3.1 id: f38e67 compiler: gcc 4.7.2 compiled: 13:18:05 Aug 11 2015 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES } ``` Before I catch the crash till it happens again, below is what I can give right now: 4 back traces and syslog indicate crash address all corefiles are kept, I will feedback if I get another clues. #### BT 1 ``` ===syslog=== Sep 4 14:24:57 sip1 kernel: [41174906.447276] kamailio[50056]: segfault at 7f97b600676e ip 00007f97b600676e sp 00007fff6e141a28 error 14 in mi_rpc.so[7f97b5f3b000+200000] Sep 4 14:25:17 sip1 media-dispatcher[76950]: debug: Connection to OpenSIPS lost: Connection was closed cleanly. Sep 4 14:25:17 sip1 /home/pkg/kamailio/sbin/kamailio[49990]: ALERT: <core> [main.c:728]: handle_sigs(): child process 50056 exited by a signal 11 Sep 4 14:25:17 sip1 /home/pkg/kamailio/sbin/kamailio[49990]: ALERT: <core> [main.c:731]: handle_sigs(): core was generated ===backtrace=== #0 0x00007f97b600676e in ?? () No symbol table info available. #1 0x00007f97b803db5e in run_trans_callbacks_internal (cb_lst=0x7f97b98e5900, type=32, trans=0x7f97b98e5890, params=0x7fff6e141b10) at t_hooks.c:268 cbp = 0x7f97b98e7380 backup_from = 0xa82430 backup_to = 0xa82438 backup_dom_from = 0xa82440 backup_dom_to = 0xa82448 backup_uri_from = 0xa82420 backup_uri_to = 0xa82428 backup_xavps = 0xa82560 __FUNCTION__ = "run_trans_callbacks_internal" #2 0x00007f97b803dc6f in run_trans_callbacks (type=32, trans=0x7f97b98e5890, req=0x7f97b98b38f8, rpl=0x7f98fb64e2b0, code=180) at t_hooks.c:295 params = {req = 0x7f97b98b38f8, rpl = 0x7f98fb64e2b0, param = 0x7f97b98e7390, code = 180, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, send_buf = {s = 0x0, len = 0}} #3 0x00007f97b809382e in relay_reply (t=0x7f97b98e5890, p_msg=0x7f98fb64e2b0, branch=1, msg_status=180, cancel_data=0x7fff6e141e70, do_put_on_wait=1) at t_reply.c:1767 relay = 1 save_clone = 0 buf = 0x0 res_len = 0 relayed_code = 0 relayed_msg = 0x0 reply_bak = 0x7fff05051cb0 bm = {to_tag_val = {s = 0xffffffff01b46f02 <Address 0xffffffff01b46f02 out of bounds>, len = -77247288}} totag_retr = 0 reply_status = RPS_PROVISIONAL uas_rb = 0x7f97b98e5950 to_tag = 0x7f97b80837bf reason = {s = 0x7fff6e141c60 "\200\034\024n\005", len = -1207424906} onsend_params = {req = 0x7fff6e141c80, rpl = 0x7f97b804db23, param = 0x7fff6e141c10, code = 1, flags = 0, branch = 0, t_rbuf = 0x7f97b98e5a50, dst = 0x50075b821, send_buf = { s = 0xfab1b348 <Address 0xfab1b348 out of bounds>, len = 1024}} __FUNCTION__ = "relay_reply" #4 0x00007f97b8097959 in reply_received (p_msg=0x7f98fb64e2b0) at t_reply.c:2429 msg_status = 180 last_uac_status = 100 ack = 0x7fff6e141f60 "` \024n\377\177" ack_len = 32664 branch = 1 reply_status = 6440375 onreply_route = 3 cancel_data = {cancel_bitmap = 0, reason = {cause = 0, u = {text = {s = 0x0, len = 6682541}, e2e_cancel = 0x0, packed_hdrs = {s = 0x0, len = 6682541}}}} uac = 0x7f97b98e5c48 t = 0x7f97b98e5890 lack_dst = {send_sock = 0x7fff6e141e70, to = {s = {sa_family = 17847, sa_data = "b\000\000\000\000\000\200\036\024n\377\177\000"}, sin = {sin_family = 17847, sin_port = 98, sin_addr = { s_addr = 0}, sin_zero = "\200\036\024n\377\177\000"}, sin6 = {sin6_family = 17847, sin6_port = 98, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = "\200\036\024n\377\177\000\000\020\260\261\372\230\177\000", __u6_addr16 = {7808, 28180, 32767, 0, 45072, 64177, 32664, 0}, __u6_addr32 = {1846812288, 32767, 4205948944, 32664}}}, sin6_scope_id = 778}}, id = 10, proto = 84 'T', send_flags = {f = 109 'm', blst_imask = 180 '\264'}} backup_user_from = 0xa82430 backup_user_to = 0xa82438 backup_domain_from = 0xa82440 backup_domain_to = 0xa82448 backup_uri_from = 0xa82420 backup_uri_to = 0xa82428 backup_xavps = 0xa82560 replies_locked = 1 branch_ret = 1846812496 prev_branch = 32664 blst_503_timeout = -77274448 hf = 0xa96c10 onsend_params = {req = 0x4004188b0, rpl = 0x75fc90, param = 0x0, code = 0, flags = 3, branch = 0, t_rbuf = 0x7fff6e141ee0, dst = 0x631363, send_buf = {s = 0x7fff6e141ee0 "`\037\024n\377\177", len = 6422143}} ctx = {rec_lev = 0, run_flags = 0, last_retcode = 1, jmp_env = {{__jmpbuf = {797, -5029273663833343261, 4294832, 140735040203504, 0, 0, -5029273663808177437, 5029028274090965731}, __mask_was_saved = 0, __saved_mask = {__val = {6422143, 140735040200416, 6475430, 140735040200128, 140295017705488, 140735040200192, 140289551658488, 140735040200160, 0, 1073741824, 1401221318984, 140295029470864, 7733692, 64, 28601913, 174}}}}} __FUNCTION__ = "reply_received" #5 0x00000000004901cc in do_forward_reply (msg=0x7f98fb64e2b0, mode=0) at forward.c:747 new_buf = 0x0 dst = {send_sock = 0x0, to = {s = {sa_family = 0, sa_data = '\000' <repeats 13 times>}, sin = {sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 0, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, id = 0, proto = 0 '\000', send_flags = {f = 0 '\000', blst_imask = 0 '\000'}} new_len = 0 r = 2 ip = {af = 0, len = 0, u = {addrl = {21482551329, 140295017709352}, addr32 = {7714849, 5, 4205952808, 32664}, addr16 = {47137, 117, 5, 0, 48936, 64177, 32664, 0}, addr = "!\270u\000\005\000\000\000(\277\261\372\230\177\000"}} s = 0x7f98fb64e2b8 "99\351U" len = 32663 __FUNCTION__ = "do_forward_reply" #6 0x0000000000491856 in forward_reply (msg=0x7f98fb64e2b0) at forward.c:849 No locals. #7 0x000000000050e062 in receive_msg ( buf=0x1b46d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.1:5003;branch=z9hG4bK60b8.17e8d16cb9ef6d39be60d4cc68762171.1;i=9e02;received=211.78.19.1;rport=57074\r\nVia: SIP/2.0/TCP 192.168.1.112:64044;received=218."..., len=797, rcv_info=0x7f97b98f1610) at receive.c:255 msg = 0x7f98fb64e2b0 ctx = {rec_lev = -1181805064, run_flags = 32663, last_retcode = 16383, jmp_env = {{__jmpbuf = {17179869186, 140289629072096, 4294832, 3424935750384, 0, 0, 4294832, 140735040203504}, __mask_was_saved = 1846813104, __saved_mask = {__val = {6234849, 28601648, 140296091965321, 0, 140296091950726, 140735040201912, 140289629951480, 65552, 797, 42949672963, 140289629953026, 0, 140289629953029, 140735040201360, 6235333, 4294832}}}}} ret = 0 inb = { s = 0x1b46d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.1:5003;branch=z9hG4bK60b8.17e8d16cb9ef6d39be60d4cc68762171.1;i=9e02;received=211.78.19.1;rport=57074\r\nVia: SIP/2.0/TCP 192.168.1.112:64044;received=218."..., len = 797} __FUNCTION__ = "receive_msg" #8 0x00000000005f65fc in receive_tcp_msg ( tcpbuf=0x7f97b98f18e8 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.1:5003;branch=z9hG4bK60b8.17e8d16cb9ef6d39be60d4cc68762171.1;i=9e02;received=211.78.19.1;rport=57074\r\nVia: SIP/2.0/TCP 192.168.1.112:64044;received=218."..., len=797, rcv_info=0x7f97b98f1610, con=0x7f97b98f15f8) at tcp_read.c:1247 buf = 0x1b46d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.1:5003;branch=z9hG4bK60b8.17e8d16cb9ef6d39be60d4cc68762171.1;i=9e02;received=211.78.19.1;rport=57074\r\nVia: SIP/2.0/TCP 192.168.1.112:64044;received=218."... bsize = 65535 blen = 65535 __FUNCTION__ = "receive_tcp_msg" #9 0x00000000005f7d9b in tcp_read_req (con=0x7f97b98f15f8, bytes_read=0x7fff6e1424c0, read_flags=0x7fff6e1424b8) at tcp_read.c:1401 bytes = 797 total_bytes = 797 resp = 1 size = 140735040201552 req = 0x7f97b98f1678 dst = {send_sock = 0x14, to = {s = {sa_family = 1, sa_data = "\000\000P\000\000\000\001 \000\200\370\320\366", <incomplete sequence \372>}, sin = {sin_family = 1, sin_port = 0, sin_addr = { s_addr = 80}, sin_zero = "\001 \000\200\370\320\366", <incomplete sequence \372>}, sin6 = {sin6_family = 1, sin6_port = 0, sin6_flowinfo = 80, sin6_addr = {__in6_u = { __u6_addr8 = "\001 \000\200\370\320\366\372\230\177\000\000\000\000\000", __u6_addr16 = {8193, 32768, 53496, 64246, 32664, 0, 0, 0}, __u6_addr32 = {2147491841, 4210479352, 32664, 0}}}, sin6_scope_id = 1846813872}}, id = 32767, proto = 8 '\b', send_flags = {f = 0 '\000', blst_imask = 0 '\000'}} c = 0 '\000' ret = -1 __FUNCTION__ = "tcp_read_req" #10 0x00000000005fadab in handle_io (fm=0x7f98faf6d0f8, events=1, idx=-1) at tcp_read.c:1624 ret = 0 n = -1 read_flags = 1 con = 0x7f97b98f15f8 s = 11 resp = 1 t = 381376958 __FUNCTION__ = "handle_io" #11 0x00000000005ee8c0 in io_wait_loop_epoll (h=0xa2dfe0, t=2, repeat=1) at io_wait.h:1061 n = 1 r = 0 fm = 0x7f98faf6d0f8 revents = 1 __FUNCTION__ = "io_wait_loop_epoll" #12 0x00000000005fbe1a in tcp_receive_loop (unix_sock=97) at tcp_read.c:1739 __FUNCTION__ = "tcp_receive_loop" #13 0x00000000005e54e1 in tcp_init_children () at tcp_main.c:4787 r = 15 i = 23 reader_fd_1 = 97 pid = 0 si_desc = "tcp receiver (generic)\000\000ygY\000\000\000\000\000P'\024n\377\177\000\000R\342B\000\000\000\000\000\060'\024n\377\177\000\000\260ò:\231\177\000\000\220\023\364\372\230\177\000\000_\301\211T\000\000\000\000\217sp\000\000\000\000\000\020\021\265\372\230\177\000\000(\000\000\000)\000\000\000UZ-;a\303\000\000m\303\000\000Tb\214K_\301\211T\000\000\000" si = 0x0 __FUNCTION__ = "tcp_init_children" #14 0x00000000004ab258 in main_loop () at main.c:1658 i = 24 pid = 50017 si = 0x0 si_desc = "udp receiver child=23 sock=211.78.19.1:5003\000n\000\000\000~/q\000\001\000\000\000\260䕸\227\177\000\000\060(\024n\377\177\000\000\032\264N\000\000\000\000\000\200(\024n\377\177\000\000\260\000\364\372\230\177\000\000\350\327⸗\177\000\000\260䕸\227\177\000\000_\301\211T\000\000\000\000\260\210A\000\001\000\000" nrprocs = 24 __FUNCTION__ = "main_loop" #15 0x00000000004b0b5b in main (argc=13, argv=0x7fff6e142af8) at main.c:2533 cfg_stream = 0x1a9a010 c = -1 r = 0 tmp = 0x7fff6e144d59 "" tmp_len = 32665 port = 994981744 proto = 0 options = 0x707db8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 1686944683 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x76 p = 0x7fff6e1429fe "" __FUNCTION__ = "main" ``` #### BT 2 ``` ===syslog=== Sep 8 09:59:08 sip2 kernel: [58418949.036449] kamailio[145444]: segfault at 7fa6a900676e ip 00007fa6a900676e sp 00007fff6fed90a8 error 14 in textops.so[7fa6a8ec6000+200000] Sep 8 09:59:38 sip2 media-dispatcher[98511]: debug: Connection to OpenSIPS lost: Connection was closed cleanly. Sep 8 09:59:38 sip2 /home/pkg/kamailio/sbin/kamailio[145378]: ALERT: <core> [main.c:728]: handle_sigs(): child process 145444 exited by a signal 11 Sep 8 09:59:38 sip2 /home/pkg/kamailio/sbin/kamailio[145378]: ALERT: <core> [main.c:731]: handle_sigs(): core was generated ===backtrace=== #0 0x00007fa6a900676e in ?? () No symbol table info available. #1 0x00007fa6ab3d9b5e in run_trans_callbacks_internal (cb_lst=0x7fa6acd75a88, type=32, trans=0x7fa6acd75a18, params=0x7fff6fed9190) at t_hooks.c:268 cbp = 0x7fa6acd680f0 backup_from = 0xa82430 backup_to = 0xa82438 backup_dom_from = 0xa82440 backup_dom_to = 0xa82448 backup_uri_from = 0xa82420 backup_uri_to = 0xa82428 backup_xavps = 0xa82560 __FUNCTION__ = "run_trans_callbacks_internal" #2 0x00007fa6ab3d9c6f in run_trans_callbacks (type=32, trans=0x7fa6acd75a18, req=0x7fa6acd6c828, rpl=0x7fa7ee9ea2b0, code=180) at t_hooks.c:295 params = {req = 0x7fa6acd6c828, rpl = 0x7fa7ee9ea2b0, param = 0x7fa6acd68100, code = 180, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, send_buf = {s = 0x0, len = 0}} #3 0x00007fa6ab42f82e in relay_reply (t=0x7fa6acd75a18, p_msg=0x7fa7ee9ea2b0, branch=1, msg_status=180, cancel_data=0x7fff6fed94f0, do_put_on_wait=1) at t_reply.c:1767 relay = 1 save_clone = 0 buf = 0x0 res_len = 0 relayed_code = 0 relayed_msg = 0x0 reply_bak = 0x7fff05059330 bm = {to_tag_val = {s = 0xffffffff00c75ead <Address 0xffffffff00c75ead out of bounds>, len = -291574016}} totag_retr = 0 reply_status = RPS_PROVISIONAL uas_rb = 0x7fa6acd75ad8 to_tag = 0x7fa6ab41f7bf reason = {s = 0x7fff6fed92e0 "", len = -1421744010} onsend_params = {req = 0x7fff6fed9300, rpl = 0x7fa6ab3e9b23, param = 0x7fff6fed9290, code = 1, flags = 0, branch = 0, t_rbuf = 0x7fa6acd75bd8, dst = 0x50075b821, send_buf = { s = 0xedeb7328 <Address 0xedeb7328 out of bounds>, len = 1024}} __FUNCTION__ = "relay_reply" #4 0x00007fa6ab433959 in reply_received (p_msg=0x7fa7ee9ea2b0) at t_reply.c:2429 msg_status = 180 last_uac_status = 100 ack = 0x7fff6fed95e0 "\340\226\355o\377\177" ack_len = 32679 branch = 1 reply_status = 6440375 onreply_route = 3 cancel_data = {cancel_bitmap = 0, reason = {cause = 0, u = {text = {s = 0x0, len = 6682541}, e2e_cancel = 0x0, packed_hdrs = {s = 0x0, len = 6682541}}}} uac = 0x7fa6acd75dd0 t = 0x7fa6acd75a18 lack_dst = {send_sock = 0x7fff6fed94f0, to = {s = {sa_family = 17847, sa_data = "b\000\000\000\000\000\000\225\355o\377\177\000"}, sin = {sin_family = 17847, sin_port = 98, sin_addr = { s_addr = 0}, sin_zero = "\000\225\355o\377\177\000"}, sin6 = {sin6_family = 17847, sin6_port = 98, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = "\000\225\355o\377\177\000\000\020p\353\355\247\177\000", __u6_addr16 = {38144, 28653, 32767, 0, 28688, 60907, 32679, 0}, __u6_addr32 = {1877841152, 32767, 3991629840, 32679}}}, sin6_scope_id = 778}}, id = 10, proto = 84 'T', send_flags = {f = 93 ']', blst_imask = 199 '\307'}} backup_user_from = 0xa82430 backup_user_to = 0xa82438 backup_domain_from = 0xa82440 backup_domain_to = 0xa82448 backup_uri_from = 0xa82420 backup_uri_to = 0xa82428 backup_xavps = 0xa82560 replies_locked = 1 branch_ret = 1877841360 prev_branch = 32679 blst_503_timeout = -291593552 hf = 0xa96580 onsend_params = {req = 0x4004188b0, rpl = 0x75fc90, param = 0x0, code = 0, flags = 3, branch = 0, t_rbuf = 0x7fff6fed9560, dst = 0x631363, send_buf = {s = 0x7fff6fed9560 "\340\225\355o\377\177", len = 6422143}} ctx = {rec_lev = 0, run_flags = 0, last_retcode = 1, jmp_env = {{__jmpbuf = {797, -4883994847374486000, 4294832, 140735071232368, 0, 0, -4883994847399651824, 4883678595199653392}, __mask_was_saved = 0, __saved_mask = {__val = {6422143, 140735071229280, 6475430, 140735071228992, 140359227895824, 140735071229056, 140353761848824, 140735071229024, 0, 1073741824, 1401221321056, 140359239663288, 7733692, 64, 13065785, 175}}}}} __FUNCTION__ = "reply_received" #5 0x00000000004901cc in do_forward_reply (msg=0x7fa7ee9ea2b0, mode=0) at forward.c:747 new_buf = 0x0 dst = {send_sock = 0x0, to = {s = {sa_family = 0, sa_data = '\000' <repeats 13 times>}, sin = {sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}, sin6 = {sin6_family = 0, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = {__u6_addr8 = '\000' <repeats 15 times>, __u6_addr16 = {0, 0, 0, 0, 0, 0, 0, 0}, __u6_addr32 = {0, 0, 0, 0}}}, sin6_scope_id = 0}}, id = 0, proto = 0 '\000', send_flags = {f = 0 '\000', blst_imask = 0 '\000'}} new_len = 0 r = 2 ip = {af = 0, len = 0, u = {addrl = {21482551329, 140359227899688}, addr32 = {7714849, 5, 3991633704, 32679}, addr16 = {47137, 117, 5, 0, 32552, 60907, 32679, 0}, addr = "!\270u\000\005\000\000\000(\177\353\355\247\177\000"}} s = 0x7fa7ee9ea2b8 "\354@\356U" len = 32678 __FUNCTION__ = "do_forward_reply" #6 0x0000000000491856 in forward_reply (msg=0x7fa7ee9ea2b0) at forward.c:849 No locals. #7 0x000000000050e062 in receive_msg ( buf=0xc75d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.2:5003;branch=z9hG4bKd59d.0efeaa2488813a7c1ff6cbb4fa19f351.1;i=6592;received=211.78.19.2;rport=22430\r\nVia: SIP/2.0/TCP 192.168.1.112:58885;received=218."..., len=797, rcv_info=0x7fa6acd7b088) at receive.c:255 msg = 0x7fa7ee9ea2b0 ctx = {rec_lev = -1395150736, run_flags = 32678, last_retcode = 16383, jmp_env = {{__jmpbuf = {17179869186, 140353840147104, 4294832, 3424966779248, 0, 0, 4294832, 140735071232368}, __mask_was_saved = 1877841968, __saved_mask = {__val = {6234849, 13065520, 140360302155657, 0, 140360302141062, 140735071230776, 140353841115248, 65552, 797, 42949672963, 140353841116794, 0, 140353841116797, 140735071230224, 6235333, 4294832}}}}} ret = 0 inb = { s = 0xc75d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.2:5003;branch=z9hG4bKd59d.0efeaa2488813a7c1ff6cbb4fa19f351.1;i=6592;received=211.78.19.2;rport=22430\r\nVia: SIP/2.0/TCP 192.168.1.112:58885;received=218."..., len = 797} __FUNCTION__ = "receive_msg" #8 0x00000000005f65fc in receive_tcp_msg ( tcpbuf=0x7fa6acd7b360 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.2:5003;branch=z9hG4bKd59d.0efeaa2488813a7c1ff6cbb4fa19f351.1;i=6592;received=211.78.19.2;rport=22430\r\nVia: SIP/2.0/TCP 192.168.1.112:58885;received=218."..., len=797, rcv_info=0x7fa6acd7b088, con=0x7fa6acd7b070) at tcp_read.c:1247 buf = 0xc75d40 "SIP/2.0 180 Ringing\r\nVia: SIP/2.0/TCP 211.78.19.2:5003;branch=z9hG4bKd59d.0efeaa2488813a7c1ff6cbb4fa19f351.1;i=6592;received=211.78.19.2;rport=22430\r\nVia: SIP/2.0/TCP 192.168.1.112:58885;received=218."... bsize = 65535 blen = 65535 __FUNCTION__ = "receive_tcp_msg" #9 0x00000000005f7d9b in tcp_read_req (con=0x7fa6acd7b070, bytes_read=0x7fff6fed9b40, read_flags=0x7fff6fed9b38) at tcp_read.c:1401 bytes = 797 total_bytes = 797 resp = 1 size = 140735071230416 req = 0x7fa6acd7b0f0 dst = {send_sock = 0x14, to = {s = {sa_family = 1, sa_data = "\000\000P\000\000\000\001 \000\200\370\220", <incomplete sequence \356>}, sin = {sin_family = 1, sin_port = 0, sin_addr = { s_addr = 80}, sin_zero = "\001 \000\200\370\220", <incomplete sequence \356>}, sin6 = {sin6_family = 1, sin6_port = 0, sin6_flowinfo = 80, sin6_addr = {__in6_u = { __u6_addr8 = "\001 \000\200\370\220\060\356\247\177\000\000\000\000\000", __u6_addr16 = {8193, 32768, 37112, 60976, 32679, 0, 0, 0}, __u6_addr32 = {2147491841, 3996160248, 32679, 0}}}, sin6_scope_id = 1877842736}}, id = 32767, proto = 8 '\b', send_flags = {f = 0 '\000', blst_imask = 0 '\000'}} c = 0 '\000' ret = -1 __FUNCTION__ = "tcp_read_req" #10 0x00000000005fadab in handle_io (fm=0x7fa7ee3090f8, events=1, idx=-1) at tcp_read.c:1624 ret = 0 n = -1 read_flags = 1 con = 0x7fa6acd7b070 s = 11 resp = 1 t = 1530467254 __FUNCTION__ = "handle_io" #11 0x00000000005ee8c0 in io_wait_loop_epoll (h=0xa2dfe0, t=2, repeat=1) at io_wait.h:1061 n = 1 r = 0 fm = 0x7fa7ee3090f8 revents = 1 __FUNCTION__ = "io_wait_loop_epoll" #12 0x00000000005fbe1a in tcp_receive_loop (unix_sock=97) at tcp_read.c:1739 __FUNCTION__ = "tcp_receive_loop" #13 0x00000000005e54e1 in tcp_init_children () at tcp_main.c:4787 r = 15 i = 23 reader_fd_1 = 97 pid = 0 si_desc = "tcp receiver (generic)\000\000ygY\000\000\000\000\000Н\355o\377\177\000\000R\342B\000\000\000\000\000\260\235\355o\377\177\000\000\260\203\354-\250\177\000\000\220\323-\356\247\177\000\000\023\255\r\020\000\000\000\000\217sp\000\000\000\000\000\020\321\356\355\247\177\000\000(\000\000\000)\000\000\000U\032g.\375\067\002\000\t8\002\000\267̑`\023\255\r\020\000\000\000" si = 0x0 __FUNCTION__ = "tcp_init_children" #14 0x00000000004ab258 in main_loop () at main.c:1658 i = 24 pid = 145405 si = 0x0 si_desc = "udp receiver child=23 sock=211.78.19.2:5003\000n\000\000\000~/q\000\001\000\000\000\260\244ϫ\246\177\000\000\260\236\355o\377\177\000\000\032\264N\000\000\000\000\000\000\237\355o\377\177\000\000\260\300-\356\247\177\000\000\350\227\034\254\246\177\000\000\260\244ϫ\246\177\000\000\023\255\r\020\000\000\000\000\260\210A\000\001\000\000" nrprocs = 24 __FUNCTION__ = "main_loop" #15 0x00000000004b0b5b in main (argc=13, argv=0x7fff6feda178) at main.c:2533 cfg_stream = 0xbc9010 c = -1 r = 0 tmp = 0x7fff6fedad59 "" tmp_len = 32680 port = 780662640 proto = 0 options = 0x707db8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 503368684 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x76 p = 0x7fff6feda07e "" __FUNCTION__ = "main" ``` #### BT 3 it generates two core files 3 and 4 in 20 secs ``` ===syslog=== Sep 10 14:39:29 sip1 kernel: [41693172.748753] kamailio[245950] general protection ip:602d43 sp:7fff185e8500 error:0 in kamailio[400000+3cb000] Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245999]: CRITICAL: <core> [pass_fd.c:275]: receive_fd(): EOF on 39 Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245924]: ALERT: <core> [main.c:728]: handle_sigs(): child process 245950 exited by a signal 11 Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245924]: ALERT: <core> [main.c:731]: handle_sigs(): core was generated Sep 10 14:39:47 sip1 kernel: [41693191.570265] kamailio[245924] general protection ip:7f1f2ba23800 sp:7fff185e7ff0 error:0 in tm.so[7f1f2b9c8000+114000] ===backtrace=== #0 0x0000000000602d43 in slow_timer_main () at timer.c:1130 n = 12 ret = 4294967295 tl = 0x7f1f2cca64f0 i = 957 __FUNCTION__ = "slow_timer_main" #1 0x00000000004aacf9 in main_loop () at main.c:1628 i = 24 pid = 0 si = 0x0 si_desc = "udp receiver child=23 sock=211.78.19.1:5003\000n\000\000\000~/q\000\001\000\000\000\260D4,\037\177\000\000\060\206^\030\377\177\000\000\032\264N\000\000\000\000\000\200\206^\030\377\177\000\000\260`\222n \177\000\000\350\067\201,\037\177\000\000\260D4,\037\177\000\000\224\321\306[\000\000\000\000\260\210A\000\001\000\000" nrprocs = 24 __FUNCTION__ = "main_loop" #2 0x00000000004b0b5b in main (argc=13, argv=0x7fff185e88f8) at main.c:2533 cfg_stream = 0x27a6010 c = -1 r = 0 tmp = 0x7fff185e8f32 "" tmp_len = 32544 port = -1360226448 proto = 0 options = 0x707db8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 1739382561 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x76 p = 0x7fff185e87fe "" __FUNCTION__ = "main" ``` #### BT 4 it generates two core files 3 and 4 in 20 secs ``` ===syslog=== Sep 10 14:39:29 sip1 kernel: [41693172.748753] kamailio[245950] general protection ip:602d43 sp:7fff185e8500 error:0 in kamailio[400000+3cb000] Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245999]: CRITICAL: <core> [pass_fd.c:275]: receive_fd(): EOF on 39 Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245924]: ALERT: <core> [main.c:728]: handle_sigs(): child process 245950 exited by a signal 11 Sep 10 14:39:47 sip1 /home/pkg/kamailio/sbin/kamailio[245924]: ALERT: <core> [main.c:731]: handle_sigs(): core was generated Sep 10 14:39:47 sip1 kernel: [41693191.570265] kamailio[245924] general protection ip:7f1f2ba23800 sp:7fff185e7ff0 error:0 in tm.so[7f1f2b9c8000+114000] ===backtrace=== #0 0x00007f1f2ba23800 in run_trans_callbacks_internal (cb_lst=0x7f1f2c9ba700, type=131072, trans=0x7f1f2c9ba690, params=0x7fff185e80d0) at t_hooks.c:264 cbp = 0x3c223d65636e6174 backup_from = 0xa82430 backup_to = 0xa82438 backup_dom_from = 0xa82440 backup_dom_to = 0xa82448 backup_uri_from = 0xa82420 backup_uri_to = 0xa82428 backup_xavps = 0xa82560 __FUNCTION__ = "run_trans_callbacks_internal" #1 0x00007f1f2ba23c6f in run_trans_callbacks (type=131072, trans=0x7f1f2c9ba690, req=0x0, rpl=0x0, code=0) at t_hooks.c:295 params = {req = 0x0, rpl = 0x0, param = 0x0, code = 0, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, send_buf = {s = 0x0, len = 0}} #2 0x00007f1f2b9e2aa1 in free_cell (dead_cell=0x7f1f2c9ba690) at h_table.c:128 b = 0x621325 "\353\a\220\353\004\220\353\001\220H\201Đ" i = 0 rpl = 0x7fff185e8270 tt = 0x7fff185e8290 foo = 0x7f1f2c33c1c8 cbs = 0x621325 cbs_tmp = 0x7fff185e8280 __FUNCTION__ = "free_cell" #3 0x00007f1f2b9e4779 in free_hash_table () at h_table.c:432 p_cell = 0x7f1f2c9ba690 tmp_cell = 0x3a2772657375277b i = 53971 __FUNCTION__ = "free_hash_table" #4 0x00007f1f2ba09733 in tm_shutdown () at t_funcs.c:90 __FUNCTION__ = "tm_shutdown" #5 0x000000000059669b in destroy_modules () at sr_module.c:788 t = 0x7f206e524660 foo = 0x7f206e5241f8 __FUNCTION__ = "destroy_modules" #6 0x00000000004a011a in cleanup (show_status=1) at main.c:513 memlog = 32544 __FUNCTION__ = "cleanup" #7 0x00000000004a170e in shutdown_children (sig=15, show_status=1) at main.c:655 __FUNCTION__ = "shutdown_children" #8 0x00000000004a3c8d in handle_sigs () at main.c:746 chld = 0 chld_status = 139 memlog = 0 __FUNCTION__ = "handle_sigs" #9 0x00000000004abb64 in main_loop () at main.c:1701 i = 24 pid = 245999 si = 0x0 si_desc = "udp receiver child=23 sock=211.78.19.1:5003\000n\000\000\000~/q\000\001\000\000\000\260D4,\037\177\000\000\060\206^\030\377\177\000\000\032\264N\000\000\000\000\000\200\206^\030\377\177\000\000\260`\222n \177\000\000\350\067\201,\037\177\000\000\260D4,\037\177\000\000\224\321\306[\000\000\000\000\260\210A\000\001\000\000" nrprocs = 24 __FUNCTION__ = "main_loop" #10 0x00000000004b0b5b in main (argc=13, argv=0x7fff185e88f8) at main.c:2533 cfg_stream = 0x27a6010 c = -1 r = 0 tmp = 0x7fff185e8f32 "" tmp_len = 32544 port = -1360226448 proto = 0 options = 0x707db8 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 1739382561 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x76 p = 0x7fff185e87fe "" __FUNCTION__ = "main" ``` --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/322

2 13

git:4.3:192294cc: tm: warn in case of transaction is not suspended by a continue is attempted
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: 192294cc025f7b39efcd60c2053423ff10861d75 URL: https://github.com/kamailio/kamailio/commit/192294cc025f7b39efcd60c2053423f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T14:02:00+02:00 tm: warn in case of transaction is not suspended by a continue is attempted (cherry picked from commit 33c5449563becd2357b648ec469ef247a6ae2f5d) --- Modified: modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/192294cc025f7b39efcd60c2053423f… Patch: https://github.com/kamailio/kamailio/commit/192294cc025f7b39efcd60c2053423f… --- diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index 0658e39..34ddb38 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -178,7 +178,7 @@ int t_continue(unsigned int hash_index, unsigned int label, } if (!(t->flags & T_ASYNC_SUSPENDED)) { - LM_ERR("transaction is not suspended [%u:%u]\n", hash_index, label); + LM_WARN("transaction is not suspended [%u:%u]\n", hash_index, label); return -2; }

1 0

git:4.3:c58d4c44: tm: test if transaction was suspended before resuming inside t_continue()
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: c58d4c4471f794944c60164a19ae3aa884fe2ade URL: https://github.com/kamailio/kamailio/commit/c58d4c4471f794944c60164a19ae3aa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T13:59:28+02:00 tm: test if transaction was suspended before resuming inside t_continue() (cherry picked from commit 52c4965bbb4cde5d7bddcf697aa504e7c2202ac1) --- Modified: modules/tm/t_suspend.c --- Diff: https://github.com/kamailio/kamailio/commit/c58d4c4471f794944c60164a19ae3aa… Patch: https://github.com/kamailio/kamailio/commit/c58d4c4471f794944c60164a19ae3aa… --- diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index de18a2a..0658e39 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -106,10 +106,10 @@ int t_suspend(struct sip_msg *msg, * - failure route to be executed if the branch is not continued * before timeout */ t->uac[t->async_backup.blind_uac].on_failure = t->on_failure; + t->flags |= T_ASYNC_SUSPENDED; } else { LM_DBG("this is a suspend on reply - setting msg flag to SUSPEND\n"); msg->msg_flags |= FL_RPL_SUSPENDED; - t->flags |= T_ASYNC_SUSPENDED; /* this is a reply suspend find which branch */ if (t_check( msg , &branch )==-1){ @@ -131,6 +131,7 @@ int t_suspend(struct sip_msg *msg, LM_DBG("saving transaction data\n"); t->uac[branch].reply->flags = msg->flags; + t->flags |= T_ASYNC_SUSPENDED; } *hash_index = t->hash_index; @@ -176,7 +177,13 @@ int t_continue(unsigned int hash_index, unsigned int label, return -1; } + if (!(t->flags & T_ASYNC_SUSPENDED)) { + LM_ERR("transaction is not suspended [%u:%u]\n", hash_index, label); + return -2; + } + if (t->flags & T_CANCELED) { + t->flags &= ~T_ASYNC_SUSPENDED; /* The transaction has already been canceled, * needless to continue */ UNREF(t); /* t_unref would kill the transaction */ @@ -219,6 +226,7 @@ int t_continue(unsigned int hash_index, unsigned int label, /* Either t_continue() has already been * called or the branch has already timed out. * Needless to continue. */ + t->flags &= ~T_ASYNC_SUSPENDED; UNLOCK_ASYNC_CONTINUE(t); UNREF(t); /* t_unref would kill the transaction */ return 1; @@ -443,9 +451,14 @@ int t_continue(unsigned int hash_index, unsigned int label, sip_msg_free(t->uac[branch].reply); t->uac[branch].reply = 0; } + + /*This transaction is no longer suspended so unsetting the SUSPEND flag*/ + t->flags &= ~T_ASYNC_SUSPENDED; + return 0; kill_trans: + t->flags &= ~T_ASYNC_SUSPENDED; /* The script has hopefully set the error code. If not, * let us reply with a default error. */ if ((kill_transaction_unsafe(t,

1 0

git:4.3:0c6bed87: tm: reset async suspended flag when continuing via failure_route
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: 0c6bed8779024c0c35a9c1bb82dc24255d8f08e2 URL: https://github.com/kamailio/kamailio/commit/0c6bed8779024c0c35a9c1bb82dc242… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T13:58:09+02:00 tm: reset async suspended flag when continuing via failure_route - suspended transaction can be resumed automatically on timeout, without t_continue(), ending up in failure_route (cherry picked from commit 171553ebcac2f00a015191f36f2f228c0d3e483b) --- Modified: modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/0c6bed8779024c0c35a9c1bb82dc242… Patch: https://github.com/kamailio/kamailio/commit/0c6bed8779024c0c35a9c1bb82dc242… --- diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 8240ced..0041a4f 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -982,6 +982,8 @@ int run_failure_handlers(struct cell *t, struct sip_msg *rpl, * set next failure route, failure_route will not be reentered * on failure */ t->on_failure=0; + /* if continuing on timeout of a suspended transaction, reset the flag */ + t->flags &= ~T_ASYNC_SUSPENDED; if (exec_pre_script_cb(&faked_req, FAILURE_CB_TYPE)>0) { /* run a failure_route action if some was marked */ if (run_top_route(failure_rt.rlist[on_failure], &faked_req, 0)<0)

1 0

git:4.3:ce43a14d: tmx: err to work if resuming suspended transaction fails
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: ce43a14d701ec38276883b863cd81bbb3de3b35a URL: https://github.com/kamailio/kamailio/commit/ce43a14d701ec38276883b863cd81bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T13:53:07+02:00 tmx: err to work if resuming suspended transaction fails - it can be a non-suspended transaction id or after expiration (cherry picked from commit 2682d85657d1caf96961a6153cd82c506fde7d0d) --- Modified: modules/tmx/tmx_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ce43a14d701ec38276883b863cd81bb… Patch: https://github.com/kamailio/kamailio/commit/ce43a14d701ec38276883b863cd81bb… --- diff --git a/modules/tmx/tmx_mod.c b/modules/tmx/tmx_mod.c index 28dbcd7..d2d8e60 100644 --- a/modules/tmx/tmx_mod.c +++ b/modules/tmx/tmx_mod.c @@ -638,7 +638,7 @@ static int w_t_continue(struct sip_msg* msg, char *idx, char *lbl, char *rtn) if(_tmx_tmb.t_continue(tindex, tlabel, act)<0) { - LM_ERR("resuming the processing of transaction [%u:%u] failed\n", + LM_WARN("resuming the processing of transaction [%u:%u] failed\n", tindex, tlabel); return -1; }

1 0

git:4.3:978e3b65: auth_db: more log messages when username checks failed
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: 978e3b65c7d1d21a69a55492dc156493cc8c28bf URL: https://github.com/kamailio/kamailio/commit/978e3b65c7d1d21a69a55492dc15649… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T13:52:49+02:00 auth_db: more log messages when username checks failed (cherry picked from commit d46d008e0936a01229872df71ac26afb43122f4b) --- Modified: modules/auth_db/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/978e3b65c7d1d21a69a55492dc15649… Patch: https://github.com/kamailio/kamailio/commit/978e3b65c7d1d21a69a55492dc15649… --- diff --git a/modules/auth_db/authorize.c b/modules/auth_db/authorize.c index 6d582c2..86e1cb7 100644 --- a/modules/auth_db/authorize.c +++ b/modules/auth_db/authorize.c @@ -512,30 +512,40 @@ int auth_check(struct sip_msg* _m, char* _realm, char* _table, char *_flags) || _m->REQ_METHOD==METHOD_PRACK || _m->REQ_METHOD==METHOD_UPDATE || _m->REQ_METHOD==METHOD_MESSAGE))) { if(srealm.len!=uri->user.len - || strncmp(srealm.s, uri->user.s, srealm.len)!=0) + || strncmp(srealm.s, uri->user.s, srealm.len)!=0) { + LM_DBG("authentication username mismatch with from/to username\n"); return AUTH_USER_MISMATCH; + } } if(_m->REQ_METHOD==METHOD_REGISTER || _m->REQ_METHOD==METHOD_PUBLISH) { /* check from==to */ if(furi->user.len!=turi->user.len - || strncmp(furi->user.s, turi->user.s, furi->user.len)!=0) + || strncmp(furi->user.s, turi->user.s, furi->user.len)!=0) { + LM_DBG("from username mismatch with to username\n"); return AUTH_USER_MISMATCH; + } if(use_domain!=0 && (furi->host.len!=turi->host.len - || strncmp(furi->host.s, turi->host.s, furi->host.len)!=0)) + || strncmp(furi->host.s, turi->host.s, furi->host.len)!=0)) { + LM_DBG("from domain mismatch with to domain\n"); return AUTH_USER_MISMATCH; + } /* check r-uri==from for publish */ if(_m->REQ_METHOD==METHOD_PUBLISH) { if(parse_sip_msg_uri(_m)<0) return AUTH_ERROR; uri = &_m->parsed_uri; if(furi->user.len!=uri->user.len - || strncmp(furi->user.s, uri->user.s, furi->user.len)!=0) + || strncmp(furi->user.s, uri->user.s, furi->user.len)!=0) { + LM_DBG("from username mismatch with r-uri username\n"); return AUTH_USER_MISMATCH; + } if(use_domain!=0 && (furi->host.len!=uri->host.len - || strncmp(furi->host.s, uri->host.s, furi->host.len)!=0)) + || strncmp(furi->host.s, uri->host.s, furi->host.len)!=0)) { + LM_DBG("from domain mismatch with r-uri domain\n"); return AUTH_USER_MISMATCH; } + } } return AUTH_OK; }

1 0

git:4.3:c5b7b0ba: ipops: fixed wrong location of double quites in example in docs
by Daniel-Constantin Mierla 17 Sep '15

17 Sep '15

Module: kamailio Branch: 4.3 Commit: c5b7b0baab51c5d2ca584c1ff1366f8e03e97290 URL: https://github.com/kamailio/kamailio/commit/c5b7b0baab51c5d2ca584c1ff1366f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-09-17T13:52:24+02:00 ipops: fixed wrong location of double quites in example in docs - reported by GH#327 (cherry picked from commit 5d50171a4443eeafa5734afec58bbf41c07fece7) --- Modified: modules/ipops/README Modified: modules/ipops/doc/ipops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c5b7b0baab51c5d2ca584c1ff1366f8… Patch: https://github.com/kamailio/kamailio/commit/c5b7b0baab51c5d2ca584c1ff1366f8… --- diff --git a/modules/ipops/README b/modules/ipops/README index b213b03..bc48751 100644 --- a/modules/ipops/README +++ b/modules/ipops/README @@ -453,10 +453,10 @@ if (srv_query ("_sip._udp.example.com", "udp") > 0) { $var(cnt) = $srvquery(udp=>count); $var(i) = 0; while ($var(i) < $var(cnt)) { - xlog ("port[$var(i)] $srvquery(udp=>port[$var(i)])\n)"; - xlog ("priority[$var(i)] $srvquery(udp=>priority[$var(i)])\n)"; - xlog ("target[$var(i)] $srvquery(udp=>target[$var(i)])\n)"; - xlog ("weight[$var(i)] $srvquery(udp=>weight[$var(i)])\n)"; + xlog ("port[$var(i)] $srvquery(udp=>port[$var(i)])\n"); + xlog ("priority[$var(i)] $srvquery(udp=>priority[$var(i)])\n"); + xlog ("target[$var(i)] $srvquery(udp=>target[$var(i)])\n"); + xlog ("weight[$var(i)] $srvquery(udp=>weight[$var(i)])\n"); $var(i) = $var(i) + 1; } } diff --git a/modules/ipops/doc/ipops_admin.xml b/modules/ipops/doc/ipops_admin.xml index 90c4168..4d77b9e 100644 --- a/modules/ipops/doc/ipops_admin.xml +++ b/modules/ipops/doc/ipops_admin.xml @@ -752,10 +752,10 @@ if (srv_query ("_sip._udp.example.com", "udp") > 0) { $var(cnt) = $srvquery(udp=>count); $var(i) = 0; while ($var(i) < $var(cnt)) { - xlog ("port[$var(i)] $srvquery(udp=>port[$var(i)])\n)"; - xlog ("priority[$var(i)] $srvquery(udp=>priority[$var(i)])\n)"; - xlog ("target[$var(i)] $srvquery(udp=>target[$var(i)])\n)"; - xlog ("weight[$var(i)] $srvquery(udp=>weight[$var(i)])\n)"; + xlog ("port[$var(i)] $srvquery(udp=>port[$var(i)])\n"); + xlog ("priority[$var(i)] $srvquery(udp=>priority[$var(i)])\n"); + xlog ("target[$var(i)] $srvquery(udp=>target[$var(i)])\n"); + xlog ("weight[$var(i)] $srvquery(udp=>weight[$var(i)])\n"); $var(i) = $var(i) + 1; } }

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2015