sr-dev August 2015

sr-dev@lists.kamailio.org

30 participants
191 discussions

git:master:06e36989: core: keep info about aor being considered case sensitive or not

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 06e36989b2c5332b3ca377ec8098d8f2d953a5b6 URL: https://github.com/kamailio/kamailio/commit/06e36989b2c5332b3ca377ec8098d8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-08-26T13:56:59+02:00 core: keep info about aor being considered case sensitive or not --- Modified: dset.c Modified: dset.h --- Diff: https://github.com/kamailio/kamailio/commit/06e36989b2c5332b3ca377ec8098d8f… Patch: https://github.com/kamailio/kamailio/commit/06e36989b2c5332b3ca377ec8098d8f… --- diff --git a/dset.c b/dset.c index 46cc40d..314b2c5 100644 --- a/dset.c +++ b/dset.c @@ -893,3 +893,22 @@ int uri_restore_rcv_alias(str *uri, str *nuri, str *suri) return 0; } + +/* address of record (aor) management */ + +/* address of record considered case sensitive + * - 0 = no; 1 = yes */ +static int aor_case_sensitive=0; + +int set_aor_case_sensitive(int mode) +{ + int r; + r = aor_case_sensitive; + aor_case_sensitive = mode; + return r; +} + +int get_aor_case_sensitive(void) +{ + return aor_case_sensitive; +} diff --git a/dset.h b/dset.h index 752450f..603b202 100644 --- a/dset.h +++ b/dset.h @@ -258,4 +258,8 @@ int uri_restore_rcv_alias(str *uri, str *nuri, str *suri); int init_dst_set(void); +int set_aor_case_sensitive(int mode); + +int get_aor_case_sensitive(void); + #endif /* _DSET_H */

8 years, 8 months

git:master:821d1d9f: core: partial revert from 546e624a859 wrong clear or routename

by Victor Seva

Module: kamailio Branch: master Commit: 821d1d9f300a2d73d18a6dd95b8ad44a7d8794e8 URL: https://github.com/kamailio/kamailio/commit/821d1d9f300a2d73d18a6dd95b8ad44… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-08-26T13:50:37+02:00 core: partial revert from 546e624a859 wrong clear or routename --- Modified: cfg.lex --- Diff: https://github.com/kamailio/kamailio/commit/821d1d9f300a2d73d18a6dd95b8ad44… Patch: https://github.com/kamailio/kamailio/commit/821d1d9f300a2d73d18a6dd95b8ad44… --- diff --git a/cfg.lex b/cfg.lex index 147f597..ef8c881 100644 --- a/cfg.lex +++ b/cfg.lex @@ -605,23 +605,23 @@ IMPORTFILE "import_file" <INITIAL>{ISAVPFLAGSET} { count(); yylval.strval=yytext; return ISAVPFLAGSET; } <INITIAL>{AVPFLAGS_DECL} { count(); yylval.strval=yytext; return AVPFLAGS_DECL; } <INITIAL>{MSGLEN} { count(); yylval.strval=yytext; return MSGLEN; } -<INITIAL>{ROUTE} { count(); routename=NULL; default_routename="DEFAULT_ROUTE"; +<INITIAL>{ROUTE} { count(); default_routename="DEFAULT_ROUTE"; yylval.strval=yytext; return ROUTE; } -<INITIAL>{ROUTE_REQUEST} { count(); routename=NULL; default_routename="DEFAULT_ROUTE"; +<INITIAL>{ROUTE_REQUEST} { count(); default_routename="DEFAULT_ROUTE"; yylval.strval=yytext; return ROUTE_REQUEST; } -<INITIAL>{ROUTE_ONREPLY} { count(); routename=NULL; default_routename="DEFAULT_ONREPLY"; +<INITIAL>{ROUTE_ONREPLY} { count(); default_routename="DEFAULT_ONREPLY"; yylval.strval=yytext; return ROUTE_ONREPLY; } -<INITIAL>{ROUTE_REPLY} { count(); routename=NULL; default_routename="DEFAULT_ONREPLY"; +<INITIAL>{ROUTE_REPLY} { count(); default_routename="DEFAULT_ONREPLY"; yylval.strval=yytext; return ROUTE_REPLY; } -<INITIAL>{ROUTE_FAILURE} { count(); routename=NULL; default_routename="DEFAULT_FAILURE"; +<INITIAL>{ROUTE_FAILURE} { count(); default_routename="DEFAULT_FAILURE"; yylval.strval=yytext; return ROUTE_FAILURE; } -<INITIAL>{ROUTE_BRANCH} { count(); routename=NULL; default_routename="DEFAULT_BRANCH"; +<INITIAL>{ROUTE_BRANCH} { count(); default_routename="DEFAULT_BRANCH"; yylval.strval=yytext; return ROUTE_BRANCH; } -<INITIAL>{ROUTE_SEND} { count(); routename=NULL; default_routename="DEFAULT_SEND"; +<INITIAL>{ROUTE_SEND} { count(); default_routename="DEFAULT_SEND"; yylval.strval=yytext; return ROUTE_SEND; } -<INITIAL>{ROUTE_EVENT} { count(); routename=NULL; default_routename="DEFAULT_EVENT"; +<INITIAL>{ROUTE_EVENT} { count(); default_routename="DEFAULT_EVENT"; yylval.strval=yytext; state=EVRT_NAME_S; BEGIN(EVRTNAME); return ROUTE_EVENT; }

8 years, 8 months

git:4.1:9e03ac74: mi_datagram: free async handler when command completed

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.1 Commit: 9e03ac7410c879dc9e91dd21c04c0597ce1ccff3 URL: https://github.com/kamailio/kamailio/commit/9e03ac7410c879dc9e91dd21c04c059… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-08-26T13:22:48+02:00 mi_datagram: free async handler when command completed - reported by Torge Szczepanek, GH#298 (cherry picked from commit 374bfb1c467d6bf2a4cc143d22868c37143783bd) (cherry picked from commit d495aafb98d3560c36b681dae21b671ce8b23e86) (cherry picked from commit a4ca8feae11a8168ab600b2a648f85af1e792661) --- Modified: modules/mi_datagram/datagram_fnc.c --- Diff: https://github.com/kamailio/kamailio/commit/9e03ac7410c879dc9e91dd21c04c059… Patch: https://github.com/kamailio/kamailio/commit/9e03ac7410c879dc9e91dd21c04c059… --- diff --git a/modules/mi_datagram/datagram_fnc.c b/modules/mi_datagram/datagram_fnc.c index 66e821d..8ca0bbf 100644 --- a/modules/mi_datagram/datagram_fnc.c +++ b/modules/mi_datagram/datagram_fnc.c @@ -359,6 +359,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, } free_mi_tree(mi_rpl); pkg_free(dtgram.start); + if (done) free_async_handler( hdl ); } else if (done) { mi_send_dgram(reply_sock, MI_COMMAND_FAILED, MI_COMMAND_FAILED_LEN, (struct sockaddr*)&reply_addr, reply_addr_len, mi_socket_timeout); @@ -372,6 +373,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, if(dtgram.start) pkg_free(dtgram.start); close(reply_sock); + if (done) free_async_handler( hdl ); return; }

8 years, 8 months

git:4.2:a4ca8fea: mi_datagram: free async handler when command completed

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: a4ca8feae11a8168ab600b2a648f85af1e792661 URL: https://github.com/kamailio/kamailio/commit/a4ca8feae11a8168ab600b2a648f85a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-08-26T13:22:09+02:00 mi_datagram: free async handler when command completed - reported by Torge Szczepanek, GH#298 (cherry picked from commit 374bfb1c467d6bf2a4cc143d22868c37143783bd) (cherry picked from commit d495aafb98d3560c36b681dae21b671ce8b23e86) --- Modified: modules/mi_datagram/datagram_fnc.c --- Diff: https://github.com/kamailio/kamailio/commit/a4ca8feae11a8168ab600b2a648f85a… Patch: https://github.com/kamailio/kamailio/commit/a4ca8feae11a8168ab600b2a648f85a… --- diff --git a/modules/mi_datagram/datagram_fnc.c b/modules/mi_datagram/datagram_fnc.c index 8470ddb..eca74f3 100644 --- a/modules/mi_datagram/datagram_fnc.c +++ b/modules/mi_datagram/datagram_fnc.c @@ -359,6 +359,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, } free_mi_tree(mi_rpl); pkg_free(dtgram.start); + if (done) free_async_handler( hdl ); } else if (done) { mi_send_dgram(reply_sock, MI_COMMAND_FAILED, MI_COMMAND_FAILED_LEN, (struct sockaddr*)&reply_addr, reply_addr_len, mi_socket_timeout); @@ -372,6 +373,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, if(dtgram.start) pkg_free(dtgram.start); close(reply_sock); + if (done) free_async_handler( hdl ); return; }

8 years, 8 months

git:4.3:d495aafb: mi_datagram: free async handler when command completed

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: d495aafb98d3560c36b681dae21b671ce8b23e86 URL: https://github.com/kamailio/kamailio/commit/d495aafb98d3560c36b681dae21b671… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-08-26T13:21:21+02:00 mi_datagram: free async handler when command completed - reported by Torge Szczepanek, GH#298 (cherry picked from commit 374bfb1c467d6bf2a4cc143d22868c37143783bd) --- Modified: modules/mi_datagram/datagram_fnc.c --- Diff: https://github.com/kamailio/kamailio/commit/d495aafb98d3560c36b681dae21b671… Patch: https://github.com/kamailio/kamailio/commit/d495aafb98d3560c36b681dae21b671… --- diff --git a/modules/mi_datagram/datagram_fnc.c b/modules/mi_datagram/datagram_fnc.c index 0309b73..8e2ed71 100644 --- a/modules/mi_datagram/datagram_fnc.c +++ b/modules/mi_datagram/datagram_fnc.c @@ -359,6 +359,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, } free_mi_tree(mi_rpl); pkg_free(dtgram.start); + if (done) free_async_handler( hdl ); } else if (done) { mi_send_dgram(reply_sock, MI_COMMAND_FAILED, MI_COMMAND_FAILED_LEN, (struct sockaddr*)&reply_addr, reply_addr_len, mi_socket_timeout); @@ -372,6 +373,7 @@ static void datagram_close_async(struct mi_root *mi_rpl,struct mi_handler *hdl, if(dtgram.start) pkg_free(dtgram.start); close(reply_sock); + if (done) free_async_handler( hdl ); return; }

8 years, 8 months

[kamailio] Memory Leak in t_uac_dlg Mi function (#298)

by Torge Szczepanek

We are using the t_uac_dlg function through a UDP MI Datagram to create local SIP/TCP requests. We are seeing a memory leak of increasing shared Memory usage, which is increasing at the same rate as tcp connections are created (tested under 4.0.1 and 4.3.1). /usr/sbin/kamailio[25407]: NOTICE: fm_status: count= 71943 size= 14126536 bytes from mi_datagram: datagram_fnc.c: build_async_handler(387) After looking at the memory dump and investigating the source, I guess that the memory leak is created, when the MI_ASYNC_RPL_FLAG is set. This seems to be set by: modules/tmx/tmx_mod.c: {MI_TM_UAC, mi_tm_uac_dlg, MI_ASYNC_RPL_FLAG, 0, 0 }, only, which we are using heavily. Can someone please give me a hint, where to search for the memory leak. My guess is that: modules/mi_datagram/datagram_fnc.c:489 if (f->flags&MI_ASYNC_RPL_FLAG) { hdl = build_async_handler(mi_socket_domain, (struct sockaddr* )&reply_addr, reply_addr_len); the handler is not correctly freed up in the async reply case. Thank you! Greetings --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/298

8 years, 8 months

git:4.1:e1e3389c: modules/dialog: make dialog context available in event route tm:local-request

by Federico Cabiddu

Module: kamailio Branch: 4.1 Commit: e1e3389c946af67fd132c2121188a36a67328188 URL: https://github.com/kamailio/kamailio/commit/e1e3389c946af67fd132c2121188a36… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-08-26T13:00:37+02:00 modules/dialog: make dialog context available in event route tm:local-request (cherry picked from commit 5002f66a98b6104702c8c862e7335ff189e7b7d8) --- Modified: modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/e1e3389c946af67fd132c2121188a36… Patch: https://github.com/kamailio/kamailio/commit/e1e3389c946af67fd132c2121188a36… --- diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index 9ccdfe8..1991eee 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -1388,8 +1388,13 @@ void dlg_ontimeout(struct dlg_tl *tl) if(dlg->iflags&DLG_IFLAG_TIMEOUTBYE) { + /* set the dialog context so that it's available in + * tm:local-request event route */ + dlg_set_ctx_iuid(dlg); if(dlg_bye_all(dlg, NULL)<0) dlg_unref(dlg, 1); + dlg_reset_ctx_iuid(); + /* run event route for end of dlg */ dlg_run_event_route(dlg, NULL, dlg->state, DLG_STATE_DELETED); dlg_unref(dlg, 1);

8 years, 8 months

git:4.2:3fadd119: modules/dialog: make dialog context available in event route tm:local-request

by Federico Cabiddu

Module: kamailio Branch: 4.2 Commit: 3fadd1197e634f56b5a71fdf2cce507229213aba URL: https://github.com/kamailio/kamailio/commit/3fadd1197e634f56b5a71fdf2cce507… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-08-26T12:56:20+02:00 modules/dialog: make dialog context available in event route tm:local-request (cherry picked from commit 5002f66a98b6104702c8c862e7335ff189e7b7d8) --- Modified: modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/3fadd1197e634f56b5a71fdf2cce507… Patch: https://github.com/kamailio/kamailio/commit/3fadd1197e634f56b5a71fdf2cce507… --- diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index ac61fbb..5341fcc 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -1421,8 +1421,13 @@ void dlg_ontimeout(struct dlg_tl *tl) if(dlg->iflags&DLG_IFLAG_TIMEOUTBYE) { + /* set the dialog context so that it's available in + * tm:local-request event route */ + dlg_set_ctx_iuid(dlg); if(dlg_bye_all(dlg, NULL)<0) dlg_unref(dlg, 1); + dlg_reset_ctx_iuid(); + /* run event route for end of dlg */ dlg_run_event_route(dlg, NULL, dlg->state, DLG_STATE_DELETED);

8 years, 8 months

git:4.3:48b4261d: modules/dialog: make dialog context available in event route tm:local-request

by Federico Cabiddu

Module: kamailio Branch: 4.3 Commit: 48b4261dd6eb25e2898cac9412b13b46baacf79f URL: https://github.com/kamailio/kamailio/commit/48b4261dd6eb25e2898cac9412b13b4… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-08-26T12:51:52+02:00 modules/dialog: make dialog context available in event route tm:local-request (cherry picked from commit 5002f66a98b6104702c8c862e7335ff189e7b7d8) --- Modified: modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/48b4261dd6eb25e2898cac9412b13b4… Patch: https://github.com/kamailio/kamailio/commit/48b4261dd6eb25e2898cac9412b13b4… --- diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index aae6efb..248d985 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -1402,8 +1402,13 @@ void dlg_ontimeout(struct dlg_tl *tl) if(dlg->iflags&DLG_IFLAG_TIMEOUTBYE) { + /* set the dialog context so that it's available in + * tm:local-request event route */ + dlg_set_ctx_iuid(dlg); if(dlg_bye_all(dlg, NULL)<0) dlg_unref(dlg, 1); + dlg_reset_ctx_iuid(); + /* run event route for end of dlg */ dlg_run_event_route(dlg, NULL, dlg->state, DLG_STATE_DELETED);

8 years, 8 months

auth_ephemeral do_auth() function

by Juha Heinanen

auth_ephemeral do_auth() function has this code: ret = eph_auth_api.check_response(&cred->digest, _method, ha1); if (ret == AUTHENTICATED) { if (eph_auth_api.post_auth(_m, _h) != AUTHENTICATED) { return AUTH_ERROR; } } else if (ret == NOT_AUTHENTICATED) { return AUTH_INVALID_PASSWORD; } else { ret = AUTH_ERROR; } return AUTH_OK; i was wondering if there is a typo in 'ret = AUTH_ERROR'; statement. should it be 'return AUTH_ERROR;' instead? -- juha

8 years, 8 months

← Newer
1
...
6
7
8
9
10
11
12
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2015