sr-dev July 2015

sr-dev@lists.kamailio.org

26 participants
301 discussions

by Daniel-Constantin Mierla

Hello, I am considering to release the first patch version in 4.3 series by beginning of next week (Monday or Tuesday, July 20 or 21). If you are aware of issues not reported yet, then open an item on the tracker to be taken care: - https://github.com/kamailio/kamailio/issues Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com

9 years, 5 months

git:master:de840ed3: pkg/kamailio/deb: add sid support

by Victor Seva

Module: kamailio Branch: master Commit: de840ed3f6d41fe63bc0e27465241824edf6f377 URL: https://github.com/kamailio/kamailio/commit/de840ed3f6d41fe63bc0e2746524182… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-07-18T11:53:27+02:00 pkg/kamailio/deb: add sid support --- Added: pkg/kamailio/deb/debian/backports/sid Added: pkg/kamailio/deb/sid/changelog Added: pkg/kamailio/deb/sid/compat Added: pkg/kamailio/deb/sid/control Added: pkg/kamailio/deb/sid/copyright Added: pkg/kamailio/deb/sid/kamailio-autheph-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-berkeley-bin.dirs Added: pkg/kamailio/deb/sid/kamailio-dnssec-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-outbound-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-tls-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio-websocket-modules.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio.README.Debian Added: pkg/kamailio/deb/sid/kamailio.default Added: pkg/kamailio/deb/sid/kamailio.examples Added: pkg/kamailio/deb/sid/kamailio.init Added: pkg/kamailio/deb/sid/kamailio.lintian-overrides Added: pkg/kamailio/deb/sid/kamailio.postinst Added: pkg/kamailio/deb/sid/rules Added: pkg/kamailio/deb/sid/source.lintian-overrides Added: pkg/kamailio/deb/sid/source/format Added: pkg/kamailio/deb/sid/watch --- Diff: https://github.com/kamailio/kamailio/commit/de840ed3f6d41fe63bc0e2746524182… Patch: https://github.com/kamailio/kamailio/commit/de840ed3f6d41fe63bc0e2746524182…

9 years, 5 months

[kamailio] Run event_route[dialog:end] on dialog terminated by dlg.end_dlg (#190)

by Andrey Utkin

We want it for CDR fields setting. Currently CDR is written or such forcefully terminated calls, but it lacks some post-processing which we have in event_route[dialog:end]. Whoever is going to work on this - please leave your wallet info (e.g. paypal) for my thanksgiving. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/190

9 years, 5 months

[kamailio] http_query causes memory corruption with AVPs (#212)

by scottgrim

I have found an instance where using an avp or xavp as the response variable for http_query will cause a segfault later in t_relay(). When I change the variable to a $var instead of an avp, there is no segfault. I can only recreate it with a specific URL. If I try to reproduce it by simply sending a plain text response from a static page, it does not segfault. The http_query command is as follows: http_query("http://cnam.dashcs.com/?companyId=XXXXX&password=XXXXXXX&number=$avp(from_p…", "$avp(cnam)"); version: kamailio 4.3.0 (x86_64/linux) c6aa95 flags: STATS: Off, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c6aa95 compiled on 13:39:06 Jun 10 2015 with gcc 4.8.2 --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/212

9 years, 5 months

some potential utils/http_query() issues

by Daniel-Constantin Mierla

Hello, while investigating https://github.com/kamailio/kamailio/issues/212, I noticed some potential issues in http_query() from utils module. Not being the developer and not using this function myself that much so far, I wanted to get others reviewing my remarks. 1) at line 168 in the modules/utils/functions.c, download_size is get via CURL option and it is used in the following lines as size of stream.buf, which is allocated with pkg, but set to have the size stream.curr_size. For me it doesn't look safe to use download_size as limit to walk through stream.buf 2) same for setting the value of PV, when CRLF is not found download_size is used 3) in write_function(), it seems that for successive calls of the function one extra byte is added to the size. It is intended for keeping ending '\0', but should be enough only once. Could be harmless (few extra bytes allocated, when not really needed), but is important to know that actual value is up to stream.pos+1 (to include the '\0'), not to stream.curr_size. Are those above valid, or did I miss something? Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com

9 years, 5 months

Debian Packaging & KamCMD

by Carsten Bock

Hi, i've noticed, that the current Debian-Packaging uses the current directory as RUN_DIR for tools like kamcmd. Due to this, i get the following error when running kamcmd (from the Debian-Packages): ~# kamcmd ERROR: connect_unix_sock: connect(/home/carsten/build/ims/sip-router/debian/kamailio/var/run/kamailio//kamailio_ctl): No such file or directory [2] The default should be "/var/run/kamailio/kamailio_ctl", not "/home/carsten/build/..." where i build the package.... Is there a proper way, to set the RUN_DIR correctly, when building packages? I've noticed, it's the same for Debian Packages from the official repository.... Thanks, Carsten -- Carsten Bock CEO (Geschäftsführer) ng-voice GmbH Schomburgstr. 80 D-22767 Hamburg / Germany http://www.ng-voice.com mailto:carsten@ng-voice.com Office +49 40 5247593-0 Fax +49 40 5247593-99 Sitz der Gesellschaft: Hamburg Registergericht: Amtsgericht Hamburg, HRB 120189 Geschäftsführer: Carsten Bock Ust-ID: DE279344284 Hier finden Sie unsere handelsrechtlichen Pflichtangaben: http://www.ng-voice.com/imprint/

9 years, 5 months

git:4.1:bd85c1d1: core: fix matching network addresses with bitmask non divisible to 8

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.1 Commit: bd85c1d19fc0e1c2d706282b954a2baa1665d34f URL: https://github.com/kamailio/kamailio/commit/bd85c1d19fc0e1c2d706282b954a2ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-17T12:37:50+02:00 core: fix matching network addresses with bitmask non divisible to 8 - reported by Kyle Kurz <kkurz(a)digium.com> for permissions module (cherry picked from commit f429e753dfa750a604bfb0acb5068b47d0fbe142) (cherry picked from commit 05ac2a2b88f476b0fd32b1bf314b2357eedfceb0) (cherry picked from commit f06fc524de25e09549f7fbb57a0f08fb2765267e) --- Modified: ip_addr.c --- Diff: https://github.com/kamailio/kamailio/commit/bd85c1d19fc0e1c2d706282b954a2ba… Patch: https://github.com/kamailio/kamailio/commit/bd85c1d19fc0e1c2d706282b954a2ba… --- diff --git a/ip_addr.c b/ip_addr.c index 7175bd0..bde491d 100644 --- a/ip_addr.c +++ b/ip_addr.c @@ -356,7 +356,8 @@ char* get_proto_name(unsigned int proto) int ip_addr_match_net(ip_addr_t *iaddr, ip_addr_t *naddr, int mask) { - unsigned char c; + unsigned char ci; + unsigned char cn; int i; int mbytes; int mbits; @@ -399,8 +400,9 @@ int ip_addr_match_net(ip_addr_t *iaddr, ip_addr_t *naddr, mbits = mask % 8; if(mbits==0) return 0; - c = naddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); - if((iaddr->u.addr[i] & c) == c) + ci = iaddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); + cn = naddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); + if(ci == cn) return 0; return -1; }

9 years, 5 months

git:4.2:f06fc524: core: fix matching network addresses with bitmask non divisible to 8

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.2 Commit: f06fc524de25e09549f7fbb57a0f08fb2765267e URL: https://github.com/kamailio/kamailio/commit/f06fc524de25e09549f7fbb57a0f08f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-17T12:36:57+02:00 core: fix matching network addresses with bitmask non divisible to 8 - reported by Kyle Kurz <kkurz(a)digium.com> for permissions module (cherry picked from commit f429e753dfa750a604bfb0acb5068b47d0fbe142) (cherry picked from commit 05ac2a2b88f476b0fd32b1bf314b2357eedfceb0) --- Modified: ip_addr.c --- Diff: https://github.com/kamailio/kamailio/commit/f06fc524de25e09549f7fbb57a0f08f… Patch: https://github.com/kamailio/kamailio/commit/f06fc524de25e09549f7fbb57a0f08f… --- diff --git a/ip_addr.c b/ip_addr.c index 458eaa0..d88d5fd 100644 --- a/ip_addr.c +++ b/ip_addr.c @@ -356,7 +356,8 @@ char* get_proto_name(unsigned int proto) int ip_addr_match_net(ip_addr_t *iaddr, ip_addr_t *naddr, int mask) { - unsigned char c; + unsigned char ci; + unsigned char cn; int i; int mbytes; int mbits; @@ -399,8 +400,9 @@ int ip_addr_match_net(ip_addr_t *iaddr, ip_addr_t *naddr, mbits = mask % 8; if(mbits==0) return 0; - c = naddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); - if((iaddr->u.addr[i] & c) == c) + ci = iaddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); + cn = naddr->u.addr[i] & (~((1 << (8 - mbits)) - 1)); + if(ci == cn) return 0; return -1; }

9 years, 5 months

git:4.3:02ba3dd9: permissions: safety check for trusted hash table

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: 02ba3dd9fbb41fb3f03fa230672c72acedc39f0d URL: https://github.com/kamailio/kamailio/commit/02ba3dd9fbb41fb3f03fa230672c72a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-17T12:30:59+02:00 permissions: safety check for trusted hash table - avoid crash if a db reload is issued in db-only mode - reported Emmanuel Schmidbauer, GH #228 (cherry picked from commit f2958e5861a96e40f0aca05d5d5bd7fa14c2089e) --- Modified: modules/permissions/trusted.c --- Diff: https://github.com/kamailio/kamailio/commit/02ba3dd9fbb41fb3f03fa230672c72a… Patch: https://github.com/kamailio/kamailio/commit/02ba3dd9fbb41fb3f03fa230672c72a… --- diff --git a/modules/permissions/trusted.c b/modules/permissions/trusted.c index db20e8f..f42c096 100644 --- a/modules/permissions/trusted.c +++ b/modules/permissions/trusted.c @@ -43,9 +43,9 @@ #define TABLE_VERSION 5 -struct trusted_list ***hash_table; /* Pointer to current hash table pointer */ -struct trusted_list **hash_table_1; /* Pointer to hash table 1 */ -struct trusted_list **hash_table_2; /* Pointer to hash table 2 */ +struct trusted_list ***hash_table = 0; /* Pointer to current hash table pointer */ +struct trusted_list **hash_table_1 = 0; /* Pointer to hash table 1 */ +struct trusted_list **hash_table_2 = 0; /* Pointer to hash table 2 */ static db1_con_t* db_handle = 0; @@ -69,16 +69,21 @@ int reload_trusted_table(void) char *pattern, *tag; - cols[0] = &source_col; - cols[1] = &proto_col; - cols[2] = &from_col; - cols[3] = &tag_col; + if (hash_table == 0) { + LM_ERR("in-memory hash table not initialized\n"); + return -1; + } if (db_handle == 0) { LM_ERR("no connection to database\n"); return -1; } + cols[0] = &source_col; + cols[1] = &proto_col; + cols[2] = &from_col; + cols[3] = &tag_col; + if (perm_dbf.use_table(db_handle, &trusted_table) < 0) { LM_ERR("failed to use trusted table\n"); return -1;

9 years, 5 months

git:4.3:ff31270f: Update pipelimit_admin.xml

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: ff31270f9419d275bcf532f666075903b0b26a08 URL: https://github.com/kamailio/kamailio/commit/ff31270f9419d275bcf532f66607590… Author: Fred Posner <fred(a)palner.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-17T12:30:48+02:00 Update pipelimit_admin.xml - added information about algorithms - corrected rl typos - corrected example (wrong algorithm) - added note about algorithms being case sensitive - added example using pipelimit for specific method (INVITE) (cherry picked from commit b0f465bc6e402ba77923216affc2020ad25e97c0) --- Modified: modules/pipelimit/doc/pipelimit_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ff31270f9419d275bcf532f66607590… Patch: https://github.com/kamailio/kamailio/commit/ff31270f9419d275bcf532f66607590…

9 years, 5 months

← Newer
1
...
14
15
16
17
18
19
20
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2015