November 2015 - sr-dev - kamailio.org

[kamailio] dialog's keepalives keep sending to old address after re-INVITE with updated location (#273)
by Andrey Utkin 10 Dec '15

10 Dec '15

Hi, we use pretty recent kamailio: ``` version: kamailio 4.4.0-dev2 (x86_64/linux) 1a758d flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 1a758d compiled on 14:49:47 Jul 20 2015 with gcc 4.8.2 ``` The case: consider the mobile SIP agent which switches between networks (e.g. wifi -> mobile) during the call. It sends re-INVITE with its new location. We use keep-alives provided by dialog module. And it seems that keep-alives don't use new address and are always sent to initial address. Any thoughts? Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/273

5 11

[kamailio] app_python: Missing documentation (#249)
by Olle E. Johansson 03 Dec '15

03 Dec '15

The App_python README has too many sections with just "TBD" as documentation. Needs to be fixed. http://kamailio.org/docs/modules/4.3.x/modules/app_python.html --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/249

3 4

git:master:cc94a375: modules/ims_charging: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: cc94a3751dd536053846d7a569e8062d8cfbea7f URL: https://github.com/kamailio/kamailio/commit/cc94a3751dd536053846d7a569e8062… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T21:09:04+02:00 modules/ims_charging: correct analysis of return value for t_suspend --- Modified: modules/ims_charging/mod.c --- Diff: https://github.com/kamailio/kamailio/commit/cc94a3751dd536053846d7a569e8062… Patch: https://github.com/kamailio/kamailio/commit/cc94a3751dd536053846d7a569e8062… --- diff --git a/modules/ims_charging/mod.c b/modules/ims_charging/mod.c index d2f371d..9dae820 100644 --- a/modules/ims_charging/mod.c +++ b/modules/ims_charging/mod.c @@ -499,7 +499,7 @@ static int w_ro_ccr(struct sip_msg *msg, char* c_route_name, char* c_direction, } LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &tindex, &tlabel) < 0) { + if (tmb.t_suspend(msg, &tindex, &tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); ret = RO_RETURN_ERROR; goto done;

1 0

git:master:64491668: modules/ims_qos: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: 64491668d61b14c213e3fc0a0b55cfcf6c036e39 URL: https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfc… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T21:07:37+02:00 modules/ims_qos: correct analysis of return value for t_suspend --- Modified: modules/ims_qos/mod.c Modified: modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfc… Patch: https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfc… --- diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c index cb64390..6a84131 100644 --- a/modules/ims_qos/mod.c +++ b/modules/ims_qos/mod.c @@ -1055,7 +1055,7 @@ static int w_rx_aar_register(struct sip_msg *msg, char* route, char* str1, char* } LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_transaction_global_data(saved_t_data); return CSCF_RETURN_ERROR; diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c index ff75a0d..da1dc69 100644 --- a/modules/ims_registrar_scscf/save.c +++ b/modules/ims_registrar_scscf/save.c @@ -1128,7 +1128,7 @@ int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction, char* ro create_return_code(CSCF_RETURN_ERROR); LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(_m, &saved_t->tindex, &saved_t->tlabel) < 0) { + if (tmb.t_suspend(_m, &saved_t->tindex, &saved_t->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_transaction_data(saved_t); rerrno = R_SAR_FAILED; @@ -1357,7 +1357,7 @@ int save(struct sip_msg* msg, char* str1, char *route) { create_return_code(CSCF_RETURN_ERROR); LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_transaction_data(saved_t); rerrno = R_SAR_FAILED;

1 0

git:master:58e5709a: modules/ims_usrloc_pcscf: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: 58e5709a491dbe90c4fc97e484438090dfea1616 URL: https://github.com/kamailio/kamailio/commit/58e5709a491dbe90c4fc97e48443809… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T21:06:39+02:00 modules/ims_usrloc_pcscf: correct analysis of return value for t_suspend --- Modified: modules/ims_usrloc_pcscf/udomain.h --- Diff: https://github.com/kamailio/kamailio/commit/58e5709a491dbe90c4fc97e48443809… Patch: https://github.com/kamailio/kamailio/commit/58e5709a491dbe90c4fc97e48443809… --- diff --git a/modules/ims_usrloc_pcscf/udomain.h b/modules/ims_usrloc_pcscf/udomain.h index 26bf1c7..f7643e2 100644 --- a/modules/ims_usrloc_pcscf/udomain.h +++ b/modules/ims_usrloc_pcscf/udomain.h @@ -77,7 +77,6 @@ int update_rx_regsession(struct udomain* _d, str* session_id, struct pcontact* _ int update_pcontact(struct udomain* _d, struct pcontact_info* _ci, struct pcontact* _c); int insert_pcontact(struct udomain* _d, str* _contact, struct pcontact_info* _ci, struct pcontact** _r); int get_pcontact(udomain_t* _d, pcontact_info_t* contact_info, struct pcontact** _r); -int get_pcontact_by_src(udomain_t* _d, str * _host, unsigned short _port, unsigned short _proto, struct pcontact** _c); int assert_identity(udomain_t* _d, str * _host, unsigned short _port, unsigned short _proto, str * _identity); int delete_pcontact(udomain_t* _d, struct pcontact* _r); int update_security(udomain_t* _d, security_type _t, security_t* _s, struct pcontact* _c);

1 0

git:master:44c5a4b7: modules/ims_qos: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: 44c5a4b744f5b6e248103df267405796b1b49834 URL: https://github.com/kamailio/kamailio/commit/44c5a4b744f5b6e248103df26740579… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T21:05:42+02:00 modules/ims_qos: correct analysis of return value for t_suspend --- Modified: modules/ims_qos/mod.c --- Diff: https://github.com/kamailio/kamailio/commit/44c5a4b744f5b6e248103df26740579… Patch: https://github.com/kamailio/kamailio/commit/44c5a4b744f5b6e248103df26740579… --- diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c index c5cb363..cb64390 100644 --- a/modules/ims_qos/mod.c +++ b/modules/ims_qos/mod.c @@ -892,7 +892,7 @@ static int w_rx_aar(struct sip_msg *msg, char *route, char* dir, char *c_id, int } LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); if (auth_session) cdpb.AAASessionsUnlock(auth_session->hash); goto error;

1 0

git:master:02b97a72: modules/ims_icscf: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: 02b97a728cee7c3184314cbf37e2d9c4f7bcf9c2 URL: https://github.com/kamailio/kamailio/commit/02b97a728cee7c3184314cbf37e2d9c… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T21:05:03+02:00 modules/ims_icscf: correct analysis of return value for t_suspend --- Modified: modules/ims_icscf/location.c Modified: modules/ims_icscf/registration.c --- Diff: https://github.com/kamailio/kamailio/commit/02b97a728cee7c3184314cbf37e2d9c… Patch: https://github.com/kamailio/kamailio/commit/02b97a728cee7c3184314cbf37e2d9c… --- diff --git a/modules/ims_icscf/location.c b/modules/ims_icscf/location.c index 5b1f80b..022803a 100644 --- a/modules/ims_icscf/location.c +++ b/modules/ims_icscf/location.c @@ -143,7 +143,7 @@ int I_perform_location_information_request(struct sip_msg* msg, char* route, cha create_lia_return_code(CSCF_RETURN_ERROR); LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_lir_transaction_data(saved_t); diff --git a/modules/ims_icscf/registration.c b/modules/ims_icscf/registration.c index b9d1df5..902b77f 100644 --- a/modules/ims_icscf/registration.c +++ b/modules/ims_icscf/registration.c @@ -201,7 +201,7 @@ int I_perform_user_authorization_request(struct sip_msg* msg, char* route, char* create_uaa_return_code(CSCF_RETURN_ERROR); LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_uar_transaction_data(saved_t);

1 0

git:master:acc79d89: modules/ims_auth: correct analysis of return value for t_suspend
by jaybeepee 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: acc79d89660433c5f8827efb16f224709571f342 URL: https://github.com/kamailio/kamailio/commit/acc79d89660433c5f8827efb16f2247… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-30T20:59:26+02:00 modules/ims_auth: correct analysis of return value for t_suspend --- Modified: modules/ims_auth/authorize.c --- Diff: https://github.com/kamailio/kamailio/commit/acc79d89660433c5f8827efb16f2247… Patch: https://github.com/kamailio/kamailio/commit/acc79d89660433c5f8827efb16f2247… --- diff --git a/modules/ims_auth/authorize.c b/modules/ims_auth/authorize.c index 001412c..ae83436 100644 --- a/modules/ims_auth/authorize.c +++ b/modules/ims_auth/authorize.c @@ -465,10 +465,9 @@ int challenge(struct sip_msg* msg, char* str1, char* alg, int is_proxy_auth, cha saved_t->is_proxy_auth = is_proxy_auth; LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) < 0) { + if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_transaction_data(saved_t); - stateful_request_reply(msg, 480, MSG_480_DIAMETER_ERROR); return CSCF_RETURN_BREAK; } @@ -856,6 +855,10 @@ int authenticate(struct sip_msg* msg, char* _realm, char* str2, int is_proxy_aut /* if QOP is sent, nc must be specified */ /* the expected nc is the last used one plus 1 */ int p; + if (!nc.s || nc.len < 8 ) { + LM_ERR("qop specified with no nonce count... failing\n"); + goto cleanup; + } for (p = 0; p < 8; ++p) { /* nc is 8LHEX (RFC 2617 §3.2.2) */ nc_parsed = (nc_parsed << 4) | UNHEX((int) nc.s[p]); } @@ -870,7 +873,7 @@ int authenticate(struct sip_msg* msg, char* _realm, char* str2, int is_proxy_aut av->status = AUTH_VECTOR_USELESS; goto cleanup; } - } + } switch (av->type) { case AUTH_AKAV1_MD5:

1 0

git:master:e112a2ea: ims_charging: Added the possibility to omit the rating-group (also for STOP-Requests)
by Carsten Bock 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: e112a2ea4bbc8c53e813442e606fb6fb79b1d3b8 URL: https://github.com/kamailio/kamailio/commit/e112a2ea4bbc8c53e813442e606fb6f… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-11-30T13:22:07+01:00 ims_charging: Added the possibility to omit the rating-group (also for STOP-Requests) --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/e112a2ea4bbc8c53e813442e606fb6f… Patch: https://github.com/kamailio/kamailio/commit/e112a2ea4bbc8c53e813442e606fb6f… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index aac2af3..adb536d 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -211,8 +211,11 @@ inline int Ro_add_multiple_service_credit_Control_stop(AAAMessage *msg, int used set_4bytes(x, active_service_identifier); Ro_add_avp_list(&mscc_list, x, 4, AVP_Service_Identifier, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); - set_4bytes(x, active_rating_group); - Ro_add_avp_list(&mscc_list, x, 4, AVP_Rating_Group, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); + // Rating Group = -1 => omit Rating group + if (active_rating_group >= 0) { + set_4bytes(x, active_rating_group); + Ro_add_avp_list(&mscc_list, x, 4, AVP_Rating_Group, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); + } used_group = cdpb.AAAGroupAVPS(mscc_list); cdpb.AAAFreeAVPList(&mscc_list);

1 0

git:master:8855f0fb: ims_charging: Added the possibility to omit the rating-group
by Carsten Bock 30 Nov '15

30 Nov '15

Module: kamailio Branch: master Commit: 8855f0fbe28b94e5298176310d7cbf587bd264da URL: https://github.com/kamailio/kamailio/commit/8855f0fbe28b94e5298176310d7cbf5… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: 2015-11-30T13:14:05+01:00 ims_charging: Added the possibility to omit the rating-group --- Modified: modules/ims_charging/ims_ro.c --- Diff: https://github.com/kamailio/kamailio/commit/8855f0fbe28b94e5298176310d7cbf5… Patch: https://github.com/kamailio/kamailio/commit/8855f0fbe28b94e5298176310d7cbf5… --- diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index f736311..aac2af3 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -246,8 +246,11 @@ inline int Ro_add_multiple_service_credit_Control(AAAMessage *msg, unsigned int set_4bytes(x, active_service_identifier); Ro_add_avp_list(&mscc_list, x, 4, AVP_Service_Identifier, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); - set_4bytes(x, active_rating_group); - Ro_add_avp_list(&mscc_list, x, 4, AVP_Rating_Group, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); + // Rating Group = -1 => omit Rating group + if (active_rating_group >= 0) { + set_4bytes(x, active_rating_group); + Ro_add_avp_list(&mscc_list, x, 4, AVP_Rating_Group, AAA_AVP_FLAG_MANDATORY, 0, AVP_DUPLICATE_DATA, __FUNCTION__); + } /* if we must Used-Service-Unit */ if (used_unit >= 0) {

1 0