sr-dev November 2015

sr-dev@lists.kamailio.org

27 participants
316 discussions

git:master:d73d56b4: modules/ims_charging: removed unused impu_data parcel (memory leak)
by jaybeepee 10 Nov '15

10 Nov '15

Module: kamailio Branch: master Commit: d73d56b41028341c46a331dfb74f5805248aae56 URL: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-10T10:36:16+02:00 modules/ims_charging: removed unused impu_data parcel (memory leak) --- Modified: modules/ims_charging/mod.c Modified: modules/ims_charging/ro_session_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… Patch: https://github.com/kamailio/kamailio/commit/d73d56b41028341c46a331dfb74f580… --- diff --git a/modules/ims_charging/mod.c b/modules/ims_charging/mod.c index 48f050b..d2f371d 100644 --- a/modules/ims_charging/mod.c +++ b/modules/ims_charging/mod.c @@ -378,10 +378,7 @@ static int w_ro_ccr(struct sip_msg *msg, char* c_route_name, char* c_direction, tm_cell_t *t; unsigned int tindex = 0, tlabel = 0; - struct impu_data *impu_data; - char *p; struct dlg_cell* dlg; - unsigned int len; struct ro_session *ro_session = 0; int free_contact = 0; @@ -457,34 +454,6 @@ static int w_ro_ccr(struct sip_msg *msg, char* c_route_name, char* c_direction, } LM_DBG("IMPU data to pass to usrloc: contact <%.*s> identity <%.*s>\n", contact.len, contact.s, identity.len, identity.s); - - //create impu_data_parcel - len = identity.len + contact.len + sizeof (struct impu_data); - impu_data = (struct impu_data*) shm_malloc(len); - if (!impu_data) { - LM_ERR("Unable to allocate memory for impu_data, trying to send CCR\n"); - ret = RO_RETURN_ERROR; - goto done; - } - memset(impu_data, 0, len); - - p = (char*) (impu_data + 1); - impu_data->identity.s = p; - impu_data->identity.len = identity.len; - memcpy(p, identity.s, identity.len); - p += identity.len; - - impu_data->contact.s = p; - impu_data->contact.len = contact.len; - memcpy(p, contact.s, contact.len); - p += contact.len; - - if (p != (((char*) impu_data) + len)) { - LM_ERR("buffer overflow creating impu data, trying to send CCR\n"); - shm_free(impu_data); - ret = RO_RETURN_ERROR; - goto done; - } send_ccr: diff --git a/modules/ims_charging/ro_session_hash.h b/modules/ims_charging/ro_session_hash.h index dcd79e5..7257721 100644 --- a/modules/ims_charging/ro_session_hash.h +++ b/modules/ims_charging/ro_session_hash.h @@ -173,12 +173,6 @@ static inline void unlink_unsafe_ro_session(struct ro_session_entry *ro_session_ int init_ro_session_table(unsigned int size); /*! - * \brief Destroy a ro_session and free memory - * \param ro_session destroyed Ro Session - */ -inline void destroy_ro_session(struct ro_session *ro_session); - -/*! * \brief Destroy the ro_session dialog table */ void destroy_ro_session_table(void);

1 0

git:master:2aa7683d: nathelper: added examples in docs for few functions
by Daniel-Constantin Mierla 09 Nov '15

09 Nov '15

Module: kamailio Branch: master Commit: 2aa7683dfebedc4ef9c3fdd50fb7abd2a2d718db URL: https://github.com/kamailio/kamailio/commit/2aa7683dfebedc4ef9c3fdd50fb7abd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-09T21:06:05+01:00 nathelper: added examples in docs for few functions --- Modified: modules/nathelper/README Modified: modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/2aa7683dfebedc4ef9c3fdd50fb7abd… Patch: https://github.com/kamailio/kamailio/commit/2aa7683dfebedc4ef9c3fdd50fb7abd…

1 0

git:master:21ea68e6: pkg/kamailio/deb: [systemd] remove lintian warning
by Victor Seva 09 Nov '15

09 Nov '15

Module: kamailio Branch: master Commit: 21ea68e6260f614b89c0b282e14d6ca089c1f2e9 URL: https://github.com/kamailio/kamailio/commit/21ea68e6260f614b89c0b282e14d6ca… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-11-09T11:41:44+01:00 pkg/kamailio/deb: [systemd] remove lintian warning https://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-tar… --- Modified: pkg/kamailio/deb/debian/kamailio.service --- Diff: https://github.com/kamailio/kamailio/commit/21ea68e6260f614b89c0b282e14d6ca… Patch: https://github.com/kamailio/kamailio/commit/21ea68e6260f614b89c0b282e14d6ca… --- diff --git a/pkg/kamailio/deb/debian/kamailio.service b/pkg/kamailio/deb/debian/kamailio.service index f049b39..06c3334 100644 --- a/pkg/kamailio/deb/debian/kamailio.service +++ b/pkg/kamailio/deb/debian/kamailio.service @@ -1,6 +1,6 @@ [Unit] Description=Kamailio (OpenSER) - the Open Source SIP Server -After=syslog.target network.target +After=network.target [Service] Type=forking

1 0

git:4.3:b5d19f21: Makefile.defs: removed option -minline-all-stringops for compiler on mips
by Daniel-Constantin Mierla 09 Nov '15

09 Nov '15

Module: kamailio Branch: 4.3 Commit: b5d19f21718b94fb522db5b414d43e7fdb038ebf URL: https://github.com/kamailio/kamailio/commit/b5d19f21718b94fb522db5b414d43e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-09T09:37:41+01:00 Makefile.defs: removed option -minline-all-stringops for compiler on mips - not supported, reported by Victor Seva, FS#392 (cherry picked from commit 2718efddb8e87a269af012d8661d57887e7c4d86) --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/b5d19f21718b94fb522db5b414d43e7… Patch: https://github.com/kamailio/kamailio/commit/b5d19f21718b94fb522db5b414d43e7… --- diff --git a/Makefile.defs b/Makefile.defs index f7bbc16..0b809a9 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1272,13 +1272,15 @@ ifeq ($(CC_NAME), gcc) CFLAGS=$(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-march=r3000 -minline-all-stringops \ + CFLAGS+=-march=r3000 \ -ftree-vectorize -fno-strict-overflow + # not supported on mips: -minline-all-stringops else #if gcc 4.0+ ifeq ($(CC_SHORTVER), 4.x) - CFLAGS+=-march=r3000 -minline-all-stringops \ + CFLAGS+=-march=r3000 \ -ftree-vectorize + # not supported on mips: -minline-all-stringops else #if gcc 3.4+ ifeq ($(CC_SHORTVER), 3.4)

1 0

[kamailio] FTBFS on mips: gcc: error: unrecognized command line (#392)
by Victor Seva 09 Nov '15

09 Nov '15

>From Debian BTS https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804422 Source: kamailio Version: 4.3.3-1 Severity: serious Your package failed to build on mips: ``` gcc -funroll-loops -march=r3000 -minline-all-stringops -ftree-vectorize -fno-strict-overflow -Wall -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"4.3.3"' -DARCH='"mips"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 5.2.1"' -D__CPU_mips -D__OS_linux -DSER_VER=4003003 -DCFG_DIR='"/etc/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DWITH_XAVP -DDBG_QM_MALLOC -DMEM_JOIN_FREE -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DWITH_AS_SUPPORT -DUSE_SCTP -DMIPS_HAS_LLSC -DNOSMP -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DUSE_RAW_SOCKS -DUSE_PTHREAD_MUTEX -DHAVE_EPOLL -DHAVE_S IGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -c ppcfg.c -o ppcfg.o -MMD -MP gcc: error: unrecognized command line option '-minline-all-stringops' ``` Full logs at: https://buildd.debian.org/status/logs.php?pkg=kamailio&ver=4.3.3-1&arch=mips --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/392

2 2

git:master:2718efdd: Makefile.defs: removed option -minline-all-stringops for compiler on mips
by Daniel-Constantin Mierla 09 Nov '15

09 Nov '15

Module: kamailio Branch: master Commit: 2718efddb8e87a269af012d8661d57887e7c4d86 URL: https://github.com/kamailio/kamailio/commit/2718efddb8e87a269af012d8661d578… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-09T09:36:12+01:00 Makefile.defs: removed option -minline-all-stringops for compiler on mips - not supported, reported by Victor Seva, FS#392 --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/2718efddb8e87a269af012d8661d578… Patch: https://github.com/kamailio/kamailio/commit/2718efddb8e87a269af012d8661d578… --- diff --git a/Makefile.defs b/Makefile.defs index ba2ae19..9fa586f 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1263,13 +1263,15 @@ ifeq ($(CC_NAME), gcc) CFLAGS=$(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-march=r3000 -minline-all-stringops \ + CFLAGS+=-march=r3000 \ -ftree-vectorize -fno-strict-overflow + # not supported on mips: -minline-all-stringops else #if gcc 4.0+ ifeq ($(CC_SHORTVER), 4.x) - CFLAGS+=-march=r3000 -minline-all-stringops \ + CFLAGS+=-march=r3000 \ -ftree-vectorize + # not supported on mips: -minline-all-stringops else #if gcc 3.4+ ifeq ($(CC_SHORTVER), 3.4)

1 0

[kamailio] tls: Incompatible with the new openssl (wants an sslv3 object, which is no longer there) (#391)
by Victor Seva 09 Nov '15

09 Nov '15

>From Debian BTS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804276 > Package: kamailio-tls-modules > Version: 4.3.3-1+b1 > Severity: important > Tags: security > > Today's upgrade installs openssl 1.0.2 compiled w/o any ssl3 support > and kamailio compiled against it, but the latter fails when run with: > > [FAIL] Not starting Kamailio SIP Server: invalid configuration file! ... failed! > failed! > [....] 0(20886) ERROR: <core> [sr_module.c:576]: load_module(): could not open module </usr/lib/x86_64-linux-gnu/kamailio/modules/tls.so>: /usr/lib/x86_64-linux-gnu/kamailio/modules/tls.so: undefined symbol: SSLv3_client_method 0(20886) : <core> [cfg.y:3432]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 73, column 12-19: failed to load module 0(20886) ERROR: <core> [modparam.c:150]: set_mod_param_regex(): No module matching <tls> found 0(20886) : <core> [cfg.y:3435]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 148, column 50: Can't set module parameter 0(20886) ERROR: <core> [modparam.c:150]: set_mod_param_regex(): No module matching <tls> found 0(20886) : <core> [cfg.y:3435]: yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 149, column 45: Can't set module parameter 0(20886) ERROR: <core> [modparam.c:150]: set_mod_param_regex(): No module matching <tls> found 0(20886) : <core> [cfg.y:3435] : yyerro r_ > at(): parse error in config file /etc/kamailio/kamailio.cfg, line 150, column 35: Can't set module parameter ERROR: bad config file (4 errors) 0(20886) > > As such and kama install with needs tls cannot run. > > (All of the errors there are because the tls modules cannot load because of the load-time link failure.) > > It will need a patch removing things like SSLv3_client_method. > > It is unfortunate that this didn't result in a compile time failure but only in a dynamic-link-time failure... --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/391

2 3

git:4.3:946e996f: tls: check for support of SSLv3 method
by Daniel-Constantin Mierla 09 Nov '15

09 Nov '15

Module: kamailio Branch: 4.3 Commit: 946e996fed4bed9a62703cdd248777e2c7ab4a89 URL: https://github.com/kamailio/kamailio/commit/946e996fed4bed9a62703cdd248777e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-09T09:24:54+01:00 tls: check for support of SSLv3 method - some versions of libssl removed support for SSLv3 - reported by Victore Seva, FS#391 (cherry picked from commit b1c6c2af7e96c0bcbdee4ff46f6faf19fdc75d9f) --- Modified: modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/946e996fed4bed9a62703cdd248777e… Patch: https://github.com/kamailio/kamailio/commit/946e996fed4bed9a62703cdd248777e… --- diff --git a/modules/tls/tls_init.c b/modules/tls/tls_init.c index bd14647..d7f3cef 100644 --- a/modules/tls/tls_init.c +++ b/modules/tls/tls_init.c @@ -344,9 +344,11 @@ static void init_ssl_methods(void) ssl_methods[TLS_USE_SSLv2 - 1] = SSLv2_method(); #endif +#ifndef OPENSSL_NO_SSL3_METHOD ssl_methods[TLS_USE_SSLv3_cli - 1] = SSLv3_client_method(); ssl_methods[TLS_USE_SSLv3_srv - 1] = SSLv3_server_method(); ssl_methods[TLS_USE_SSLv3 - 1] = SSLv3_method(); +#endif ssl_methods[TLS_USE_TLSv1_cli - 1] = TLSv1_client_method(); ssl_methods[TLS_USE_TLSv1_srv - 1] = TLSv1_server_method();

1 0

git:master:b1c6c2af: tls: check for support of SSLv3 method
by Daniel-Constantin Mierla 09 Nov '15

09 Nov '15

Module: kamailio Branch: master Commit: b1c6c2af7e96c0bcbdee4ff46f6faf19fdc75d9f URL: https://github.com/kamailio/kamailio/commit/b1c6c2af7e96c0bcbdee4ff46f6faf1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-11-09T09:23:44+01:00 tls: check for support of SSLv3 method - some versions of libssl removed support for SSLv3 - reported by Victore Seva, FS#391 --- Modified: modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/b1c6c2af7e96c0bcbdee4ff46f6faf1… Patch: https://github.com/kamailio/kamailio/commit/b1c6c2af7e96c0bcbdee4ff46f6faf1… --- diff --git a/modules/tls/tls_init.c b/modules/tls/tls_init.c index bd14647..d7f3cef 100644 --- a/modules/tls/tls_init.c +++ b/modules/tls/tls_init.c @@ -344,9 +344,11 @@ static void init_ssl_methods(void) ssl_methods[TLS_USE_SSLv2 - 1] = SSLv2_method(); #endif +#ifndef OPENSSL_NO_SSL3_METHOD ssl_methods[TLS_USE_SSLv3_cli - 1] = SSLv3_client_method(); ssl_methods[TLS_USE_SSLv3_srv - 1] = SSLv3_server_method(); ssl_methods[TLS_USE_SSLv3 - 1] = SSLv3_method(); +#endif ssl_methods[TLS_USE_TLSv1_cli - 1] = TLSv1_client_method(); ssl_methods[TLS_USE_TLSv1_srv - 1] = TLSv1_server_method();

1 0

git:master:9e07c7e1: modules/ims_qos: remove CDP auth session on failure to suspend
by jaybeepee 08 Nov '15

08 Nov '15

Module: kamailio Branch: master Commit: 9e07c7e1b6cf55398c7595d5265c4944e10c7862 URL: https://github.com/kamailio/kamailio/commit/9e07c7e1b6cf55398c7595d5265c494… Author: jaybeepee <jason.penton(a)gmail.com> Committer: jaybeepee <jason.penton(a)gmail.com> Date: 2015-11-08T18:15:11+02:00 modules/ims_qos: remove CDP auth session on failure to suspend --- Modified: modules/ims_qos/mod.c --- Diff: https://github.com/kamailio/kamailio/commit/9e07c7e1b6cf55398c7595d5265c494… Patch: https://github.com/kamailio/kamailio/commit/9e07c7e1b6cf55398c7595d5265c494… --- diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c index fc9be1a..c5cb363 100644 --- a/modules/ims_qos/mod.c +++ b/modules/ims_qos/mod.c @@ -915,6 +915,10 @@ static int w_rx_aar(struct sip_msg *msg, char *route, char* dir, char *c_id, int error: LM_ERR("Error trying to send AAR (calling)\n"); + if (auth_session != NULL) { + cdpb.AAASessionsUnlock(auth_session->hash); + cdpb.AAADropAuthSession(auth_session); + } ignore: if (saved_t_data) free_saved_transaction_global_data(saved_t_data); //only free global data if no AARs were sent. if one was sent we have to rely on the callback (CDP) to free

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2015