sr-dev October 2015

sr-dev@lists.kamailio.org

28 participants
236 discussions

git:master:f8397fe8: Makefile.groups: added log_custom to list of extra modules

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f8397fe8b70cbaee573d713929e1486807bcbd84 URL: https://github.com/kamailio/kamailio/commit/f8397fe8b70cbaee573d713929e1486… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-23T13:19:25+02:00 Makefile.groups: added log_custom to list of extra modules --- Modified: Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/f8397fe8b70cbaee573d713929e1486… Patch: https://github.com/kamailio/kamailio/commit/f8397fe8b70cbaee573d713929e1486… --- diff --git a/Makefile.groups b/Makefile.groups index 880753d..c5f5300 100644 --- a/Makefile.groups +++ b/Makefile.groups @@ -20,7 +20,8 @@ mod_list_basic=async auth benchmark blst cfg_rpc cfgutils corex counters \ # - extra used modules, with no extra dependency mod_list_extra=avp auth_diameter call_control dmq domainpolicy msrp pdb \ qos sca seas sms sst timer tmrec uac_redirect xhttp \ - xhttp_rpc xprint jsonrpc-s nosip dmq_usrloc statsd rtjson + xhttp_rpc xprint jsonrpc-s nosip dmq_usrloc statsd rtjson \ + log_custom # - common modules depending on database mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \

8 years, 6 months

[kamailio] acc_radius : adding radius time mode (#375)

by Yasin

Hello; with adding microseconds to Event-Time-Stamp , it will be more specific time. radiusclient library doesnt support double so i had to convert from double to char variable. in addition , after changing radius time mode to 1 , Event-Time-Stamp attribute needs to be switched integer/date to string in dictionary.kamailio and also radius server dictionary. if you accept this request , i will add more information to radius docs. Thanks. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/375 -- Commit Summary -- * acc_radius : adding radius time mode -- File Changes -- M modules/acc_radius/acc_radius_mod.c (23) -- Patch Links -- https://github.com/kamailio/kamailio/pull/375.patch https://github.com/kamailio/kamailio/pull/375.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/375

8 years, 6 months

git:master:56cd7a0d: db_postgres: don't free pg query structure in store result function

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 56cd7a0d38c8bbee6cc3e981b7a2b78b6d47257d URL: https://github.com/kamailio/kamailio/commit/56cd7a0d38c8bbee6cc3e981b7a2b78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-22T23:08:44+02:00 db_postgres: don't free pg query structure in store result function - it is done when freeing the result --- Modified: modules/db_postgres/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/56cd7a0d38c8bbee6cc3e981b7a2b78… Patch: https://github.com/kamailio/kamailio/commit/56cd7a0d38c8bbee6cc3e981b7a2b78… --- diff --git a/modules/db_postgres/km_dbase.c b/modules/db_postgres/km_dbase.c index 50ffd7f..816a512 100644 --- a/modules/db_postgres/km_dbase.c +++ b/modules/db_postgres/km_dbase.c @@ -602,7 +602,6 @@ int db_postgres_store_result(const db1_con_t* _con, db1_res_t** _r) } done: - db_postgres_free_query(_con); return (rc); }

8 years, 6 months

Kamailio start up fails with strange IO Error on RHEL 7.1

by M S

Hi, I have been trying to setup Kamailio v4.3.3 rev. e275bc on RHEL 7.1 64bit. It has been very difficult to resolve all dependencies initially due to RHEL's extremely limited repositories and libraries support, but nevertheless I am finally able to successfully compile kamailio with all essential modules on it. However, now kamailio fails to start up and gives this strange error, -- 36(3335) CRITICAL: <core> [io_wait.c:526]: init_io_wait(): could not alloc epoll array 36(3335) CRITICAL: <core> [tcp_main.c:4523]: tcp_main_loop(): exiting... 0(3250) ALERT: <core> [main.c:725]: handle_sigs(): child process 3335 exited normally, status=255 0(3250) INFO: <core> [main.c:743]: handle_sigs(): terminating due to SIGCHLD -- I have never seem this error before nor i can find any info related to it anywhere on internet. So, i doubt it is due to any missing dependency. Any idea what may be the cause of this? Thank you.

8 years, 6 months

git:master:9251a6f3: curl Update TODO and add a note for improvement in the way we handle reading from the server.

by Olle E. Johansson

Module: kamailio Branch: master Commit: 9251a6f386c27017c71e3cd468b20df16a65329d URL: https://github.com/kamailio/kamailio/commit/9251a6f386c27017c71e3cd468b20df… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-21T14:46:04+02:00 curl Update TODO and add a note for improvement in the way we handle reading from the server. We may want to just drop data instead of allocating memory for it. It is not a good situation to swallow anything. --- Modified: modules/curl/TODO.txt Modified: modules/curl/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/9251a6f386c27017c71e3cd468b20df… Patch: https://github.com/kamailio/kamailio/commit/9251a6f386c27017c71e3cd468b20df… --- diff --git a/modules/curl/TODO.txt b/modules/curl/TODO.txt index 77ab3cc..0a728fd 100644 --- a/modules/curl/TODO.txt +++ b/modules/curl/TODO.txt @@ -3,18 +3,22 @@ The curl module - todo - connection parameters timeout=x - DONE - read=line/all + read=line/all - Implemented in API, but not in parameter tlsverify=on/off failover=curlcon Other curlcon that can be used for failover in case of 5xx response or timeout httpredirect - DONE useragent - DONE + - Make sure modparams work httpproxy - Not working with curl tls cert, key, ca - Not working with curl yet httpredirect - done timeout - done + maxdatasize - done +- Add XAVP parameter setting before running curl_connect + - save fingerprint of cert for trust-on-first-use procedure - status for curlcon-object, needs to be object in process memory, so child_init @@ -22,6 +26,8 @@ The curl module - todo - function in dialplan - curlcon_exist(object) - pv $curlstatus(object) ?? +- Figure out a way to communicate back the content-type of the response. Another pvar arg? + - pv for curl error codes (result < 100) $curlerror(code) Result string - DONE diff --git a/modules/curl/functions.c b/modules/curl/functions.c index 17b85a9..4c9961e 100644 --- a/modules/curl/functions.c +++ b/modules/curl/functions.c @@ -60,6 +60,10 @@ static int curL_query_url(struct sip_msg* _m, char* _url, char* _dst, const char */ size_t write_function( void *ptr, size_t size, size_t nmemb, void *stream_ptr) { + /* A question here is if we can somehow signal maxdatasize and stop filling + buffers at maxdatasize - we don't need any more. Or just ignore and stop + allocating pkg memory at that point. A good todo. + */ http_res_stream_t *stream = (http_res_stream_t *) stream_ptr; stream->buf = (char *) pkg_realloc(stream->buf, stream->curr_size +

8 years, 6 months

git:master:87af5531: curl Another stab at setting the maxdatasize

by Olle E. Johansson

Module: kamailio Branch: master Commit: 87af55318541bfe5705eb35f4d5693bedd6f2243 URL: https://github.com/kamailio/kamailio/commit/87af55318541bfe5705eb35f4d5693b… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-21T14:34:34+02:00 curl Another stab at setting the maxdatasize --- Modified: modules/curl/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/87af55318541bfe5705eb35f4d5693b… Patch: https://github.com/kamailio/kamailio/commit/87af55318541bfe5705eb35f4d5693b…

8 years, 6 months

Implementation of RFC 5393

by Guillaume

Hi guys, What do you think about the RFC 5393 on loop detection and amplification attack protection? The RFC is short and still a proposed standard but don't you think it could be useful to prevent loop and amplification attack? Because even if the max-forward field reduces the loop to ~70 hosts (in most cases) with some techniques we could fork the message up to 2^70 messages (as described in the RFC) to crash the servers. Basically the server has to do 2 things: * check if it is not already in the via of the message * the previous check is not enough as a B2BUA could have replaced the via headers, so the RFC introduces a new field called max-breadth to limit the forking. I have not seen a lot of implementation of this RFC on the free SIP software and I think it could be a good way to improve kamailio making a module for it (the easier way to implement this feature I think). In fact I'm in a research internship about VoIP security and I have time to develop such a module for kamailio if you think it's a good idea (I'm looking for some security improvements in free software solutions so if you have other idea don't hesitate to tell me). Cheers, Tetram

8 years, 6 months

git:master:3133918b: log_systemd: added support to replace core syslog with logging to systemd

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3133918bcd903c4ae173df40f78fe6d07ef05ae8 URL: https://github.com/kamailio/kamailio/commit/3133918bcd903c4ae173df40f78fe6d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-21T10:16:02+02:00 log_systemd: added support to replace core syslog with logging to systemd --- Modified: modules/log_systemd/README Modified: modules/log_systemd/doc/log_systemd_admin.xml Modified: modules/log_systemd/log_systemd_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/3133918bcd903c4ae173df40f78fe6d… Patch: https://github.com/kamailio/kamailio/commit/3133918bcd903c4ae173df40f78fe6d…

8 years, 6 months

git:master:ad93a206: curl Actually send POST data

by Olle E. Johansson

Module: kamailio Branch: master Commit: ad93a2064861d8a8c56cf28d1c42b8250b0b9f05 URL: https://github.com/kamailio/kamailio/commit/ad93a2064861d8a8c56cf28d1c42b82… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-21T10:39:13+02:00 curl Actually send POST data --- Modified: modules/curl/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/ad93a2064861d8a8c56cf28d1c42b82… Patch: https://github.com/kamailio/kamailio/commit/ad93a2064861d8a8c56cf28d1c42b82… --- diff --git a/modules/curl/functions.c b/modules/curl/functions.c index 31034fe..7ad96dd 100644 --- a/modules/curl/functions.c +++ b/modules/curl/functions.c @@ -131,6 +131,8 @@ static int curL_query_url(struct sip_msg* _m, char* _url, char* _dst, const char headerlist = curl_slist_append(headerlist, ctype); res |= curl_easy_setopt(curl, CURLOPT_HTTPHEADER, headerlist); + /* Tell CURL we want to upload using POST */ + res |= curl_easy_setopt(curl, CURLOPT_POSTFIELDS, _post); } @@ -246,8 +248,10 @@ int curl_con_query_url(struct sip_msg* _m, char *connection, char* _url, char* _ char connurlbuf[BUFSIZ/2]; char urlbuf[512]; unsigned int len = 0; - str postdata; + str postdatabuf; + char *postdata = NULL; long maxdatasize = default_maxdatasize; + int res; memset(usernamebuf,0,sizeof(usernamebuf)); memset(passwordbuf,0,sizeof(passwordbuf)); @@ -277,20 +281,28 @@ int curl_con_query_url(struct sip_msg* _m, char *connection, char* _url, char* _ LM_DBG("***** #### ***** CURL URL: %s \n", urlbuf); if (_post && *_post) { LM_DBG("***** #### ***** CURL POST data: %s \n", _post); - if(pv_printf_s(_m, (pv_elem_t*)_post, &postdata) != 0) { + if(pv_printf_s(_m, (pv_elem_t*)_post, &postdatabuf) != 0) { LM_ERR("curl :: unable to handle post data %s\n", _post); return -1; } - if(postdata.s==NULL || postdata.len == 0) { + if(postdatabuf.s==NULL || postdatabuf.len == 0) { LM_ERR("curl :: invalid post data parameter\n"); return -1; } - LM_DBG("***** #### ***** CURL POST data: %s Content-type %s\n", postdata.s, contenttype); + /* Allocated using pkg_memory */ + postdata = as_asciiz(&postdatabuf); + LM_DBG("***** #### ***** CURL POST data: %s Content-type %s\n", postdata, contenttype); + } /* TODO: Concatenate URL in connection with URL given in function */ - return curL_query_url(_m, urlbuf, _result, usernamebuf, passwordbuf, (contenttype ? contenttype : "text/plain"), _post, + res = curL_query_url(_m, urlbuf, _result, usernamebuf, passwordbuf, (contenttype ? contenttype : "text/plain"), postdata, conn->timeout, conn->http_follow_redirect, 0, (unsigned int) maxdatasize ); + + if (postdata != NULL) { + pkg_free(postdata); + } + return res; }

8 years, 6 months

[kamailio] kamailio 4.3.1: segfault when using tls and cli params (#374)

by Rick

When using -u or -g cli params ``` root@sip:~ # kamailio -u kamailio -g kamailio loading modules under config path: /usr/local/lib/kamailio/modules/ Listening on udp: x.x.x.x:5060 udp: 127.0.0.1:5060 tcp: x.x.x.x:5060 tcp: 127.0.0.1:5060 Aliases: tcp: localhost.my.domain:5060 tcp: localhost:5060 udp: localhost.my.domain:5060 udp: localhost:5060 ``` ``` root@sip:~ # kamailio -u kamailio -g kamailio loading modules under config path: /usr/local/lib/kamailio/modules/ ERROR: bad config file (2 errors) Segmentation fault (core dumped) ``` ``` (gdb) bt #0 0x0000000805cb3200 in ?? () #1 0x000000000078fb0d in destroy_tls () #2 0x0000000000512fd1 in cleanup () #3 0x000000000051a91a in handle_sigs () #4 0x0000000000532441 in main () (gdb) ``` --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/374

8 years, 6 months

← Newer
1
...
6
7
8
9
10
11
12
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2015