sr-dev October 2015

sr-dev@lists.kamailio.org

28 participants
236 discussions

git:4:39d1b8f8: dialog: keep slot locked when searching for duplicate dialog

by Daniel-Constantin Mierla

Module: kamailio Branch: 4 Commit: 39d1b8f8eeddef1d796855e8d7ef63569987fb65 URL: https://github.com/kamailio/kamailio/commit/39d1b8f8eeddef1d796855e8d7ef635… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T16:32:28+02:00 dialog: keep slot locked when searching for duplicate dialog - when attempting to create a new dialog, the function searching to see if it is already one with same attributes keeps the slot locked so is no race in between the return of function and building the new dlg structure - if the dlg is found, release the lock after figuring out it is a spiral or not (cherry picked from commit 9d807d1d8af24c0163d3bb2ae876a87a8b637494) --- Modified: modules/dialog/dlg_handlers.c Modified: modules/dialog/dlg_hash.c Modified: modules/dialog/dlg_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/39d1b8f8eeddef1d796855e8d7ef635… Patch: https://github.com/kamailio/kamailio/commit/39d1b8f8eeddef1d796855e8d7ef635…

8 years, 7 months

git:master:6620fe7b: dialog: don't update dlg vars in db if in deleted state

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6620fe7b0963ffe0e2c0d4ab7a38e85d1dfd121d URL: https://github.com/kamailio/kamailio/commit/6620fe7b0963ffe0e2c0d4ab7a38e85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T16:51:59+02:00 dialog: don't update dlg vars in db if in deleted state - dlg record and vars are scheduled for deletion --- Modified: modules/dialog/dlg_db_handler.c --- Diff: https://github.com/kamailio/kamailio/commit/6620fe7b0963ffe0e2c0d4ab7a38e85… Patch: https://github.com/kamailio/kamailio/commit/6620fe7b0963ffe0e2c0d4ab7a38e85… --- diff --git a/modules/dialog/dlg_db_handler.c b/modules/dialog/dlg_db_handler.c index da4b091..e3b66df 100644 --- a/modules/dialog/dlg_db_handler.c +++ b/modules/dialog/dlg_db_handler.c @@ -712,8 +712,8 @@ int update_dialog_dbinfo_unsafe(struct dlg_cell * cell) &sflags_column, /*18*/ &toroute_name_column, /*19*/ &req_uri_column, /*20*/ &xdata_column, /*21*/ &iflags_column /*22*/ }; - if(cell->state<DLG_STATE_EARLY) { - LM_DBG("not storing dlg in db during initial state\n"); + if(cell->state<DLG_STATE_EARLY || cell->state==DLG_STATE_DELETED) { + LM_DBG("not storing dlg in db during initial or deleted states\n"); return 0; }

8 years, 7 months

git:master:098849c7: dialog: updated old comment to reflect current behaviour

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 098849c72a8b651a5757eac3eb3dee6772766d76 URL: https://github.com/kamailio/kamailio/commit/098849c72a8b651a5757eac3eb3dee6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T16:34:59+02:00 dialog: updated old comment to reflect current behaviour --- Modified: modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/098849c72a8b651a5757eac3eb3dee6… Patch: https://github.com/kamailio/kamailio/commit/098849c72a8b651a5757eac3eb3dee6… --- diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index d20a215..99235ee 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -720,7 +720,7 @@ dlg_cell_t* dlg_get_by_iuid(dlg_iuid_t *diuid) * \param ftag from tag * \param ttag to tag * \param dir direction - * \param mode let hash table slot locked if dialog is not found + * \param mode let hash table slot locked or not * \return dialog structure on success, NULL on failure */ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry,

8 years, 7 months

git:master:04bd28ff: dialog: release remote profile lock on remove operation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 04bd28fffdfed05dda9a8fff41b220a3bb008a17 URL: https://github.com/kamailio/kamailio/commit/04bd28fffdfed05dda9a8fff41b220a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T16:31:07+02:00 dialog: release remote profile lock on remove operation --- Modified: modules/dialog/dlg_profile.c --- Diff: https://github.com/kamailio/kamailio/commit/04bd28fffdfed05dda9a8fff41b220a… Patch: https://github.com/kamailio/kamailio/commit/04bd28fffdfed05dda9a8fff41b220a… --- diff --git a/modules/dialog/dlg_profile.c b/modules/dialog/dlg_profile.c index 39dc1df..9a47082 100644 --- a/modules/dialog/dlg_profile.c +++ b/modules/dialog/dlg_profile.c @@ -394,6 +394,7 @@ int remove_profile(dlg_profile_table_t *profile, str *value, str *puid) lh->next = lh->prev = NULL; if(lh->linker) shm_free(lh->linker); p_entry->content--; + lock_release(&profile->lock ); return 1; } lh = lh->next;

8 years, 7 months

git:master:b198b390: dialog: completed previous commit for spiral handling

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b198b390106924df2279d94f28305c25c86b435e URL: https://github.com/kamailio/kamailio/commit/b198b390106924df2279d94f28305c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T16:08:13+02:00 dialog: completed previous commit for spiral handling --- Modified: modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/b198b390106924df2279d94f28305c2… Patch: https://github.com/kamailio/kamailio/commit/b198b390106924df2279d94f28305c2… --- diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index 3117e33..123330b 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -796,8 +796,10 @@ int dlg_new_dialog(sip_msg_t *req, struct cell *t, const int run_initial_cbs) dlg = dlg_search(&callid, &ftag, &ttag, &dir); if(dlg) { if (detect_spirals) { - if (spiral_detected == 1) + if (spiral_detected == 1) { + dlg_hash_release(&callid); return 0; + } if ( dlg->state != DLG_STATE_DELETED ) { LM_DBG("Callid '%.*s' found, must be a spiraled request\n",

8 years, 7 months

git:master:9d807d1d: dialog: keep slot locked when searching for duplicate dialog

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9d807d1d8af24c0163d3bb2ae876a87a8b637494 URL: https://github.com/kamailio/kamailio/commit/9d807d1d8af24c0163d3bb2ae876a87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:49:26+02:00 dialog: keep slot locked when searching for duplicate dialog - when attempting to create a new dialog, the function searching to see if it is already one with same attributes keeps the slot locked so is no race in between the return of function and building the new dlg structure - if the dlg is found, release the lock after figuring out it is a spiral or not --- Modified: modules/dialog/dlg_handlers.c Modified: modules/dialog/dlg_hash.c Modified: modules/dialog/dlg_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/9d807d1d8af24c0163d3bb2ae876a87… Patch: https://github.com/kamailio/kamailio/commit/9d807d1d8af24c0163d3bb2ae876a87…

8 years, 7 months

Install scripts and /var/run/kamailio

by Olle E. Johansson

Just a note so I don’t forget: When doing training we installed a few computers from tarballs, and got problems running the default script - install doesn’t seem to create /var/run/kamailio which is now a default for some options. We propably need to make sure this directory is created by standard install, not just by the RPM/DEB installs. /O

8 years, 7 months

git: new commits in branch 4.3

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/ce1cdba720e34cff1b5c2d150996d66… Author: Sven Neuhaus <neuhaus(a)tyntec.com> Date: 2015-10-01T10:05:57+02:00 core: Fix label for RPC command ("proto" -> "port") (cherry picked from commit 03b955ef8cc2ffcc08d0b361c0f1d6ce057c68b8) - URL: https://github.com/kamailio/kamailio/commit/a79449a149a84957a2786200ba22070… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T10:06:15+02:00 core: pv - helper function to return empty string (cherry picked from commit 36a704e8b54b65e8414fd2a02d973e74a9256e1d) - URL: https://github.com/kamailio/kamailio/commit/170d6717abb3b824bf0e7046ab47abc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T10:06:36+02:00 tmx: proper response of branch ruid pv for tm onreply route (cherry picked from commit 11791d2b749df9673e9c8fe09ae9e923fb6e735b) - URL: https://github.com/kamailio/kamailio/commit/4479272e96f73d03607af82b4dd3b17… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T10:06:53+02:00 tmx: tm reply code pv to use status code directly in onreply routes - no need to lookup transaction (cherry picked from commit 738b113b4be346b7caef600249202d361b556a41) - URL: https://github.com/kamailio/kamailio/commit/c8d17ba355b3979fc28390f9c934605… Author: Yasin <yasin.caner(a)netgsm.com.tr> Date: 2015-10-01T10:07:20+02:00 acc_radius : fixes extra attribues memory leak if we dont free getting memory from extrarstr , can give out of memory. this commit fixes this problem. (cherry picked from commit f84689aa9f56693abe95f537f8a0217a068b1f01) - URL: https://github.com/kamailio/kamailio/commit/98228c451bb6f8d08070b56232736e7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T10:07:36+02:00 acc_radius: fixed identation, removed history (cherry picked from commit f9a6b7893ad421cb142e03c9c2797773061c8933) - URL: https://github.com/kamailio/kamailio/commit/1452eddee9ec5933325faf4d6b26a07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:15:11+02:00 core: cast operator (int) converts hex strings as well - in addition to dec string (cherry picked from commit 33f159121193b3ed09e2ec7aa7b55aa543aeb852) - URL: https://github.com/kamailio/kamailio/commit/59976f8235f091e911137e1e1a74154… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:16:03+02:00 htable: more checks of updateexpire when item is updated (cherry picked from commit dd0fd7011b750e34c595936b6c95759ccb77f786) - URL: https://github.com/kamailio/kamailio/commit/fdecde3715688aa9145f21e0cbdb414… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:16:16+02:00 evapi: implemented receive buffering per connected client - incomplete data may be received on tcp, needing to wait to get more (only for netstring format) (cherry picked from commit 4eb7656726d1b1b408a12d55b3d7d297b78ee68d) - URL: https://github.com/kamailio/kamailio/commit/f31270d714f6017ec6d4ad3c1ebced6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:16:40+02:00 evapi: more debug messages when processing received data (cherry picked from commit a8adf3bdb74dd3819bb23e2876eee704663f3cef) - URL: https://github.com/kamailio/kamailio/commit/14297b78418cbe963b491de928f8e44… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-01T15:16:54+02:00 async: Fix some error messages (cherry picked from commit 103b915cffd63b4abab1a3e57b51644eef20e81d) - URL: https://github.com/kamailio/kamailio/commit/7e788aac3bd94c2c979441d6ab8b452… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-01T15:17:37+02:00 srdb1 Check if the module is loaded, so the error message makes sense in case of missing module If a module use a default database and it's not loaded, currently Kamailio complains that the module doesn't implement an API function instead of actually telling the Kamailian that the module is not loaded. This patch modifies that behaviour. (cherry picked from commit c1a1a1bb054ee79af6ca44d262c8f73c725a2d90) - URL: https://github.com/kamailio/kamailio/commit/6c387ca9c854a426c206266deef6bfc… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-01T15:17:51+02:00 mi_rpc Change "sercmd" to "kamcmd" in docs (cherry picked from commit 52d88ef0f0b0b361419edede208acd459af9fb1a) - URL: https://github.com/kamailio/kamailio/commit/91788e01dec1fba92a2484b5c547a5c… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-01T15:17:58+02:00 tm Change "sercmd" to "kamcmd" (cherry picked from commit 0c9ea3ccb7fac1180f26741422857807d24fcea1) - URL: https://github.com/kamailio/kamailio/commit/0d2fe9ae840d3e34f3c69577a5d6875… Author: Olle E. Johansson <oej(a)edvina.net> Date: 2015-10-01T15:18:06+02:00 sctp Documentation - change "sercmd" to "kamcmd" (cherry picked from commit 58b4ea9ca31305a4450807add2c21e7ecb01614b) - URL: https://github.com/kamailio/kamailio/commit/660edda79e65925b414f0d0cb477646… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:18:17+02:00 cnxcc: build fake msg for event route before terminating the dialog - dialog structure can be deleted in between - reported by GH#324 (cherry picked from commit 6177e766035f6bad2d5ee512ccde9a805d026760) - URL: https://github.com/kamailio/kamailio/commit/8a943bd7ab88942aabdd28f1959b0b7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:18:33+02:00 core: name of structure exported by a module can be prefixed with module name - some modules use the flag for global exporting, which can lead to naming conflicts - related to GH#333 (cherry picked from commit 6c7d38ee0fcbd482ff0527178481345fc93a7fc8) - URL: https://github.com/kamailio/kamailio/commit/0ceab4ea76348fd91b86ee9d372783a… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-10-01T15:18:44+02:00 app_perl: renamed the exported structure "_app_perl_exports" to avoid naming conflicts - reported by GH#333 (cherry picked from commit 2c736877dc215592f3f8889ffd47e90ab68066af) - URL: https://github.com/kamailio/kamailio/commit/8559ab818ffae6e24941758ecb97d37… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:19:03+02:00 evapi: debug messages for invalid len and execution of event route (cherry picked from commit 093337bc7f3d8d3ce31ad3770252503628bc3599) - URL: https://github.com/kamailio/kamailio/commit/5d7d1fd3ccc96e032ef73a799dfbd97… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:19:19+02:00 textops: prevent null dereference on tr_txt_eval_re error - Check for NULL pointer before calling subst_expr_free to prevent NULL pointer dereference when there is an unknown subtype error. (cherry picked from commit 5aa2ed265f80664f57073213b17c83b1dac42ab4) - URL: https://github.com/kamailio/kamailio/commit/209162e56facff75549560361cfd1d5… Author: zxcpoiu <zxcpoiu(a)gmail.com> Date: 2015-10-01T15:19:32+02:00 tmx: safety check for bad callid header in t_precheck_tran() - reported by GH#331 (cherry picked from commit 7cc1d1113e8e461656d55595f1a268d345d2676b) - URL: https://github.com/kamailio/kamailio/commit/b7c3276fd6a8c309465a6bb22db0904… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:19:44+02:00 htable: Fix buffer overrun in htable_rpc_list - Fix for using wrong len variable in htable_rpc_list if ht->dbtable.len is greater than 127, causing an out of bounds write. (cherry picked from commit 1c164473c6fd78318236254827a4cadbe8271463) - URL: https://github.com/kamailio/kamailio/commit/1e0e1a8cd24aac95ffe1970643a2a8c… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:19:59+02:00 sqlops: Don't pkg_free memory that wasn't pkg_malloc'd - Don't pkg_free the gparam_t parameter of sql_parse_index. When called within pv_parse_dbr_name that parameter is an internal field in the sql_pv_t structure and wasn't allocated with pkg_malloc. (cherry picked from commit 460e0a6077d69cf74ceb4b095195b683fb49269c) - URL: https://github.com/kamailio/kamailio/commit/8cdf9a26e90b1006a6992ad73d1e60f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:20:32+02:00 tsilo: ts_append_to() check if transation is active before adding new branches (cherry picked from commit 9451625ff8cc7e02abc2c6cf95572bff9c086d20) - URL: https://github.com/kamailio/kamailio/commit/cfc9fee62d9a7023743b694eeab4276… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:20:41+02:00 tm: t_suspend() skip suspending if a final response was sent out for transaction already (cherry picked from commit 92c376dbeb6ee515a80537c91014972ada4a5f34) - URL: https://github.com/kamailio/kamailio/commit/3b2946b41a69e19f4a995c26baa03f6… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:20:55+02:00 sqlops: Fix memory leak in error condition - Fix pv_parse_dbr_name to free spv if the key is unknown. - Fix typo in error log in pv_parse_dbr_name. (cherry picked from commit 48de750550dd12016e957d60e0ae57e59944558d) - URL: https://github.com/kamailio/kamailio/commit/8ffab1caa7753f5cdcf00584340a68f… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:21:26+02:00 janssonrpc-c: Fix double free if retry timer add fails - Fix double free if schedule_retry fails when adding request retry timer. timeout_cb called fail_request which frees req after schedule_retry had already done so. (cherry picked from commit bce9cf97646153af6abcf9f43cbb72f2c734e490) - URL: https://github.com/kamailio/kamailio/commit/e0406d460b29e3a4872dfb2f31b710c… Author: Chris Double <chris.double(a)double.co.nz> Date: 2015-10-01T15:21:33+02:00 janssonrpc-c: Fix use after free - Fix use after free due to pointer aliasing of 'arg' and 'a' in server_backoff_cb. - Fix use after free in force_disconnect - Fix use after free in free_server_list (cherry picked from commit a53b2fb68d555b07be479e41895937ae1c6318f6) - URL: https://github.com/kamailio/kamailio/commit/915f1410d9c0b4a5afe89727ad2d644… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T15:22:14+02:00 jsonrpc-s: input buffer for fifo transport increased to 8k (cherry picked from commit 0a7e24398a564d1703f4484834b823e988cf64db)

8 years, 7 months

git:master:f9a6b789: acc_radius: fixed identation, removed history

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f9a6b7893ad421cb142e03c9c2797773061c8933 URL: https://github.com/kamailio/kamailio/commit/f9a6b7893ad421cb142e03c9c279777… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T09:48:26+02:00 acc_radius: fixed identation, removed history --- Modified: modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f9a6b7893ad421cb142e03c9c279777… Patch: https://github.com/kamailio/kamailio/commit/f9a6b7893ad421cb142e03c9c279777…

8 years, 7 months

git:master:ed024ed2: Merge pull request #349 from ycaner06/master

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ed024ed2489803b41f333695dc0475fd77ac6f60 URL: https://github.com/kamailio/kamailio/commit/ed024ed2489803b41f333695dc0475f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-10-01T09:46:54+02:00 Merge pull request #349 from ycaner06/master acc_radius : fixes extra attribues memory leak --- Modified: modules/acc_radius/acc_radius_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ed024ed2489803b41f333695dc0475f… Patch: https://github.com/kamailio/kamailio/commit/ed024ed2489803b41f333695dc0475f… --- diff --git a/modules/acc_radius/acc_radius_mod.c b/modules/acc_radius/acc_radius_mod.c index b1843d6..5975c3e 100644 --- a/modules/acc_radius/acc_radius_mod.c +++ b/modules/acc_radius/acc_radius_mod.c @@ -24,6 +24,7 @@ * History: * ------- * 2010-07-28 - moved out radius account out of acc module (daniel) + * 2015-10-01 - accounting memory leak is fixed with free_strar_mem (ycaner) */ /*! \file @@ -49,6 +50,7 @@ #include "../../lib/kcore/radius.h" #include "../../modules/acc/acc_api.h" #include "acc_radius_mod.h" +#include "../../modules/acc/acc_extra.h" MODULE_VERSION @@ -329,6 +331,8 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) uint32_t av_type; int offset; int i; + int m=0; + int o=0; send=NULL; @@ -353,8 +357,11 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) ADD_RAD_AVPAIR( RA_TIME_STAMP, &av_type, -1); /* add extra also */ - attr_cnt += accb.get_extra_attrs(rad_extra, req, inf->varr+attr_cnt, - inf->iarr+attr_cnt, inf->tarr+attr_cnt); + o = accb.get_extra_attrs(rad_extra, req, inf->varr+attr_cnt, + inf->iarr+attr_cnt, inf->tarr+attr_cnt); + attr_cnt += o; + m = attr_cnt; + /* add the values for the vector - start from 1 instead of * 0 to skip the first value which is the METHOD as string */ @@ -388,10 +395,14 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) goto error; } rc_avpair_free(send); + /* free memory allocated by extra2strar */ + free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); return 1; error: rc_avpair_free(send); + /* free memory allocated by extra2strar */ + free_strar_mem( &(inf->tarr[m-o]), &(inf->varr[m-o]), o, m); return -1; }

8 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2015