sr-dev January 2015

sr-dev@lists.kamailio.org

38 participants
531 discussions

strict routing and sip spirals
by Jasmin Schnatterbeck 28 Jan '15

28 Jan '15

Hi, may there is a routing-issue in rr-module, that causes some problems with sip-spirals: If is_myself("$ru") is true (in-dialog), kamailio rewrites the $ru to the $route_uri (strict routing). That is usually correct. loose.c 944 if (is_myself(&_m->parsed_uri)) { 945 return after_strict(_m); This includes the case if is_myself("$route_uri") is also true - but(!) $route_uri and $ru can still be different, and this can be very relevant. rfc3261 says: 16.4 Route Information Preprocessing The proxy MUST inspect the Request-URI of the request. If the Request-URI of the request contains a value this proxy previously placed into a Record-Route header field (see Section 16.6 item 4), the proxy MUST replace the Request-URI in the request with the last value from the Route header field, and remove that value from the Route header field. The proxy MUST then proceed as if it received this modified request. It says " If the Request-URI of the request contains a value this proxy previously placed into a Record-Route header field ". This means $route_uri == $ru Then - indeed - it does not matter to replace the $ru (even: does it really change something?) I do not see a sign to decide for strict routing instead of loose routing, if (in-dialog) is_myself("$ru") AND is_myself("$route_uri") in general, and especially not if $ru == $route_uri Or is there any reason to process the request like it is now? Cheers Jasmin

1 0

[kamailio] Is cross module function call a good practice? (#50)
by mading087 28 Jan '15

28 Jan '15

Started creating a new module auth_jwt, which supports JSON Web Token for auth. Need to access the database to validate some claims in the token. Wonder if I should just make a function call to auth_db or copy the code from auth_db? Which approach is a better approach? Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/50

4 7

[kamailio] presence_dialoginfo : optionally send dummy dialog (#55)
by lazedo 28 Jan '15

28 Jan '15

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/55 -- Commit Summary -- * presence_dialoginfo : optionally send dummy dialog -- File Changes -- M modules/presence_dialoginfo/doc/presence_dialoginfo_admin.xml (25) M modules/presence_dialoginfo/notify_body.c (47) M modules/presence_dialoginfo/presence_dialoginfo.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/55.patch https://github.com/kamailio/kamailio/pull/55.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/55

3 8

git:master:010977f5: sca: initialize sca variable to catch destroy on shutdown at startup
by Daniel-Constantin Mierla 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: 010977f5febcf923a31d545bd631fbee11dd426c URL: https://github.com/kamailio/kamailio/commit/010977f5febcf923a31d545bd631fbe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-28T22:09:21+01:00 sca: initialize sca variable to catch destroy on shutdown at startup - reported by GH#35 --- Modified: modules/sca/sca.c --- Diff: https://github.com/kamailio/kamailio/commit/010977f5febcf923a31d545bd631fbe… Patch: https://github.com/kamailio/kamailio/commit/010977f5febcf923a31d545bd631fbe… --- diff --git a/modules/sca/sca.c b/modules/sca/sca.c index 743ec96..e739e18 100644 --- a/modules/sca/sca.c +++ b/modules/sca/sca.c @@ -40,7 +40,7 @@ MODULE_VERSION /* MODULE OBJECT */ -sca_mod *sca; +sca_mod *sca = NULL; /* EXTERNAL API */ @@ -363,10 +363,15 @@ sca_mod_init( void ) void sca_mod_destroy( void ) { + if(sca==0) + return; + /* write back to the DB to retain most current subscription info */ if ( sca_subscription_db_update() != 0 ) { - LM_ERR( "sca_mod_destroy: failed to save current subscriptions " - "in DB %.*s", STR_FMT( sca->cfg->db_url )); + if(sca && sca->cfg && sca->cfg->db_url) { + LM_ERR( "sca_mod_destroy: failed to save current subscriptions " + "in DB %.*s", STR_FMT( sca->cfg->db_url )); + } } sca_db_disconnect();

1 0

[kamailio] userblacklist (?) : Core dump (#42)
by Olle E. Johansson 28 Jan '15

28 Jan '15

As other cases, just starting Kamailio and trying to stop it. Config with a lot of modules and no messages. Git head. (gdb) bt full #0 0x00000001139744be in dtrie_delete (root=0x10fabdec0, node=0x40000000000, delete_payload=0, branches=10) at dtrie.c:82 i = 0 #1 0x00000001139744d1 in dtrie_delete (root=0x10fabdec0, node=0x10fabdec0, delete_payload=0, branches=10) at dtrie.c:82 i = 0 #2 0x0000000113974b10 in dtrie_destroy (root=0x11396e788, delete_payload=0, branches=10) at dtrie.c:104 No locals. #3 0x000000011395c3ef in mod_destroy () at userblacklist.c:742 No locals. #4 0x000000010d20a089 in destroy_modules () at sr_module.c:788 t = (struct sr_module *) 0x10d671600 foo = (struct sr_module *) 0x10d6712b0 #5 0x000000010d0613cb in cleanup (show_status=1) at main.c:512 memlog = 0 #6 0x000000010d068d2b in shutdown_children (sig=15, show_status=1) at main.c:654 No locals. #7 0x000000010d064394 in handle_sigs () at main.c:684 chld = 0 chld_status = 0 memlog = 0 #8 0x000000010d068db7 in sig_usr (signo=2) at main.c:781 memlog = 0 #9 <signal handler called> No symbol table info available. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/42

2 3

git:master:c28551cd: userblacklist: init variables for safer destroy at startup
by Daniel-Constantin Mierla 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: c28551cd245f5e8ab9fc5d5c29f657cc06ad81e2 URL: https://github.com/kamailio/kamailio/commit/c28551cd245f5e8ab9fc5d5c29f657c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-01-28T22:02:56+01:00 userblacklist: init variables for safer destroy at startup - reported by GH#42 --- Modified: modules/userblacklist/userblacklist.c --- Diff: https://github.com/kamailio/kamailio/commit/c28551cd245f5e8ab9fc5d5c29f657c… Patch: https://github.com/kamailio/kamailio/commit/c28551cd245f5e8ab9fc5d5c29f657c… --- diff --git a/modules/userblacklist/userblacklist.c b/modules/userblacklist/userblacklist.c index 5e13a04..73bcd0c 100644 --- a/modules/userblacklist/userblacklist.c +++ b/modules/userblacklist/userblacklist.c @@ -169,7 +169,7 @@ struct source_list_t { static gen_lock_t *lock = NULL; static struct source_list_t *sources = NULL; -static struct dtrie_node_t *dtrie_root; +static struct dtrie_node_t *dtrie_root = NULL; static int check_user_blacklist_fixup(void** param, int param_no) @@ -627,7 +627,7 @@ static int init_source_list(void) SHM_MEM_ERROR; return -1; } - sources->head = NULL; + memset(sources, 0, sizeof(struct source_list_t)); return 0; }

1 0

git:master:48a548df: utils Remove SVN ID, remove history
by Olle E. Johansson 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: 48a548df00b9efc9e6d467b05f7998d913d9b87a URL: https://github.com/kamailio/kamailio/commit/48a548df00b9efc9e6d467b05f7998d… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-28T21:39:29+01:00 utils Remove SVN ID, remove history --- Modified: modules/utils/conf.c Modified: modules/utils/conf.h Modified: modules/utils/functions.c Modified: modules/utils/functions.h Modified: modules/utils/pidf.c Modified: modules/utils/pidf.h Modified: modules/utils/utils.c Modified: modules/utils/utils.h Modified: modules/utils/xcap_auth.c Modified: modules/utils/xcap_auth.h --- Diff: https://github.com/kamailio/kamailio/commit/48a548df00b9efc9e6d467b05f7998d… Patch: https://github.com/kamailio/kamailio/commit/48a548df00b9efc9e6d467b05f7998d…

1 0

git:master:dad18e39: cfg_db Remove SVN ID, history
by Olle E. Johansson 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: dad18e39dcd1718735243032952051f76598df44 URL: https://github.com/kamailio/kamailio/commit/dad18e39dcd1718735243032952051f… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-28T21:35:23+01:00 cfg_db Remove SVN ID, history --- Modified: modules/cfg_db/cfg_db.c --- Diff: https://github.com/kamailio/kamailio/commit/dad18e39dcd1718735243032952051f… Patch: https://github.com/kamailio/kamailio/commit/dad18e39dcd1718735243032952051f… --- diff --git a/modules/cfg_db/cfg_db.c b/modules/cfg_db/cfg_db.c index a571ef3..a1d13a1 100644 --- a/modules/cfg_db/cfg_db.c +++ b/modules/cfg_db/cfg_db.c @@ -1,21 +1,14 @@ /* - * $Id$ - * * Copyright (C) 2007 iptelorg GmbH * - * This file is part of ser, a free SIP server. + * This file is part of Kamailio, a free SIP server. * - * ser is free software; you can redistribute it and/or modify + * Kamailio is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version * - * For a license to use the ser software under conditions - * other than those described here, or to purchase support for this - * software, please contact iptel.org by e-mail at the following addresses: - * info(a)iptel.org - * - * ser is distributed in the hope that it will be useful, + * Kamailio is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. @@ -24,9 +17,6 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * - * History - * ------- - * 2008-01-05 Initial version (tma) */ #include "../../sr_module.h"

1 0

git:master:f4e2938c: cfg_db README update
by Olle E. Johansson 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: f4e2938c80b86e9f146309bb40cf23a5f8f3f8d2 URL: https://github.com/kamailio/kamailio/commit/f4e2938c80b86e9f146309bb40cf23a… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-28T21:35:09+01:00 cfg_db README update --- Modified: modules/cfg_db/README Modified: modules/cfg_db/doc/cfg_db.xml --- Diff: https://github.com/kamailio/kamailio/commit/f4e2938c80b86e9f146309bb40cf23a… Patch: https://github.com/kamailio/kamailio/commit/f4e2938c80b86e9f146309bb40cf23a…

1 0

git:master:8554f2b1: Merge pull request #56 from linuxmaniac/fix_kamctl_build
by Victor Seva 28 Jan '15

28 Jan '15

Module: kamailio Branch: master Commit: 8554f2b136d59cedc4b7d2d4bf4a268cc0f8690f URL: https://github.com/kamailio/kamailio/commit/8554f2b136d59cedc4b7d2d4bf4a268… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2015-01-28T21:27:06+01:00 Merge pull request #56 from linuxmaniac/fix_kamctl_build utils/kamctl: use $(basedir) as tmp dir on building instead of insecure /tmp --- Modified: utils/kamctl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/8554f2b136d59cedc4b7d2d4bf4a268… Patch: https://github.com/kamailio/kamailio/commit/8554f2b136d59cedc4b7d2d4bf4a268…

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2015