sr-dev January 2015

sr-dev@lists.kamailio.org

38 participants
530 discussions

git:master:ae0e7952: ctl Remove svn ID, remove history, add a tiny bit of doxygen
by Olle E. Johansson 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: ae0e79526a37643441ce2589f078850d9f595df8 URL: https://github.com/kamailio/kamailio/commit/ae0e79526a37643441ce2589f078850… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-17T20:58:57+01:00 ctl Remove svn ID, remove history, add a tiny bit of doxygen --- Modified: modules/ctl/binrpc.c Modified: modules/ctl/binrpc.h Modified: modules/ctl/binrpc_run.c Modified: modules/ctl/binrpc_run.h Modified: modules/ctl/ctl.c Modified: modules/ctl/ctl.h Modified: modules/ctl/ctl_defaults.h Modified: modules/ctl/ctrl_socks.c Modified: modules/ctl/ctrl_socks.h Modified: modules/ctl/fifo_server.c Modified: modules/ctl/fifo_server.h Modified: modules/ctl/init_socks.c Modified: modules/ctl/init_socks.h Modified: modules/ctl/io_listener.c Modified: modules/ctl/io_listener.h --- Diff: https://github.com/kamailio/kamailio/commit/ae0e79526a37643441ce2589f078850… Patch: https://github.com/kamailio/kamailio/commit/ae0e79526a37643441ce2589f078850…

1 0

git:master:5bafc032: sipcapture Add some missing \n in log messages
by Olle E. Johansson 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: 5bafc03222bf6fcc59dbcf8aec30def9cdb24581 URL: https://github.com/kamailio/kamailio/commit/5bafc03222bf6fcc59dbcf8aec30def… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-17T20:51:09+01:00 sipcapture Add some missing \n in log messages --- Modified: modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/5bafc03222bf6fcc59dbcf8aec30def… Patch: https://github.com/kamailio/kamailio/commit/5bafc03222bf6fcc59dbcf8aec30def… --- diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index 42df2c3..070482c 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -794,16 +794,16 @@ static int mod_init(void) { } if ((insert_retries <0) || ( insert_retries > 500)) { - LM_ERR("insert_retries should be a value between 0 and 500"); + LM_ERR("insert_retries should be a value between 0 and 500\n"); return -1; } if (( 0 == insert_retries) && (insert_retry_timeout != 0)){ - LM_ERR("insert_retry_timeout has no meaning when insert_retries is not set"); + LM_ERR("insert_retry_timeout has no meaning when insert_retries is not set\n"); } if ((insert_retry_timeout <0) || ( insert_retry_timeout > 300)) { - LM_ERR("insert_retry_timeout should be a value between 0 and 300"); + LM_ERR("insert_retry_timeout should be a value between 0 and 300\n"); return -1; } @@ -964,7 +964,7 @@ static int child_init(int rank) while (c){ if (!c->db_url.s || !c->db_url.len ){ - LM_ERR("DB URL not set for capture mode:[%.*s]", c->name.len, c->name.s); + LM_ERR("DB URL not set for capture mode:[%.*s]\n", c->name.len, c->name.s); return -1; } c->db_con = c->db_funcs.init(&c->db_url);

1 0

[kamailio] sipcapture: Repeating error message (#40)
by Olle E. Johansson 17 Jan '15

17 Jan '15

With the sip capture module loaded, but not activated, this error message is repeated many times - with no traffic. 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled 0(93552) ERROR: sipcapture [hep.c:61]: hep_msg_received(): sipcapture:hep_msg_received HEP is not enabled --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/40

2 7

git:master:cb8304f1: Merge pull request #44 from adubovikov/master
by Alexandr Dubovikov 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: cb8304f1f6be1eca3f9bd982265d5c3bed528189 URL: https://github.com/kamailio/kamailio/commit/cb8304f1f6be1eca3f9bd982265d5c3… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Committer: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: 2015-01-17T20:48:05+01:00 Merge pull request #44 from adubovikov/master added bool to print error once --- Modified: modules/sipcapture/hep.c --- Diff: https://github.com/kamailio/kamailio/commit/cb8304f1f6be1eca3f9bd982265d5c3… Patch: https://github.com/kamailio/kamailio/commit/cb8304f1f6be1eca3f9bd982265d5c3… --- diff --git a/modules/sipcapture/hep.c b/modules/sipcapture/hep.c index c1ff51c..a14fcd9 100644 --- a/modules/sipcapture/hep.c +++ b/modules/sipcapture/hep.c @@ -37,7 +37,7 @@ #include "sipcapture.h" - +static int show_error = 0; static int count = 0; struct hep_timehdr* heptime; @@ -58,7 +58,10 @@ int hep_msg_received(void *data) struct receive_info *ri; if(!hep_capture_on) { - LOG(L_ERR, "sipcapture:hep_msg_received HEP is not enabled\n"); + if(show_error == 0) { + LOG(L_ERR, "sipcapture:hep_msg_received HEP is not enabled\n"); + show_error = 1; + } return -1; }

1 0

git:master:c8363905: added bool to print error once
by Alexandr Dubovikov 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: c8363905755e5d120251eed95c5fa1be45e8f216 URL: https://github.com/kamailio/kamailio/commit/c8363905755e5d120251eed95c5fa1b… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Committer: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: 2015-01-17T20:34:35+01:00 added bool to print error once --- Modified: modules/sipcapture/hep.c --- Diff: https://github.com/kamailio/kamailio/commit/c8363905755e5d120251eed95c5fa1b… Patch: https://github.com/kamailio/kamailio/commit/c8363905755e5d120251eed95c5fa1b… --- diff --git a/modules/sipcapture/hep.c b/modules/sipcapture/hep.c index c1ff51c..a14fcd9 100644 --- a/modules/sipcapture/hep.c +++ b/modules/sipcapture/hep.c @@ -37,7 +37,7 @@ #include "sipcapture.h" - +static int show_error = 0; static int count = 0; struct hep_timehdr* heptime; @@ -58,7 +58,10 @@ int hep_msg_received(void *data) struct receive_info *ri; if(!hep_capture_on) { - LOG(L_ERR, "sipcapture:hep_msg_received HEP is not enabled\n"); + if(show_error == 0) { + LOG(L_ERR, "sipcapture:hep_msg_received HEP is not enabled\n"); + show_error = 1; + } return -1; }

1 0

[kamailio] added bool to print error once (#44)
by Alexandr Dubovikov 17 Jan '15

17 Jan '15

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/44 -- Commit Summary -- * added bool to print error once -- File Changes -- M modules/sipcapture/hep.c (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/44.patch https://github.com/kamailio/kamailio/pull/44.diff --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/44

1 1

Can we create a core-dump-free Kamailio?
by Olle E. Johansson 17 Jan '15

17 Jan '15

Friends, For a long time I've been able to cause core dumps by configuring stuff badly. It should not be possible. We should validate input and not crash because of missing or bad configurations. In many cases there's a core dump after load of the module, in some times a modules seems to cause core dump when Kamailio exits. I will try to isolate where possible and create a very, very minimal configuration file to be able to repeat it. ...and as you see, I will file bug reports. :-) I am also trying to spot where I see log messages that are not properly ended with \n or error messages that are repeated too many times, just annoying the Kamailio admin. Let's work on this to make 4.3 a bit more stable for beginners. First impression is important :-) Cheers, /O

1 0

git:master:618a148c: matrix Add \n at the end of log messages where missing
by Olle E. Johansson 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: 618a148c6b214bb285fd7cb5fb6620482f7e38d6 URL: https://github.com/kamailio/kamailio/commit/618a148c6b214bb285fd7cb5fb66204… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-17T18:19:35+01:00 matrix Add \n at the end of log messages where missing --- Modified: modules/matrix/matrix.c --- Diff: https://github.com/kamailio/kamailio/commit/618a148c6b214bb285fd7cb5fb66204… Patch: https://github.com/kamailio/kamailio/commit/618a148c6b214bb285fd7cb5fb66204… --- diff --git a/modules/matrix/matrix.c b/modules/matrix/matrix.c index a218f9f..1279a58 100644 --- a/modules/matrix/matrix.c +++ b/modules/matrix/matrix.c @@ -321,7 +321,7 @@ static int matrix_insert(int first, short int second, int res) while (srcitem) { if (srcitem->id == first) { srcitem->second_list[second] = res; - LM_DBG("inserted (%d, %d, %d)", first, second, res); + LM_DBG("inserted (%d, %d, %d)\n", first, second, res); return 0; } srcitem = srcitem->next; @@ -329,7 +329,7 @@ static int matrix_insert(int first, short int second, int res) /* not found */ srcitem = shm_malloc(sizeof(struct first_t)); if (srcitem == NULL) { - LM_ERR("out of shared memory."); + LM_ERR("out of shared memory.\n"); return -1; } memset(srcitem, 0, sizeof(struct first_t)); @@ -343,7 +343,7 @@ static int matrix_insert(int first, short int second, int res) matrix->head = srcitem; } - LM_DBG("inserted new row for (%d, %d, %d)", first, second, res); + LM_DBG("inserted new row for (%d, %d, %d)\n", first, second, res); return 0; } @@ -498,7 +498,7 @@ static int db_reload_matrix(void) matrix_dbf.free_result(matrix_dbh, res); - LM_INFO("loaded %d matrix entries.", n); + LM_INFO("loaded %d matrix entries.\n", n); return n; }

1 0

git:master:8d8cea81: srdb2 Remove SVN ID, change "ser" => "kamailio"
by Olle E. Johansson 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: 8d8cea81449ad0a39b5541e4c5bec01c1298ca3d URL: https://github.com/kamailio/kamailio/commit/8d8cea81449ad0a39b5541e4c5bec01… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-17T15:06:06+01:00 srdb2 Remove SVN ID, change "ser" => "kamailio" --- Modified: lib/srdb2/db.c Modified: lib/srdb2/db.h Modified: lib/srdb2/db_cmd.c Modified: lib/srdb2/db_cmd.h Modified: lib/srdb2/db_con.c Modified: lib/srdb2/db_con.h Modified: lib/srdb2/db_ctx.c Modified: lib/srdb2/db_ctx.h Modified: lib/srdb2/db_drv.c Modified: lib/srdb2/db_drv.h Modified: lib/srdb2/db_fld.c Modified: lib/srdb2/db_fld.h Modified: lib/srdb2/db_gen.c Modified: lib/srdb2/db_gen.h Modified: lib/srdb2/db_pool.c Modified: lib/srdb2/db_pool.h Modified: lib/srdb2/db_rec.c Modified: lib/srdb2/db_rec.h Modified: lib/srdb2/db_res.c Modified: lib/srdb2/db_res.h Modified: lib/srdb2/db_uri.c Modified: lib/srdb2/db_uri.h --- Diff: https://github.com/kamailio/kamailio/commit/8d8cea81449ad0a39b5541e4c5bec01… Patch: https://github.com/kamailio/kamailio/commit/8d8cea81449ad0a39b5541e4c5bec01…

1 0

git:master:ce41c400: domain Add \n at end of LM_ERR message, add LM_DBG for db_url
by Olle E. Johansson 17 Jan '15

17 Jan '15

Module: kamailio Branch: master Commit: ce41c40055139b3eb5a44d940585457e48830724 URL: https://github.com/kamailio/kamailio/commit/ce41c40055139b3eb5a44d940585457… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2015-01-17T15:06:06+01:00 domain Add \n at end of LM_ERR message, add LM_DBG for db_url --- Modified: modules/domain/domain.c Modified: modules/domain/domain_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ce41c40055139b3eb5a44d940585457… Patch: https://github.com/kamailio/kamailio/commit/ce41c40055139b3eb5a44d940585457… --- diff --git a/modules/domain/domain.c b/modules/domain/domain.c index 3fd7472..19943ab 100644 --- a/modules/domain/domain.c +++ b/modules/domain/domain.c @@ -40,7 +40,7 @@ static db_func_t domain_dbf; int domain_db_bind(const str* db_url) { if (db_bind_mod(db_url, &domain_dbf )) { - LM_ERR("Cannot bind to database module!"); + LM_ERR("Cannot bind to database module!\n"); return -1; } return 0; diff --git a/modules/domain/domain_mod.c b/modules/domain/domain_mod.c index 6c86c5a..81f3091 100644 --- a/modules/domain/domain_mod.c +++ b/modules/domain/domain_mod.c @@ -176,7 +176,8 @@ static int mod_init(void) /* Bind database */ if (domain_db_bind(&db_url)) { - LM_ERR("no database module found\n"); + LM_DBG("Usign db_url [%.*s]\n", db_url.len, db_url.s); + LM_ERR("no database module found. Have you configure thed \"db_url\" modparam properly?\n"); return -1; }

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
53
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2015