sr-dev September 2014

sr-dev@lists.kamailio.org

33 participants
376 discussions

git:master: ims_registrar_pcscf: Safety check, if (r) is set ( caused a crash)
by Carsten Bock 11 Sep '14

11 Sep '14

Module: sip-router Branch: master Commit: 9673bbe0fff1c3f05803a7a51f16cee9d299601f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9673bbe… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Sep 11 12:19:18 2014 +0200 ims_registrar_pcscf: Safety check, if (r) is set (caused a crash) --- modules/ims_registrar_pcscf/service_routes.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c index 851ffad..1eef7f4 100644 --- a/modules/ims_registrar_pcscf/service_routes.c +++ b/modules/ims_registrar_pcscf/service_routes.c @@ -297,7 +297,7 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) { if (r) { LM_DBG("Route is %.*s\n", r->nameaddr.uri.len, r->nameaddr.uri.s); /* Skip first headers containing myself: */ - while (parse_uri(r->nameaddr.uri.s, r->nameaddr.uri.len, &uri) == 0 + while (r && (parse_uri(r->nameaddr.uri.s, r->nameaddr.uri.len, &uri) == 0) && check_self(&uri.host,uri.port_no?uri.port_no:SIP_PORT,0)) { LM_DBG("Self\n"); /* Check for more headers and fail, if it was the last one @@ -315,6 +315,7 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) { if (r) LM_DBG("Next Route is %.*s\n", r->nameaddr.uri.len, r->nameaddr.uri.s); } + LM_DBG("We have %d service-routes\n"); /* Then check the following headers: */ for (i=0; i< c->num_service_routes; i++) { LM_DBG("Route must be: %.*s\n", c->service_routes[i].len, c->service_routes[i].s);

1 0

[tracker] Task closed: To tag parsing bug
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#465 - To tag parsing bug User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch applied to master. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=465 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: Makefile.defs: version set to 4.2.0-pre0
by Daniel-Constantin Mierla 11 Sep '14

11 Sep '14

Module: sip-router Branch: master Commit: 23a35c0598696a7a4e97c95466b321ade05bf823 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=23a35c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 11 12:10:44 2014 +0200 Makefile.defs: version set to 4.2.0-pre0 - pre-release phase - testing period, no new features till branching 4.2 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 4ee2430..f98b168 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -165,7 +165,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 4 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -dev9 +EXTRAVERSION = -pre0 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master: msg_parser: fix To parameter with null value parsing
by Daniel-Constantin Mierla 11 Sep '14

11 Sep '14

Module: sip-router Branch: master Commit: 14183ffa5e1bab1659d1df87a77057d50c376029 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=14183ff… Author: Alekzander Spiridonov <sipidronov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 4 07:09:02 2014 -0700 msg_parser: fix To parameter with null value parsing --- msg_translator.c | 2 +- parser/parse_addr_spec.c | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/msg_translator.c b/msg_translator.c index 788cff8..677d44e 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -2406,7 +2406,7 @@ char * build_res_buf_from_sip_req( unsigned int code, str *text ,str *new_tag, case HDR_TO_T: if (new_tag && new_tag->len) { to_tag=get_to(msg)->tag_value; - if (to_tag.len ) + if ( to_tag.len || to_tag.s ) len+=new_tag->len-to_tag.len; else len+=new_tag->len+TOTAG_TOKEN_LEN/*";tag="*/; diff --git a/parser/parse_addr_spec.c b/parser/parse_addr_spec.c index c6635d3..f0388a2 100644 --- a/parser/parse_addr_spec.c +++ b/parser/parse_addr_spec.c @@ -546,7 +546,12 @@ endofheader: break; case S_PARA_VALUE: /* parameter with null value, e.g. foo= */ - param->value.s=tmp; + if ( status==F_CRLF ) + param->value.s=tmp-2; + else if ( status==F_CR || status==F_LF ) + param->value.s=tmp-1; + else + param->value.s=tmp; param->value.len=0; add_param(param, to_b, newparam); saved_status=E_PARA_VALUE;

1 0

[tracker] Task closed: tm doesn't relay changed 'To' header in CANCEL before dialog is established
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#325 - tm doesn't relay changed 'To' header in CANCEL before dialog is established User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: This is implemented in latest stable versions. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=325 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Improving logging (show at least the transaction branch)
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#57 - Improving logging (show at least the transaction branch) User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=57 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Improving logging (show at least the transaction branch)
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#57 - Improving logging (show at least the transaction branch) User who did this - Daniel-Constantin Mierla (miconda) ---------- This should be now possible via log_prefix core parameter/ ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=57#comment1615 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: error message does not include cfg file line number
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#58 - error message does not include cfg file line number User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=58 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: error message does not include cfg file line number
by sip-router 11 Sep '14

11 Sep '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#58 - error message does not include cfg file line number User who did this - Daniel-Constantin Mierla (miconda) ---------- This should be possible now with log_prefix and cfg line variable. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=58#comment1614 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: ims_auth: Fix crash, if the third parameter was ommited on ims_www_challenge.
by Carsten Bock 11 Sep '14

11 Sep '14

Module: sip-router Branch: master Commit: 81fbf1504548c0978f4e8f056df594f57d681e88 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=81fbf15… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Sep 11 11:17:43 2014 +0200 ims_auth: Fix crash, if the third parameter was ommited on ims_www_challenge. --- modules/ims_auth/authims_mod.c | 4 ++-- modules/ims_auth/authorize.c | 5 ++++- modules/ims_auth/authorize.h | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/modules/ims_auth/authims_mod.c b/modules/ims_auth/authims_mod.c index 8d8afd1..dcdd421 100644 --- a/modules/ims_auth/authims_mod.c +++ b/modules/ims_auth/authims_mod.c @@ -112,8 +112,8 @@ int ignore_failed_auth = 0; */ static cmd_export_t cmds[] = { {"ims_www_authenticate", (cmd_function) www_authenticate, 1, auth_fixup, 0, REQUEST_ROUTE}, - {"ims_www_challenge", (cmd_function) www_challenge, 2, challenge_fixup_async, 0, REQUEST_ROUTE}, - {"ims_www_challenge", (cmd_function) www_challenge, 3, challenge_fixup_async, 0, REQUEST_ROUTE}, + {"ims_www_challenge", (cmd_function) www_challenge2, 2, challenge_fixup_async, 0, REQUEST_ROUTE}, + {"ims_www_challenge", (cmd_function) www_challenge3, 3, challenge_fixup_async, 0, REQUEST_ROUTE}, {"ims_www_resync_auth", (cmd_function) www_resync_auth, 2, challenge_fixup_async, 0, REQUEST_ROUTE}, {"ims_proxy_authenticate", (cmd_function) proxy_authenticate, 1, auth_fixup, 0, REQUEST_ROUTE}, {"ims_proxy_challenge", (cmd_function) proxy_challenge, 2, auth_fixup_async, 0, REQUEST_ROUTE}, diff --git a/modules/ims_auth/authorize.c b/modules/ims_auth/authorize.c index bb93ffa..bebb4fc 100644 --- a/modules/ims_auth/authorize.c +++ b/modules/ims_auth/authorize.c @@ -476,8 +476,11 @@ int challenge(struct sip_msg* msg, char* str1, char* alg, int is_proxy_auth, cha } return CSCF_RETURN_BREAK; } +int www_challenge2(struct sip_msg* msg, char* _route, char* str1, char* str2) { + return challenge(msg, str1, 0, 0, _route); +} -int www_challenge(struct sip_msg* msg, char* _route, char* str1, char* str2) { +int www_challenge3(struct sip_msg* msg, char* _route, char* str1, char* str2) { return challenge(msg, str1, str2, 0, _route); } diff --git a/modules/ims_auth/authorize.h b/modules/ims_auth/authorize.h index 54942bb..41360b7 100644 --- a/modules/ims_auth/authorize.h +++ b/modules/ims_auth/authorize.h @@ -139,7 +139,8 @@ int proxy_challenge(struct sip_msg* msg, char* route, char* _realm, char* str2); * Authorize using WWW-Authorization header field */ int www_authenticate(struct sip_msg* _msg, char* _realm, char* _table); -int www_challenge(struct sip_msg* msg, char* route, char* _realm, char* str2); +int www_challenge2(struct sip_msg* msg, char* route, char* _realm, char* str2); +int www_challenge3(struct sip_msg* msg, char* route, char* _realm, char* str2); int www_resync_auth(struct sip_msg* msg, char* _route, char* str1, char* str2);

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
38
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2014