sr-dev June 2014

sr-dev@lists.kamailio.org

21 participants
152 discussions

git:master: acc: allow recording to the rest of backends even when setting db table fails

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 655711330b2ffd82dc84330ef0e0fbbad82a9160 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6557113… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 12 11:48:01 2014 +0200 acc: allow recording to the rest of backends even when setting db table fails - such error doesn't affect radius or custom backends --- modules/acc/acc_logic.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 93bf5c1..051209c 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -529,9 +529,9 @@ static inline void acc_onreply( struct cell* t, struct sip_msg *req, if (is_db_acc_on(req)) { if(acc_db_set_table_name(req, db_table_acc_data, &db_table_acc)<0) { LM_ERR("cannot set acc db table name\n"); - return; + } else { + acc_db_request(req); } - acc_db_request(req); } #endif #ifdef RAD_ACC

9 years, 10 months

git:4.1: auth: proper fixup for optional method parameter in pv_www_authenticate()

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: be8fb6fa8a1492259a26abe4825653f1f66ff0d8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=be8fb6f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 12 11:39:55 2014 +0200 auth: proper fixup for optional method parameter in pv_www_authenticate() - reported by Muhammad Shahzad (cherry picked from commit dd00819f7cca976e699a20960956abff760df957) --- modules/auth/auth_mod.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/auth/auth_mod.c b/modules/auth/auth_mod.c index a148053..e0ed083 100644 --- a/modules/auth/auth_mod.c +++ b/modules/auth/auth_mod.c @@ -830,6 +830,7 @@ static int fixup_pv_auth(void **param, int param_no) switch(param_no) { case 1: case 2: + case 4: return fixup_var_pve_str_12(param, 1); case 3: return fixup_var_int_12(param, 1);

9 years, 10 months

git:master: auth: proper fixup for optional method parameter in pv_www_authenticate()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: dd00819f7cca976e699a20960956abff760df957 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dd00819… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 12 11:39:55 2014 +0200 auth: proper fixup for optional method parameter in pv_www_authenticate() - reported by Muhammad Shahzad --- modules/auth/auth_mod.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/auth/auth_mod.c b/modules/auth/auth_mod.c index a148053..e0ed083 100644 --- a/modules/auth/auth_mod.c +++ b/modules/auth/auth_mod.c @@ -830,6 +830,7 @@ static int fixup_pv_auth(void **param, int param_no) switch(param_no) { case 1: case 2: + case 4: return fixup_var_pve_str_12(param, 1); case 3: return fixup_var_int_12(param, 1);

9 years, 10 months

planning the release of v4.1.4

by Daniel-Constantin Mierla

Hello, I am considering to release v4.1.4 next week, in one of the days within the interval June 10-12, depending on work that has to be done. If anyone is aware of issue not reported on tracker or patches that have not been backported, add to the tracker or write a message to sr-dev mailing list. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

9 years, 10 months

New commits on branch 4.1

by Daniel-Constantin Mierla

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b1ab677… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 12 09:59:44 2014 +0200 core: sync definition of destroy_rpcs() - reported by Victor Seva (cherry picked from commit 28be6c3c79c02600f03a51b2393b289fbe8c9bd9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fbe7347… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jun 11 17:12:37 2014 +0200 dialog: execute internal event_route blocks under local_route type - request_route type triggers additional script callbacks that could reset the transaction and can cause crashing - reported by Nuno Miguel Reis, FS#440 (cherry picked from commit 88a9ffee284338d536b6f7e072e5c99b29d983ee) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fc7f840… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 30 13:34:08 2014 +0200 core/parse/sdp: proper parsing of a=rtpmap line - error handling when malformed line, avoiding crash to due to invalid offsetting when clockrate is missing - reported by Michael Ricordeau, FS#435 (cherry picked from commit c842bda9dac46724c58b734d092391c79867f2fb) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c81c360… Author: Olle E. Johansson <oej(a)edvina.net> Date: Fri May 30 09:20:49 2014 +0100 auth_radius: Improve error message to simplify debugging (cherry picked from commit 6e51019b0a2c60178b9ca03b9bb2a5fef49ca7ba) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2f8f293… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 28 15:47:10 2014 +0200 pkg/rpm: use pkg memory size when checking config in init script - for large configs, check can fail due to low memory (cherry picked from commit 91a362e2f1bae90e2564491560aff8bad5b04564) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=177723a… Author: Konstantin Mosesov <ez(a)voipgroup.org.ua> Date: Sat May 24 05:58:19 2014 +0400 Fixed misstypes and indents in docs. (cherry picked from commit 5bede9a9a77ad01e06d849485d6ce4274eca3fd4) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8375c7f… Author: Konstantin Mosesov <ez(a)voipgroup.org.ua> Date: Sat May 24 05:57:16 2014 +0400 Fixed bug with JAVA_HOME detection. (cherry picked from commit 5a05370f35bdeb7277b2f53f5c3e95fb672d4024) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f2afd02… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Thu May 22 21:07:17 2014 +0200 Core: Bugfix: Do not reset tcp_listeners: We may only listen on TCP. (cherry picked from commit 9b9d15875aa09a5574ff0754309f4f77161d3194) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4267ba4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 21 09:55:46 2014 +0200 core: allow listening on tls without listening on tcp - reported in FS#425 (cherry picked from commit eea7f9d04090a736c8a0f2b2a350c08635cc8e39) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7453f5e… Author: Juha Heinanen <jh(a)tutpro.com> Date: Tue May 20 16:22:58 2014 +0300 modules/siputils: generate error message if parsing of is_gruu() uri fails (cherry picked from commit 365a60772de9c1d2f19ecf52b12f6d75b348e996) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=93fb970… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue May 20 09:16:01 2014 +0200 core: print number of parameters used for searching cfg function (cherry picked from commit a313a8d33afdee6c7eb70cd57161aef8e70c5bcf) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a008e0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 15 12:48:04 2014 +0200 core: use port 5061 for checking self when uri has transport tls - 5060 was used, failing to match myself condition (cherry picked from commit 2e55d7bd218c9f954da7d289ec1be090bb4d88b0) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fdea08a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 15 12:46:14 2014 +0200 topoh: match on all ports if none is in the uri for checking self - forcing default 5060 can fail for multi-listen case and tls (cherry picked from commit 1d90f4de94dfc887cc6129624fd5e6ad989abd37) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a768ffa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:37:54 2014 +0200 kamcmd: proper size for memset, based on malloc (cherry picked from commit 7134959725011baa504a027c4561e0054dd907ae) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c7e14f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:12:33 2014 +0200 rls: proper header define guard and check of null returned value (cherry picked from commit 4f2da3e025fa281f88e80bb841a51d6546219ae8) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=164b17f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:08:06 2014 +0200 ipops: free dns pv structure on invalid pv name (cherry picked from commit e53c715c74fb5b58f4f68b81acb60de66b19b8cc) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=386ef2f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 23:03:19 2014 +0200 db_flatstore: free result before returning null on no more pkg - partial allocation when doing an incomplete new connection (cherry picked from commit 74743d6ef3bf74c1226ba5a1b6bebfbe19b06b93) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5c1002… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 22:56:37 2014 +0200 core: free previous allocated variable if no more pkg to build rve struct - cleaner shut down if not enough memory at startup (cherry picked from commit ace56c6bd2221920b965185c1c9a5997cd3f2768) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8c47852… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed May 14 22:53:35 2014 +0200 pv: proper length for line transformation when handling last line of value (cherry picked from commit f1a09e44268c77641216a78878f2c73c6e5a4d66) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=12a0a92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon May 12 22:54:54 2014 +0200 dialog: if sending BYE fails at timeout, unref dialog - destroy dialog structures (cherry picked from commit e39a90e11bfed2b4445c37db1532488aa9e3e725) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3457dc4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat May 3 21:06:34 2014 +0200 mem/q_malloc: free old pointer if allocation in realloc fails (cherry picked from commit 8c2888fcd33bee45cb4654222da619e70ed44ecc) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ce46f54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat May 3 21:03:34 2014 +0200 mem/f_malloc: free old pointer if allocation in realloc fails (cherry picked from commit 41a37b570758445d723d4d78b9786f8e6cb5722c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2cfb00b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 2 23:58:12 2014 +0200 mem/f_malloc: check returned pointer for bitmask index - if null, reset slot and search on bigger chunks slots (cherry picked from commit 892a24f7256e60e2a0116655e0052c284479b7d2) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6e17d6e… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Sun Apr 27 21:22:49 2014 -0500 cnxcc: fixed deadlock when call gets terminated under certain conditions - fixed some indentation problems introduced by Eclipse IDE (cherry picked from commit d0f0ba702bd44524bc9f52e07341db03267b15f7)

9 years, 10 months

git:master: core: sync definition of destroy_rpcs()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 28be6c3c79c02600f03a51b2393b289fbe8c9bd9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=28be6c3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jun 12 09:59:44 2014 +0200 core: sync definition of destroy_rpcs() - reported by Victor Seva --- rpc_lookup.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rpc_lookup.h b/rpc_lookup.h index 7988e04..53d40b6 100644 --- a/rpc_lookup.h +++ b/rpc_lookup.h @@ -33,7 +33,7 @@ extern rpc_export_t** rpc_sarray; extern int rpc_sarray_crt_size; int init_rpcs(void); -int destroy_rpcs(void); +void destroy_rpcs(void); rpc_export_t* rpc_lookup(const char* name, int len); int rpc_register(rpc_export_t* rpc);

9 years, 10 months

git:master: ims_usrloc_pcscf: Add option, to disable the "received check" upon lookup.

by Carsten Bock

Module: sip-router Branch: master Commit: a9155e4c73d533d0837bfd480ff7d838d18dc995 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a9155e4… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Fri Jun 6 19:09:55 2014 +0200 ims_usrloc_pcscf: Add option, to disable the "received check" upon lookup. --- .../doc/ims_usrloc_pcscf_admin.xml | 27 ++++++++++++++++++++ modules/ims_usrloc_pcscf/udomain.c | 3 +- modules/ims_usrloc_pcscf/ul_mod.c | 4 +++ 3 files changed, 33 insertions(+), 1 deletions(-) diff --git a/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml b/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml index 43c91f8..2bdb7c1 100644 --- a/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml +++ b/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml @@ -204,6 +204,33 @@ modparam("ims_usrloc_pcscf", "hashing_type", 1) </programlisting> </example> </section> + <section> + <title>lookup_check_received (int)</title> + + <para>If set to 1 (default), the Host in the contact will be checked + against the Host, from which the request was received.</para> + + <itemizedlist> + <listitem> + <para>0 - Upon lookup, do not check the host against received.</para> + </listitem> + + <listitem> + <para>1 - Compare the host in the contact against the received info.</para> + </listitem> + </itemizedlist> + + <para><emphasis>Default value is 1.</emphasis></para> + + <example> + <title>Set lookup_check_received parameter</title> + + <programlisting format="linespecific">... +modparam("ims_usrloc_pcscf", "lookup_check_received", 0) +... +</programlisting> + </example> + </section> </section> <section> diff --git a/modules/ims_usrloc_pcscf/udomain.c b/modules/ims_usrloc_pcscf/udomain.c index d655dea..e19b0f4 100644 --- a/modules/ims_usrloc_pcscf/udomain.c +++ b/modules/ims_usrloc_pcscf/udomain.c @@ -63,6 +63,7 @@ extern int db_mode; extern unsigned int hashing_type; +extern int lookup_check_received; #ifdef STATISTICS static char *build_stat_name( str* domain, char *var_name) @@ -471,7 +472,7 @@ int get_pcontact(udomain_t* _d, str* _contact, struct pcontact** _c) { _contact->len, _contact->s); - if ((c->aorhash == aorhash) && (c->aor.len == _contact->len) + if (lookup_check_received && (c->aorhash == aorhash) && (c->aor.len == _contact->len) && !memcmp(c->aor.s, _contact->s, _contact->len)) { *_c = c; return 0; diff --git a/modules/ims_usrloc_pcscf/ul_mod.c b/modules/ims_usrloc_pcscf/ul_mod.c index 998d4bc..d9e2b08 100644 --- a/modules/ims_usrloc_pcscf/ul_mod.c +++ b/modules/ims_usrloc_pcscf/ul_mod.c @@ -85,6 +85,8 @@ int db_mode = 0; /*!< Database sync scheme: 0-no db, 1-write throug int ul_fetch_rows = 2000; int hashing_type = 0; /*!< has type for storing P-CSCF contacts - 0 - use full contact AOR, 1 - use IP:PORT only */ +int lookup_check_received = 1; /*!< Should we check received on lookup? + db1_con_t* ul_dbh = 0; db_func_t ul_dbf; @@ -109,6 +111,8 @@ static param_export_t params[] = { {"timer_interval", INT_PARAM, &timer_interval }, {"db_mode", INT_PARAM, &db_mode }, {"hashing_type", INT_PARAM, &hashing_type }, + {"lookup_check_received", INT_PARAM, &lookup_check_received }, + {0, 0, 0} };

9 years, 10 months

[tracker] Comment added: CRASH: segmentation fault after INVITE

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#439 - CRASH: segmentation fault after INVITE User who did this - Nuno Miguel Reis (nmreis) ---------- Hi Daniel. You were right. That seemed to be the case. I think you can close this one too. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=439#comment1531 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 10 months

[tracker] Comment added: CRASH: segmentation fault if there is no dispatcher available

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#440 - CRASH: segmentation fault if there is no dispatcher available User who did this - Nuno Miguel Reis (nmreis) ---------- Hi Daniel. I did some tests using your fix and kamailio isn't crashing anymore. If i notice the issue again I'll reopen the bug, but for now i would say it's closed. Thanks and keep up with the good work. Cheers, Nuno. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=440#comment1530 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 10 months

[tracker] Task opened: db_unixodbc cannot load more than 1024 bytes from a database field (patch supplied) (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Alex Villacis Lasso (a_villacis) Attached to Project - sip-router Summary - db_unixodbc cannot load more than 1024 bytes from a database field (patch supplied) Task Type - Bug Report Category - libsrdb1 (kamailio) Status - Unconfirmed Assigned To - Operating System - All Severity - Medium Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - When configurin Kamailio 4.1.3 to use db_unixodbc as the database source, several capabilities are broken because they require reading database columns with values exceeding 1024 bytes (essentially any TEXT/BLOB columns). This was first noticed when setting up XCAP document storage. The attached patch solves this for db_unixodbc by allocating a growing amount of memory for fields longer than 1024 bytes. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=443 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 10 months

← Newer
1
...
4
5
6
7
8
9
10
...
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2014