sr-dev June 2014

sr-dev@lists.kamailio.org

21 participants
152 discussions

by Alex Balashov

I'm using the latest rtpengine master and still getting crashes once every 1-2 days on a high call volume installation: (gdb) where #0 0x000000304e232925 in raise () from /lib64/libc.so.6 #1 0x000000304e234105 in abort () from /lib64/libc.so.6 #2 0x000000304e22ba4e in __assert_fail_base () from /lib64/libc.so.6 #3 0x000000304e22bb10 in __assert_fail () from /lib64/libc.so.6 #4 0x0000000000412d50 in stream_packet (fd=<value optimized out>, p= 0x7f1dcc1b1030, u=<value optimized out>) at call.c:547 #5 stream_fd_readable (fd=<value optimized out>, p=0x7f1dcc1b1030, u=<value optimized out>) at call.c:819 #6 0x000000000040b4ce in poller_poll (p=0x10d3750, timeout=<value optimized out>) at poller.c:354 #7 0x000000000040722d in poller_loop (d=0x10d3750) at main.c:542 #8 0x000000000040bb5f in thread_detach_func (d=<value optimized out>) at aux.c:160 #9 0x000000304e6079d1 in start_thread () from /lib64/libpthread.so.0 #10 0x000000304e2e8b6d in clone () from /lib64/libc.so.6 Unfortunately, this packet capture is not very insightful. What's the easiest way to build rtpengine with debug symbols so that some of these values can be filled in? -- Alex Balashov - Principal Evariste Systems LLC Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/ Please be kind to the English language: http://www.entrepreneur.com/article/232906

9 years, 9 months

Kamailio Development Workshop, July 9-10, 2014, Paris, France

by Daniel-Constantin Mierla

Hello, I want to announce the next Kamailio Development Workshop, to take place in Paris, France, during July 9-10, 2014. This event is the next in its series targeting to show the internals of Kamailio and enable more people to become developers as well as let users of Kamailio to get more knowledge about the design of the application which can have relevant impact in operating deployment. Be aware that it is not a workshop about Kamailio installation and administration. Its content is about writing C code to extend Kamailio. More details can be found at: - http://www.kamailio.org/w/2014/06/kamailio-development-workshop-july-9-10-2… Similar to the past events, we are considering to have a social networking event in the evening of July 9 (most probably a dinner meetup at a nice place in Paris), which is open for everyone, each participant taking care of own expenses. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

9 years, 9 months

[tracker] Comment added: modules/tmx: t_is_failure_route() code or documentation is wrong

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#445 - modules/tmx: t_is_failure_route() code or documentation is wrong User who did this - Andrew Pogrebennyk (marduk) ---------- Thank you Daniel. I just tried it again. Not sure if I'm doing anything wrong, but t_is_failure_route() returns false when in branch route. Call flow: when entering failure route, I do append_branch, from there I go to request route that does a few simple operations and arms branch route. Jun 30 18:01:44 sp1 proxy[1116]: NOTICE: <script>: t_is_failure_route in failure route returned TRUE - R=sip:43991001@192.168.51.16 ID=8rhmFoEafzBBk9f9twwlw3ttEy3JImkU Jun 30 18:01:44 sp1 proxy[1116]: NOTICE: <script>: t_is_failure_route in request route returned TRUE - R=sip:43991004@192.168.51.16 ID=8rhmFoEafzBBk9f9twwlw3ttEy3JImkU Jun 30 18:01:44 sp1 proxy[1116]: NOTICE: <script>: t_is_failure_route in branch route returned FALSE - R=sip:43991004@192.168.51.16 ID=8rhmFoEafzBBk9f9twwlw3ttEy3JImkU ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=445#comment1534 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 9 months

[tracker] Task opened: sca_call_info_update() function for 180 responses (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Joao Vitor Arruda (jarruda) Attached to Project - sip-router Summary - sca_call_info_update() function for 180 responses Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - The actual code for sca_call_info_update() function in the SCA Module deal with 180 and 183 response codes in different ways: https://github.com/kamailio/kamailio/blob/master/modules/sca/sca_call_info.… - For 180 responses it will produce a NOTIFY with "appearance-state=alerting"; - For 183 responses it will produce a NOTIFY with "appearance-state=progressing"; Reading the attached "Broadworks SIP Access Side Extensions Interface Specifications, Release 13.0, version 1", which the module use as guide, it looks that both 180 and 183 should produce a NOTIFY with "appearance-state=progressing". This document says: The defined states are: ..... Progressing = This appearance on the line is currently making an outgoing call. Alerting = This appearance is receiving an incoming call. ..... So when processing 180 and 183 responses it should use the same appearance-state (progressing) as it is dealing with responses for an outgoing call. It was noticed that using the "wrong" appearance-state (alerting) when processing 180 responses will lead to problems with Polycom phones using firmware version 4.0.3 as the phones upon receiving the wrong appearance-state will change the display from "To:CalledExtension" to "From:CalledExtension" and record the call in the "Received Calls" instead of "Placed Calls". The attached patch was produced to fix the actual code. One or more files have been attached. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=446 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 9 months

[tracker] Comment added: modules/tmx: t_is_failure_route() code or documentation is wrong

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#445 - modules/tmx: t_is_failure_route() code or documentation is wrong User who did this - Daniel-Constantin Mierla (miconda) ---------- The error message is not related to t_is_failure_route(), but to the variable that gives the reply code associated with the transaction. I committed a patch to deal with $T_reply_code in branch_route. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=445#comment1533 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 9 months

git:master: tmx: handle branch_route for $T_reply_code

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 2e28163f2f3e756c89f8cc43df0644be38c5e06f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2e28163… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 30 14:37:40 2014 +0200 tmx: handle branch_route for $T_reply_code - use latest sent reply code - related to the log message reported in FS#445 --- modules/tmx/t_var.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/tmx/t_var.c b/modules/tmx/t_var.c index 6f7d346..b71c3bb 100644 --- a/modules/tmx/t_var.c +++ b/modules/tmx/t_var.c @@ -487,6 +487,7 @@ int pv_get_tm_reply_code(struct sip_msg *msg, pv_param_t *param, } else { switch (get_route_type()) { case REQUEST_ROUTE: + case BRANCH_ROUTE: /* use the status of the last sent reply */ code = t->uas.status; break;

9 years, 9 months

git:master: kamctl: use DEFAULT_Q variable in ul_add command

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8fac19ba52345a4dd10480ef4efb62012bbbbff6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8fac19b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 30 12:34:24 2014 +0200 kamctl: use DEFAULT_Q variable in ul_add command --- utils/kamctl/kamctl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index aac4533..8fa8ac2 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -2455,7 +2455,7 @@ usrloc() { fi $CTLCMD ul_add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN" "$2" \ -"$UL_EXPIRES" "1.00" "$UL_PATH" "$UL_FLAGS" "$BR_FLAGS" "$ALL_METHODS" +"$UL_EXPIRES" "$DEFAULT_Q" "$UL_PATH" "$UL_FLAGS" "$BR_FLAGS" "$ALL_METHODS" exit $? ;; rm)

9 years, 10 months

git:master: geoip: free allocated pointers at startup in case of error

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5db25855613f922059b53d7149e97b4985120de0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5db2585… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 30 12:11:45 2014 +0200 geoip: free allocated pointers at startup in case of error - cleaner shut down --- modules/geoip/geoip_pv.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules/geoip/geoip_pv.c b/modules/geoip/geoip_pv.c index 6a18461..d2aaf7c 100644 --- a/modules/geoip/geoip_pv.c +++ b/modules/geoip/geoip_pv.c @@ -107,6 +107,7 @@ sr_geoip_item_t *sr_geoip_add_item(str *name) if(it->pvclass.s==NULL) { LM_ERR("no more pkg.\n"); + pkg_free(it); return NULL; } memcpy(it->pvclass.s, name->s, name->len); @@ -220,6 +221,9 @@ int pv_parse_geoip_name(pv_spec_p sp, str *in) return 0; error: + if(gpv!=NULL) + pkg_free(gpv); + LM_ERR("error at PV geoip name: %.*s\n", in->len, in->s); return -1; }

9 years, 10 months

git:master: core: reset cur_opt shortcut after use, it points to local variable

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 1faf19fa7d34528b6cc15ffcb1ec91a6c6074e90 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1faf19f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 30 12:05:19 2014 +0200 core: reset cur_opt shortcut after use, it points to local variable - safety to prevent invalid access on future extensions --- cfg_parser.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cfg_parser.c b/cfg_parser.c index fa8721b..594eb8e 100644 --- a/cfg_parser.c +++ b/cfg_parser.c @@ -732,7 +732,8 @@ int sr_cfg_parse(cfg_parser_t* st) } st->cur_opt = &t; - if (process_option(st, opt) < 0) return -1; + if (process_option(st, opt) < 0) { st->cur_opt = 0; return -1; } + st->cur_opt = 0; break; case '[':

9 years, 10 months

git:4.1: uac: print new and old uri in log message in case of error

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: 84c1ff056abf33c0ed8ed666d81d9e3e80cfaabb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=84c1ff0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 30 11:06:41 2014 +0200 uac: print new and old uri in log message in case of error (cherry picked from commit 6feeb886b58f4cd1cefeef132245c009bf8ca07f) --- modules/uac/replace.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/uac/replace.c b/modules/uac/replace.c index 3c78abe..f8285c6 100644 --- a/modules/uac/replace.c +++ b/modules/uac/replace.c @@ -587,7 +587,8 @@ int restore_uri( struct sip_msg *msg, str *rr_param, str* restore_avp, int check /* get new uri */ if ( new_uri.len<old_uri.len ) { - LM_ERR("new URI shorter than old URI\n"); + LM_ERR("new URI [%.*s] shorter than old URI [%.*s]\n", + new_uri.len, new_uri.s, old_uri.len, old_uri.s); goto failed; } for( i=0 ; i<old_uri.len ; i++ ) {

9 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2014