sr-dev June 2014

sr-dev@lists.kamailio.org

21 participants
152 discussions

[tracker] Comment added: memory leak in mysql module (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- Attached is the proposed patch ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1501 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Comment added: memory leak in mysql module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- I think I have a theory regarding the leak.... in linb/srdb1/db.c the code is as follows <code> id = new_db_id(url, pooling); if (!id) { LM_ERR("cannot parse URL '%.*s'\n", url->len, url->s); goto err; } /* Find the connection in the pool */ con = pool_get(id); if (!con) { LM_DBG("connection %p not found in pool\n", id); /* Not in the pool yet */ con = new_connection(id); if (!con) { LM_ERR("could not add connection to the pool"); goto err; } pool_insert((struct pool_con*)con); } else { LM_DBG("connection %p found in pool\n", id); } </code> In the case a new connection is made, the connection will have the reference to the id object you just allocated. In the case a connection is found from the pool, the connection will have a reference to a previously allocated id object, and the id created by new_db_id should be freed I suggest that in the case be modified as follows <code> } else { LM_DBG("connection %p found in pool\n", id); free_db_id(id); // free the new id, as we use the pool instead id = 0; } </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1500 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

git:master: modules/ims_charging: improvement on failed CCR during initial routing ( no longer just wait for timeout)

by Jason Penton

Module: sip-router Branch: master Commit: c4e2df2b494a80ff8493fcc5df66b75478c31789 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c4e2df2… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Mon Jun 2 11:07:02 2014 +0200 modules/ims_charging: improvement on failed CCR during initial routing (no longer just wait for timeout) - some minor cleanup too --- modules/ims_charging/ims_ro.c | 46 ++++++++++++++++++++++++++++------------ 1 files changed, 32 insertions(+), 14 deletions(-) diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index ef1f6e4..ef324f1 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -477,7 +477,7 @@ void send_ccr_interim(struct ro_session* ro_session, unsigned int used, unsigned subscription_id_t subscr; time_stamps_t *time_stamps; struct interim_ccr *i_req = shm_malloc(sizeof(struct interim_ccr)); - + int ret = 0; event_type_t *event_type; int node_role = 0; @@ -590,11 +590,14 @@ void send_ccr_interim(struct ro_session* ro_session, unsigned int used, unsigned cdpb.AAASessionsUnlock(auth->hash); if (ro_forced_peer.len > 0) { - cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_interim_ccr, (void *) i_req); + ret = cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_interim_ccr, (void *) i_req); } else { - cdpb.AAASendMessage(ccr, resume_on_interim_ccr, (void *) i_req); + ret = cdpb.AAASendMessage(ccr, resume_on_interim_ccr, (void *) i_req); } + if (ret != 1) { + goto error; + } // cdpb.AAASessionsUnlock(auth->hash); Ro_free_CCR(ro_ccr_data); @@ -703,6 +706,7 @@ void send_ccr_stop(struct ro_session *ro_session) { time_stamps_t *time_stamps; unsigned int used = 0; str user_name = {0, 0}; + int ret = 0; if (ro_session->event_type != pending) { used = time(0) - ro_session->last_event_timestamp; @@ -814,9 +818,13 @@ void send_ccr_stop(struct ro_session *ro_session) { cdpb.AAASessionsUnlock(auth->hash); if (ro_forced_peer.len > 0) { - cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_termination_ccr, NULL); + ret = cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_termination_ccr, NULL); } else { - cdpb.AAASendMessage(ccr, resume_on_termination_ccr, NULL); + ret = cdpb.AAASendMessage(ccr, resume_on_termination_ccr, NULL); + } + + if (ret != 1) { + goto error1; } Ro_free_CCR(ro_ccr_data); @@ -869,14 +877,13 @@ static void resume_on_termination_ccr(int is_timeout, void *param, AAAMessage *c LM_DBG("Valid CCA response for STOP record\n"); } -// Ro_free_CCA(ro_cca_data); -// cdpb.AAAFreeMessage(&cca); - update_stat(successful_final_ccrs, 1); error: Ro_free_CCA(ro_cca_data); - cdpb.AAAFreeMessage(&cca); + if (!is_timeout && cca) { + cdpb.AAAFreeMessage(&cca); + } } @@ -905,14 +912,20 @@ int Ro_Send_CCR(struct sip_msg *msg, struct dlg_cell *dlg, int dir, str* charge_ Ro_CCR_t * ro_ccr_data = 0; AAAMessage * ccr = 0; struct ro_session *new_session = 0; - struct session_setup_data *ssd = shm_malloc(sizeof(struct session_setup_data)); // lookup structure used to load session info from cdp callback on CCA - + struct session_setup_data *ssd; + int ret = 0; struct hdr_field *h=0; int cc_event_number = 0; //According to IOT tests this should start at 0 int cc_event_type = RO_CC_START; int free_called_asserted_identity = 0; + ssd = shm_malloc(sizeof(struct session_setup_data)); // lookup structure used to load session info from cdp callback on CCA + if (!ssd) { + LM_ERR("no more shm mem\n"); + goto error; + } + //getting asserted identity if ((asserted_identity = cscf_get_asserted_identity(msg, 0)).len == 0) { LM_DBG("No P-Asserted-Identity hdr found. Using From hdr for asserted_identity"); @@ -1020,10 +1033,15 @@ int Ro_Send_CCR(struct sip_msg *msg, struct dlg_cell *dlg, int dir, str* charge_ if (ro_forced_peer.len > 0) { LM_DBG("Sending message with Peer\n"); - cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_initial_ccr, (void *) ssd); + ret = cdpb.AAASendMessageToPeer(ccr, &ro_forced_peer, resume_on_initial_ccr, (void *) ssd); } else { LM_DBG("Sending message without Peer and realm is [%.*s]\n", ccr->dest_realm->data.len, ccr->dest_realm->data.s); - cdpb.AAASendMessage(ccr, resume_on_initial_ccr, (void *) ssd); + ret = cdpb.AAASendMessage(ccr, resume_on_initial_ccr, (void *) ssd); + } + + if (ret != 1) { + LM_ERR("Failed to send Diameter CCR\n"); + goto error; } Ro_free_CCR(ro_ccr_data); @@ -1054,7 +1072,7 @@ error: } if (ssd) - pkg_free(ssd); + shm_free(ssd); LM_DBG("Trying to reserve credit on initial INVITE failed.\n"); return RO_RETURN_ERROR;

9 years, 11 months

[tracker] Comment added: memory leak in mysql module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- Reproduced the leak in the lab... won't paste the full output as it's massive but there seems to be 4 objects leaking here is a subset of the output showing 2 examples of each leak Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23724. N address=0x7fc02f560e88 frag=0x7fc02f560e58 size=160 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: new_db_id(254) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23725. N address=0x7fc02f560f88 frag=0x7fc02f560f58 size=16 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23726. N address=0x7fc02f560ff8 frag=0x7fc02f560fc8 size=48 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23727. N address=0x7fc02f561088 frag=0x7fc02f561058 size=16 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23728. N address=0x7fc02f5610f8 frag=0x7fc02f5610c8 size=48 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23729. N address=0x7fc02f561188 frag=0x7fc02f561158 size=160 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: new_db_id(254) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23730. N address=0x7fc02f561288 frag=0x7fc02f561258 size=16 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23731. N address=0x7fc02f5612f8 frag=0x7fc02f5612c8 size=48 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23732. N address=0x7fc02f561388 frag=0x7fc02f561358 size=16 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23733. N address=0x7fc02f5613f8 frag=0x7fc02f5613c8 size=48 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23734. N address=0x7fc02f561488 frag=0x7fc02f561458 size=16 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: 23735. N address=0x7fc02f5614f8 frag=0x7fc02f5614c8 size=48 used=1 Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: alloc'd from <core>: db_id.c: dupl_string(50) Jun 2 06:23:02 bebr0lbr02 /usr/sbin/kamailio[12216]: ALERT: qm_status: start check=f0f0f0f0, end check= c0c0c0c0, abcdefed ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1499 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Comment added: CRASH: dialog module out of bounds issue

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#438 - CRASH: dialog module out of bounds issue User who did this - Daniel-Constantin Mierla (miconda) ---------- Again, this seems to be same as: - http://sip-router.org/tracker/index.php?do=details&task_id=427&project=1 Patch to fix it is now in branch 4.1. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=438#comment1498 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Task closed: kamailio sometimes crash when handling failure events

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch backported to branch 4.1 as well. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

[tracker] Comment added: CRASH: BUG: qm_free: freeing already freed pointer (0x7fcaeaee3ac0), called from dialog: dlg_cb.c

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#437 - CRASH: BUG: qm_free: freeing already freed pointer (0x7fcaeaee3ac0), called from dialog: dlg_cb.c User who did this - Daniel-Constantin Mierla (miconda) ---------- This seems to be same as: - http://sip-router.org/tracker/index.php?do=details&task_id=427&project=1 I backported the patch in branch 4.1. Can you try it? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=437#comment1497 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 11 months

git:4.1: dialog: add wait-for-ack callback before response unref

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: 642428cf8be1c7355f91b14276e888ec505cd69a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=642428c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon May 19 08:56:38 2014 +0200 dialog: add wait-for-ack callback before response unref - in case of a sipral for ending in a negative response from initial state, ack to second iteration can unref prematurely the dialog - reported by Pawel Sternal, FS#427 (cherry picked from commit d81fd1bf067b78b55ad348db2531c4ba9b10dddb) --- modules/dialog/dlg_handlers.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/dialog/dlg_handlers.c b/modules/dialog/dlg_handlers.c index 9393d7f..239f442 100644 --- a/modules/dialog/dlg_handlers.c +++ b/modules/dialog/dlg_handlers.c @@ -543,6 +543,8 @@ static void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) LM_DBG("dialog %p failed (negative reply)\n", dlg); /* dialog setup not completed (3456XX) */ run_dlg_callbacks( DLGCB_FAILED, dlg, req, rpl, DLG_DIR_UPSTREAM, 0); + if(dlg_wait_ack==1) + dlg_set_tm_waitack(t, dlg); /* do unref */ if (unref) dlg_unref(dlg, unref); @@ -551,8 +553,6 @@ static void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) if_update_stat(dlg_enable_stats, failed_dlgs, 1); - if(dlg_wait_ack==1) - dlg_set_tm_waitack(t, dlg); goto done; }

9 years, 11 months

FS#438 - CRASH: dialog module out of bounds issue

by Nuno Reis

Hi guys. I 've just opened a new bug report for another kamailio CRASH, probably caused by the same issue as in FS#437. If you need anything else from me just le me know. Looking forward to hear from you. Best Regards, -- *Nuno Miguel Reis* | *Unified Communication** Systems* M. +351 913907481 | nreis(a)wavecom.pt WAVECOM-Soluções Rádio, S.A. Cacia Park | Rua do Progresso, Lote 15 3800-639 AVEIRO | Portugal T. +351 309 700 225 | F. +351 234 919 191 *GPS <http://maps.google.com/maps/ms?msa=0&msid=202333747613191340808.0004b4b227a…> | www.wavecom.pt <http://www.wavecom.pt/>** <http://www.wavecom.pt/>* [image: Description: Description: WavecomSignature] <http://www.wavecom.pt/pt/wavecom/premios.php> [image: Publicity] <http://www.wavecom.pt/pt/mail_eventos.php> On Sun, Jun 1, 2014 at 2:58 AM, Nuno Reis <nreis(a)wavecom.pt> wrote: > Hi guys. > > I've just opened a bug FS#437 about a kamailio CRASH. > Please let me know if anything else is needed from me. It seems to be > related with an out of bounds situation in dialog module. > Looking forward to hear from you. > > Best Regards, > > -- > > *Nuno Miguel Reis* | *Unified Communication** Systems* > M. +351 913907481 | nreis(a)wavecom.pt > WAVECOM-Soluções Rádio, S.A. > Cacia Park | Rua do Progresso, Lote 15 > 3800-639 AVEIRO | Portugal > T. +351 309 700 225 | F. +351 234 919 191 > *GPS > <http://maps.google.com/maps/ms?msa=0&msid=202333747613191340808.0004b4b227a…> > | www.wavecom.pt <http://www.wavecom.pt/>** <http://www.wavecom.pt/>* > > [image: Description: Description: WavecomSignature] > <http://www.wavecom.pt/pt/wavecom/premios.php> > > [image: Publicity] <http://www.wavecom.pt/pt/mail_eventos.php> > > >

9 years, 11 months

FS#437 - CRASH: BUG: qm_free: freeing already freed pointer (0x7fcaeaee3ac0), called from dialog: dlg_cb.c

by Nuno Reis

Hi guys. I've just opened a bug FS#437 about a kamailio CRASH. Please let me know if anything else is needed from me. It seems to be related with an out of bounds situation in dialog module. Looking forward to hear from you. Best Regards, -- *Nuno Miguel Reis* | *Unified Communication** Systems* M. +351 913907481 | nreis(a)wavecom.pt WAVECOM-Soluções Rádio, S.A. Cacia Park | Rua do Progresso, Lote 15 3800-639 AVEIRO | Portugal T. +351 309 700 225 | F. +351 234 919 191 *GPS <http://maps.google.com/maps/ms?msa=0&msid=202333747613191340808.0004b4b227a…> | www.wavecom.pt <http://www.wavecom.pt/>** <http://www.wavecom.pt/>* [image: Description: Description: WavecomSignature] <http://www.wavecom.pt/pt/wavecom/premios.php> [image: Publicity] <http://www.wavecom.pt/pt/mail_eventos.php>

9 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2014