sr-dev May 2014

sr-dev@lists.kamailio.org

34 participants
238 discussions

git:master: modules/cdp: omitted last_selected time when choosing a loadbalanced peer
by Jason Penton 30 May '14

30 May '14

Module: sip-router Branch: master Commit: 70f7dbedd7c7f188270bf6d3649bd9d67d4c2b7e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=70f7dbe… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri May 30 16:51:20 2014 +0200 modules/cdp: omitted last_selected time when choosing a loadbalanced peer --- modules/cdp/routing.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/cdp/routing.c b/modules/cdp/routing.c index 499519a..a0fd7f3 100644 --- a/modules/cdp/routing.c +++ b/modules/cdp/routing.c @@ -123,6 +123,7 @@ peer* get_first_connected_route(routing_entry *r,int app_id,int vendor_id) } } + p->last_selected = time(NULL); return p; }

1 0

[tracker] Comment added: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- command not found.... apparently it's because I don't load the cfg_rpc module in my config I'll look to see if I can reproduce it in the with the module loaded, but that's going to take a bit of time :-) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1490 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you run: kamcmd cfg.set_now_int core mem_dump_pkg 10470 Then what the logs for memory dump and attach it to see if there is a leak around. If you don't have anymore that instance, then take the pid of the MI FIFO process. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1489 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- log analysis indicates the issue happened after 3 days ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1488 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Torrey Searle (tsearle) ---------- Using kamailio 4.1.1 + mysql patches backported Process:: ID=0 PID=10463 Type=attendant Process:: ID=1 PID=10464 Type=udp receiver child=0 sock=*******************:5060 Process:: ID=2 PID=10465 Type=udp receiver child=1 sock=*******************:5060 Process:: ID=3 PID=10466 Type=udp receiver child=2 sock=*******************:5060 Process:: ID=4 PID=10467 Type=udp receiver child=3 sock=*******************:5060 Process:: ID=5 PID=10468 Type=slow timer Process:: ID=6 PID=10469 Type=timer Process:: ID=7 PID=10470 Type=MI FIFO Process:: ID=8 PID=10471 Type=ctl handler Process:: ID=9 PID=10472 Type=WEBSOCKET KEEPALIVE Process:: ID=10 PID=10473 Type=tcp receiver (generic) child=0 Process:: ID=11 PID=10474 Type=tcp receiver (generic) child=1 Process:: ID=12 PID=10475 Type=tcp receiver (generic) child=2 Process:: ID=13 PID=10476 Type=tcp receiver (generic) child=3 Process:: ID=14 PID=10477 Type=tcp main process { entry: 0 pid: 10463 rank: 0 used: 505640 free: 3272752 real_used: 921552 } { entry: 1 pid: 10464 rank: 1 used: 515696 free: 3249064 real_used: 945240 } { entry: 2 pid: 10465 rank: 2 used: 515696 free: 3252232 real_used: 942072 } { entry: 3 pid: 10466 rank: 3 used: 515888 free: 3248968 real_used: 945336 } { entry: 4 pid: 10467 rank: 4 used: 515696 free: 3252040 real_used: 942264 } { entry: 5 pid: 10468 rank: -1 used: 3073920 free: 3262384 real_used: 4071592 } { entry: 6 pid: 10469 rank: -1 used: 2977416 free: 3262384 real_used: 3975088 } { entry: 7 pid: 0 rank: 0 used: 1687016 free: 112 real_used: 4194192 } { entry: 8 pid: 10471 rank: -2 used: 514632 free: 3262608 real_used: 931696 } { entry: 9 pid: 10472 rank: -1 used: 515712 free: 3262008 real_used: 932296 } { entry: 10 pid: 10473 rank: 5 used: 3103312 free: 3177328 real_used: 4073528 } { entry: 11 pid: 10474 rank: 6 used: 3061104 free: 3177336 real_used: 4058776 } { entry: 12 pid: 10475 rank: 7 used: 592520 free: 3177232 real_used: 1017072 } { entry: 13 pid: 10476 rank: 8 used: 3065392 free: 3177416 real_used: 4062008 } { entry: 14 pid: 10477 rank: -4 used: 3005992 free: 3192712 real_used: 4003664 } from this I can infer that the leak is due to the address reload cron * * * * * kamailio /usr/sbin/kamctl fifo address_reload ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1487 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#436 - memory leak in mysql module User who did this - Daniel-Constantin Mierla (miconda) ---------- What version do you have? What command do you use for reloading? Is it showing up quickly? Can you give the output for: kamctl ps kamcmd pkg.stats ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436#comment1486 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: memory leak in mysql module
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Torrey Searle (tsearle) Attached to Project - sip-router Summary - memory leak in mysql module Task Type - Bug Report Category - DB interface Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - after running kamailio with a per-minute reload of the address module I eventually get the following error ERROR: db_mysql [km_res.c:81]: db_mysql_get_columns(): no private memory left ERROR: db_mysql [km_res.c:214]: db_mysql_convert_result(): error while getting column names ERROR: db_mysql [km_dbase.c:191]: db_mysql_store_result(): error while converting result This is the case even with the patch of 37983c9f57536c57c5d34ce2d8a1c8f411e61e39 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=436 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

t_relay explanations
by Olle E. Johansson 30 May '14

30 May '14

Hi! Got a minute to explore the old wiki and found a very interesting document: http://www.kamailio.org/dokuwiki/doku.php/troubleshooting:tm:t_relay In this document, Juha and Iñaki discusses how t_relay REALLY works and in which cases the failure_route is executed. Is this document still valid? Do we still have to document this in TM? Are any of these issues fixed in the code? Maybe we should copy the document over to the new wiki. /O

2 1

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Daniel-Constantin Mierla (miconda) ---------- The issue was when parsing the line: a=rtpmap:9 G700 According to the rfc4566, the format of the line is: a=rtpmap:<payload type> <encoding name>/<clock rate> [/<encoding parameters>] The clock rate is missing and the parser was not handling properly this case. I pushed a fix with the commit: - http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c842bda… Needs a bit of testing before backporting, I had not time yet, I will do it soon, but feedback is welcome. Also, there is some room for improvement around that sdp parsing. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1485 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core/parse/sdp: proper parsing of a=rtpmap line
by Daniel-Constantin Mierla 30 May '14

30 May '14

Module: sip-router Branch: master Commit: c842bda9dac46724c58b734d092391c79867f2fb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c842bda… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 30 13:34:08 2014 +0200 core/parse/sdp: proper parsing of a=rtpmap line - error handling when malformed line, avoiding crash to due to invalid offsetting when clockrate is missing - reported by Michael Ricordeau, FS#435 --- parser/sdp/sdp_helpr_funcs.c | 34 ++++++++++++++++++---------------- 1 files changed, 18 insertions(+), 16 deletions(-) diff --git a/parser/sdp/sdp_helpr_funcs.c b/parser/sdp/sdp_helpr_funcs.c index 64868c1..6436b85 100644 --- a/parser/sdp/sdp_helpr_funcs.c +++ b/parser/sdp/sdp_helpr_funcs.c @@ -142,6 +142,10 @@ other: +/** + * rfc4566: + * a=rtpmap:<payload type> <encoding name>/<clock rate> [/<encoding parameters>] + */ int extract_rtpmap(str *body, str *rtpmap_payload, str *rtpmap_encoding, str *rtpmap_clockrate, str *rtpmap_parmas) { @@ -179,30 +183,28 @@ int extract_rtpmap(str *body, rtpmap_encoding->s = cp; cp1 = (char*)ser_memmem(cp, "/", len, 1); - len -= cp1 - cp; - if (len <= 0 || cp == cp1) { - LM_ERR("invalid encoding in `a=rtpmap'\n"); + if(cp1==NULL) { + LM_ERR("invalid encoding in `a=rtpmap' at [%.*s]\n", len, cp); return -1; } + len -= cp1 - cp; rtpmap_encoding->len = cp1 - cp; - cp = cp1; + cp = cp1+1; /* skip '/' */ + len--; + rtpmap_clockrate->s = cp; cp1 = (char*)ser_memmem(cp, "/", len, 1); - len -= cp1 - cp; - if (len <= 0) { - LM_ERR("invalid encoding in `a=rtpmap:'\n"); - return -1; - } - - rtpmap_clockrate->s = cp + 1; /* skip '/' */ - rtpmap_clockrate->len = len -1; /* skip '/' */ - if ( cp == cp1) { + if(cp1==NULL) { + /* no encoding parameters */ + rtpmap_clockrate->len = len; rtpmap_parmas->s = NULL; rtpmap_parmas->len = 0; - } else { - rtpmap_parmas->s = cp1 + 1; - rtpmap_parmas->len = cp1 - cp; + return 0; } + rtpmap_clockrate->len = cp1 - cp; + len -= cp1 - cp; + rtpmap_parmas->s = cp1 + 1; /* skip '/' */ + rtpmap_parmas->len = len - 1; return 0; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2014