sr-dev April 2014

sr-dev@lists.kamailio.org

26 participants
304 discussions

git:master: mi_rpc: don' t access fields in structure after free in mi_rpc_async_close()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f619a813ef46c76dd25c50b86f8af6cd768ac38f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f619a81… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:50:17 2014 +0200 mi_rpc: don't access fields in structure after free in mi_rpc_async_close() --- modules/mi_rpc/mi_rpc_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/mi_rpc/mi_rpc_mod.c b/modules/mi_rpc/mi_rpc_mod.c index 7a9bd77..c1a6f2a 100644 --- a/modules/mi_rpc/mi_rpc_mod.c +++ b/modules/mi_rpc/mi_rpc_mod.c @@ -323,8 +323,8 @@ static void mi_rpc_async_close(struct mi_root* mi_rpl, if (dctx==0){ BUG("null dctx\n"); shm_free(mi_h->param); - shm_free(mi_h); mi_h->param=0; + shm_free(mi_h); goto error; } mode=((struct mi_rpc_handler_param*)mi_h->param)->mode;

10 years, 8 months

git:master: htable: init allocated memory after checking parameter

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 9f042bb2798f29d476148ab2887a05709d5258fc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f042bb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:52:16 2014 +0200 htable: init allocated memory after checking parameter - avoid useless operation and extra check for leak --- modules/htable/htable.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/htable/htable.c b/modules/htable/htable.c index 7270416..63262c0 100644 --- a/modules/htable/htable.c +++ b/modules/htable/htable.c @@ -266,12 +266,12 @@ static int fixup_ht_key(void** param, int param_no) pv_spec_t *sp; str s; - sp = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); if(param_no != 1) { LM_ERR("invalid parameter number %d\n", param_no); return -1; } + sp = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); if (sp == 0) { LM_ERR("no pkg memory left\n");

10 years, 8 months

git:master: nathelper: free local variable if getting anchor for contact header fails

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f2d95b0e8326ae7d61b31288d3b695e1db85ec77 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f2d95b0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:49:27 2014 +0200 nathelper: free local variable if getting anchor for contact header fails --- modules/nathelper/nathelper.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules/nathelper/nathelper.c b/modules/nathelper/nathelper.c index c34beee..9a76550 100644 --- a/modules/nathelper/nathelper.c +++ b/modules/nathelper/nathelper.c @@ -906,8 +906,10 @@ set_contact_alias_f(struct sip_msg* msg, char* str1, char* str2) offset = c->uri.s - msg->buf; anchor = del_lump(msg, offset, c->uri.len, HDR_CONTACT_T); - if (anchor == 0) + if (anchor == 0) { + pkg_free(buf); return -1; + } if (insert_new_lump_after(anchor, buf, len, HDR_CONTACT_T) == 0) { pkg_free(buf); @@ -2350,6 +2352,7 @@ add_rcv_param_f(struct sip_msg* msg, char* str1, char* str2) } if (anchor == NULL) { LM_ERR("anchor_lump failed\n"); + pkg_free(param); return -1; }

10 years, 8 months

git:master: rr: free forgotten allocated local variable trans in case of error

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: ed60b891f915017b385a722f2a9c0bf171802eab URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ed60b89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:47:06 2014 +0200 rr: free forgotten allocated local variable trans in case of error --- modules/rr/record.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/rr/record.c b/modules/rr/record.c index 33da5bc..3ccd452 100644 --- a/modules/rr/record.c +++ b/modules/rr/record.c @@ -714,6 +714,7 @@ static inline int build_advertised_rr(struct lump* _l, struct lump* _l2, str *_d return 1; lump_err: if (hdr) pkg_free(hdr); + if (trans) pkg_free(trans); if (suffix) pkg_free(suffix); if (term) pkg_free(term); if (r2) pkg_free(r2);

10 years, 8 months

git:master: pv: removed mistaken pkg_malloc() left for $cnt()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b6b023038452a7cb1ded28bf82f81622b34ce201 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b6b0230… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:44:42 2014 +0200 pv: removed mistaken pkg_malloc() left for $cnt() --- modules/pv/pv_core.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/pv/pv_core.c b/modules/pv/pv_core.c index ecf956a..3f48830 100644 --- a/modules/pv/pv_core.c +++ b/modules/pv/pv_core.c @@ -2593,6 +2593,9 @@ int pv_set_xto_attr(struct sip_msg* msg, pv_param_t *param, LM_ERR("failed to set xto attribute %d\n", type); goto error; } + } else { + if(buf.s!=0) + pkg_free(buf.s); } return 0; @@ -2780,7 +2783,6 @@ int pv_parse_cnt_name(pv_spec_p sp, str *in) return -1; pv = pv_cache_get(in); - pv = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); if(pv==NULL) { LM_ERR("cannot find pv name [%.*s]\n", in->len, in->s); return -1;

10 years, 8 months

git:master: sipcapture: free proper db_url field and destroy capture mode data list

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 0a1acc7cbf21e2332ca25d94bb320a3b8708357c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0a1acc7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:45:46 2014 +0200 sipcapture: free proper db_url field and destroy capture mode data list --- modules/sipcapture/sipcapture.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/sipcapture/sipcapture.c b/modules/sipcapture/sipcapture.c index f89b98c..afea32b 100644 --- a/modules/sipcapture/sipcapture.c +++ b/modules/sipcapture/sipcapture.c @@ -1054,15 +1054,17 @@ static void destroy(void) /*free content from the linked list*/ _capture_mode_data_t * c; + _capture_mode_data_t * c0; c = capture_modes_root; while (c){ + c0 = c; if (c->name.s){ pkg_free(c->name.s); } if (c->db_url.s){ - pkg_free(c->name.s); + pkg_free(c->db_url.s); } if (c->db_con){ c->db_funcs.close(c->db_con); @@ -1072,7 +1074,7 @@ static void destroy(void) } pkg_free(c); - c = c->next; + c = c0->next; } if (capture_on_flag)

10 years, 8 months

git:master: textops: cleanup on error parsing methods at startup

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cee4b58e1728be7de2c15ae25c4c1be0dd3088fb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cee4b58… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:43:59 2014 +0200 textops: cleanup on error parsing methods at startup --- modules/textops/textops.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/textops/textops.c b/modules/textops/textops.c index 168a8ac..12bcf88 100644 --- a/modules/textops/textops.c +++ b/modules/textops/textops.c @@ -1740,6 +1740,7 @@ static int fixup_method(void** param, int param_no) { LM_ERR("unknown method in list [%.*s/%d] - must be only defined methods\n", s->len, s->s, method); + pkg_free(s); return E_UNSPEC; } LM_DBG("using id for methods [%.*s/%d]\n",

10 years, 8 months

git:master: tls: free the file path clone when all went ok

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5fe289cae2ece412eeaec4efefcb411a7ed434aa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fe289c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:43:05 2014 +0200 tls: free the file path clone when all went ok --- modules/tls/tls_config.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/tls/tls_config.c b/modules/tls/tls_config.c index 917d5d6..fa52800 100644 --- a/modules/tls/tls_config.c +++ b/modules/tls/tls_config.c @@ -423,6 +423,7 @@ tls_domains_cfg_t* tls_load_config(str* filename) cfg_section_parser(parser, parse_domain, NULL); if (sr_cfg_parse(parser)) goto error; cfg_parser_close(parser); + if (file_path) pkg_free(file_path); return cfg; error:

10 years, 8 months

git:master: tm: clean contacts in case of failure in t_load_contacts()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 09ebe81a4ccb4346af778cc21c789b0db0e193d9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=09ebe81… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:41:59 2014 +0200 tm: clean contacts in case of failure in t_load_contacts() --- modules/tm/t_serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/tm/t_serial.c b/modules/tm/t_serial.c index 817a303..8c9e131 100644 --- a/modules/tm/t_serial.c +++ b/modules/tm/t_serial.c @@ -309,6 +309,7 @@ int t_load_contacts(struct sip_msg* msg, char* key, char* value) len = MAX_SOCKET_STR - 1; if (socket2str(sock_buf, &len, curr->sock) < 0) { LM_ERR("failed to convert socket to str\n"); + free_contact_list(contacts); return -1; } sock_buf[len] = 0;

10 years, 8 months

git:master: xhttp: wrong variable was used for checking memory allocation

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8589936aac4a6341b4d56bfe2ed7d4d90a169d56 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8589936… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 21:41:00 2014 +0200 xhttp: wrong variable was used for checking memory allocation --- modules/xhttp/xhttp_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/xhttp/xhttp_mod.c b/modules/xhttp/xhttp_mod.c index 9848892..eea8bda 100644 --- a/modules/xhttp/xhttp_mod.c +++ b/modules/xhttp/xhttp_mod.c @@ -385,7 +385,7 @@ static int xhttp_send_reply(sip_msg_t *msg, int code, str *reason, tbuf.len=sizeof("Content-Type: ") - 1 + ctype->len + CRLF_LEN; tbuf.s=pkg_malloc(sizeof(char)*(tbuf.len)); - if (tbuf.len==0) + if (tbuf.s==0) { LM_ERR("out of pkg memory\n"); return -1;

10 years, 8 months

← Newer
1
...
12
13
14
15
16
17
18
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2014