sr-dev March 2014

sr-dev@lists.kamailio.org

29 participants
300 discussions

[tracker] Task closed: Crash in asynchronous processing
by sip-router 04 Mar '14

04 Mar '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#400 - Crash in asynchronous processing User who did this - Carsten Bock (carstenbock) Reason for closing: Fixed Additional comments about closing: Tested: OK. Thanks! More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=400 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: ims_registrar_pcscf: Make sure, the contact stays NULL if the ip, port or reg_state is incorrect.
by Carsten Bock 04 Mar '14

04 Mar '14

Module: sip-router Branch: master Commit: 01cd0a309ea85eaf6509e5266a825f6ffb834964 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=01cd0a3… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Tue Mar 4 15:51:04 2014 +0100 ims_registrar_pcscf: Make sure, the contact stays NULL if the ip,port or reg_state is incorrect. --- modules/ims_registrar_pcscf/service_routes.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c index 452548a..6360aab 100644 --- a/modules/ims_registrar_pcscf/service_routes.c +++ b/modules/ims_registrar_pcscf/service_routes.c @@ -142,6 +142,8 @@ pcontact_t * getContactP(struct sip_msg* _m, udomain_t* _d) { break; c = NULL; } + } else { + c = NULL; } } }

1 0

New official Debian and Ubuntu repository
by Victor Seva 04 Mar '14

04 Mar '14

The new build system for Debian and Ubuntu packages is now in place. This service is kindly sponsored by SipWise [0] thanks to Andreas Granig [1]. Sipwise is providing the hosting and man power to create and manage this new system. deb.kamailio.org is based on jenkins-debian-glue[2] project running on AWS EC2 environment thanks to Michael Prokop [3] and myself. All the needed files, scripts and info to reproduce this system is kept public at [4]. In [5] is described all the repositories available. * nightly builds are been built if a change is detected in the branch, once by night. - kamailiodev-nightly branch: - 'master' distributions: jessie, wheezy, squeeze, precise - kamailio41-nightly branch: - '4.1' distributions: jessie, wheezy, squeeze, precise - kamailio40-nightly branch: - '4.0' distributions: lenny, squeeze, wheezy, lucid, precise - kamailio33-nightly branch: - '3.3' distributions: lenny, squeeze, wheezy, lucid, precise * tags are been built if a new tag is detected once by night. - kamailio41 branch: - '*/tags/4.1*' distributions: jessie, wheezy, squeeze, precise - kamailio40 branch: - '*/tags/4.0*' distributions: lenny, squeeze, wheezy, lucid, precise - kamailio33 branch: - '*/tags/3.3*' distributions: lenny, squeeze, wheezy, lucid, precise Now there is no 4.1.1 package built so the default kamailio repository is pointing to a empty repository. As soon as we release 4.1.2 this will be fixed. Regards, Victor Seva ( kamailio admin hat on ) [0] http://www.sipwise.com/ [1] http://www.kamailio.org/w/andreas-granig/ [2] https://github.com/mika/jenkins-debian-glue [3] http://michael-prokop.at/ [4] https://github.com/sipwise/kamailio-deb-jenkins [5] http://deb.kamailio.org/index.html

3 2

[tracker] Comment added: NATHELPER module to support RFC6598
by sip-router 04 Mar '14

04 Mar '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#402 - NATHELPER module to support RFC6598 User who did this - Klaus Darilion (klaus3000) ---------- Indeed: from the RFC: The Shared Address Space address range is 100.64.0.0/10. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=402#comment1335 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.3: sqlops: safety check for result row field
by Daniel-Constantin Mierla 04 Mar '14

04 Mar '14

Module: sip-router Branch: 3.3 Commit: d3d1e6947ffe4fbf02a1bddb64d2b9ca969c24a9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3d1e69… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Mar 4 12:04:13 2014 +0100 sqlops: safety check for result row field - it might not be set in case of a failure in the middle of result conversion from db to internal memory - freeing the partial result could result in a crash - reported by Juha Heinanen (cherry picked from commit f27df26ca01394250cbe12c5ccf694c6afd3707f) (cherry picked from commit 20276e667631ec281851c2ef58d71863ae2318c4) --- modules_k/sqlops/sql_api.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/modules_k/sqlops/sql_api.c b/modules_k/sqlops/sql_api.c index 83b3690..c4c05dc 100644 --- a/modules_k/sqlops/sql_api.c +++ b/modules_k/sqlops/sql_api.c @@ -226,13 +226,16 @@ void sql_reset_result(sql_result_t *res) { for(i=0; i<res->nrows; i++) { - for(j=0; j<res->ncols; j++) + if(res->vals[i]) { - if(res->vals[i][j].flags&PV_VAL_STR - && res->vals[i][j].value.s.len>0) - pkg_free(res->vals[i][j].value.s.s); + for(j=0; j<res->ncols; j++) + { + if(res->vals[i][j].flags&PV_VAL_STR + && res->vals[i][j].value.s.len>0) + pkg_free(res->vals[i][j].value.s.s); + } + pkg_free(res->vals[i]); } - pkg_free(res->vals[i]); } pkg_free(res->vals); res->vals = NULL;

1 0

git:4.0: sqlops: safety check for result row field
by Daniel-Constantin Mierla 04 Mar '14

04 Mar '14

Module: sip-router Branch: 4.0 Commit: 00f26f831133d770b9fd9ae5ea0026a125abcf40 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=00f26f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Mar 4 09:59:07 2014 +0100 sqlops: safety check for result row field - it might not be set in case of a failure in the middle of result conversion from db to internal memory - freeing the partial result could result in a crash - reported by Juha Heinanen (cherry picked from commit f27df26ca01394250cbe12c5ccf694c6afd3707f) (cherry picked from commit 20276e667631ec281851c2ef58d71863ae2318c4) --- modules/sqlops/sql_api.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/modules/sqlops/sql_api.c b/modules/sqlops/sql_api.c index 6528078..bfd4e96 100644 --- a/modules/sqlops/sql_api.c +++ b/modules/sqlops/sql_api.c @@ -228,13 +228,16 @@ void sql_reset_result(sql_result_t *res) { for(i=0; i<res->nrows; i++) { - for(j=0; j<res->ncols; j++) + if(res->vals[i]) { - if(res->vals[i][j].flags&PV_VAL_STR - && res->vals[i][j].value.s.len>0) - pkg_free(res->vals[i][j].value.s.s); + for(j=0; j<res->ncols; j++) + { + if(res->vals[i][j].flags&PV_VAL_STR + && res->vals[i][j].value.s.len>0) + pkg_free(res->vals[i][j].value.s.s); + } + pkg_free(res->vals[i]); } - pkg_free(res->vals[i]); } pkg_free(res->vals); res->vals = NULL;

1 0

git:4.1: sqlops: safety check for result row field
by Daniel-Constantin Mierla 04 Mar '14

04 Mar '14

Module: sip-router Branch: 4.1 Commit: 20276e667631ec281851c2ef58d71863ae2318c4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=20276e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Mar 4 09:59:07 2014 +0100 sqlops: safety check for result row field - it might not be set in case of a failure in the middle of result conversion from db to internal memory - freeing the partial result could result in a crash - reported by Juha Heinanen (cherry picked from commit f27df26ca01394250cbe12c5ccf694c6afd3707f) --- modules/sqlops/sql_api.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/modules/sqlops/sql_api.c b/modules/sqlops/sql_api.c index 6528078..bfd4e96 100644 --- a/modules/sqlops/sql_api.c +++ b/modules/sqlops/sql_api.c @@ -228,13 +228,16 @@ void sql_reset_result(sql_result_t *res) { for(i=0; i<res->nrows; i++) { - for(j=0; j<res->ncols; j++) + if(res->vals[i]) { - if(res->vals[i][j].flags&PV_VAL_STR - && res->vals[i][j].value.s.len>0) - pkg_free(res->vals[i][j].value.s.s); + for(j=0; j<res->ncols; j++) + { + if(res->vals[i][j].flags&PV_VAL_STR + && res->vals[i][j].value.s.len>0) + pkg_free(res->vals[i][j].value.s.s); + } + pkg_free(res->vals[i]); } - pkg_free(res->vals[i]); } pkg_free(res->vals); res->vals = NULL;

1 0

git:master: sqlops: safety check for result row field
by Daniel-Constantin Mierla 04 Mar '14

04 Mar '14

Module: sip-router Branch: master Commit: f27df26ca01394250cbe12c5ccf694c6afd3707f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f27df26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Mar 4 09:59:07 2014 +0100 sqlops: safety check for result row field - it might not be set in case of a failure in the middle of result conversion from db to internal memory - freeing the partial result could result in a crash - reported by Juha Heinanen --- modules/sqlops/sql_api.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/modules/sqlops/sql_api.c b/modules/sqlops/sql_api.c index 6528078..bfd4e96 100644 --- a/modules/sqlops/sql_api.c +++ b/modules/sqlops/sql_api.c @@ -228,13 +228,16 @@ void sql_reset_result(sql_result_t *res) { for(i=0; i<res->nrows; i++) { - for(j=0; j<res->ncols; j++) + if(res->vals[i]) { - if(res->vals[i][j].flags&PV_VAL_STR - && res->vals[i][j].value.s.len>0) - pkg_free(res->vals[i][j].value.s.s); + for(j=0; j<res->ncols; j++) + { + if(res->vals[i][j].flags&PV_VAL_STR + && res->vals[i][j].value.s.len>0) + pkg_free(res->vals[i][j].value.s.s); + } + pkg_free(res->vals[i]); } - pkg_free(res->vals[i]); } pkg_free(res->vals); res->vals = NULL;

1 0

git:master: ims_registrar_pcscf: Make sure, Contact-Info-Structure is properly initialized.
by Carsten Bock 04 Mar '14

04 Mar '14

Module: sip-router Branch: master Commit: 2cfe0862faafa736b342f15d640581acdf15808c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2cfe086… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Tue Mar 4 11:50:19 2014 +0100 ims_registrar_pcscf: Make sure, Contact-Info-Structure is properly initialized. --- modules/ims_registrar_pcscf/save.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules/ims_registrar_pcscf/save.c b/modules/ims_registrar_pcscf/save.c index e9bcd7d..2843278 100644 --- a/modules/ims_registrar_pcscf/save.c +++ b/modules/ims_registrar_pcscf/save.c @@ -131,6 +131,10 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma * then, we will update on NOTIFY */ return 0; } + + // Set the structure to "0", to make sure it's properly initialized + memset(&ci, 0, sizeof(struct pcontact_info)); + for (h = rpl->contact; h; h = h->next) { if (h->type == HDR_CONTACT_T && h->parsed) for (c = ((contact_body_t*) h->parsed)->contacts; c; c = c->next) {

1 0

git:master: kamctl: Minor typo (missing ; ; ), resulted in Syntax Error: syntax error near unexpected token `)' (on Debian 7)
by Carsten Bock 04 Mar '14

04 Mar '14

Module: sip-router Branch: master Commit: 80536540caf19a594f91ed9999c7f812f4f40e82 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8053654… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Tue Mar 4 11:35:31 2014 +0100 kamctl: Minor typo (missing ;;), resulted in Syntax Error: syntax error near unexpected token `)' (on Debian 7) --- utils/kamctl/kamctl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 30dddcf..aac4533 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -1017,6 +1017,7 @@ db_ops() { exit 1 fi $DBCMDCONNECT + ;; *) usage_db_ops exit 1

1 0

← Newer
1
...
23
24
25
26
27
28
29
30
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2014