sr-dev March 2014

sr-dev@lists.kamailio.org

29 participants
298 discussions

[tracker] Task closed: Debian init script log_faiulre_msg

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#407 - Debian init script log_faiulre_msg User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Committed by Ovidiu Sas, e22293d865926a200e336293692886f983904275 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=407 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 9 months

msg_apply_changes query

by Richard Good

Hi We have found that in kamailio processing if you: 1. set msg->path_vec 2. call msg_apply_changes() 3. t_telay The route-header of the outgoing message is set twice. We think this is because msg_apply_changes() adds the router header if the path is set - but leaves the path set. So the router header is added again when you t_relay. To fix this: --- a/modules/textopsx/textopsx.c +++ b/modules/textopsx/textopsx.c @@ -166,7 +166,7 @@ static int msg_apply_changes_f(sip_msg_t *msg, char *str1, char *str2) } else { obuf.s = build_req_buf_from_sip_req(msg, (unsigned int*)&obuf.len, &dst, - BUILD_NO_LOCAL_VIA|BUILD_NO_VIA1_UPDATE); + BUILD_NO_PATH|BUILD_NO_LOCAL_VIA|BUILD_NO_VIA1_UPDATE); } if(obuf.s == NULL) { This stops msg_apply_changes() from adding the router header if path is set. Any objections to comitting this to master? Might other functionality be effected? The alternative is for msg_apply_changes() to add the router header but then unset the path. Regards Richard. -- This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/home/email-disclaimer/ <http://www.smilecoms.com/disclaimer>

10 years, 9 months

git:4.1: core/parser: handle the case when username field in auth header has proto scheme

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: e70df7338330f2d3248c7ec0b6d81ff0f188617b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e70df73… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 24 15:43:59 2014 +0100 core/parser: handle the case when username field in auth header has proto scheme - some phones put there "sip:username@domain", so far it was handling "username" and "username@domain" (cherry picked from commit e56ff0e6a5745321c6a4a5f362cc728177acef0d) --- parser/digest/digest_parser.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/parser/digest/digest_parser.c b/parser/digest/digest_parser.c index 6e4adce..08683d7 100644 --- a/parser/digest/digest_parser.c +++ b/parser/digest/digest_parser.c @@ -275,6 +275,7 @@ static inline void parse_username(struct username* _u) _u->user = _u->whole; if (_u->whole.len <= 2) return; + /* get domain - it can be: username@domain */ d = q_memchr(_u->whole.s, '@', _u->whole.len); if (d) { @@ -282,6 +283,13 @@ static inline void parse_username(struct username* _u) _u->domain.len = _u->whole.len - (d - _u->whole.s) - 1; _u->user.len = d - _u->user.s; } + + /* get user - it can be: sip:username@domain */ + d = q_memchr(_u->user.s, ':', _u->user.len); + if (d) { + _u->user.len = _u->user.s + _u->user.len - d - 1; + _u->user.s = d + 1; + } }

10 years, 9 months

git:4.0: kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/

by Ovidiu Sas

Module: sip-router Branch: 4.0 Commit: 7e50f981bcb95b6511d902b57423b0fd0bbf1cfc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7e50f98… Author: Corey Edwards <tensai(a)zmonkey.org> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sat Mar 8 11:28:36 2014 -0500 kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/ (cherry picked from commit e22293d865926a200e336293692886f983904275) --- pkg/kamailio/deb/debian/kamailio.init | 2 +- pkg/kamailio/deb/lucid/kamailio.init | 2 +- pkg/kamailio/deb/precise/kamailio.init | 2 +- pkg/kamailio/deb/squeeze/kamailio.init | 2 +- pkg/kamailio/deb/wheezy/kamailio.init | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kamailio/deb/debian/kamailio.init b/pkg/kamailio/deb/debian/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/debian/kamailio.init +++ b/pkg/kamailio/deb/debian/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/lucid/kamailio.init b/pkg/kamailio/deb/lucid/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/lucid/kamailio.init +++ b/pkg/kamailio/deb/lucid/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/precise/kamailio.init b/pkg/kamailio/deb/precise/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/precise/kamailio.init +++ b/pkg/kamailio/deb/precise/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/squeeze/kamailio.init b/pkg/kamailio/deb/squeeze/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/squeeze/kamailio.init +++ b/pkg/kamailio/deb/squeeze/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/wheezy/kamailio.init b/pkg/kamailio/deb/wheezy/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/wheezy/kamailio.init +++ b/pkg/kamailio/deb/wheezy/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi }

10 years, 9 months

git:4.1: kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/

by Ovidiu Sas

Module: sip-router Branch: 4.1 Commit: 9ce73e20b7042c6a1249de39fd1fdf5489e01ab4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ce73e2… Author: Corey Edwards <tensai(a)zmonkey.org> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sat Mar 8 11:28:36 2014 -0500 kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/ (cherry picked from commit e22293d865926a200e336293692886f983904275) --- pkg/kamailio/deb/debian/kamailio.init | 2 +- pkg/kamailio/deb/jessie/kamailio.init | 2 +- pkg/kamailio/deb/precise/kamailio.init | 2 +- pkg/kamailio/deb/squeeze/kamailio.init | 2 +- pkg/kamailio/deb/wheezy/kamailio.init | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kamailio/deb/debian/kamailio.init b/pkg/kamailio/deb/debian/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/debian/kamailio.init +++ b/pkg/kamailio/deb/debian/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/jessie/kamailio.init b/pkg/kamailio/deb/jessie/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/jessie/kamailio.init +++ b/pkg/kamailio/deb/jessie/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/precise/kamailio.init b/pkg/kamailio/deb/precise/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/precise/kamailio.init +++ b/pkg/kamailio/deb/precise/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/squeeze/kamailio.init b/pkg/kamailio/deb/squeeze/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/squeeze/kamailio.init +++ b/pkg/kamailio/deb/squeeze/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/wheezy/kamailio.init b/pkg/kamailio/deb/wheezy/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/wheezy/kamailio.init +++ b/pkg/kamailio/deb/wheezy/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi }

10 years, 9 months

git:master: kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/

by Ovidiu Sas

Module: sip-router Branch: master Commit: e22293d865926a200e336293692886f983904275 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e22293d… Author: Corey Edwards <tensai(a)zmonkey.org> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sat Mar 8 11:28:36 2014 -0500 kamailio.init: fix typo: s/log_faiulre_msg/log_failure_msg/ --- pkg/kamailio/deb/debian/kamailio.init | 2 +- pkg/kamailio/deb/jessie/kamailio.init | 2 +- pkg/kamailio/deb/precise/kamailio.init | 2 +- pkg/kamailio/deb/squeeze/kamailio.init | 2 +- pkg/kamailio/deb/wheezy/kamailio.init | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kamailio/deb/debian/kamailio.init b/pkg/kamailio/deb/debian/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/debian/kamailio.init +++ b/pkg/kamailio/deb/debian/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/jessie/kamailio.init b/pkg/kamailio/deb/jessie/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/jessie/kamailio.init +++ b/pkg/kamailio/deb/jessie/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/precise/kamailio.init b/pkg/kamailio/deb/precise/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/precise/kamailio.init +++ b/pkg/kamailio/deb/precise/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/squeeze/kamailio.init b/pkg/kamailio/deb/squeeze/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/squeeze/kamailio.init +++ b/pkg/kamailio/deb/squeeze/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi } diff --git a/pkg/kamailio/deb/wheezy/kamailio.init b/pkg/kamailio/deb/wheezy/kamailio.init index 1f8f796..d4801d2 100644 --- a/pkg/kamailio/deb/wheezy/kamailio.init +++ b/pkg/kamailio/deb/wheezy/kamailio.init @@ -52,7 +52,7 @@ check_kamailio_config () log_failure_msg "Not starting $DESC: invalid configuration file!" log_failure_msg log_failure_msg "$out" - log_faiulre_msg + log_failure_msg exit 1 fi }

10 years, 9 months

git:4.1: modules/xmlrpc: xmlrpc scalar <int> value can be positive or negative

by Juha Heinanen

Module: sip-router Branch: 4.1 Commit: 18376e35ebbc1ba82fcce78c4eaa7f7b04e00aa8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=18376e3… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Mar 7 23:54:05 2014 +0200 modules/xmlrpc: xmlrpc scalar <int> value can be positive or negative (cherry picked from commit 67c2101fc60e4a963a6133f7a71f5faf510ca214) --- modules/xmlrpc/xmlrpc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index 4fa9b15..5522a8f 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -993,7 +993,7 @@ static int print_value(struct xmlrpc_reply* res, case 'd': prefix = int_prefix; suffix = int_suffix; - body.s = int2str(va_arg(*ap, int), &body.len); + body.s = sint2str(va_arg(*ap, int), &body.len); break; case 'f':

10 years, 9 months

git:master: modules/xmlrpc: xmlrpc scalar <int> value can be positive or negative

by Juha Heinanen

Module: sip-router Branch: master Commit: 67c2101fc60e4a963a6133f7a71f5faf510ca214 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67c2101… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Mar 7 23:54:05 2014 +0200 modules/xmlrpc: xmlrpc scalar <int> value can be positive or negative --- modules/xmlrpc/xmlrpc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index 4fa9b15..5522a8f 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -993,7 +993,7 @@ static int print_value(struct xmlrpc_reply* res, case 'd': prefix = int_prefix; suffix = int_suffix; - body.s = int2str(va_arg(*ap, int), &body.len); + body.s = sint2str(va_arg(*ap, int), &body.len); break; case 'f':

10 years, 9 months

[tracker] Task opened: Debian init script log_faiulre_msg (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Corey Edwards (tensai) Attached to Project - sip-router Summary - Debian init script log_faiulre_msg Task Type - Bug Report Category - tools/scripts Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - The Debian init scripts have a typo in the check_kamailio_config subroutine. "log_failure_msg" is misspelled as "log_faiulre_msg". Attached is a patch against git master to correct this. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=407 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 9 months

[tracker] Comment added: Crash in websocket module (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#406 - Crash in websocket module User who did this - Vitaliy Aleksandrov (Vitaliy) ---------- In the attachment a patch that add reference counting to websocket connections. Modified version is working right now on my ws gateway without any visible issues. Can somebody look through it to check if the way i chose and its implementation are right ? At now it has lots of debug messages and commented code. I'll prepare a clean version after more testing and approving by someone from the kamailio community. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=406#comment1340 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 9 months

← Newer
1
...
15
16
17
18
19
20
21
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2014