sr-dev February 2014

sr-dev@lists.kamailio.org

38 participants
235 discussions

git:master: htable: fix crash if key_value is not string

by Ovidiu Sas

Module: sip-router Branch: master Commit: 065439c0fbabe2806fcd615cec5e2445db59beec URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=065439c… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Mon Feb 10 19:41:20 2014 -0500 htable: fix crash if key_value is not string --- modules/htable/ht_db.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/htable/ht_db.c b/modules/htable/ht_db.c index 0dc512a..280e08a 100644 --- a/modules/htable/ht_db.c +++ b/modules/htable/ht_db.c @@ -261,6 +261,11 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) hname = kname; } vtype = RES_ROWS(db_res)[i].values[2].val.int_val; + if (RES_ROWS(db_res)[i].values[3].type != DB1_STRING) { + LM_ERR("Wrong db type [%d] for key_value column\n", + RES_ROWS(db_res)[i].values[3].type); + goto error; + } kvalue.s = (char*)(RES_ROWS(db_res)[i].values[3].val.string_val); if(kvalue.s==NULL) { LM_ERR("null value in row %d\n", i);

10 years, 10 months

[tracker] Comment added: dlg_end_dlg on a two-armed proxy only sends bye to one party

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#382 - dlg_end_dlg on a two-armed proxy only sends bye to one party User who did this - Per Carlen (peca) ---------- It was already in there. Sorry. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=382#comment1294 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

git:master: modules/ims_registrar_pcscf: Add domain unlock to prevent deadlock when processing notifies

by Richard Good

Module: sip-router Branch: master Commit: 3630f36c1e34562e93267d87f9e83a69cf8dd861 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3630f36… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Mon Feb 10 18:05:12 2014 +0200 modules/ims_registrar_pcscf: Add domain unlock to prevent deadlock when processing notifies --- modules/ims_registrar_pcscf/notify.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_pcscf/notify.c b/modules/ims_registrar_pcscf/notify.c index 719f1dc..67f03ac 100644 --- a/modules/ims_registrar_pcscf/notify.c +++ b/modules/ims_registrar_pcscf/notify.c @@ -106,7 +106,8 @@ int process_contact(udomain_t * _d, int expires, str contact_uri, int contact_st if (ul.get_pcontact(_d, &contact_uri, &pcontact) != 0) { //contact does not exist if (contact_state == STATE_TERMINATED) { LM_DBG("This contact: <%.*s> is in state terminated and is not in usrloc, ignore\n", contact_uri.len, contact_uri.s); - return 1; + ret = RESULT_CONTACTS_FOUND; + goto done; } LM_DBG("This contact: <%.*s> is in state active and is not in usrloc so adding it to usrloc, expires: %d which is in %d seconds\n", contact_uri.len, contact_uri.s, expires, expires-local_time_now); if (ul.insert_pcontact(_d, &contact_uri, &ci, &pcontact) != 0) {

10 years, 10 months

[tracker] Task opened: kamailio crashed time to time in the different places

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Sergey (lagutas) Attached to Project - sip-router Summary - kamailio crashed time to time in the different places Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - Linux Severity - Critical Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - <code> #0 auth_check (_m=0x7fbfdc7be4e0, _realm=<value optimized out>, _table=0x7fbfdc7d1240 "\300\305xܿ\177", _flags=0x7fbfdc7d12a0 "\300\357xܿ\177") at authorize.c:487 #1 0x000000000041777d in do_action (h=<value optimized out>, a=0x7fbfdc790cd0, msg=<value optimized out>) at action.c:1092 #2 0x000000000041f056 in run_actions (h=0x7fff0dc6ea40, a=<value optimized out>, msg=<value optimized out>) at action.c:1573 #3 0x000000000041f744 in run_actions_safe (h=0x7fff0dc70340, a=0x40, msg=0x80) at action.c:1637 #4 0x00000000004bf03d in rval_get_int (h=0x7fff0dc70340, msg=0x7fbfdc7dfc30, i=0x7fff0dc6ee3c, rv=0x40, cache=0x4) at rvalue.c:920 #5 0x00000000004c37e4 in rval_expr_eval_int (h=0x7fff0dc70340, msg=0x7fbfdc7be4e0, res=0x7fff0dc6ee3c, rve=0x7fbfdc791990) at rvalue.c:1914 #6 0x00000000004c38a9 in rval_expr_eval_int (h=0x7fff0dc70340, msg=0x7fbfdc7be4e0, res=0x7fff0dc6f2a8, rve=0x7fbfdc7912b0) at rvalue.c:1922 #7 0x0000000000417f42 in do_action (h=<value optimized out>, a=0x7fbfdc792a50, msg=<value optimized out>) at action.c:1050 #8 0x000000000041f056 in run_actions (h=0x7fff0dc70340, a=<value optimized out>, msg=<value optimized out>) at action.c:1573 #9 0x0000000000417f9b in do_action (h=<value optimized out>, a=0x7fbfdc797ac0, msg=<value optimized out>) at action.c:1065 #10 0x000000000041f056 in run_actions (h=0x7fff0dc70340, a=<value optimized out>, msg=<value optimized out>) at action.c:1573 #11 0x0000000000417f9b in do_action (h=<value optimized out>, a=0x7fbfdc797bc0, msg=<value optimized out>) at action.c:1065 #12 0x000000000041f056 in run_actions (h=0x7fff0dc70340, a=<value optimized out>, msg=<value optimized out>) at action.c:1573 #13 0x0000000000418108 in do_action (h=<value optimized out>, a=0x7fbfdc7119d0, msg=<value optimized out>) at action.c:690 #14 0x000000000041f056 in run_actions (h=0x7fff0dc70340, a=<value optimized out>, msg=<value optimized out>) at action.c:1573 #15 0x000000000041f6d0 in run_top_route (a=0x7fbfdc70c9f0, msg=0x7fbfdc7be4e0, c=<value optimized out>) at action.c:1658 #16 0x00000000004a0296 in receive_msg ( buf=0x8d4140 "REGISTER sip:sip.zadarma.com SIP/2.0\r\nVia: SIP/2.0/UDP 213.190.215.57:49153;branch=z9hG4bKqHGvdzYD7eXTadvH;rport\r\nContact: <sip:50055@213.190.215.57:49153>;rinstance=F3C3D830;expires=600\r\nMax-Forwards"..., len=<value optimized out>, rcv_info=0x7fff0dc705e0) at receive.c:209 #17 0x00000000005321be in udp_rcv_loop () at udp_server.c:557 #18 0x0000000000468c8e in main_loop () at main.c:1638 #19 0x000000000046bba2 in main (argc=<value optimized out>, argv=0x0) at main.c:2566‏ </code> segfault moment <code> auth_check (_m=0x7f0bb1458a40, _realm=<value optimized out>, _table=0x7f0bb147cc50 "\300\365B\261\v\177", _flags=0x7f0bb147ccb0 "\300\037C\261\v\177") at authorize.c:487 srealm = {s = 0x7f0bb1432020 "sip.zadarma.com", len = 15} stable = {s = 0x7f0bb142f5c0 "sip_buddies", len = 11} iflags = <value optimized out> ret = <value optimized out> hdr = 0x7f0bb1471d50 uri = <value optimized out> turi = <value optimized out> furi = <value optimized out> __FUNCTION__ = "auth_check" </code> These crashes happen in the auth, sometimes in the time to receive OPTIONS messages. Version of my kamailio installation 4.0.3 Server:: kamailio (4.0.3 (x86_64/linux)) Build:: mi_core.c compiled on 17:07:17 Aug 19 2013 with gcc 4.4.5 Flags:: STATS: Off, USE_IPV6, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES UsrLoc Stats: usrloc:location-contacts = 3166 usrloc:location-expires = 1558 usrloc:location-users = 3042 usrloc:registered_users = 3042 Transaction Statistics: tmx:UAS_transactions = 14993 tmx:UAC_transactions = 517 tmx:inuse_transactions = 32 Stateless Server Statistics: sl:sent_replies = 291243 sl:sent_err_replies = 0 sl:received_ACKs = 3807 Operation system debian squeeze. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=393 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

FreeBSD rc-file

by Victor V. Kustov

Hi all! Here modern FreeBSD rc-file attached. Provide start/stop/restart and checkconfig. -- WBR, Victor JID: coyote(a)bks.tv JID: coyote(a)bryansktel.ru I use FREE operation system: 3.12.9-calculate GNU/Linux

10 years, 10 months

[tracker] Task closed: websocket WS / WSS port support

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#392 - websocket WS / WSS port support User who did this - Víctor Seva (linuxmaniac) Reason for closing: Not a bug Additional comments about closing: really? [0] [0] https://www.google.at/search?q=websocket+kamailio+example+config More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=392 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

[tracker] Task opened: websocket WS / WSS port support

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jagdish Bairagi (jagdish020586) Attached to Project - sip-router Summary - websocket WS / WSS port support Task Type - Feature Request Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Please enable feature so that we can specify WS / WSS port to kamailio server More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=392 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

[tracker] Task closed: ws or wss port in kamailio.cfg file

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#391 - ws or wss port in kamailio.cfg file User who did this - Víctor Seva (linuxmaniac) Reason for closing: Not a bug Additional comments about closing: Please ask on the user mail list. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=391 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

[tracker] Task opened: ws or wss port in kamailio.cfg file

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jagdish Bairagi (jagdish020586) Attached to Project - sip-router Summary - ws or wss port in kamailio.cfg file Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - i can't add ws or wss port in kamailio.cfg file, what is the syntex for that.. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=391 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 10 months

git:4.1: presence: bugfix: Add option to disable per-Table lock for database layer

by Carsten Bock

Module: sip-router Branch: 4.1 Commit: f6dfa8d5e91b287ceccb84659448ee1aadbfc486 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f6dfa8d… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Jan 30 21:55:11 2014 +0100 presence: bugfix: Add option to disable per-Table lock for database layer (causes trouble with MySQL in DB_ONLY mode) --- modules/presence/doc/presence_admin.xml | 22 ++++++++++++++++++++++ modules/presence/notify.c | 6 +++--- modules/presence/presence.c | 7 +++++++ modules/presence/presence.h | 2 ++ modules/presence/presentity.c | 4 ++-- modules/presence/subscribe.c | 4 ++-- 6 files changed, 38 insertions(+), 7 deletions(-) diff --git a/modules/presence/doc/presence_admin.xml b/modules/presence/doc/presence_admin.xml index 02b3562..8b18174 100644 --- a/modules/presence/doc/presence_admin.xml +++ b/modules/presence/doc/presence_admin.xml @@ -575,6 +575,28 @@ modparam("presence", "fetch_rows", 1000) </programlisting> </example> </section> + <section> + <title><varname>db_table_lock_type</varname> (integer)</title> + <para> + Enable (=1) or disable (=0) the Locks for table during an transaction. + Locking only the "current" table causes problems with a MySQL-Databases + in "DB-Only" mode. + </para> + <para> + <emphasis> + Default value is 1 (Write Lock for the Tables). + </emphasis> + </para> + <example> + <title>Set <varname>db_table_lock_type</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("presence", "db_table_lock_type", 0) +... +</programlisting> + </example> + </section> + </section> diff --git a/modules/presence/notify.c b/modules/presence/notify.c index 0a7ffb2..402aacc 100644 --- a/modules/presence/notify.c +++ b/modules/presence/notify.c @@ -1335,7 +1335,7 @@ int publ_notify_notifier(str pres_uri, pres_ev_t *event) if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; @@ -2701,7 +2701,7 @@ int process_dialogs(int round, int presence_winfo) if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; @@ -2810,7 +2810,7 @@ int process_dialogs(int round, int presence_winfo) if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; diff --git a/modules/presence/presence.c b/modules/presence/presence.c index 067a1e1..6a87776 100644 --- a/modules/presence/presence.c +++ b/modules/presence/presence.c @@ -149,6 +149,9 @@ int pres_waitn_time = 5; int pres_notifier_poll_rate = 10; int pres_notifier_processes = 1; +int db_table_lock_type = 1; +db_locking_t db_table_lock = DB_LOCKING_WRITE; + int *pres_notifier_id = NULL; int phtable_size= 9; @@ -199,6 +202,7 @@ static param_export_t params[]={ { "timeout_rm_subs", INT_PARAM, &timeout_rm_subs}, { "send_fast_notify", INT_PARAM, &send_fast_notify}, { "fetch_rows", INT_PARAM, &pres_fetch_rows}, + { "db_table_lock_type", INT_PARAM, &db_table_lock_type}, {0,0,0} }; @@ -401,6 +405,9 @@ static int mod_init(void) register_basic_timers(pres_notifier_processes); } + if (db_table_lock_type != 1) + db_table_lock = DB_LOCKING_NONE; + pa_dbf.close(pa_db); pa_db = NULL; diff --git a/modules/presence/presence.h b/modules/presence/presence.h index e064bb2..b94e4dc 100644 --- a/modules/presence/presence.h +++ b/modules/presence/presence.h @@ -94,6 +94,8 @@ extern int pres_notifier_processes; extern int phtable_size; extern phtable_t* pres_htable; +extern db_locking_t db_table_lock; + int update_watchers_status(str pres_uri, pres_ev_t* ev, str* rules_doc); int pres_auth_status(struct sip_msg* msg, str watcher_uri, str presentity_uri); diff --git a/modules/presence/presentity.c b/modules/presence/presentity.c index 47a828a..6d7ffd5 100644 --- a/modules/presence/presentity.c +++ b/modules/presence/presentity.c @@ -426,7 +426,7 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body, if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; @@ -1195,7 +1195,7 @@ int mark_presentity_for_delete(presentity_t *pres) if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; diff --git a/modules/presence/subscribe.c b/modules/presence/subscribe.c index aff55f3..75e0c9c 100644 --- a/modules/presence/subscribe.c +++ b/modules/presence/subscribe.c @@ -863,7 +863,7 @@ int handle_subscribe(struct sip_msg* msg, str watcher_user, str watcher_domain) LM_ERR("unsuccessful use_table sql operation\n"); goto error; } - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error; @@ -1662,7 +1662,7 @@ void update_db_subs_timer_notifier(void) if (pa_dbf.start_transaction) { - if (pa_dbf.start_transaction(pa_db, DB_LOCKING_WRITE) < 0) + if (pa_dbf.start_transaction(pa_db, db_table_lock) < 0) { LM_ERR("in start_transaction\n"); goto error;

10 years, 10 months

← Newer
1
...
14
15
16
17
18
19
20
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2014