sr-dev December 2014

sr-dev@lists.kamailio.org

33 participants
255 discussions

git:master: db_text Add support for empty strings as a replacement for NULL strings
by Olle E. Johansson 12 Dec '14

12 Dec '14

Module: sip-router Branch: master Commit: 935f11ab8daf40ce48359c7a0f0b3759720ac5bd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=935f11a… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Fri Dec 12 22:05:16 2014 +0100 db_text Add support for empty strings as a replacement for NULL strings Some modules, like dialplan, doesn't accept NULL strings from databases. db_text had no way to define a string as empty - all empty strings was NULL. Adding a new option to change this behaviour. With "emptystring" set to 1 db_text will not set an empty string to NULL any more. --- modules/db_text/README | 54 +++++++++++++++++++++-------- modules/db_text/dbt_file.c | 14 +++++-- modules/db_text/dbt_lib.h | 1 + modules/db_text/dbtext.c | 4 ++ modules/db_text/doc/db_text.xml | 5 +++ modules/db_text/doc/db_text_admin.xml | 61 ++++++++++++++++++++++---------- 6 files changed, 101 insertions(+), 38 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=935…

1 0

overriding q value
by Juha Heinanen 12 Dec '14

12 Dec '14

looks like register module does not provide means to override q value given in contact uri when save is done. any thoughts if it would make sense to add such a capability? save already has optional params, so perhaps the implementation should use an avp to store the q value. -- juha

4 5

Re: [sr-dev] [Kamailio -feature]
by Ludovic DURAND 12 Dec '14

12 Dec '14

Hi, The purpose of projet is to implement a VoIP secure solution with Kamailio as core IMS network. In this project VoIP call will be established with zRTP. SBC is transparent for zRTP call, zRTP is establish between 2 end point (terminals), SBC don't decrypt or encrypt the call. Thus SBC don't modify codec. Is there a SBC solution provided by Kamailio ? How is managed the SBC failover mecanism ? is there SBC backup ? What is the status of context registered in Kamailio (P-CSCF & S-CSCF) in case of SBC failure ? - Is it deleted automatically ? - dispatched to another SBC (backup SBC) ? Is there mecanism in Kamailio to check SBC overload and manage a dispatching of zRTP call to available SBC ? Question related to P-CSCF and S-CSCF : - Is there redundant function (such as active/active or active/standby solution) of contextual data (customer data stored at the registration REGISTER on P-CSCF and S-CSCF) ? Best Regards Ludovic DURAND SII

2 1

git:lazedo/4.2.1: Merge branch '4.2' into lazedo/4.2.1
by Luis Azedo 12 Dec '14

12 Dec '14

Module: sip-router Branch: lazedo/4.2.1 Commit: e7fe6e6d2c30e6caba04940ef92e69a4e3bc7b82 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7fe6e6… Author: Luis Azedo <luis(a)2600hz.com> Committer: Luis Azedo <luis(a)2600hz.com> Date: Fri Dec 12 11:18:24 2014 +0000 Merge branch '4.2' into lazedo/4.2.1 * 4.2: core: set log prefix only for sip messages dialog: reset local variables shortcuts after reply and failure processing registrar: Fix memory leak around path and outbound header parsing pv Update error in docs. evapi Add link to external library. (cherry picked from commit 8370ef43f0fbd2ee447ab65c5b5172677a47f644) auth_db: added sections ids for functions acc: fixed computation of extra accounting fields auth_db: added ids to parameters tmx: added its for mi functions in doc tmx: added section ids for functions ---

1 0

git:4.2: core: set log prefix only for sip messages
by Daniel-Constantin Mierla 11 Dec '14

11 Dec '14

Module: sip-router Branch: 4.2 Commit: d80dfcc179af4cb45552722887a35cfe8efcc435 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d80dfcc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 11 23:37:24 2014 +0100 core: set log prefix only for sip messages (cherry picked from commit 79a23a4fc154ad1ff174c3a8c2a14c3c5f85f402) --- dprint.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dprint.c b/dprint.c index caf39c3..9bc9d93 100644 --- a/dprint.c +++ b/dprint.c @@ -396,7 +396,7 @@ void log_prefix_set(sip_msg_t *msg) { if(log_prefix_pvs == NULL) return; - if(msg==NULL) { + if(msg==NULL || !IS_SIP(msg)) { log_prefix_val = NULL; return; }

1 0

git:master: core: set log prefix only for sip messages
by Daniel-Constantin Mierla 11 Dec '14

11 Dec '14

Module: sip-router Branch: master Commit: 79a23a4fc154ad1ff174c3a8c2a14c3c5f85f402 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=79a23a4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 11 23:37:24 2014 +0100 core: set log prefix only for sip messages --- dprint.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dprint.c b/dprint.c index caf39c3..9bc9d93 100644 --- a/dprint.c +++ b/dprint.c @@ -396,7 +396,7 @@ void log_prefix_set(sip_msg_t *msg) { if(log_prefix_pvs == NULL) return; - if(msg==NULL) { + if(msg==NULL || !IS_SIP(msg)) { log_prefix_val = NULL; return; }

1 0

Planning to switch committing to github
by Daniel-Constantin Mierla 11 Dec '14

11 Dec '14

Hello, I setup the mirror of Kamailio github repository to kamailio.org, can be seen online at: - http://git.kamailio.org/gitlist/index.php/kamailio/ Mirroring is triggered by a push to github, so it is pretty much in real time. Right now the commit and mirroring flow is: - commit to git.sip-router.org triggers mirroring (push) to github, which triggers a mirroring (fetch) on git.kamailio.org Practically with a commit pushed directly to github, the first part of the above is skipped. All seems to be ok, my last commits were done to test the mirroring including the notification emails - I will send a separate message about what we can get there. The missing parts are the deployment of gitweb in order to have the links from archived email notifications still valid and pointing git.sip-router.org to kamailio mirror server. Considering all above, I propose to stop committing to git.sip-router.org and pushing to github starting either next Monday (Dec 15) (or Wednesday (Dec 17) if not ready by Monday). Existing developers have to send me the github username to add it to kamailio project. Any suggestions and comments are welcome! Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

5 7

git:master: modules/ims_registrar_scscf: removed path vector being set on lookups, not necessary
by Jason Penton 11 Dec '14

11 Dec '14

Module: sip-router Branch: master Commit: d773cc1105e3c5c25ea06717854b5c084fd9d1b9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d773cc1… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Thu Dec 11 22:11:14 2014 +0200 modules/ims_registrar_scscf: removed path vector being set on lookups, not necessary --- modules/ims_registrar_scscf/lookup.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/modules/ims_registrar_scscf/lookup.c b/modules/ims_registrar_scscf/lookup.c index 4a0cfa6..8c67598 100644 --- a/modules/ims_registrar_scscf/lookup.c +++ b/modules/ims_registrar_scscf/lookup.c @@ -123,11 +123,6 @@ int lookup(struct sip_msg* _m, udomain_t* _d) { ret = -3; goto done; } - if (set_path_vector(_m, &ptr->path) < 0) { - LM_ERR("failed to set path vector\n"); - ret = -3; - goto done; - } if (set_dst_uri(_m, &path_dst) < 0) { LM_ERR("failed to set dst_uri of Path\n"); ret = -3;

1 0

git:master: modules/ims_usrloc_scscf: if no contacts left for IMPU change state from REGISTERED to UNREGISTERED
by Jason Penton 11 Dec '14

11 Dec '14

Module: sip-router Branch: master Commit: d0c862c76fda42b467d1543bf98eca5678a81db3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d0c862c… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Thu Dec 11 22:01:52 2014 +0200 modules/ims_usrloc_scscf: if no contacts left for IMPU change state from REGISTERED to UNREGISTERED --- modules/ims_usrloc_scscf/impurecord.c | 13 +++++++++++-- modules/ims_usrloc_scscf/usrloc_db.c | 2 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/modules/ims_usrloc_scscf/impurecord.c b/modules/ims_usrloc_scscf/impurecord.c index a50cfc4..a3d64c0 100644 --- a/modules/ims_usrloc_scscf/impurecord.c +++ b/modules/ims_usrloc_scscf/impurecord.c @@ -315,9 +315,10 @@ void mem_delete_ucontact(ucontact_t* _c) { */ static inline void nodb_timer(impurecord_t* _r) { ucontact_t* ptr; - int i, flag, mustdeleteimpu=1; + int i, flag, mustdeleteimpu=1, hascontacts=0; udomain_t* udomain; unsigned int hash_code = 0; + impurecord_t* tmp_impu; reg_subscriber *s; subs_t* sub_dialog; @@ -370,6 +371,7 @@ static inline void nodb_timer(impurecord_t* _r) { ptr->c.len, ptr->c.s, (unsigned int) (ptr->expires - time(NULL))); mustdeleteimpu = 0; + hascontacts = 1; } } else { @@ -380,10 +382,17 @@ static inline void nodb_timer(impurecord_t* _r) { if (!flag) LM_DBG("no contacts\n"); - register_udomain("location", &udomain); if (mustdeleteimpu) { delete_impurecord(udomain, &_r->public_identity, _r); + } else { + if (!hascontacts) { + LM_DBG("This impu is not to be deleted but has no contacts - should change state to IMPU_UNREGISTERED\n"); + if (update_impurecord(udomain, &_r->public_identity, IMPU_UNREGISTERED, + -1/*do not change*/, -1 /*do not change */, -1/*do not change*/, NULL, NULL, NULL, NULL, NULL, &tmp_impu) != 0) { + LM_ERR("Unable to update impurecord for <%.*s>\n", _r->public_identity.len, _r->public_identity.s); + } + } } } diff --git a/modules/ims_usrloc_scscf/usrloc_db.c b/modules/ims_usrloc_scscf/usrloc_db.c index d156649..7571ee5 100644 --- a/modules/ims_usrloc_scscf/usrloc_db.c +++ b/modules/ims_usrloc_scscf/usrloc_db.c @@ -507,7 +507,7 @@ int inline int_to_str_len(int i) { } static inline int dbrow2contact(db_val_t* val, ucontact_info_t* ci) { - static str params, path, user_agent, callid; + static str path, user_agent, callid; //TODO FIX PARAMS

1 0

Dispatcher reverse lookup by IP
by Olle E. Johansson 11 Dec '14

11 Dec '14

Hi! Digging through the dispatcher source code I think this is the way IP matching works: * When loading or reloading dispatcher, hostnames are looked up to IP * When running a reverse check in dispatcher the IP address is checked against $si I don't understand if we handle DNS TTL and re-lookup the name here. Do I have to run a crontab dispatcher reload to make sure we have an up-to-date IP? How is names with multiple addresses handled - or SRV record sets? /O

1 2

← Newer
1
...
10
11
12
13
14
15
16
...
26
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2014