sr-dev November 2014

sr-dev@lists.kamailio.org

38 participants
207 discussions

[tracker] Comment added: Kamailio Crash in WEBSOCKET module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#495 - Kamailio Crash in WEBSOCKET module User who did this - Varghese Paul (varghesepaul87) ---------- ruser@registrar-1ivuf5b:~$ /usr/sbin/kamailio -v version: kamailio 4.1.2 (x86_64/linux) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=495#comment1706 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 4 months

[tracker] Comment added: Kamailio Crash in WEBSOCKET module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#495 - Kamailio Crash in WEBSOCKET module User who did this - Daniel-Constantin Mierla (miconda) ---------- Attach also the version details -- output of: kamailio -v ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=495#comment1705 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 4 months

[tracker] Task opened: Kamailio Crash in WEBSOCKET module (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Varghese Paul (varghesepaul87) Attached to Project - sip-router Summary - Kamailio Crash in WEBSOCKET module Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi Team, We got one crash yesterday in our server. Please find the attached GDB output files. The user is a WEBRTC endpoint and the crash related to web socket module. Kindly assist and let me know if anyone need more information. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=495 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 4 months

git:master: modules/ims_registrar_scscf: added log line

by Richard Good

Module: sip-router Branch: master Commit: b407273dbf0edbf34a0113f3984a7e780cf67d72 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b407273… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Nov 26 10:39:10 2014 +0200 modules/ims_registrar_scscf: added log line --- modules/ims_registrar_scscf/registrar_notify.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_scscf/registrar_notify.c b/modules/ims_registrar_scscf/registrar_notify.c index b751861..dacde16 100644 --- a/modules/ims_registrar_scscf/registrar_notify.c +++ b/modules/ims_registrar_scscf/registrar_notify.c @@ -1125,7 +1125,11 @@ int subscribe_to_reg(struct sip_msg *msg, char *_t, char *str2) { goto error; } } else { - LM_ERR("Re-subscribe for same watcher_contact, presentity_uri, event but with different callid, fromtag and totag - What happened?\n"); + LM_ERR("Re-subscribe for same watcher_contact, presentity_uri, event but with different callid [%.*s], fromtag [%.*s] and totag [%.*s] for presentity [%.*s] - What happened?\n", + subscriber_data.callid->len, subscriber_data.callid->s, + subscriber_data.ftag->len, subscriber_data.ftag->s, + subscriber_data.ttag->len, subscriber_data.ttag->s, + presentity_impurecord->public_identity.len, presentity_impurecord->public_identity.s); LM_DBG("Removing old subscriber and adding new one\n"); subscriber_data.presentity_uri = &presentity_impurecord->public_identity; ul.external_delete_subscriber(reg_subscriber, (udomain_t*) _t, 0 /*domain is already locked*/);

9 years, 4 months

git:4.2: kamctl: supress all output of which command searching for g/ readlink

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.2 Commit: 9eb85067e4c93ad952f87abcfc1d2ede6d194b97 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9eb8506… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 25 16:07:31 2014 +0100 kamctl: supress all output of which command searching for g/readlink - based on patch and report by Morten Tryfoss, FS#492 (cherry picked from commit ed301d16f30195d9352245f782269f2b3ddf40cf) --- utils/kamctl/kamctl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index f1b3109..9fcd170 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -16,12 +16,12 @@ TEST="false" ### include config files # check for rc file at same location with kamctl -which greadlink > /dev/null +which greadlink >/dev/null 2>&1 ret=$? if [ $ret -eq 0 ] ; then KAMCTLFULLPATH=$(greadlink -f "$0") else - which readlink > /dev/null + which readlink >/dev/null 2>&1 ret=$? if [ $ret -eq 0 ] ; then KAMCTLFULLPATH=$(readlink -f "$0")

9 years, 4 months

git:master: kamctl: supress all output of which command searching for g/ readlink

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: ed301d16f30195d9352245f782269f2b3ddf40cf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ed301d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 25 16:07:31 2014 +0100 kamctl: supress all output of which command searching for g/readlink - based on patch and report by Morten Tryfoss, FS#492 --- utils/kamctl/kamctl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index f1b3109..9fcd170 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -16,12 +16,12 @@ TEST="false" ### include config files # check for rc file at same location with kamctl -which greadlink > /dev/null +which greadlink >/dev/null 2>&1 ret=$? if [ $ret -eq 0 ] ; then KAMCTLFULLPATH=$(greadlink -f "$0") else - which readlink > /dev/null + which readlink >/dev/null 2>&1 ret=$? if [ $ret -eq 0 ] ; then KAMCTLFULLPATH=$(readlink -f "$0")

9 years, 4 months

[tracker] Comment added: kamctl warning when greadlink does not exist

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#492 - kamctl warning when greadlink does not exist User who did this - Daniel-Constantin Mierla (miconda) ---------- Interesting, I didn't know this syntax. To get all output suppressed I used something like '... >/dev/null 2>&1'. I see the manual is for bash, wondering if it is specific for it or is common to other shells. Kamctl is invoking bash, but a portable way would be better to use. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=492#comment1704 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 4 months

[tracker] Comment added: kamctl warning when greadlink does not exist

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#492 - kamctl warning when greadlink does not exist User who did this - Morten Tryfoss (mtryfoss) ---------- &> should redirect stdout and stderr to /dev/null according to: http://tldp.org/HOWTO/Bash-Prog-Intro-HOWTO-3.html 3.6 Sample: stderr and stdout 2 file This will place every output of a program to a file. This is suitable sometimes for cron entries, if you want a command to pass in absolute silence. rm -f $(find / -name core) &> /dev/null ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=492#comment1703 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 4 months

git:master: usrloc: fixed issue updating last_modified

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 767c2bc60f7f5a601118329df2c16b2646dbb58f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=767c2bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 25 12:20:36 2014 +0100 usrloc: fixed issue updating last_modified - introduced in previos commit --- modules/usrloc/ucontact.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/usrloc/ucontact.c b/modules/usrloc/ucontact.c index b0cbb28..cc1c2e5 100644 --- a/modules/usrloc/ucontact.c +++ b/modules/usrloc/ucontact.c @@ -827,7 +827,7 @@ int db_update_ucontact_addr(ucontact_t* _c) keys2[nr_cols2] = &last_mod_col; vals2[nr_cols2].nul = 0; - vals2[nr_cols2].val = _c->last_modified; + UL_DB_EXPIRES_SET(&vals2[nr_cols2], _c->last_modified); nr_cols2++; keys2[nr_cols2] = &ruid_col;

9 years, 4 months

pua_rpc crash

by Juha Heinanen

i have tried to implement pua_rpc module in order to get rid of pua_mi module. unfortunately pua.publish crashes when it executes the callback function. i have not been able to figure out why. rpc callback system is heavily using void typed variables and parameters with casts, which means that compiler cannot help in finding the bug. my current code of the module is enclosed. pua.publish causes this kind of crash during callback execution: (gdb) where #0 0xb3e9a513 in fix_delayed_reply_ctx (ctx=0x0) at xmlrpc.c:664 #1 0xb3e9c3ff in rpc_add (ctx=0x0, fmt=0xb3944868 "dS") at xmlrpc.c:1095 #2 0xb393c6ce in publish_callback (hentity=0xb48e0db8, reply=0xffffffff) at pua_rpc.c:98 #3 0xb397fc82 in run_pua_callbacks (hentity=0xb48e0db8, msg=0xffffffff) at pua_callback.h:72 #4 0xb3984074 in publ_cback_func (t=0xb48e0fb4, type=1024, ps=0xbfbaa85c) at send_publish.c:436 #5 0xb69cfc09 in run_trans_callbacks_internal (cb_lst=0xb48e0ff4, type=1024, trans=0xb48e0fb4, params=0xbfbaa85c) at t_hooks.c:290 #6 0xb69cfd1a in run_trans_callbacks (type=1024, trans=0xb48e0fb4, req=0x0, rpl=0xffffffff, code=408) at t_hooks.c:317 #7 0xb6a0815e in local_reply (t=0xb48e0fb4, p_msg=0xffffffff, branch=0, msg_status=408, cancel_data=0xbfbaa958) at t_reply.c:2120 #8 0xb6a1ca05 in fake_reply (t=0xb48e0fb4, branch=0, code=408) at timer.c:350 #9 0xb6a1ce61 in final_response_handler (r_buf=0xb48e1110, t=0xb48e0fb4) at timer.c:527 #10 0xb6a1cefa in retr_buf_handler (ticks=98494515, tl=0xb48e1124, p=0x1f40) at timer.c:585 #11 0x08216c78 in slow_timer_main () at timer.c:1145 #12 0x080df91b in main_loop () at main.c:1687 #13 0x080e4956 in main (argc=17, argv=0xbfbaae14) at main.c:2568 what should i do with the code? commit it to git in case someone would later be able to figure out where the bug is or just through it to waste bin? -- juha /* * $Id$ * * pua_rpc module - RPC pua module * * Copyright (C) 2014 Juha Heinanen * * This file is part of Kamailio, a free SIP server. * * Kamailio is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version * * Kamailio is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * * History: * -------- * 2014-11-16 initial version (jh) */ #include <stdio.h> #include <stdlib.h> #include <string.h> #include <time.h> #include "../../sr_module.h" #include "../../parser/parse_expires.h" #include "../../dprint.h" #include "../../mem/shm_mem.h" #include "../../parser/msg_parser.h" #include "../../str.h" #include "../../mem/mem.h" #include "../../pt.h" #include "../../rpc_lookup.h" #include "../../modules/tm/tm_load.h" #include "../../lib/kcore/cmpapi.h" #include "../pua/pua_bind.h" #include "rpc_func.h" MODULE_VERSION static int mod_init(void); send_publish_t pua_send_publish; static const char* publish_doc[2] = { "sends publish request and waits for the final reply, using a list " "of string parameters: presentity uri, expires, event package, " "content type, id, etag, outbound proxy, extra headers, " " and body (optional)", 0 }; static int publish_callback(ua_pres_t* hentity, struct sip_msg* reply) { rpc_delayed_ctx_t* dctx; void* c; rpc_t* rpc; struct hdr_field* hdr= NULL; int statuscode; int expires; int found; str etag; str reason = {0, 0}; if (reply == NULL || hentity == NULL || hentity->cb_param == NULL) { LM_ERR("NULL reply or hentity parameter\n"); return -1; } dctx = (rpc_delayed_ctx_t *)(hentity->cb_param); hentity->cb_param = 0; if (dctx == 0){ BUG("null delayed reply ctx\n"); return -1; } LM_INFO("dctx %u\n", (unsigned int)dctx); rpc = &dctx->rpc; c = dctx->reply_ctx; if (reply == FAKED_REPLY) { statuscode = 408; reason.s = "Request Timeout"; reason.len = strlen(reason.s); } else { statuscode = reply->first_line.u.reply.statuscode; reason = reply->first_line.u.reply.reason; } rpc->add(c, "dS", statuscode, &reason); rpc->delayed_ctx_close(dctx); if (statuscode == 200) { expires = ((exp_body_t*)reply->expires->parsed)->val; LM_DBG("expires = %d\n", expires); hdr = reply->headers; found = 0; while (hdr != NULL) { if(cmp_hdrname_strzn(&hdr->name, "SIP-ETag",8) == 0) { found = 1; break; } hdr = hdr->next; } if (found == 0) { LM_ERR("SIP-ETag header field not found\n"); return -1; } etag= hdr->body; rpc->add(c, "Sd", &etag, expires); } return 0; } static void publish(rpc_t* rpc, void* c) { str pres_uri, expires, event, content_type, id, etag, outbound_proxy, extra_headers, body; rpc_delayed_ctx_t* dctx; int exp, sign, ret, err_ret, sip_error; char err_buf[MAX_REASON_LEN]; struct sip_uri uri; publ_info_t publ; body.s = 0; body.len = 0; dctx = 0; LM_DBG("publishing ...\n"); if ((rpc->capabilities == 0) || !(rpc->capabilities(c) & RPC_DELAYED_REPLY)) { rpc->fault(c, 600, "Reply wait/async mode not supported" " by this rpc transport"); return; } ret = rpc->scan(c, "SSSSSSSS*S", &pres_uri, &expires, &event, &content_type, &id, &etag, &outbound_proxy, &extra_headers, &body); if (ret < 8) { rpc->fault(c, 400, "too few parameters (%d)", ret); return; } if (parse_uri(pres_uri.s, pres_uri.len, &uri) <0) { LM_ERR("bad resentity uri\n"); rpc->fault(c, 400, "Invalid presentity uri '%s'", pres_uri.s); return; } LM_DBG("presentity uri '%.*s'\n", pres_uri.len, pres_uri.s); if (expires.s[0]== '-') { sign= -1; expires.s++; expires.len--; } else { sign = 1; } if (str2int(&expires, (unsigned int*)&exp) < 0) { LM_ERR("invalid expires parameter\n" ); rpc->fault(c, 400, "Invalid expires '%s'", expires.s); return; } exp= exp * sign; LM_DBG("expires '%d'\n", exp); LM_DBG("event '%.*s'\n", event.len, event.s); LM_DBG("content type '%.*s'\n", content_type.len, content_type.s); LM_DBG("id '%.*s'\n", id.len, id.s); LM_DBG("ETag '%.*s'\n", etag.len, etag.s); LM_DBG("outbound_proxy '%.*s'\n", outbound_proxy.len, outbound_proxy.s); LM_DBG("extra headers '%.*s'\n", extra_headers.len, extra_headers.s); if (body.len > 0) LM_DBG("body '%.*s'\n", body.len, body.s); if ((body.s == 0) && (content_type.len != 1 || content_type.s[0] != '.')) { LM_ERR("body is missing, but content type is not .\n"); rpc->fault(c, 400, "Body is missing"); return; } memset(&publ, 0, sizeof(publ_info_t)); publ.pres_uri= &pres_uri; publ.expires= exp; publ.event= get_event_flag(&event); if (publ.event < 0) { LM_ERR("unknown event '%.*s'\n", event.len, event.s); rpc->fault(c, 400, "Unknown event"); return; } if (content_type.len != 1) { publ.content_type= content_type; } if (!((id.len == 1) && (id.s[0]== '.'))) { publ.id= id; } if (!((etag.len== 1) && (etag.s[0]== '.'))) { publ.etag= &etag; } if (!((outbound_proxy.len == 1) && (outbound_proxy.s[0] == '.'))) { publ.outbound_proxy = &outbound_proxy; } if (!((extra_headers.len == 1) && (extra_headers.s[0] == '.'))) { publ.extra_headers = &extra_headers; } if (body.s != 0) { publ.body= &body; } dctx = rpc->delayed_ctx_new(c); if (dctx == 0) { LM_ERR("internal error: failed to create context\n"); rpc->fault(c, 500, "internal error: failed to create context"); return; } LM_INFO("dctx %u\n", (unsigned int)dctx); publ.source_flag = MI_ASYN_PUBLISH; publ.cb_param = dctx; rpc = &dctx->rpc; c = dctx->reply_ctx; LM_DBG("sending publish\n"); ret = pua_send_publish(&publ); if (ret <= 0) { err_ret = err2reason_phrase(ret, &sip_error, err_buf, sizeof(err_buf), "RPC/PUBLISH") ; if (err_ret > 0 ) { rpc->fault(c, sip_error, "%s", err_buf); } else { rpc->fault(c, 500, "RPC/PUBLISH error"); } rpc->delayed_ctx_close(dctx); return; } if (ret == 418) { rpc->fault(c, 500, "Wrong ETag"); return; } return; } rpc_export_t pua_rpc[] = { {"pua.publish", publish, publish_doc, 0}, {0, 0, 0, 0} }; /** module exports */ struct module_exports exports= { "pua_rpc", 0, pua_rpc, 0, mod_init, 0, 0, 0, 0 }; /** * init module function */ static int mod_init(void) { bind_pua_t bind_pua; pua_api_t pua; bind_pua= (bind_pua_t)find_export("bind_pua", 1,0); if (!bind_pua) { LM_ERR("can't find pua\n"); return -1; } if (bind_pua(&pua) < 0) { LM_ERR("can't bind pua\n"); return -1; } if (pua.send_publish == NULL) { LM_ERR("could not import send_publish\n"); return -1; } pua_send_publish = pua.send_publish; if (pua.register_puacb(MI_ASYN_PUBLISH, publish_callback, NULL) < 0) { LM_ERR("could not register callback\n"); return -1; } return 0; }

9 years, 4 months

← Newer
1
2
3
4
5
6
7
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2014