sr-dev October 2014

sr-dev@lists.kamailio.org

34 participants
381 discussions

git:master: modules/ims_qos: Changed Rx event process from PROC_SIPINIT to PROC_MIN

by Richard Good

Module: sip-router Branch: master Commit: c78d1ce9d3b01a03133d09a8f762b5dfd221eded URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c78d1ce… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Oct 29 11:05:35 2014 +0200 modules/ims_qos: Changed Rx event process from PROC_SIPINIT to PROC_MIN --- modules/ims_qos/mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c index a3923e6..dcea09e 100644 --- a/modules/ims_qos/mod.c +++ b/modules/ims_qos/mod.c @@ -232,7 +232,7 @@ static int mod_child_init(int rank) { LM_DBG("Initialization of module in child [%d] \n", rank); if (rank == PROC_MAIN) { - int pid = fork_process(PROC_SIPINIT, "Rx Event Processor", 1); + int pid = fork_process(PROC_MIN, "Rx Event Processor", 1); if (pid < 0) return -1; //error if (pid == 0) {

9 years, 6 months

git:master: modules/dialog_ng: prevent seg fault if socket struct is null

by Jason Penton

Module: sip-router Branch: master Commit: de369d4b466078c4c5aada0fc55d9689b2d13047 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=de369d4… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Tue Oct 28 17:26:43 2014 +0200 modules/dialog_ng: prevent seg fault if socket struct is null --- modules/dialog_ng/dlg_db_handler.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/dialog_ng/dlg_db_handler.c b/modules/dialog_ng/dlg_db_handler.c index d966f8a..99fa7cd 100644 --- a/modules/dialog_ng/dlg_db_handler.c +++ b/modules/dialog_ng/dlg_db_handler.c @@ -885,7 +885,7 @@ error: int update_dialog_out_dbinfo_unsafe(struct dlg_cell * cell) { struct dlg_cell_out *dlg_out = cell->dlg_entry_out.first; - + str x = {0,0}; if(use_dialog_out_table()!=0) return -1; @@ -935,7 +935,7 @@ int update_dialog_out_dbinfo_unsafe(struct dlg_cell * cell) SET_STR_VALUE(GET_FIELD_IDX(values, DLGO_CALLEE_CSEQ_IDX), dlg_out->callee_cseq); SET_STR_VALUE(GET_FIELD_IDX(values, DLGO_CALLEE_CONTACT_IDX), dlg_out->callee_contact); SET_STR_VALUE(GET_FIELD_IDX(values, DLGO_CALLEE_ROUTESET_IDX), dlg_out->callee_route_set); - SET_STR_VALUE(GET_FIELD_IDX(values, DLGO_CALLEE_SOCK_IDX), dlg_out->callee_bind_addr->sock_str); + SET_STR_VALUE(GET_FIELD_IDX(values, DLGO_CALLEE_SOCK_IDX), dlg_out->callee_bind_addr?dlg_out->callee_bind_addr->sock_str:x); SET_PROPER_NULL_FLAG(dlg_out->callee_route_set, values, DLGO_CALLEE_ROUTESET_IDX); SET_PROPER_NULL_FLAG(dlg_out->caller_cseq, values, DLGO_CALLER_CSEQ_IDX);

9 years, 6 months

git:master: modules/ims_usrloc_scsc, modules/ims_registrar_scscf: overhaul of contact storage, more efficient and clean

by Jason Penton

Module: sip-router Branch: master Commit: 0e59fd0c1d569ac216268da5f17b35a7a8183d17 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e59fd0… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Tue Oct 28 17:08:44 2014 +0200 modules/ims_usrloc_scsc, modules/ims_registrar_scscf: overhaul of contact storage, more efficient and clean NB API's have changed but fortunately no impact to any other modules. --- modules/ims_registrar_scscf/lookup.c | 221 +++--- modules/ims_registrar_scscf/registrar_notify.c | 331 +++++----- modules/ims_registrar_scscf/regpv.c | 6 +- modules/ims_registrar_scscf/reply.c | 24 +- modules/ims_registrar_scscf/reply.h | 2 +- modules/ims_registrar_scscf/save.c | 40 +- modules/ims_usrloc_scscf/contact_hslot.c | 221 ++++++ modules/ims_usrloc_scscf/contact_hslot.h | 107 +++ modules/ims_usrloc_scscf/dlist.c | 185 +++--- modules/ims_usrloc_scscf/hslot_sp.h | 4 +- modules/ims_usrloc_scscf/impurecord.c | 368 +++++++---- modules/ims_usrloc_scscf/impurecord.h | 16 +- modules/ims_usrloc_scscf/ucontact.c | 82 ++-- modules/ims_usrloc_scscf/ucontact.h | 2 + modules/ims_usrloc_scscf/udomain.c | 854 ++++++++++++----------- modules/ims_usrloc_scscf/udomain.h | 26 +- modules/ims_usrloc_scscf/ul_callback.h | 5 +- modules/ims_usrloc_scscf/ul_mod.c | 39 +- modules/ims_usrloc_scscf/ul_rpc.c | 247 ++++---- modules/ims_usrloc_scscf/usrloc.c | 10 +- modules/ims_usrloc_scscf/usrloc.h | 49 ++- modules/ims_usrloc_scscf/usrloc_db.c | 884 +++++++++++------------- modules/ims_usrloc_scscf/usrloc_db.h | 6 +- 23 files changed, 2119 insertions(+), 1610 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0e5…

9 years, 6 months

[tracker] Task opened: htable segfault

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Savolainen Dmitri (snen) Attached to Project - sip-router Summary - htable segfault Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - it take a place while trying to reload htable from DB (at startup or by htable.reload command) if key_name column type is INT. <code> (gdb) bt #0 0x00007f60a412685f in __strlen_sse42 () from /lib64/libc.so.6 #1 0x00007f608b53234e in ht_db_load_table (ht=0x7f608c5c09d8, dbtable=0x7f608c5c09f0, mode=0) at ht_db.c:207 #2 0x00007f608b52b0f6 in ht_db_load_tables () at ht_api.c:880 #3 0x00007f608b542943 in mod_init () at htable.c:193 #4 0x0000000000590de0 in init_mod (m=0x7f60a001fd10) at sr_module.c:966 #5 0x0000000000590b42 in init_mod (m=0x7f60a00210b8) at sr_module.c:963 #6 0x0000000000590b42 in init_mod (m=0x7f60a0021d58) at sr_module.c:963 #7 0x0000000000590b42 in init_mod (m=0x7f60a0022870) at sr_module.c:963 #8 0x0000000000590b42 in init_mod (m=0x7f60a00240c0) at sr_module.c:963 #9 0x0000000000590b42 in init_mod (m=0x7f60a00249c8) at sr_module.c:963 #10 0x0000000000590b42 in init_mod (m=0x7f60a00254a8) at sr_module.c:963 #11 0x0000000000590b42 in init_mod (m=0x7f60a0025d90) at sr_module.c:963 #12 0x0000000000590b42 in init_mod (m=0x7f60a0026a40) at sr_module.c:963 #13 0x0000000000590b42 in init_mod (m=0x7f60a0027070) at sr_module.c:963 #14 0x0000000000590b42 in init_mod (m=0x7f60a00274a8) at sr_module.c:963 #15 0x0000000000590b42 in init_mod (m=0x7f60a0027830) at sr_module.c:963 #16 0x0000000000590b42 in init_mod (m=0x7f60a0027d58) at sr_module.c:963 #17 0x0000000000590b42 in init_mod (m=0x7f60a0028448) at sr_module.c:963 #18 0x0000000000590b42 in init_mod (m=0x7f60a0028948) at sr_module.c:963 #19 0x0000000000590b42 in init_mod (m=0x7f60a0028f28) at sr_module.c:963 #20 0x00000000005910e5 in init_modules () at sr_module.c:995 #21 0x00000000004aa326 in main (argc=11, argv=0x7fffa43a86f8) at main.c:2501 </code> may be it will be better convert any key type to string or just print warning and prevent crash <code> diff --git a/modules/htable/ht_db.c b/modules/htable/ht_db.c index 28af3a8..0eea317 100644 --- a/modules/htable/ht_db.c +++ b/modules/htable/ht_db.c @@ -198,6 +198,11 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) do { for(i=0; i<RES_ROW_N(db_res); i++) { + if ( RES_ROWS(db_res)[i].values[0].type!=DB1_STRING){ + LM_ERR("key type must be string\n"); + goto error; + } + /* not NULL values enforced in table definition ?!?! */ kname.s = (char*)(RES_ROWS(db_res)[i].values[0].val.string_val); if(kname.s==NULL) { </code> More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=486 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 6 months

git:4.2: htable: set str shortcut to iterator name

by Elena-Ramona Modroiu

Module: sip-router Branch: 4.2 Commit: 7d6ad74fece3cb038ce3c8c3e82bd7380bfca3fa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7d6ad74… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Tue Oct 28 11:41:47 2014 +0100 htable: set str shortcut to iterator name - intended for optimization of iterator search by name (cherry picked from commit 583c705374c9e1da7817bf204b3da225c784e54a) --- modules/htable/ht_api.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/htable/ht_api.c b/modules/htable/ht_api.c index a57af23..13d373d 100644 --- a/modules/htable/ht_api.c +++ b/modules/htable/ht_api.c @@ -1400,6 +1400,8 @@ int ht_iterator_start(str *iname, str *hname) } strncpy(_ht_iterators[k].bname, iname->s, iname->len); _ht_iterators[k].bname[iname->len] = '\0'; + _ht_iterators[k].name.len = iname->len; + _ht_iterators[k].name.s = _ht_iterators[k].bname; } _ht_iterators[k].it = NULL; _ht_iterators[k].slot = 0;

9 years, 6 months

git:master: htable: set str shortcut to iterator name

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 583c705374c9e1da7817bf204b3da225c784e54a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=583c705… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Tue Oct 28 11:41:47 2014 +0100 htable: set str shortcut to iterator name - intended for optimization of iterator search by name --- modules/htable/ht_api.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/htable/ht_api.c b/modules/htable/ht_api.c index a57af23..13d373d 100644 --- a/modules/htable/ht_api.c +++ b/modules/htable/ht_api.c @@ -1400,6 +1400,8 @@ int ht_iterator_start(str *iname, str *hname) } strncpy(_ht_iterators[k].bname, iname->s, iname->len); _ht_iterators[k].bname[iname->len] = '\0'; + _ht_iterators[k].name.len = iname->len; + _ht_iterators[k].name.s = _ht_iterators[k].bname; } _ht_iterators[k].it = NULL; _ht_iterators[k].slot = 0;

9 years, 6 months

Kamailo master crash

by Jason Penton

Hey guys, I am getting intermittent crash with latest kamailio when using srdb1 API. has anyone seen this before? #0 __GI_getenv (name=0x7f7057409d4b "", name@entry=0x7f7057409d49 "TZ") at getenv.c:85 #1 0x00007f705733da70 in tzset_internal (always=<optimized out>, explicit=explicit@entry=1) at tzset.c:413 #2 0x00007f705733e4a3 in __tz_convert (timer=0x7fff47782208, use_localtime=1, tp=0x7f705764fde0 <_tmbuf>) at tzset.c:632 #3 0x00007f7052de60b6 in db_time2str (_v=1414082447, Seems like a crash in stdlib when trying to convert a time_t to a str understandable by DB backend... Is this possibly a problem on my OS? Why would it be erratic? Cheers Jason

9 years, 6 months

[tracker] Task closed: Segfault in dialog.so

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#474 - Segfault in dialog.so User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Duplicate Additional comments about closing: Reopen if still an issue with latest version, as mentioned in the comment. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=474 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 6 months

[tracker] Task closed: WEBRTC registrations are not updating to DB always

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#480 - WEBRTC registrations are not updating to DB always User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Reopen if still an issue when using db_ops_ruid More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=480 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 6 months

[tracker] Comment added: CRASH: segfault in parser/parse_via.c

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#478 - CRASH: segfault in parser/parse_via.c User who did this - Daniel-Constantin Mierla (miconda) ---------- Back after traveling, can you give the output for: <code>frame 2 p *t p *t->request</code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=478#comment1681 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

9 years, 6 months

← Newer
1
2
3
4
5
6
7
8
9
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2014