sr-dev October 2014

sr-dev@lists.kamailio.org

34 participants
382 discussions

error for kamailio-4.2
by andrew 16 Oct '14

16 Oct '14

Hi all, Centos 6.5(64bit) is used to build kamailio. I download kamailio source code via git, and below is about the code version: ****************************************************************************** commit e6e65283abd41043e3188240d89cd8c7549daada Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Oct 13 23:40:51 2014 +0200 pkg/kamailio/deb: update version to 4.2.0~rc1 commit 1103028d36259d1304b81deef15da44e8c1c7275 Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 13 18:03:04 2014 +0200 Makefile.defs: version set to 4.2.0-rc1 ******************************************************************************* I follow the steps of (http://www.kamailio.org/wiki/install/4.2.x/git), then am stuck at the 9th step(9. The init.d script). After run ' /etc/init.d/kamailio start', one error is reported by kamailio at /var/log/message ******************************************************************************* Oct 16 13:47:18 sipserver kamailio: : <core> [cfg.y:3439]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 297, column 54: Can't initialize shared memory Oct 16 13:47:18 sipserver kamailio: ERROR: mi_fifo [mi_fifo.c:271]: mi_destroy(): FIFO stat failed: Bad address ******************************************************************************* line 297 in kamailio.cfg is shown as below: # ----- mi_fifo params ----- modparam("mi_fifo", "fifo_name", "/tmp/kamailio_fifo") how to fix the issue? Thanks! B.R andrew

2 1

[tracker] Task opened: kamailio -c complains about PKG_MEM size -M parameter
by sip-router 16 Oct '14

16 Oct '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Nuno Miguel Reis (nmreis) Attached to Project - sip-router Summary - kamailio -c complains about PKG_MEM size -M parameter Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - $ kamailio -c <code> loading modules under /usr/local/lib/kamailio/modules_k/:/usr/lib64/kamailio/modules/ 0(6030) : <core> [cfg.lex:1390]: addstr(): ERROR:lex:addstr: memory allocation error 0(6030) : <core> [cfg.lex:1392]: addstr(): ERROR:lex:addstr: try to increase pkg size with -M parameter </code> throws an error back at you if the memory needed to process kamailio config (PKG_MEM size) is over the default limit. This can lead people into thinking something is wrong with their config files where nothing is actually wrong. This is even worse when people use an RPM based kamailio (like me) with a proper /etc/sysconfig/kamailio file in place, because the kamailio.init verifies the config file with 'kamailio -c' upon startup before considering the defaults under '/etc/sysconfig/kamailio'. My opinion is that kamailio should consider the defaults under /etc/sysconfig/kamailio when they actually exist. For now a proper workaround for this is disabling the kamailio config checkup in kamailio.init file on rpm based systems. Any other ideas to make this better? More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=481 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.2: textops: fix not initialized variable for muti-part body
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: 4.2 Commit: 450eaed84907357626f84ded58ae04537a63507f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=450eaed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 01:06:09 2014 +0200 textops: fix not initialized variable for muti-part body (cherry picked from commit f1178c4d0e12f7d7e05bd6551ec3a841f1f23055) --- modules/textops/textops.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/textops/textops.c b/modules/textops/textops.c index 836f8ac..581fe12 100644 --- a/modules/textops/textops.c +++ b/modules/textops/textops.c @@ -1546,7 +1546,7 @@ int set_multibody_helper(struct sip_msg* msg, char* p1, char* p2, char* p3) str default_delimiter = {"unique-boundary-1", 17}; str nc = {0,0}; str cth = {"Content-Type: ", 14}; - str* nbb; + str* nbb = NULL; unsigned int convert = 0; fparam_t header; header.orig = NULL;

1 0

git:4.2: dialog: proper de-serialization of expires value for a profile
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: 4.2 Commit: 78a5d5d1f1cb8c59b5ff64d7df9c6ecd1634fcf8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=78a5d5d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 01:03:54 2014 +0200 dialog: proper de-serialization of expires value for a profile (cherry picked from commit ab9d9a242ec60b820496794953610a84b303d2f3) --- modules/dialog/dlg_profile.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/dialog/dlg_profile.c b/modules/dialog/dlg_profile.c index 69f1788..b355ad5 100644 --- a/modules/dialog/dlg_profile.c +++ b/modules/dialog/dlg_profile.c @@ -1257,8 +1257,8 @@ int dlg_json_to_profiles(dlg_cell_t *dlg, srjson_doc_t *jdoc) val.len = strlen(val.s); } else if(strcmp(jt->string, "puid")==0) { puid.s = jt->valuestring; - puid.len = strlen(val.s); - } else if(strcmp(jt->string, "puid")==0) { + puid.len = strlen(puid.s); + } else if(strcmp(jt->string, "expires")==0) { expires = (time_t)jt->valueint; } else if(strcmp(jt->string, "flags")==0) { flags = jt->valueint;

1 0

git:4.2: htable: initialize the value for iterator list index
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: 4.2 Commit: 980bf253a9458180e7a34eefd9bc221b1744c0a6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=980bf25… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 00:58:27 2014 +0200 htable: initialize the value for iterator list index (cherry picked from commit 853bb22836c888b19edc9db00edb1df0c0be0554) --- modules/htable/ht_api.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/htable/ht_api.c b/modules/htable/ht_api.c index f888714..a57af23 100644 --- a/modules/htable/ht_api.c +++ b/modules/htable/ht_api.c @@ -1417,6 +1417,7 @@ int ht_iterator_next(str *iname) int i; int k; + k = -1; for(i=0; i<HT_ITERATOR_SIZE; i++) { if(_ht_iterators[i].name.len>0)

1 0

git:4.2: websocket: safety guard when computing the list of connections
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: 4.2 Commit: c07c94c3fe7809d4b0e4ec143d9e1ebef8a7cfc3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c07c94c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 00:57:29 2014 +0200 websocket: safety guard when computing the list of connections - avoid going further if connection is null -- unlikely to happen as len of the list is computed before (cherry picked from commit 19e8a5618f86833995d17200267910e44471141d) --- modules/websocket/ws_conn.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/websocket/ws_conn.c b/modules/websocket/ws_conn.c index 88fe5e8..06f7b13 100644 --- a/modules/websocket/ws_conn.c +++ b/modules/websocket/ws_conn.c @@ -486,6 +486,7 @@ ws_connection_t **wsconn_get_list(void) { if (!wsc) { LM_ERR("Wrong list length\n"); + break; } list[i] = wsc; @@ -494,7 +495,7 @@ ws_connection_t **wsconn_get_list(void) wsc = wsc->used_next; } - list[list_len] = NULL; /* explicit NULL termination */ + list[i] = NULL; /* explicit NULL termination */ end: WSCONN_UNLOCK;

1 0

git:master: textops: fix not initialized variable for muti-part body
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: master Commit: f1178c4d0e12f7d7e05bd6551ec3a841f1f23055 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f1178c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 01:06:09 2014 +0200 textops: fix not initialized variable for muti-part body --- modules/textops/textops.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/textops/textops.c b/modules/textops/textops.c index 836f8ac..581fe12 100644 --- a/modules/textops/textops.c +++ b/modules/textops/textops.c @@ -1546,7 +1546,7 @@ int set_multibody_helper(struct sip_msg* msg, char* p1, char* p2, char* p3) str default_delimiter = {"unique-boundary-1", 17}; str nc = {0,0}; str cth = {"Content-Type: ", 14}; - str* nbb; + str* nbb = NULL; unsigned int convert = 0; fparam_t header; header.orig = NULL;

1 0

git:master: htable: initialize the value for iterator list index
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: master Commit: 853bb22836c888b19edc9db00edb1df0c0be0554 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=853bb22… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 00:58:27 2014 +0200 htable: initialize the value for iterator list index --- modules/htable/ht_api.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/htable/ht_api.c b/modules/htable/ht_api.c index f888714..a57af23 100644 --- a/modules/htable/ht_api.c +++ b/modules/htable/ht_api.c @@ -1417,6 +1417,7 @@ int ht_iterator_next(str *iname) int i; int k; + k = -1; for(i=0; i<HT_ITERATOR_SIZE; i++) { if(_ht_iterators[i].name.len>0)

1 0

git:master: dialog: proper de-serialization of expires value for a profile
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: master Commit: ab9d9a242ec60b820496794953610a84b303d2f3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ab9d9a2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 01:03:54 2014 +0200 dialog: proper de-serialization of expires value for a profile --- modules/dialog/dlg_profile.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/dialog/dlg_profile.c b/modules/dialog/dlg_profile.c index 69f1788..b355ad5 100644 --- a/modules/dialog/dlg_profile.c +++ b/modules/dialog/dlg_profile.c @@ -1257,8 +1257,8 @@ int dlg_json_to_profiles(dlg_cell_t *dlg, srjson_doc_t *jdoc) val.len = strlen(val.s); } else if(strcmp(jt->string, "puid")==0) { puid.s = jt->valuestring; - puid.len = strlen(val.s); - } else if(strcmp(jt->string, "puid")==0) { + puid.len = strlen(puid.s); + } else if(strcmp(jt->string, "expires")==0) { expires = (time_t)jt->valueint; } else if(strcmp(jt->string, "flags")==0) { flags = jt->valueint;

1 0

git:master: websocket: safety guard when computing the list of connections
by Daniel-Constantin Mierla 15 Oct '14

15 Oct '14

Module: sip-router Branch: master Commit: 19e8a5618f86833995d17200267910e44471141d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=19e8a56… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 16 00:57:29 2014 +0200 websocket: safety guard when computing the list of connections - avoid going further if connection is null -- unlikely to happen as len of the list is computed before --- modules/websocket/ws_conn.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/websocket/ws_conn.c b/modules/websocket/ws_conn.c index 88fe5e8..06f7b13 100644 --- a/modules/websocket/ws_conn.c +++ b/modules/websocket/ws_conn.c @@ -486,6 +486,7 @@ ws_connection_t **wsconn_get_list(void) { if (!wsc) { LM_ERR("Wrong list length\n"); + break; } list[i] = wsc; @@ -494,7 +495,7 @@ ws_connection_t **wsconn_get_list(void) wsc = wsc->used_next; } - list[list_len] = NULL; /* explicit NULL termination */ + list[i] = NULL; /* explicit NULL termination */ end: WSCONN_UNLOCK;

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2014