sr-dev January 2014

sr-dev@lists.kamailio.org

27 participants
210 discussions

[tracker] Comment added: Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#338 - Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify User who did this - Wonbin Cho (wbcho) ---------- The patch has been applied to 4.1. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=338#comment1278 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

git:master: modules/sca: use sca_create_canonical_aor in INVITE/ 2OO OK handler.

by Andrew Mortensen

Module: sip-router Branch: master Commit: 1d63ad4715cf046955f27726f3d0003fcfb5ffac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1d63ad4… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Jan 27 12:03:55 2014 -0500 modules/sca: use sca_create_canonical_aor in INVITE/2OO OK handler. - abstract AoR construction for future improvements. --- modules/sca/sca_call_info.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/sca/sca_call_info.c b/modules/sca/sca_call_info.c index 6fa933f..b6d6b38 100644 --- a/modules/sca/sca_call_info.c +++ b/modules/sca/sca_call_info.c @@ -1288,11 +1288,9 @@ sca_call_info_invite_reply_200_handler( sip_msg_t *msg, "parse_uri <%.*s> failed", STR_FMT( contact_uri )); goto done; } - if ( sca_aor_create_from_info( &app_uri_aor, c_uri.type, &c_uri.user, - &GET_TO_PURI( msg )->host, &GET_TO_PURI( msg )->port ) < 0 ) { + if ( sca_create_canonical_aor( msg, &app_uri_aor ) < 0 ) { LM_ERR( "sca_call_info_invite_200_reply_handler: " - "sca_aor_create_from_info %.*s and %.*s failed", - STR_FMT( contact_uri ), STR_FMT( &to->uri )); + "sca_create_canonical_aor failed" ); goto done; }

10 years, 3 months

git:master: modules/sca: optionally update call-info state for only caller or callee.

by Andrew Mortensen

Module: sip-router Branch: master Commit: ba5c2f973cafcb1d871337ffefb8fa95f5463eee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ba5c2f9… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Jan 27 12:01:19 2014 -0500 modules/sca: optionally update call-info state for only caller or callee. - sca_call_info_update can now take an int argument (1=caller, 2=callee) limiting call-info state update to only that leg's AoR. --- modules/sca/sca.c | 2 ++ modules/sca/sca_call_info.c | 32 ++++++++++++++++++++++++++++++-- modules/sca/sca_call_info.h | 2 ++ 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/modules/sca/sca.c b/modules/sca/sca.c index f196c27..ee1425d 100644 --- a/modules/sca/sca.c +++ b/modules/sca/sca.c @@ -59,6 +59,8 @@ static cmd_export_t cmds[] = { { "sca_handle_subscribe", sca_handle_subscribe, 0, NULL, REQUEST_ROUTE }, { "sca_call_info_update", sca_call_info_update, 0, NULL, REQUEST_ROUTE | FAILURE_ROUTE | ONREPLY_ROUTE }, + { "sca_call_info_update", sca_call_info_update, 1, fixup_var_int_1, + REQUEST_ROUTE | FAILURE_ROUTE | ONREPLY_ROUTE }, { NULL, NULL, -1, 0, 0 }, }; diff --git a/modules/sca/sca_call_info.c b/modules/sca/sca_call_info.c index 1e5bbfd..6fa933f 100644 --- a/modules/sca/sca_call_info.c +++ b/modules/sca/sca_call_info.c @@ -1885,6 +1885,7 @@ sca_call_info_update( sip_msg_t *msg, char *p1, char *p2 ) int i; int method; int rc = -1; + int update_mask = SCA_CALL_INFO_SHARED_BOTH; method = sca_get_msg_method( msg ); @@ -1905,6 +1906,29 @@ sca_call_info_update( sip_msg_t *msg, char *p1, char *p2 ) return( -1 ); } + if ( p1 != NULL ) { + if ( get_int_fparam( &update_mask, msg, (fparam_t *)p1 ) < 0 ) { + LM_ERR( "sca_call_info_update: argument 1: bad value " + "(integer expected)" ); + return( -1 ); + } + + switch ( update_mask ) { + case SCA_CALL_INFO_SHARED_NONE: + update_mask = SCA_CALL_INFO_SHARED_BOTH; + break; + + case SCA_CALL_INFO_SHARED_CALLER: + case SCA_CALL_INFO_SHARED_CALLEE: + break; + + default: + LM_ERR( "sca_call_info_update: argument 1: invalid value " + "(0, 1 or 2 expected)" ); + return( -1 ); + } + } + memset( &call_info, 0, sizeof( sca_call_info )); call_info_hdr = sca_call_info_header_find( msg->headers ); if ( !SCA_HEADER_EMPTY( call_info_hdr )) { @@ -1967,10 +1991,14 @@ sca_call_info_update( sip_msg_t *msg, char *p1, char *p2 ) /* early check to see if we're dealing with any SCA endpoints */ if ( sca_uri_is_shared_appearance( sca, &from_aor )) { - call_info.ua_shared |= SCA_CALL_INFO_SHARED_CALLER; + if (( update_mask & SCA_CALL_INFO_SHARED_CALLER )) { + call_info.ua_shared |= SCA_CALL_INFO_SHARED_CALLER; + } } if ( sca_uri_is_shared_appearance( sca, &to_aor )) { - call_info.ua_shared |= SCA_CALL_INFO_SHARED_CALLEE; + if (( update_mask & SCA_CALL_INFO_SHARED_CALLEE )) { + call_info.ua_shared |= SCA_CALL_INFO_SHARED_CALLEE; + } } if ( call_info_hdr == NULL ) { diff --git a/modules/sca/sca_call_info.h b/modules/sca/sca_call_info.h index 6a9f1ea..5e9dd0d 100644 --- a/modules/sca/sca_call_info.h +++ b/modules/sca/sca_call_info.h @@ -35,6 +35,8 @@ enum { SCA_CALL_INFO_SHARED_CALLER = (1 << 0), SCA_CALL_INFO_SHARED_CALLEE = (1 << 1), }; +#define SCA_CALL_INFO_SHARED_BOTH \ + (SCA_CALL_INFO_SHARED_CALLER | SCA_CALL_INFO_SHARED_CALLEE) struct _sca_call_info { str sca_uri;

10 years, 3 months

git:master: pkg/kamailio/deb: fix typo on depends

by Victor Seva

Module: sip-router Branch: master Commit: b03e871a62f3895bfb70fe5b72b0142afa613684 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b03e871… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Jan 27 16:29:46 2014 +0100 pkg/kamailio/deb: fix typo on depends --- pkg/kamailio/deb/debian/control | 2 +- pkg/kamailio/deb/jessie/control | 2 +- pkg/kamailio/deb/wheezy/control | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index 64398a8..6a4d491 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -433,7 +433,7 @@ Multi-Arch: same Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends}, ${shlibs:Depends}, - gjc-jre, + gcj-jre, kamailio (= ${binary:Version}) Description: contains the app_java module Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/jessie/control b/pkg/kamailio/deb/jessie/control index 64398a8..6a4d491 100644 --- a/pkg/kamailio/deb/jessie/control +++ b/pkg/kamailio/deb/jessie/control @@ -433,7 +433,7 @@ Multi-Arch: same Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends}, ${shlibs:Depends}, - gjc-jre, + gcj-jre, kamailio (= ${binary:Version}) Description: contains the app_java module Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index 50f54b2..3e51edd 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -418,7 +418,7 @@ Multi-Arch: same Pre-Depends: ${misc:Pre-Depends} Depends: ${misc:Depends}, ${shlibs:Depends}, - gjc-jre, + gcj-jre, kamailio (= ${binary:Version}) Description: contains the app_java module Kamailio is a very fast and flexible SIP (RFC3261)

10 years, 3 months

[tracker] User took ownership: libsrdb1.so.1.0 in multiple debian packages

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Víctor Seva has taken ownership of the following task: FS#389 - libsrdb1.so.1.0 in multiple debian packages More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=389 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Task opened: libsrdb1.so.1.0 in multiple debian packages

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Krischan Udelhoven (Krischan) Attached to Project - sip-router Summary - libsrdb1.so.1.0 in multiple debian packages Task Type - Bug Report Category - tools/scripts Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - Hello, there is a problem with the kamailio 4.1 debian packages. libsrdb1.so.1.0 seems to be part of multiple packages. When I try to install kamailio-xml-modules I get the following error: dpkg: error processing /var/cache/apt/archives/kamailio-xml-modules_4.1.0_amd64.deb (--unpack): trying to overwrite '/usr/lib64/kamailio/libsrdb1.so.1.0', which is also in package kamailio-mysql-modules 4.1.0 Workaround: Install package with "dpkg -i --force-all" Regards Krischan More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=389 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

[tracker] Task opened: bt:<code>Program terminated with signal 6, Aborted. (kamailio 4.1.1)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Seudin Kasumovic (seudin) Attached to Project - sip-router Summary - bt:<code>Program terminated with signal 6, Aborted. (kamailio 4.1.1) Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi all, kamailio is compiled with mode=debug. I happens when 487 Request Cancelled received. Abort is raised in script_cb:167 <code>162 unsigned int flags; 163 164 #ifdef EXTRA_DEBUG 165 if (type >= SCRIPT_CB_NUM) { 166 LOG(L_BUG, "exec_pre_script_cb: Uknown callback type\n"); 167 abort(); 168 } 169 #endif 170 flags = PRE_SCRIPT_CB | (1<<(type-1)); 171 for (cb=pre_script_cb[type-1]; cb ; cb=cb->next ) {</code> Check in line 165 is wrong. The BRANCH_FAILURE_CB_TYPE is added in commit 0b79baecf4a36a47522fd222614e370c5d044e8f. check should be: <code>type > SCRIPT_CB_NUM</code> (or type-1 >= SCRIPT_CB_NUM, or type >= MAX_CB_TYPE), because pre_script_cb is always accessed by [type-1] (e.g. see line=171). SCRIPT_CB_NUM is defined here: script_cb.c:56:#define SCRIPT_CB_NUM (MAX_CB_TYPE-1)</code> and used for allocate space: <code>script_cb.c:58:static struct script_cb *pre_script_cb[SCRIPT_CB_NUM]; script_cb.c:59:static struct script_cb *post_script_cb[SCRIPT_CB_NUM];</code> bt:<code>Program terminated with signal 6, Aborted. #0 0xb776a430 in __kernel_vsyscall () (gdb) bt #0 0xb776a430 in __kernel_vsyscall () #1 0xb75ef241 in raise () from /lib/libc.so.6 #2 0xb75f0a1e in abort () from /lib/libc.so.6 #3 0x08168475 in exec_pre_script_cb (msg=0xb6dcdc60 <faked_req.10511>, type=BRANCH_FAILURE_CB_TYPE) at script_cb.c:167 #4 0xb6d5a938 in free_faked_req (faked_req=0xb553914c, t=0xb72e1904) at t_reply.c:996 #5 0xb6d5b85b in run_branch_failure_handlers (t=0xb553914c, rpl=0x1e7, code=0, extra_flags=-1074577000) at t_reply.c:1122 #6 0xb6d5d785 in t_retransmit_reply (t=0xb553914c) at t_reply.c:1609 #7 0xb6d60703 in reply_received (p_msg=0xb72e1904) at t_reply.c:2255 #8 0x080e7d25 in forward_request (msg=0xb72e1904, dst=0x0, port=0, send_info=0x0) at forward.c:552 #9 0x080e8599 in forward_request (msg=0xb72e1904, dst=0x3, port=5210, send_info=0x8233d40) at forward.c:614 #10 0x08136aa0 in receive_msg ( buf=0x82958e0 <buf.6058> "SIP/2.0 487 Request Cancelled\r\nVia: SIP/2.0/UDP 127.0.0.1:5070;rport=5070;branch=z9hG4bK47b3.e74da0151135f7c0ee995dcc0f877c7a.0\r\nVia: SIP/2.0/UDP 127.0.0.1:5090;rport=5090;branch=z9hG4bK6gUQ2ND4N5rjD\r"..., len=683, rcv_info=0xbff34630) at receive.c:273 #11 0x080ac8c9 in udp_init (sock_info=0x2) at udp_server.c:320 #12 0x080fcb3c in main_loop () at main.c:1289 #13 0x080ffc7c in main (argc=5, argv=0xbff34924) at main.c:2074</code> More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=388 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 3 months

git:master: core/parser: handle the case when username field in auth header has proto scheme

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: e56ff0e6a5745321c6a4a5f362cc728177acef0d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e56ff0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 24 15:43:59 2014 +0100 core/parser: handle the case when username field in auth header has proto scheme - some phones put there "sip:username@domain", so far it was handling "username" and "username@domain" --- parser/digest/digest_parser.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/parser/digest/digest_parser.c b/parser/digest/digest_parser.c index 6e4adce..08683d7 100644 --- a/parser/digest/digest_parser.c +++ b/parser/digest/digest_parser.c @@ -275,6 +275,7 @@ static inline void parse_username(struct username* _u) _u->user = _u->whole; if (_u->whole.len <= 2) return; + /* get domain - it can be: username@domain */ d = q_memchr(_u->whole.s, '@', _u->whole.len); if (d) { @@ -282,6 +283,13 @@ static inline void parse_username(struct username* _u) _u->domain.len = _u->whole.len - (d - _u->whole.s) - 1; _u->user.len = d - _u->user.s; } + + /* get user - it can be: sip:username@domain */ + d = q_memchr(_u->user.s, ':', _u->user.len); + if (d) { + _u->user.len = _u->user.s + _u->user.len - d - 1; + _u->user.s = d + 1; + } }

10 years, 3 months

git:4.1: gzcompress: fixed info about header_value parameter in docs

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: 5bc5726eed23da01f722067e69f0c02a92006ae5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5bc5726… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 24 08:56:20 2014 +0100 gzcompress: fixed info about header_value parameter in docs (cherry picked from commit cbd525649237c3beb05ad7bcb38969fb3629b90e) --- modules/gzcompress/README | 2 +- modules/gzcompress/doc/gzcompress_admin.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/gzcompress/README b/modules/gzcompress/README index bfd9412..0f9532d 100644 --- a/modules/gzcompress/README +++ b/modules/gzcompress/README @@ -131,7 +131,7 @@ modparam("gzcompress", "header_name", "Encoded") 3.2. header_value (str) - Name of the header that indicates compression or decompression has to + Value of the header that indicates compression or decompression has to be done. Default value is "deflate". diff --git a/modules/gzcompress/doc/gzcompress_admin.xml b/modules/gzcompress/doc/gzcompress_admin.xml index ab46622..ae2bd22 100644 --- a/modules/gzcompress/doc/gzcompress_admin.xml +++ b/modules/gzcompress/doc/gzcompress_admin.xml @@ -113,7 +113,7 @@ modparam("gzcompress", "header_name", "Encoded") <section id="gzcompress.p.header_value"> <title><varname>header_value</varname> (str)</title> <para> - Name of the header that indicates compression or decompression has + Value of the header that indicates compression or decompression has to be done. </para> <para>

10 years, 3 months

git:master: gzcompress: fixed info about header_value parameter in docs

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cbd525649237c3beb05ad7bcb38969fb3629b90e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cbd5256… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 24 08:56:20 2014 +0100 gzcompress: fixed info about header_value parameter in docs --- modules/gzcompress/README | 2 +- modules/gzcompress/doc/gzcompress_admin.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/gzcompress/README b/modules/gzcompress/README index bfd9412..0f9532d 100644 --- a/modules/gzcompress/README +++ b/modules/gzcompress/README @@ -131,7 +131,7 @@ modparam("gzcompress", "header_name", "Encoded") 3.2. header_value (str) - Name of the header that indicates compression or decompression has to + Value of the header that indicates compression or decompression has to be done. Default value is "deflate". diff --git a/modules/gzcompress/doc/gzcompress_admin.xml b/modules/gzcompress/doc/gzcompress_admin.xml index ab46622..ae2bd22 100644 --- a/modules/gzcompress/doc/gzcompress_admin.xml +++ b/modules/gzcompress/doc/gzcompress_admin.xml @@ -113,7 +113,7 @@ modparam("gzcompress", "header_name", "Encoded") <section id="gzcompress.p.header_value"> <title><varname>header_value</varname> (str)</title> <para> - Name of the header that indicates compression or decompression has + Value of the header that indicates compression or decompression has to be done. </para> <para>

10 years, 3 months

← Newer
1
2
3
4
5
6
7
8
9
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2014