sr-dev August 2013

sr-dev@lists.kamailio.org

29 participants
149 discussions

git:master: rls: Fix memory leak in rls notify.c
by Hugh Waite 12 Aug '13

12 Aug '13

Module: sip-router Branch: master Commit: 4f42993660c52c757918ca2806f7ffe6af0674ce URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4f42993… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Mon Aug 12 11:05:55 2013 +0100 rls: Fix memory leak in rls notify.c - xml is leaked in an error case --- modules/rls/notify.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/rls/notify.c b/modules/rls/notify.c index 7b5bec3..6738f91 100644 --- a/modules/rls/notify.c +++ b/modules/rls/notify.c @@ -1073,6 +1073,7 @@ int process_list_and_exec(xmlNodePtr list_node, str username, str domain, else { LM_ERR("unable to parse URI for <resource-list/>\n"); + xmlFree(uri.s); return -1; } }

1 0

git:master: outbound: Fix freeing null pointer in destroy function
by Hugh Waite 12 Aug '13

12 Aug '13

Module: sip-router Branch: master Commit: e88af0a02de79fac583c126f08d762f7ef3f1b01 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e88af0a… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Jul 16 10:51:29 2013 +0100 outbound: Fix freeing null pointer in destroy function - Only appears in error cases, e.g. syntax check --- modules/outbound/ob_mod.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index 04f2e38..0233ee5 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -127,7 +127,8 @@ static int mod_init(void) static void destroy(void) { - shm_free(ob_key.s); + if (ob_key.s) + shm_free(ob_key.s); } /* Structure of flow-token

1 0

git:4.0: rls: Fix memory leak in rls notify.c
by Hugh Waite 12 Aug '13

12 Aug '13

Module: sip-router Branch: 4.0 Commit: d3be7fa1c47d12a1eb6e725729c6a0a2e481bc63 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3be7fa… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Mon Aug 12 11:05:55 2013 +0100 rls: Fix memory leak in rls notify.c - xml is leaked in an error case --- modules/rls/notify.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/rls/notify.c b/modules/rls/notify.c index 7b5bec3..6738f91 100644 --- a/modules/rls/notify.c +++ b/modules/rls/notify.c @@ -1073,6 +1073,7 @@ int process_list_and_exec(xmlNodePtr list_node, str username, str domain, else { LM_ERR("unable to parse URI for <resource-list/>\n"); + xmlFree(uri.s); return -1; } }

1 0

git:4.0: presence: Iterate correctly around presence updates
by Hugh Waite 12 Aug '13

12 Aug '13

Module: sip-router Branch: 4.0 Commit: a72a01a1cac4bd17e0aa91912ab158e73908d561 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a72a01a… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Mon Aug 12 11:15:55 2013 +0100 presence: Iterate correctly around presence updates - timer_send_notify should increment the subset by one on each loop --- modules/presence/notify.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/presence/notify.c b/modules/presence/notify.c index d06fa6c..0a7ffb2 100644 --- a/modules/presence/notify.c +++ b/modules/presence/notify.c @@ -2667,9 +2667,6 @@ int process_dialogs(int round, int presence_winfo) int updated = 0; db_query_f query_fn = pa_dbf.query_lock ? pa_dbf.query_lock : pa_dbf.query; - if (++subset > (pres_waitn_time * pres_notifier_poll_rate) -1) - subset = 0; - query_cols[n_query_cols] = &str_updated_col; query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; @@ -3000,6 +2997,9 @@ void pres_timer_send_notify(unsigned int ticks, void *param) int round = subset + (pres_waitn_time * pres_notifier_poll_rate * process_num); + if (++subset > (pres_waitn_time * pres_notifier_poll_rate) -1) + subset = 0; + if (process_dialogs(round, 0) < 0) { LM_ERR("Handling non presence.winfo dialogs\n");

1 0

git:4.0: outbound: Fix freeing null pointer in destroy function
by Hugh Waite 12 Aug '13

12 Aug '13

Module: sip-router Branch: 4.0 Commit: 6abd4b4d1eeea2c57a8bcfb071fadaca21efc20f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6abd4b4… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Jul 16 10:51:29 2013 +0100 outbound: Fix freeing null pointer in destroy function - Only appears in error cases, e.g. syntax check (cherry picked from commit e88af0a02de79fac583c126f08d762f7ef3f1b01) --- modules/outbound/ob_mod.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index 3d4d967..6318b16 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -112,7 +112,8 @@ static int mod_init(void) static void destroy(void) { - shm_free(ob_key.s); + if (ob_key.s) + shm_free(ob_key.s); } /* Structure of flow-token

1 0

[tracker] Comment added: debugger: new RPC command dbg.reset_msgid
by sip-router 12 Aug '13

12 Aug '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#330 - debugger: new RPC command dbg.reset_msgid User who did this - Víctor Seva (linuxmaniac) ---------- I just need to be able to reset the msgid ( $mi ) without restart kamailio. I have a logger parser that exports the info ( route, var_dump, sip_in, sip_out ) for every message relaying on the $mi. So, I have test cases for every message $mi.yml in a sipp scenario and several sipp scenarios. So for each one I have to be able to reset $mi. This is the first idea that came to my mind. Add a debugger parameter to enable the functionality, a callback at receive and a new debugger RPC command to reset the id. Can you explain me how can I do this without messing around in a normal environment? What is that debbuger pre-script function? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=330#comment1045 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: debugger: new RPC command dbg.reset_msgid
by sip-router 12 Aug '13

12 Aug '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#330 - debugger: new RPC command dbg.reset_msgid User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you detail a bit more about this need? Adding this condition in core does not seem the right way just for some test cases. If it is not too late, maybe is ok to do it in pre-script callback function done in debugger module, so in config gets with the msg id you want. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=330#comment1044 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

releasing v3.3.5
by Daniel-Constantin Mierla 12 Aug '13

12 Aug '13

Hello, I am considering to package soon a new version out of branch 3.3. If anyone has spotted fixes that should be backported to that branch, reply here. I'm not sure yet of an exact date, but should be rather soon, being just a patch update. A new release out of branch 4.0 will be done short after this one. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

3 7

[tracker] PM request denied: Possible memory leak in srdb1
by sip-router 09 Aug '13

09 Aug '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A Project Manager has denied the request pending for the following task: FS#319 - Possible memory leak in srdb1 User who did this - Daniel-Constantin Mierla (miconda) Reason for denial: Commented in the issue. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=319 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:mgw/free_faked_req: tm: fix memory leak in free_faked_req
by Matthew Williams 09 Aug '13

09 Aug '13

Module: sip-router Branch: mgw/free_faked_req Commit: f326b3070d8af8f84b3b9b077e029d43ec7f7000 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f326b30… Author: Matthew Williams <mgwilliams(a)gmail.com> Committer: Matthew Williams <mgwilliams(a)gmail.com> Date: Thu Aug 8 16:43:08 2013 -0700 tm: fix memory leak in free_faked_req --- modules/tm/t_reply.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 97b813f..ce1301a 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -973,6 +973,11 @@ void free_faked_req(struct sip_msg *faked_req, struct cell *t) faked_req->dst_uri.s = 0; } + if (faked_req->path_vec.s) { + pkg_free(faked_req->path_vec.s); + faked_req->path_vec.len=0; + } + /* free all types of lump that were added in failure handlers */ del_nonshm_lump( &(faked_req->add_rm) ); del_nonshm_lump( &(faked_req->body_lumps) );

2 2

← Newer
1
...
9
10
11
12
13
14
15
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2013