sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

[tracker] Task closed: error when calling uac_replace_from from branch route
by sip-router 18 Jul '13

18 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#323 - error when calling uac_replace_from from branch route User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch in master and 4.0 branches. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=323 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.0: uac: restrict check of multiple from/ to header changes to request route blocks
by Daniel-Constantin Mierla 18 Jul '13

18 Jul '13

Module: sip-router Branch: 4.0 Commit: 86864275e240be94d901fe21dde2472701e1669e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8686427… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 17 20:19:28 2013 +0200 uac: restrict check of multiple from/to header changes to request route blocks - it can occur many times in due to branch route usage - reported by Andrew Pogrebennyk, FS#323 (cherry picked from commit d3a0a8b15af59846fdaee5d9ceae61484f1d7301) --- modules/uac/replace.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/uac/replace.c b/modules/uac/replace.c index 791d69b..7f1f92c 100644 --- a/modules/uac/replace.c +++ b/modules/uac/replace.c @@ -39,6 +39,7 @@ #include "../../parser/parse_from.h" #include "../../mem/mem.h" #include "../../data_lump.h" +#include "../../route.h" #include "../../modules/tm/h_table.h" #include "../../modules/tm/tm_load.h" #include "../rr/api.h" @@ -251,10 +252,12 @@ int replace_uri( struct sip_msg *msg, str *display, str *uri, str * dlgvar_names; uac_flag = (hdr==msg->from)?FL_USE_UAC_FROM:FL_USE_UAC_TO; - if(msg->msg_flags & uac_flag) - { - LM_ERR("Called uac_replace multiple times on the message\n"); - return -1; + if(get_route_type()==REQUEST_ROUTE) { + if(msg->msg_flags & uac_flag) + { + LM_ERR("Called uac_replace multiple times on the message\n"); + return -1; + } } /* consistency check! in AUTO mode, do NOT allow URI changing

1 0

[tracker] Comment added: error when calling uac_replace_from from branch route
by sip-router 18 Jul '13

18 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#323 - error when calling uac_replace_from from branch route User who did this - Víctor Seva (linuxmaniac) ---------- This fix should to be pushed to 4.0 too, doesn't it? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=323#comment1019 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: error when calling uac_replace_from from branch route
by sip-router 18 Jul '13

18 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#323 - error when calling uac_replace_from from branch route User who did this - Andrew Pogrebennyk (marduk) ---------- Thank you Daniel, it works. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=323#comment1018 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: tm doesn't relay changed 'To' header in CANCEL before dialog is established
by sip-router 18 Jul '13

18 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#325 - tm doesn't relay changed 'To' header in CANCEL before dialog is established User who did this - Daniel-Constantin Mierla (miconda) ---------- The 3.3.x does not check the To-header change flag, it should be backported. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=325#comment1017 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: error when calling uac_replace_from from branch route
by sip-router 17 Jul '13

17 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#323 - error when calling uac_replace_from from branch route User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you try the patch from: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3a0a8b… ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=323#comment1016 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: tm doesn't relay changed 'To' header in CANCEL before dialog is established
by sip-router 17 Jul '13

17 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#325 - tm doesn't relay changed 'To' header in CANCEL before dialog is established User who did this - Trip Volpe (tvolpe) ---------- We're running 3.3.4. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=325#comment1015 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: uac: restrict check of multiple from/ to header changes to request route blocks
by Daniel-Constantin Mierla 17 Jul '13

17 Jul '13

Module: sip-router Branch: master Commit: d3a0a8b15af59846fdaee5d9ceae61484f1d7301 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3a0a8b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 17 20:19:28 2013 +0200 uac: restrict check of multiple from/to header changes to request route blocks - it can occur many times in due to branch route usage - reported by Andrew Pogrebennyk, FS#323 --- modules/uac/replace.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/uac/replace.c b/modules/uac/replace.c index 791d69b..7f1f92c 100644 --- a/modules/uac/replace.c +++ b/modules/uac/replace.c @@ -39,6 +39,7 @@ #include "../../parser/parse_from.h" #include "../../mem/mem.h" #include "../../data_lump.h" +#include "../../route.h" #include "../../modules/tm/h_table.h" #include "../../modules/tm/tm_load.h" #include "../rr/api.h" @@ -251,10 +252,12 @@ int replace_uri( struct sip_msg *msg, str *display, str *uri, str * dlgvar_names; uac_flag = (hdr==msg->from)?FL_USE_UAC_FROM:FL_USE_UAC_TO; - if(msg->msg_flags & uac_flag) - { - LM_ERR("Called uac_replace multiple times on the message\n"); - return -1; + if(get_route_type()==REQUEST_ROUTE) { + if(msg->msg_flags & uac_flag) + { + LM_ERR("Called uac_replace multiple times on the message\n"); + return -1; + } } /* consistency check! in AUTO mode, do NOT allow URI changing

1 0

[tracker] Comment added: tm doesn't relay changed 'To' header in CANCEL before dialog is established
by sip-router 17 Jul '13

17 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#325 - tm doesn't relay changed 'To' header in CANCEL before dialog is established User who did this - Daniel-Constantin Mierla (miconda) ---------- What version are you running? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=325#comment1014 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: tm doesn't relay changed 'To' header in CANCEL before dialog is established
by sip-router 17 Jul '13

17 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#325 - tm doesn't relay changed 'To' header in CANCEL before dialog is established User who did this - Trip Volpe (tvolpe) ---------- Hmm, I just tried uac_replace_to(): it correctly replaces the To header, but the change is still not reflected on relaying a subsequent CANCEL. Is there something else that has to be done for tm to remember and substitute the new To URI? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=325#comment1013 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013