sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

by Shane Harrison

Hi Peter, In thread: http://lists.kamailio.org/pipermail/sr-dev/2013-January/018347.html you mentioned transaction support that you have added to PostgreSQL driver. Unfortunately I do need to use mysql as our HA solution is based on mysql cluster. Hence I have implemented the required new functions e.g start_transaction. However mysql only has one table locking mode (unlike PostgreSQL) and if you lock a table within a transaction, you can't read other tables without also obtaining locks for them as well. As there are places where active_watchers table is locked but the code tries to query the watchers table, this is an issue. I have simply disabled the table locking for the time being. It is possible that the implicit transaction locking that mysql is enough to solve the issues you were trying to solve. To determine this, can you tell me or point to a thread that explains what race conditions were trying to be mitigated in process_notifier mode. Cheers and thanks Shane -- Imagination NZ Ltd Level 6 92 Queens Drive P0 Box 30449 Lower Hutt 5040 +64 4 5703870 Extn 875 +64 21 608919 (mobile)

10 years, 8 months

git:tmp/tm_async_reply_support: Merge branch 'master' into tmp/ tm_async_reply_support

by Richard Good

Module: sip-router Branch: tmp/tm_async_reply_support Commit: 2ee08195d53cdb78dc7491958a2a12db7f7b23b0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2ee0819… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Mon Jul 29 17:36:25 2013 +0200 Merge branch 'master' into tmp/tm_async_reply_support ---

10 years, 8 months

[tracker] Comment added: bugs in uac_redirect module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#327 - bugs in uac_redirect module User who did this - Federico Cabiddu (lester) ---------- Imho the fact that the pool_id stores it's not so strange. While the other db modules implement the interface with the engine, db_flatstore implement the interface and the engine. The dir part of the connection is actually the db_url, while the pools are an "internal" mechanism to optimize file write/read, without opening/closing the file for each request. About the pkg_malloc question: I cannot answer but I can dig in the code to try to understand if there are some drawbacks. Thank you for looking at it. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=327#comment1039 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

git:richard.good/diameter_rx_media: Merge branch 'master' into richard.good /diameter_rx_media

by Richard Good

Module: sip-router Branch: richard.good/diameter_rx_media Commit: 81c8398b462c4449f5307d5c3bdbfa8fc6e756f0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=81c8398… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Mon Jul 29 16:10:03 2013 +0200 Merge branch 'master' into richard.good/diameter_rx_media ---

10 years, 8 months

[tracker] Comment added: bugs in uac_redirect module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#327 - bugs in uac_redirect module User who did this - Daniel-Constantin Mierla (miconda) ---------- I applied the first patch for acc module. For the second one I wanted to ask first if the new pkg malloc is safe for runtime, not to result in a leak. I hadn't have the time to look at the code in more details. I saw it has a part of freeing the table name, just don't know if both of the functions are executed together. Also, seems a bit strange for me that the table name is part of the database id. Only the db_url should be taken in consideration. But I haven't used flatstore in ages to know its insights by heart. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=327#comment1038 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

git:master: Merge branch 'master' of ssh://git.sip-router.org/sip-router

by Carlos Ruiz Diaz

Module: sip-router Branch: master Commit: 1bf5c8328e8b4ed13f6404bf617cac9e26c05e63 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1bf5c83… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Mon Jul 29 09:49:57 2013 -0400 Merge branch 'master' of ssh://git.sip-router.org/sip-router ---

10 years, 8 months

git:master: acc: acc_db_set_table_name fixup

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 7ba6cbfcaf70cb546ea3a9f148a0f0b0bc38c16d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7ba6cbf… Author: Federico Cabiddu <fcabiddu(a)orange-vallee.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jul 29 07:59:13 2013 +0200 acc: acc_db_set_table_name fixup - add termination char to db_table_name_buf --- modules/acc/acc_logic.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 55b4196..c9bdd20 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -197,6 +197,8 @@ int acc_db_set_table_name(struct sip_msg *msg, void *param, str *table) return -1; } strncpy(db_table_name_buf, dbtable.s, dbtable.len); + /* FS#327: since the buffer is static terminate the table name */ + db_table_name_buf[dbtable.len] = '\0'; env_set_text(db_table_name_buf, dbtable.len); } else { if(table==NULL) {

10 years, 8 months

git:master: Modified cnxcc_set_max_credit behavior

by Carlos Ruiz Diaz

Module: sip-router Branch: master Commit: 0e9b4b351e70323fd8581d298f1a7d682f2310fe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e9b4b3… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Mon Jul 29 09:46:35 2013 -0400 Modified cnxcc_set_max_credit behavior - Updated documentation - Updated examples --- modules/cnxcc/doc/cnxcc.xml | 4 +- modules/cnxcc/doc/cnxcc_admin.xml | 118 ++++++++++++++++++++++++++++++++++++- 2 files changed, 118 insertions(+), 4 deletions(-) diff --git a/modules/cnxcc/doc/cnxcc.xml b/modules/cnxcc/doc/cnxcc.xml index bb3125b..866be3f 100644 --- a/modules/cnxcc/doc/cnxcc.xml +++ b/modules/cnxcc/doc/cnxcc.xml @@ -17,7 +17,7 @@ <firstname>Carlos</firstname> <surname>Ruiz Diaz</surname> <affiliation> - <orgname>ConexionGroup SA</orgname> + <orgname>ConexionGroup S.A.</orgname> </affiliation> <address> <email>carlos.ruizdiaz(a)gmail.com</email> @@ -25,7 +25,7 @@ </author> </authorgroup> <copyright> - <year>2012</year> + <year>2013</year> <holder>Carlos Ruiz Diaz, carlos.ruizdiaz(a)gmail.com</holder> </copyright> </bookinfo> diff --git a/modules/cnxcc/doc/cnxcc_admin.xml b/modules/cnxcc/doc/cnxcc_admin.xml index 12e976c..6c6d4cc 100644 --- a/modules/cnxcc/doc/cnxcc_admin.xml +++ b/modules/cnxcc/doc/cnxcc_admin.xml @@ -37,6 +37,11 @@ If your accounting program does not maintain the state of the call in real time, this module can provide you that ability. </para> + <para> + Cnxcc can also provide more common means of monitoring, i.e., by time limit or by maximum simultaneous calls. + </para> + + </section> <section> @@ -120,6 +125,13 @@ modparam("cnxcc", "credit_check_period", 1) <emphasis>-1 - failed, error logged</emphasis> </para> </listitem> + + <listitem> + <para> + <emphasis>-2 - failed, credit value is less than initial pulse value</emphasis> + </para> + </listitem> + </itemizedlist> </para> <example> @@ -168,13 +180,115 @@ cnxcc_set_max_credit("$var(customer)", "$var(credit)", "$var(cps)", "$var(initia $var(customer) = "john-doe-123-basic"; $var(max_time) = 120; -cnxcc_set_max_tim ("$var(customer)", "$var(max_time)"); +cnxcc_set_max_time("$var(customer)", "$var(max_time)"); +... + </programlisting> + </example> + </section> + + <section> + <title> + <function moreinfo="none">cnxcc_set_max_channel()</function> + </title> + <para> + Specifies a limit for the number of simultaneous calls + </para> + <para> + <emphasis>Return code:</emphasis> + <itemizedlist> + <listitem> + <para> + <emphasis>1 - successful</emphasis> + </para> + </listitem> + + <listitem> + <para> + <emphasis>-1 - failed, error logged</emphasis> + </para> + </listitem> + + <listitem> + <para> + <emphasis>-2 - failed, calls established plus calls being established result in more than the limit you specified</emphasis> + </para> + </listitem> + + <listitem> + <para> + <emphasis>-3 - failed, number of calls established is more than the limit you specified</emphasis> + </para> + </listitem> + + </itemizedlist> + </para> + <example> + <title>cnxcc_set_max_time()</title> + <programlisting format="linespecific"> +... +$var(customer) = "john-doe-123-basic"; +$var(max_chan) = 2; +$var(retcode) = cnxcc_set_max_channels("$var(customer)", "$var(max_chan)"); + +if ($var(retcode) == -1) { + xlog("Error setting up credit control"); + return; +} + +if ($var(retcode) < -1) { + xlog("Too many channels for customer"); + sl_send_reply(403, "Forbidden"); + + if (!cnxcc_terminate_all("$var(customer)")) { + xlog("Error terminating customer's calls"); + } + + exit; +} + +... + </programlisting> + </example> + </section> + + <section> + <title> + <function moreinfo="none">cnxcc_terminate_all()</function> + </title> + <para> + Terminates all calls of the specified customer/profile + </para> + <para> + <emphasis>Return code:</emphasis> + <itemizedlist> + <listitem> + <para> + <emphasis>1 - successful</emphasis> + </para> + </listitem> + + <listitem> + <para> + <emphasis>-1 - failed, error logged</emphasis> + </para> + </listitem> + </itemizedlist> + </para> + <example> + <title>cnxcc_set_max_time()</title> + <programlisting format="linespecific"> +... +$var(customer) = "john-doe-123-basic"; + +if (!cnxcc_terminate_all("$var(customer)")) { + xlog("Error terminating customer's calls"); +} ... </programlisting> </example> </section> </section> - + <section> <title>Exported RPC Commands</title>

10 years, 8 months

[tracker] Task closed: Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#328 - Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=328 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 8 months

[tracker] Comment added: bugs in uac_redirect module (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#327 - bugs in uac_redirect module User who did this - Federico Cabiddu (lester) ---------- Forgot to attach the file. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=327#comment1037 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013