sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

[tracker] Task closed: pipelimit pl_set_pipe command is broken

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#315 - pipelimit pl_set_pipe command is broken User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=315 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: pipelimit pl_set_pipe command is broken

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#315 - pipelimit pl_set_pipe command is broken User who did this - Daniel-Constantin Mierla (miconda) ---------- A fix for blocking should be now in master and 4.0 branches. Re-open if still some issues. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=315#comment986 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

git:4.0: pipelimit: avoid double locking when changing pipe via rpc

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 3612981970e8002b3ab7f7d0324354e282205e2b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3612981… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 11 14:36:02 2013 +0200 pipelimit: avoid double locking when changing pipe via rpc (cherry picked from commit 0c6fef5fdc2a586ebfa607d3b5344266c08ca996) --- modules/pipelimit/pl_ht.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/modules/pipelimit/pl_ht.c b/modules/pipelimit/pl_ht.c index a6b9b8a..f044203 100644 --- a/modules/pipelimit/pl_ht.c +++ b/modules/pipelimit/pl_ht.c @@ -675,16 +675,14 @@ void rpc_pl_set_pipe(rpc_t *rpc, void *c) it->algo = algo_id; it->limit = limit; + pl_pipe_release(&pipeid); if (check_feedback_setpoints(0)) { - pl_pipe_release(&pipeid); LM_ERR("feedback limits don't match\n"); rpc->fault(c, 400, "Feedback limits don't match"); return; } else { *_pl_pid_setpoint = 0.01 * (double)_pl_cfg_setpoint; } - - pl_pipe_release(&pipeid); }

11 years, 5 months

git:4.0: pipelimit: avoid double locking when changing pipe via mi

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 5e11ebf34bd525f02c7ff08b9520382c3aaf00f2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5e11ebf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 11 14:32:48 2013 +0200 pipelimit: avoid double locking when changing pipe via mi - reported by Krischan Udelhoven, FS#315 (cherry picked from commit 04fd56dc1b84b70a04438ccbf719eb85177524ad) --- modules/pipelimit/pl_ht.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/pipelimit/pl_ht.c b/modules/pipelimit/pl_ht.c index 1146468..a6b9b8a 100644 --- a/modules/pipelimit/pl_ht.c +++ b/modules/pipelimit/pl_ht.c @@ -566,16 +566,15 @@ struct mi_root* mi_set_pipe(struct mi_root* cmd_tree, void* param) it->algo = algo_id; it->limit = limit; + pl_pipe_release(&pipeid); + if (check_feedback_setpoints(0)) { - pl_pipe_release(&pipeid); LM_ERR("feedback limits don't match\n"); goto error; } else { *_pl_pid_setpoint = 0.01 * (double)_pl_cfg_setpoint; } - pl_pipe_release(&pipeid); - return init_mi_tree( 200, MI_OK_S, MI_OK_LEN); error: return init_mi_tree( 400, MI_BAD_PARM_S, MI_BAD_PARM_LEN);

11 years, 5 months

git:master: pipelimit: avoid double locking when changing pipe via rpc

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 0c6fef5fdc2a586ebfa607d3b5344266c08ca996 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0c6fef5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 11 14:36:02 2013 +0200 pipelimit: avoid double locking when changing pipe via rpc --- modules/pipelimit/pl_ht.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/modules/pipelimit/pl_ht.c b/modules/pipelimit/pl_ht.c index a6b9b8a..f044203 100644 --- a/modules/pipelimit/pl_ht.c +++ b/modules/pipelimit/pl_ht.c @@ -675,16 +675,14 @@ void rpc_pl_set_pipe(rpc_t *rpc, void *c) it->algo = algo_id; it->limit = limit; + pl_pipe_release(&pipeid); if (check_feedback_setpoints(0)) { - pl_pipe_release(&pipeid); LM_ERR("feedback limits don't match\n"); rpc->fault(c, 400, "Feedback limits don't match"); return; } else { *_pl_pid_setpoint = 0.01 * (double)_pl_cfg_setpoint; } - - pl_pipe_release(&pipeid); }

11 years, 5 months

git:master: pipelimit: avoid double locking when changing pipe via mi

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 04fd56dc1b84b70a04438ccbf719eb85177524ad URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=04fd56d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 11 14:32:48 2013 +0200 pipelimit: avoid double locking when changing pipe via mi - reported by Krischan Udelhoven, FS#315 --- modules/pipelimit/pl_ht.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/pipelimit/pl_ht.c b/modules/pipelimit/pl_ht.c index 1146468..a6b9b8a 100644 --- a/modules/pipelimit/pl_ht.c +++ b/modules/pipelimit/pl_ht.c @@ -566,16 +566,15 @@ struct mi_root* mi_set_pipe(struct mi_root* cmd_tree, void* param) it->algo = algo_id; it->limit = limit; + pl_pipe_release(&pipeid); + if (check_feedback_setpoints(0)) { - pl_pipe_release(&pipeid); LM_ERR("feedback limits don't match\n"); goto error; } else { *_pl_pid_setpoint = 0.01 * (double)_pl_cfg_setpoint; } - pl_pipe_release(&pipeid); - return init_mi_tree( 200, MI_OK_S, MI_OK_LEN); error: return init_mi_tree( 400, MI_BAD_PARM_S, MI_BAD_PARM_LEN);

11 years, 5 months

[tracker] Comment added: Possible memory leak in srdb1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#319 - Possible memory leak in srdb1 User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you provide a patch with what you think is going to fix it? Is easier to review. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=319#comment985 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: Nathelper: modparam natping_processes max value

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#321 - Nathelper: modparam natping_processes max value User who did this - Daniel-Constantin Mierla (miconda) ---------- Is it ok when natping_processes==0? I haven't looked at source code, but your patch has the condition with <0. Maybe when ==0, the core timer process is used... Otherwise is good to go. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=321#comment984 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: error when calling uac_replace_from from branch route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#323 - error when calling uac_replace_from from branch route User who did this - Daniel-Constantin Mierla (miconda) ---------- Changing from should be allowed per branch. There is an option to use the uac module without dialog, are you using that or the mode with dlg variables? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=323#comment983 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

git:tmp/tm_async_reply_support: modules/tm: no need to restore after faked environment for async TM

by Jason Penton

Module: sip-router Branch: tmp/tm_async_reply_support Commit: 33c943b339955dc21c672de1e8fc35bd45fee07c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=33c943b… Author: Jason Penton <jason.penton(a)smilecoms.com> Committer: Jason Penton <jason.penton(a)smilecoms.com> Date: Wed Jul 10 14:40:22 2013 +0200 modules/tm: no need to restore after faked environment for async TM --- modules/tm/t_reply.c | 22 +++------------------- modules/tm/t_suspend.c | 2 +- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index d6f6030..4ab4532 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1019,25 +1019,9 @@ void faked_env_async( struct cell *t, struct sip_msg *msg) { backup_body_lumps = t->uas.request->body_lumps; backup_reply_lump = t->uas.request->reply_lump; } else { - /* restore original environment */ - set_t(backup_t, backup_branch); - global_msg_id=backup_msgid; - set_route_type(backup_route_type); - /* restore original avp list */ - set_avp_list(AVP_TRACK_FROM | AVP_CLASS_USER, backup_user_from ); - set_avp_list(AVP_TRACK_TO | AVP_CLASS_USER, backup_user_to ); - set_avp_list(AVP_TRACK_FROM | AVP_CLASS_DOMAIN, backup_domain_from ); - set_avp_list(AVP_TRACK_TO | AVP_CLASS_DOMAIN, backup_domain_to ); - set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, backup_uri_from ); - set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, backup_uri_to ); -#ifdef WITH_XAVP - xavp_set_list(backup_xavps); -#endif - bind_address=backup_si; - /* restore lump lists */ - t->uas.request->add_rm = backup_add_rm; - t->uas.request->body_lumps = backup_body_lumps; - t->uas.request->reply_lump = backup_reply_lump; + /* on async restore - we don't need to do anything because we never really had + an environment to restore prior to the suspend anyway ;) */ + LM_DBG("nothing to restore for async...\n"); } } diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c index b9806a0..adc8faa 100644 --- a/modules/tm/t_suspend.c +++ b/modules/tm/t_suspend.c @@ -277,7 +277,7 @@ int t_continue(unsigned int hash_index, unsigned int label, /* TODO: save_msg_lumps should clone the lumps to shm mem */ /* restore original environment and free the fake msg */ - faked_env( t, 0); + faked_env_async( t, 0); free_faked_req(&faked_req, t); /* update the flags */

11 years, 5 months

← Newer
1
...
15
16
17
18
19
20
21
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013