sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

mediaproxy-ng failed to rewrite sdp from jssip ws client

by Juha Heinanen

i tried what happens when i make rtpproxy_answer("co2sp") call on 200 ok from jssip ws client. mediaproxy-ng replied with failed to rewrite sdp error. i don't know if there is something wrong in jssip sdp or if there is a bug in mediaproxy-ng. -- juha Jul 12 12:00:35 siika /usr/sbin/sip-proxy[24258]: INFO: ===== making rtpproxy_answer(co2sp) Jul 12 12:00:35 siika mediaproxy-ng[15173]: Got valid command from 127.0.0.1:37753: answer - { "sdp": "v=0#015#012o=- 7784118477498446372 2 IN IP4 127.0.0.1#015#012s=-#015#012t=0 0#015#012a=msid-semantic: WMS Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b#015#012m=audio 52768 RTP/SAVPF 0 8 101#015#012c=IN IP4 192.98.102.10#015#012a=rtcp:35156 IN IP4 192.98.102.10#015#012a=candidate:488769141 1 udp 2113937151 192.98.102.10 52768 typ host generation 0#015#012a=candidate:3477369669 1 udp 2113937151 87.95.11.3 54654 typ host generation 0#015#012a=candidate:488769141 2 udp 2113937150 192.98.102.10 35156 typ host generation 0#015#012a=candidate:3477369669 2 udp 2113937150 87.95.11.3 41538 typ host generation 0#015#012a=candidate:1403124357 1 tcp 1509957375 192.98.102.10 0 typ host generation 0#015#012a=candidate:2177339317 1 tcp 1509957375 87.95.11.3 0 typ host generation 0#015#012a=candidate:1403124357 2 tcp 1509957374 192.98.102.10 0 typ host generation 0#015#012a=candidate:2177339317 2 tcp 1509957374 87.95.11.3 0 typ host generation 0#015#012a=ice-ufrag:84M0GoeLawbPRCtI#015#012a=ice-pwd:0d0+xU+T7a4GeeFSWffXH71m#015#012a=sendrecv#015#012a=mid:audio#015#012a=crypto:0 AES_CM_128_HMAC_SHA1_80 inline:QfUiviqGYSIBnQdS/ZRuYKdBdTF11sjOc107mKS8#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=ssrc:932705198 cname:/crPhms9UoL3P5CY#015#012a=ssrc:932705198 msid:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1ba0#015#012a=ssrc:932705198 mslabel:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b#015#012a=ssrc:932705198 label:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1ba0#015#012m=video 35740 RTP/SAVPF 96#015#012c=IN IP4 192.98.102.10#015#012a=rtcp:40599 IN IP4 192.98.102.10#015#012a=candidate:488769141 1 udp 2113937151 192.98.102.10 35740 typ host generation 0#015#012a=candidate:3477369669 1 udp 2113937151 87.95.11.3 55064 typ host generation 0#015#012a=candidate:488769141 2 udp 2113937150 192.98.102.10 40599 typ host generation 0#015#012a=candidate:3477369669 2 udp 2113937150 87. Jul 12 12:00:35 siika mediaproxy-ng[15173]: [7cd288942112dd88 - z9hG4bK779cdf1cf94f5904] Got LOOKUP, but no usable callstreams found Jul 12 12:00:35 siika mediaproxy-ng[15173]: Error rewriting SDP Jul 12 12:00:35 siika mediaproxy-ng[15173]: Protocol error in packet from 127.0.0.1:37753: Error rewriting SDP [d3:sdp2555:v=0#015#012o=- 7784118477498446372 2 IN IP4 127.0.0.1#015#012s=-#015#012t=0 0#015#012a=msid-semantic: WMS Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b#015#012m=audio 52768 RTP/SAVPF 0 8 101#015#012c=IN IP4 192.98.102.10#015#012a=rtcp:35156 IN IP4 192.98.102.10#015#012a=candidate:488769141 1 udp 2113937151 192.98.102.10 52768 typ host generation 0#015#012a=candidate:3477369669 1 udp 2113937151 87.95.11.3 54654 typ host generation 0#015#012a=candidate:488769141 2 udp 2113937150 192.98.102.10 35156 typ host generation 0#015#012a=candidate:3477369669 2 udp 2113937150 87.95.11.3 41538 typ host generation 0#015#012a=candidate:1403124357 1 tcp 1509957375 192.98.102.10 0 typ host generation 0#015#012a=candidate:2177339317 1 tcp 1509957375 87.95.11.3 0 typ host generation 0#015#012a=candidate:1403124357 2 tcp 1509957374 192.98.102.10 0 typ host generation 0#015#012a=candidate:2177339317 2 tcp 1509957374 87.95.11.3 0 typ host generation 0#015#012a=ice-ufrag:84M0GoeLawbPRCtI#015#012a=ice-pwd:0d0+xU+T7a4GeeFSWffXH71m#015#012a=sendrecv#015#012a=mid:audio#015#012a=crypto:0 AES_CM_128_HMAC_SHA1_80 inline:QfUiviqGYSIBnQdS/ZRuYKdBdTF11sjOc107mKS8#015#012a=rtpmap:0 PCMU/8000#015#012a=rtpmap:8 PCMA/8000#015#012a=rtpmap:101 telephone-event/8000#015#012a=ssrc:932705198 cname:/crPhms9UoL3P5CY#015#012a=ssrc:932705198 msid:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1ba0#015#012a=ssrc:932705198 mslabel:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1b#015#012a=ssrc:932705198 label:Eu5Sypk7W9nqcEJTwC2L8NseDJ5errAYzo1ba0#015#012m=video 35740 RTP/SAVPF 96#015#012c=IN IP4 192.98.102.10#015#012a=rtcp:40599 IN IP4 192.98.102.10#015#012a=candidate:488769141 1 udp 2113937151 192.98.102.10 35740 typ host generation 0#015#012a=candidate:3477369669 1 udp 2113937151 87.95.11.3 55064 typ host generation 0#015#012a=candidate:488769141 2 udp 2113937150 192.98.102.10 40599 typ host generation 0#015#012a=candidate:3477369669 Jul 12 12:00:35 siika mediaproxy-ng[15173]: Returning to SIP proxy: d6:result5:error12:error-reason19:Error rewriting SDPe Jul 12 12:00:35 siika /usr/sbin/sip-proxy[24258]: ERROR: rtpproxy-ng [rtpproxy.c:1343]: rtpp_function_call(): proxy replied with error: Error rewriting SDP

10 years, 11 months

[tracker] Comment added: Entity URI in NOTIFY XML body

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#324 - Entity URI in NOTIFY XML body User who did this - Pawel Sternal (Sternik) ---------- Yes, you're right. I forgot to update len check. And yes, this work with all phones which I test. Polycom seems to be rfc pedantic piece of hardware. Module parameter would be ok because I don't know how to mark this subscription without hardcoding "polycom" as User-Agent. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=324#comment998 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

[tracker] Task opened: Entity URI in NOTIFY XML body (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Pawel Sternal (Sternik) Attached to Project - sip-router Summary - Entity URI in NOTIFY XML body Task Type - Improvement Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Hi. We had a small problem with polycom phones to realize blf functionality. On yealink, cisco, aastra etc works like a charm. We discover that in xml body of NOTIFY, entity uri doesn't contain a "sip:" value. In RFC 4235 however in xml body "sip:" is on every example. I've modify notify_body.c in presence_dialoginfo module to enable BLF functionality for polycom phone by adding "sip:" to entity pres and it works. I wonder it's ok? I've attach sip trace before the change and diff of notify_body. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=324 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

[tracker] Comment added: Entity URI in NOTIFY XML body

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#324 - Entity URI in NOTIFY XML body User who did this - Daniel-Constantin Mierla (miconda) ---------- Does this work with all the phones? I wonder if there has to be a flag to do it per subscription dialog or maybe a module parameter to control this. The patch is missing the update of the uri len check, not to overflow the buffer it is built in. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=324#comment997 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

[tracker] Comment added: Entity URI in NOTIFY XML body (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#324 - Entity URI in NOTIFY XML body User who did this - Pawel Sternal (Sternik) ---------- And this is a log before I've patch notify_body.c ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=324#comment996 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

[tracker] Comment added: error when calling uac_replace_from from branch route

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#323 - error when calling uac_replace_from from branch route User who did this - Andrew Pogrebennyk (marduk) ---------- restore_mode is set to auto (as it was in our config for 3.3.x) and restore_dlg is not set with 0 being the default. The config is as follows: modparam("uac", "rr_from_store_param", "vsf") modparam("uac", "restore_mode", "auto") modparam("uac", "restore_passwd", "XYZ") ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=323#comment995 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

git:3.3: core: avoid doing dns srv again after naptr function that includes srv lookup

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.3 Commit: 211ef44012b744f05db1ff17cf23f824727ee6da URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=211ef44… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 12 00:44:51 2013 +0200 core: avoid doing dns srv again after naptr function that includes srv lookup (cherry picked from commit 80935f9e8bbe20e5c320828183999b5d395ec34c) --- resolve.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/resolve.c b/resolve.c index 17772b7..3537b88 100644 --- a/resolve.c +++ b/resolve.c @@ -1515,6 +1515,7 @@ struct hostent* _sip_resolvehost(str* name, unsigned short* port, char* proto) #ifdef USE_NAPTR if (cfg_get(core, core_cfg, dns_try_naptr)) res = naptr_sip_resolvehost(name, port, proto); + else #endif res = srv_sip_resolvehost(name, 0, port, proto, 0, 0); if( unlikely(!res) ){

10 years, 11 months

git:4.0: core: avoid doing dns srv again after naptr function that includes srv lookup

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: f8826df994a6baac9cfee219abafa3e1b82ee4f8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f8826df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 12 00:44:51 2013 +0200 core: avoid doing dns srv again after naptr function that includes srv lookup (cherry picked from commit 80935f9e8bbe20e5c320828183999b5d395ec34c) --- resolve.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/resolve.c b/resolve.c index 0a77ed7..e739f4b 100644 --- a/resolve.c +++ b/resolve.c @@ -1702,6 +1702,7 @@ struct hostent* _sip_resolvehost(str* name, unsigned short* port, char* proto) #ifdef USE_NAPTR if (cfg_get(core, core_cfg, dns_try_naptr)) res = naptr_sip_resolvehost(name, port, proto); + else #endif res = srv_sip_resolvehost(name, 0, port, proto, 0, 0); if( unlikely(!res) ){

10 years, 11 months

git:master: dispatcher: allow pv in ds_is_from_list(setid) parameter

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 9a25e712529cb7aacbae8e64a2e1be4da3c9a8c3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9a25e71… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 12 10:22:33 2013 +0200 dispatcher: allow pv in ds_is_from_list(setid) parameter --- modules/dispatcher/README | 4 +++- modules/dispatcher/dispatcher.c | 10 ++++++++-- modules/dispatcher/doc/dispatcher_admin.xml | 4 +++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/modules/dispatcher/README b/modules/dispatcher/README index 4736445..9f8e73c 100644 --- a/modules/dispatcher/README +++ b/modules/dispatcher/README @@ -829,7 +829,9 @@ failure_route[tryagain] { Parameter groupid is optional, when it is missing, then the matching will be done against all addresses in all groups. Upon a match, the variable specified by 'setid_pvname' parameter will be set to groupid - of matching address. + of matching address and the attributes will be set in variable + specified by 'attrs_pvname'. The parameter can be an integer or a + variable holding an integer value. This function can be used from ANY_ROUTE. diff --git a/modules/dispatcher/dispatcher.c b/modules/dispatcher/dispatcher.c index 4af6757..9cb5ed5 100644 --- a/modules/dispatcher/dispatcher.c +++ b/modules/dispatcher/dispatcher.c @@ -183,7 +183,7 @@ static cmd_export_t cmds[]={ {"ds_is_from_list", (cmd_function)w_ds_is_from_list0, 0, 0, 0, REQUEST_ROUTE|FAILURE_ROUTE|ONREPLY_ROUTE|BRANCH_ROUTE}, {"ds_is_from_list", (cmd_function)w_ds_is_from_list1, 1, - fixup_uint_null, 0, ANY_ROUTE}, + fixup_igp_null, 0, ANY_ROUTE}, {"ds_load_unset", (cmd_function)w_ds_load_unset, 0, 0, 0, ANY_ROUTE}, {"ds_load_update", (cmd_function)w_ds_load_update, 0, @@ -807,7 +807,13 @@ static int w_ds_is_from_list0(struct sip_msg *msg, char *str1, char *str2) static int w_ds_is_from_list1(struct sip_msg *msg, char *set, char *str2) { - return ds_is_from_list(msg, (int)(long)set); + int s; + if(fixup_get_ivalue(msg, (gparam_p)set, &s)!=0) + { + LM_ERR("cannot get set id value\n"); + return -1; + } + return ds_is_from_list(msg, s); } static int ds_parse_reply_codes() { diff --git a/modules/dispatcher/doc/dispatcher_admin.xml b/modules/dispatcher/doc/dispatcher_admin.xml index 7115225..b63a523 100644 --- a/modules/dispatcher/doc/dispatcher_admin.xml +++ b/modules/dispatcher/doc/dispatcher_admin.xml @@ -986,7 +986,9 @@ failure_route[tryagain] { Parameter groupid is optional, when it is missing, then the matching will be done against all addresses in all groups. Upon a match, the variable specified by 'setid_pvname' parameter will be set to groupid - of matching address. + of matching address and the attributes will be set in variable + specified by 'attrs_pvname'. The parameter can be an integer or a + variable holding an integer value. </para> <para> This function can be used from ANY_ROUTE.

10 years, 11 months

git:master: core: avoid doing dns srv again after naptr function that includes srv lookup

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 80935f9e8bbe20e5c320828183999b5d395ec34c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=80935f9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 12 00:44:51 2013 +0200 core: avoid doing dns srv again after naptr function that includes srv lookup --- resolve.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/resolve.c b/resolve.c index 2005a0b..be47260 100644 --- a/resolve.c +++ b/resolve.c @@ -1679,6 +1679,7 @@ struct hostent* _sip_resolvehost(str* name, unsigned short* port, char* proto) #ifdef USE_NAPTR if (cfg_get(core, core_cfg, dns_try_naptr)) res = naptr_sip_resolvehost(name, port, proto); + else #endif res = srv_sip_resolvehost(name, 0, port, proto, 0, 0); if( unlikely(!res) ){

10 years, 11 months

← Newer
1
...
10
11
12
13
14
15
16
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013