sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
235 discussions

[tracker] Task closed: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Juha Heinanen (jh) Reason for closing: Implemented Additional comments about closing: Patch has been applied. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

git:master: modules/lcr: use pv_cache_get

by Juha Heinanen

Module: sip-router Branch: master Commit: 0f54ee9c29faf767a5ec38de9f70bfaab8836ac9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f54ee9… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Tue Jun 4 10:44:36 2013 +0300 modules/lcr: use pv_cache_get - Applied patch by Victor Seva. --- modules/lcr/lcr_mod.c | 40 +++++++++++++++++++++------------------- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/modules/lcr/lcr_mod.c b/modules/lcr/lcr_mod.c index d5a927e..42d55f2 100644 --- a/modules/lcr/lcr_mod.c +++ b/modules/lcr/lcr_mod.c @@ -402,7 +402,7 @@ static void lcr_db_close(void) */ static int mod_init(void) { - pv_spec_t avp_spec; + pv_spec_t *avp_spec; str s; unsigned short avp_flags; unsigned int i; @@ -475,13 +475,13 @@ static int mod_init(void) if (gw_uri_avp_param && *gw_uri_avp_param) { s.s = gw_uri_avp_param; s.len = strlen(s.s); - if (pv_parse_spec(&s, &avp_spec)==0 - || avp_spec.type!=PVT_AVP) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL|| avp_spec->type!=PVT_AVP) { LM_ERR("malformed or non AVP definition <%s>\n", gw_uri_avp_param); return -1; } - - if (pv_get_avp_name(0, &(avp_spec.pvp), &gw_uri_avp, &avp_flags) != 0) { + + if (pv_get_avp_name(0, &(avp_spec->pvp), &gw_uri_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", gw_uri_avp_param); return -1; } @@ -493,14 +493,14 @@ static int mod_init(void) if (ruri_user_avp_param && *ruri_user_avp_param) { s.s = ruri_user_avp_param; s.len = strlen(s.s); - if (pv_parse_spec(&s, &avp_spec)==0 - || avp_spec.type!=PVT_AVP) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL || avp_spec->type!=PVT_AVP) { LM_ERR("malformed or non AVP definition <%s>\n", ruri_user_avp_param); return -1; } - - if (pv_get_avp_name(0, &(avp_spec.pvp), &ruri_user_avp, &avp_flags) + + if (pv_get_avp_name(0, &(avp_spec->pvp), &ruri_user_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", ruri_user_avp_param); return -1; @@ -513,11 +513,12 @@ static int mod_init(void) if (tag_avp_param) { s.s = tag_avp_param; s.len = strlen(s.s); - if ((pv_parse_spec(&s, &avp_spec)==0) || (avp_spec.type!=PVT_AVP)) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL || (avp_spec->type!=PVT_AVP)) { LM_ERR("malformed or non AVP definition <%s>\n", tag_avp_param); return -1; } - if (pv_get_avp_name(0, &(avp_spec.pvp), &tag_avp, &avp_flags) != 0) { + if (pv_get_avp_name(0, &(avp_spec->pvp), &tag_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", tag_avp_param); return -1; } @@ -526,11 +527,12 @@ static int mod_init(void) if (flags_avp_param) { s.s = flags_avp_param; s.len = strlen(s.s); - if ((pv_parse_spec(&s, &avp_spec)==0) || (avp_spec.type != PVT_AVP)) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL || (avp_spec->type != PVT_AVP)) { LM_ERR("malformed or non AVP definition <%s>\n", flags_avp_param); return -1; } - if (pv_get_avp_name(0, &(avp_spec.pvp), &flags_avp, &avp_flags) != 0) { + if (pv_get_avp_name(0, &(avp_spec->pvp), &flags_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", flags_avp_param); return -1; } @@ -540,13 +542,13 @@ static int mod_init(void) if (defunct_capability_param > 0) { if (defunct_gw_avp_param && *defunct_gw_avp_param) { s.s = defunct_gw_avp_param; s.len = strlen(s.s); - if ((pv_parse_spec(&s, &avp_spec) == 0) || - (avp_spec.type != PVT_AVP)) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL || (avp_spec->type != PVT_AVP)) { LM_ERR("malformed or non AVP definition <%s>\n", defunct_gw_avp_param); return -1; } - if (pv_get_avp_name(0, &(avp_spec.pvp), &defunct_gw_avp, + if (pv_get_avp_name(0, &(avp_spec->pvp), &defunct_gw_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", defunct_gw_avp_param); return -1; @@ -558,13 +560,13 @@ static int mod_init(void) } if (lcr_id_avp_param && *lcr_id_avp_param) { s.s = lcr_id_avp_param; s.len = strlen(s.s); - if ((pv_parse_spec(&s, &avp_spec) == 0) || - (avp_spec.type != PVT_AVP)) { + avp_spec = pv_cache_get(&s); + if (avp_spec==NULL || (avp_spec->type != PVT_AVP)) { LM_ERR("malformed or non AVP definition <%s>\n", lcr_id_avp_param); return -1; } - if (pv_get_avp_name(0, &(avp_spec.pvp), &lcr_id_avp, + if (pv_get_avp_name(0, &(avp_spec->pvp), &lcr_id_avp, &avp_flags) != 0) { LM_ERR("invalid AVP definition <%s>\n", lcr_id_avp_param); return -1;

10 years, 11 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Daniel-Constantin Mierla (miconda) ---------- To clarify, a patch to use the core pv cache instead of parsing locally the PV specs is good, because can help in using lower memory and eventually faster startup -- over all it cannot not make it worse, but better. If this patch is done well, should be applied. My concern was related to dumping PV values at runtime via rpc, which is in another item FS#307. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment931 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Juha Heinanen (jh) ---------- Looks like there is some uncertainty about the patch. I leave it uncommitted for now until there is agreement that the patch makes sense. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment930 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

git:master: modules/auth_db: regenerate README

by Klaus Darilion

Module: sip-router Branch: master Commit: 76709d2ea2eb3c05cf62a3368310f50e8bfee355 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=76709d2… Author: Klaus Darilion <klaus.mailinglists(a)pernau.at> Committer: Klaus Darilion <klaus.mailinglists(a)pernau.at> Date: Mon Jun 3 22:13:20 2013 +0000 modules/auth_db: regenerate README --- modules/auth_db/README | 281 ++++++++++++++++++++++++------------------------ 1 files changed, 142 insertions(+), 139 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=767…

10 years, 11 months

git:master: modules/auth_db: document authentication return values

by Klaus Darilion

Module: sip-router Branch: master Commit: 2940d5012250a134745a2cf9abed2f88ed95576e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2940d50… Author: Klaus Darilion <klaus.mailinglists(a)pernau.at> Committer: Klaus Darilion <klaus.mailinglists(a)pernau.at> Date: Mon Jun 3 22:10:20 2013 +0000 modules/auth_db: document authentication return values --- modules/auth_db/doc/auth_db_admin.xml | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/modules/auth_db/doc/auth_db_admin.xml b/modules/auth_db/doc/auth_db_admin.xml index 999c3cf..246d532 100644 --- a/modules/auth_db/doc/auth_db_admin.xml +++ b/modules/auth_db/doc/auth_db_admin.xml @@ -327,13 +327,27 @@ modparam("auth_db", "version_table", 0) occurred and no reply was sent out; </para></listitem> <listitem><para> - <emphasis>-2 (invalid password)</emphasis> - valid user, but - wrong password; + <emphasis>-2 (invalid password)</emphasis> - wrong password; </para></listitem> <listitem><para> <emphasis>-3 (invalid user)</emphasis> - authentication user does not exist. </para></listitem> + <listitem><para> + <emphasis>-4 (nonce expired)</emphasis> - the nonce has expired + </para></listitem> + <listitem><para> + <emphasis>-5 (no credentials)</emphasis> - request does not contain + an Authorization header with the correct realm. + </para></listitem> + <listitem><para> + <emphasis>-6 (nonce reused)</emphasis> - the nonce has already been + used to authenticate a previous request + </para></listitem> + <listitem><para> + <emphasis>-8 (authuser mismatch)</emphasis> - depending on the method, th + From/To/RURI user does not match the authentication user (see auth_check() function). + </para></listitem> </itemizedlist> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -479,6 +493,8 @@ if (!proxy_authorize("$fd", "subscriber)) { the function checks if authentication username matches From/To header username, and Request-URI in case of PUBLISH. </para> + <para>Negative return codes have the same meaning as for + www_authenticate().</para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> <listitem>

10 years, 11 months

git:master: Makefile: added install-initd-centos target

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5bed1c2f9721405d5e6e0678f583aee474d4b9b9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5bed1c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 3 23:23:15 2013 +0200 Makefile: added install-initd-centos target - install centos specific init.d scripts --- Makefile | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 4f2de07..898f99e 100644 --- a/Makefile +++ b/Makefile @@ -1038,6 +1038,26 @@ install_initd_debian install-initd-debian: --home /var/run/$(NAME) $(NAME) chown $(NAME):$(NAME) /var/run/$(NAME) +.PHONY: install_initd_centos install-initd-centos +install_initd_centos install-initd-centos: + sed -e "s#KAM=/usr/sbin/kamailio#KAM=$(bin_prefix)/$(bin_dir)$(NAME)#g" \ + -e "s#PROG=kamailio#PROG=$(NAME)#g" \ + -e "s#DEFAULTS=/etc/default/kamailio#DEFAULTS=/etc/default/$(NAME)#g" \ + -e "s#PID_FILE=/var/run/kamailio.pid#PID_FILE=/var/run/$(NAME).pid#g" \ + -e "s#LOCK_FILE=/var/lock/subsys/kamailio#LOCK_FILE=/var/lock/subsys/$(NAME)#g" \ + -e "s#KAMCFG=/etc/kamailio/kamailio.cfg#KAMCFG=$(cfg_prefix)/$(cfg_dir)$(NAME).cfg#g" \ + < pkg/kamailio/rpm/kamailio.init \ + > /etc/init.d/$(NAME) + chmod +x /etc/init.d/$(NAME) + sed -e "s#RUN_KAMAILIO=no#RUN_KAMAILIO=yes#g" \ + -e "s#USER=kamailio#USER=$(NAME)#g" \ + -e "s#GROUP=kamailio#GROUP=$(NAME)#g" \ + < pkg/kamailio/rpm/kamailio.default \ + > /etc/default/$(NAME) + /usr/sbin/groupadd -r $(NAME) + /usr/sbin/useradd -r -g $(NAME) -s /bin/false -c "Kamailio Daemon" \ + -d ${lib_prefix}/${lib_dir} $(NAME) + .PHONY: dbschema dbschema: -@echo "Build database schemas"

10 years, 11 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Víctor Seva (linuxmaniac) ---------- FS#307 tries to dump some values. We can discuss on FS#307 if that makes sense at all or if there is a better way to accomplish that task. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment929 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

git:master: dialog: shift next timer run for keepalives of dialog

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: a17a32e5f7a3120c200d6e48fe91d7aa1dfd28b1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a17a32e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jun 3 20:53:05 2013 +0200 dialog: shift next timer run for keepalives of dialog - reported by Daniel Tryba --- modules/dialog/dlg_hash.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c index 3aee269..c669290 100644 --- a/modules/dialog/dlg_hash.c +++ b/modules/dialog/dlg_hash.c @@ -209,6 +209,7 @@ int dlg_ka_run(ticks_t ti) /* append to tail */ if(dka!=NULL) { + dka->katime = ti + dlg_ka_interval; lock_get(dlg_ka_list_lock); if(*dlg_ka_list_tail!=NULL) (*dlg_ka_list_tail)->next = dka;

10 years, 11 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Daniel-Constantin Mierla (miconda) ---------- To clarify things a bit. Usage of PV cache from core is good because can lower usage of pkg memory if PVs are used more than once in config file. I had no time to look at FS#307, maybe it just dumps the names of PVs used in config, which is ok. But, if it tries dumping PVs values, then it will be rather impossible in many cases and quite dangerous. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment928 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013