sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
235 discussions

git:4.0: app_lua: solve crash when setting a variable not convertible to string.

by Vicente Hernando

Module: sip-router Branch: 4.0 Commit: 9ee53f2abe580026c83d62b0edf1f6288dc0111a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ee53f2… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Jun 10 12:14:54 2013 +0200 app_lua: solve crash when setting a variable not convertible to string. (cherry picked from commit 4af0bc13901525a5638c2c64b863f377e033903f) --- modules/app_lua/app_lua_sr.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/app_lua/app_lua_sr.c b/modules/app_lua/app_lua_sr.c index b5a6a6c..21a9c18 100644 --- a/modules/app_lua/app_lua_sr.c +++ b/modules/app_lua/app_lua_sr.c @@ -989,6 +989,14 @@ static int lua_sr_pv_sets (lua_State *L) LM_ERR("to few parameters [%d]\n",lua_gettop(L)); return 0; } + + if(!lua_isstring(L, -1)) + { + LM_ERR("Cannot convert to a string when assigning value to variable: %s\n", + lua_tostring(L, -2)); + return 0; + } + memset(&val, 0, sizeof(pv_value_t)); val.rs.s = (char*)lua_tostring(L, -1); val.rs.len = strlen(val.rs.s);

11 years

git:master: app_lua: solve crash when setting a variable not convertible to string.

by Vicente Hernando

Module: sip-router Branch: master Commit: 4af0bc13901525a5638c2c64b863f377e033903f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4af0bc1… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Jun 10 12:14:54 2013 +0200 app_lua: solve crash when setting a variable not convertible to string. --- modules/app_lua/app_lua_sr.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/app_lua/app_lua_sr.c b/modules/app_lua/app_lua_sr.c index 4011e52..93b89b8 100644 --- a/modules/app_lua/app_lua_sr.c +++ b/modules/app_lua/app_lua_sr.c @@ -990,6 +990,14 @@ static int lua_sr_pv_sets (lua_State *L) LM_ERR("to few parameters [%d]\n",lua_gettop(L)); return 0; } + + if(!lua_isstring(L, -1)) + { + LM_ERR("Cannot convert to a string when assigning value to variable: %s\n", + lua_tostring(L, -2)); + return 0; + } + memset(&val, 0, sizeof(pv_value_t)); val.rs.s = (char*)lua_tostring(L, -1); val.rs.len = strlen(val.rs.s);

11 years

[tracker] Comment added: modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#307 - modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache User who did this - Daniel-Constantin Mierla (miconda) ---------- Not enough time to review this properly, few notes anyhow: - there is a json lib in the lib/srutils/, I would try to avoid making an external dependency for debugger module. If that external json lib is a constraint, better a new module, because debugger is part of default config and json libs were not in many old linux distros - $( is not a marker that the PV is with transformation, there can be "$(ru)n" in a function param to avoid using $run because the lookup is on longest name match. There is a field inside parsed structure that is set to transformation functions list - that should be checked if you want to avoid printing vars with transformations ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=307#comment943 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

[tracker] Task closed: Crash in ims_registrar_scscf caused by log

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#305 - Crash in ims_registrar_scscf caused by log User who did this - Camille Oudot (coudot) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=305 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:4.0: modules/ims_registrar_scscf: safety check for log line when recieving an SAR_UNREGISTERED_USER response

by Camille Oudot

Module: sip-router Branch: 4.0 Commit: c3f4bda21273a5172dbfe048c5a1a14216f6d047 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c3f4bda… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue May 28 17:53:07 2013 +0200 modules/ims_registrar_scscf: safety check for log line when recieving an SAR_UNREGISTERED_USER response --- modules/ims_registrar_scscf/cxdx_sar.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_scscf/cxdx_sar.c b/modules/ims_registrar_scscf/cxdx_sar.c index af6b3e9..3c67ce7 100644 --- a/modules/ims_registrar_scscf/cxdx_sar.c +++ b/modules/ims_registrar_scscf/cxdx_sar.c @@ -237,7 +237,11 @@ void async_cdp_callback(int is_timeout, void *param, AAAMessage *saa, long elaps goto error; } - LM_DBG("Updated contacts: %.*s\n", data->contact_header->data_len, data->contact_header->buf); + if (data->contact_header) { + LM_DBG("Updated contacts: %.*s\n", data->contact_header->data_len, data->contact_header->buf); + } else { + LM_DBG("Updated unreg contact\n"); + } }

11 years

git:master: modules/ims_registrar_scscf: safety check for log line when recieving an SAR_UNREGISTERED_USER response

by Camille Oudot

Module: sip-router Branch: master Commit: b5f0a62a2acfbf0f4ce9cd146cb342d717e662a9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b5f0a62… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue May 28 17:53:07 2013 +0200 modules/ims_registrar_scscf: safety check for log line when recieving an SAR_UNREGISTERED_USER response --- modules/ims_registrar_scscf/cxdx_sar.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_scscf/cxdx_sar.c b/modules/ims_registrar_scscf/cxdx_sar.c index af6b3e9..3c67ce7 100644 --- a/modules/ims_registrar_scscf/cxdx_sar.c +++ b/modules/ims_registrar_scscf/cxdx_sar.c @@ -237,7 +237,11 @@ void async_cdp_callback(int is_timeout, void *param, AAAMessage *saa, long elaps goto error; } - LM_DBG("Updated contacts: %.*s\n", data->contact_header->data_len, data->contact_header->buf); + if (data->contact_header) { + LM_DBG("Updated contacts: %.*s\n", data->contact_header->data_len, data->contact_header->buf); + } else { + LM_DBG("Updated unreg contact\n"); + } }

11 years

[tracker] Comment added: modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#307 - modules/debugger: add dbg_pv_dump config function. It dumps on json format the content of pv_cache User who did this - Víctor Seva (linuxmaniac) ---------- - Added param mask to dbg_pv_dump config function in order to control what to include in the output. - Do not dump vars that start with "$(". We don't want transformations to show up. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=307#comment942 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

is using Gerrit for Kamailio a good idea?

by Victor Seva

Hello fellow Kamailio users and developers, I would like to throw the idea of use Gerrit[0] for code contributions reviews. This is not a replacement for the bugtracker, Gerrit will help developers at the task of review and merge contributors patches. I'm going to use mainly [1] to try to explain what Gerrit is: "Gerrit is a web-based tool that is used for code review. Its main features are the side-by-side difference viewing and inline commenting which makes code reviews quick and simple task. It is used together with Git version control system. Gerrit allows authorized contributors to submit changes to Git repository, after reviews are done. Contributors can get their code reviewed with a little effort, and get their changes quickly through the system." It has a nice interface to review the different patch versions of the change, you can comment any line of code easily and the change has to be approved to be merged. I would like to know your opinion on this subject and your experience using it if you have it. Cheers, Victor [0] http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/intro-quic… [1] http://qt-project.org/wiki/Gerrit-Introduction

11 years

[tracker] Task opened: DNS failover bugs

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jasmin Schnatterbeck (jasmin) Attached to Project - sip-router Summary - DNS failover bugs Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi, there are two bugs in t_fwd.c regarding DNS failover: 1) DNS failover uses wrong send socket [different socket than original request rcv] if not forced. Pls fix t_fwd.c as follows: Change line 1071 to : old_uac->request.dst.send_sock:msg->rcv.bind_address, Change line 1086 to: old_uac->request.dst.send_sock:msg->rcv.bind_address, 2) onreply_route does not work for branches added by dns_failover, if "reparse_on_dns_failover"==1. Pls fix t_fwd.c as follows: insert after line 1003 t->uac[branch].on_reply = t->on_reply; t->uac[branch].on_failure = t->on_failure; t->uac[branch].on_branch_failure = t->on_branch_failure; Cheers Jasmin More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=313 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

bug in t_pick_branch for FAKED_REPLY?

by Jasmin Schnatterbeck

Hi, for a local reply (e.g. 408 on request timeout with dns failover) t_should_relay_response() and t_pick_branch() is called - which uses t_reply.c 1190 rpl = t->uac[b].reply; to check for FAKED_REPLY in get_prio(). But (that's the problem), this does not work for the t_should_relay_response()-run of a local_reply()-branch. The reason is, that store_reply(), which sets the necessary value: t_reply.c 1663 if (rpl==FAKED_REPLY) 1664 trans->uac[branch].reply=FAKED_REPLY; is called too late (after t_should_relay_response()): t_reply.c, within local_reply() 2062 reply_status=t_should_relay_response( t, msg_status, branch, 2063 &local_store, &local_winner, cancel_data, p_msg ); 2064 DBG("DEBUG: local_reply: branch=%d, save=%d, winner=%d\n", 2065 branch, local_store, local_winner ); 2066 if (local_store) { 2067 if (!store_reply(t, branch, p_msg)) This can lead to miscalculation of branch prio values. Cheers Jasmin

11 years

← Newer
1
...
12
13
14
15
16
17
18
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013