sr-dev May 2013

sr-dev@lists.kamailio.org

29 participants
317 discussions

git:master: modules/websocket: added warning when websocket module is loaded in a configuration without either the nathelper or outbound modules

by Peter Dunkley

Module: sip-router Branch: master Commit: b220a571d010851ee72c6bf6263a958335283b62 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b220a57… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Sun May 12 13:55:46 2013 +0100 modules/websocket: added warning when websocket module is loaded in a configuration without either the nathelper or outbound modules --- modules/websocket/ws_mod.c | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/modules/websocket/ws_mod.c b/modules/websocket/ws_mod.c index 9b82dea..c6331f7 100644 --- a/modules/websocket/ws_mod.c +++ b/modules/websocket/ws_mod.c @@ -265,12 +265,20 @@ static int mod_init(void) } if (cfg_declare("websocket", ws_cfg_def, &default_ws_cfg, - cfg_sizeof(websocket), &ws_cfg)) { + cfg_sizeof(websocket), &ws_cfg)) + { LM_ERR("declaring configuration\n"); return -1; } cfg_get(websocket, ws_cfg, keepalive_timeout) = ws_keepalive_timeout; + if (!module_loaded("nathelper") && !module_loaded("outbound")) + { + LM_WARN("neither \"nathelper\" nor \"outbound\" modules are" + " loaded. At least one of these is required for correct" + " routing of SIP over WebSocket.\n"); + } + return 0; error:

11 years, 3 months

[tracker] Comment added: add_contact_alias doesn't translate address when sending NOTIFY

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#286 - add_contact_alias doesn't translate address when sending NOTIFY User who did this - oren avraham (orenav) ---------- I suppose you call the fix_nated_contact on the SUBSCRIBE method, and then the NOTIFY are sent OK, but if you call the add_contact_alias on the SUBSCRIBE method, then the NOTIFY messages get to the wrong address. (this is my case...) and i think it is a normal behaviour because the handle_subscribe uses the Contact/From headers to generate the target address. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=286#comment866 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 3 months

git:ez/uac: modules/uac: added ability to change Call-Id header through pseudo variables via uac_req_send ()

by Konstantin Mosesov

Module: sip-router Branch: ez/uac Commit: 30681c471504bfafd804d8422b341d18184a17c2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=30681c4… Author: Konstantin Mosesov <ez(a)voipgroup.org.ua> Committer: Konstantin Mosesov <ez(a)voipgroup.org.ua> Date: Sat May 11 21:41:21 2013 +0300 modules/uac: added ability to change Call-Id header through pseudo variables via uac_req_send() --- modules/tm/uac.c | 5 ++++- modules/uac/doc/uac_admin.xml | 1 + modules/uac/uac_send.c | 27 +++++++++++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletions(-) diff --git a/modules/tm/uac.c b/modules/tm/uac.c index c1f8256..38ead71 100644 --- a/modules/tm/uac.c +++ b/modules/tm/uac.c @@ -762,7 +762,10 @@ int request(uac_req_t *uac_r, str* ruri, str* to, str* from, str *next_hop) if (check_params(uac_r, to, from) < 0) goto err; - generate_callid(&callid); + if (uac_r->callid == NULL || uac_r->callid->len <= 0) + generate_callid(&callid); + else + callid = *uac_r->callid; generate_fromtag(&fromtag, &callid); if (new_dlg_uac(&callid, &fromtag, DEFAULT_CSEQ, from, to, &dialog) < 0) { diff --git a/modules/uac/doc/uac_admin.xml b/modules/uac/doc/uac_admin.xml index 3610f12..a7604b7 100644 --- a/modules/uac/doc/uac_admin.xml +++ b/modules/uac/doc/uac_admin.xml @@ -703,6 +703,7 @@ $uac_req(method)="OPTIONS"; $uac_req(ruri)="sip:kamailio.org"; $uac_req(furi)="sip:kamailio.org"; $uac_req(turi)="sip:kamailio.org"; +$uac_req(callid)=$(mb{s.md5}); uac_req_send(); ... </programlisting> diff --git a/modules/uac/uac_send.c b/modules/uac/uac_send.c index 50bff25..91ad56c 100644 --- a/modules/uac/uac_send.c +++ b/modules/uac/uac_send.c @@ -61,6 +61,8 @@ typedef struct _uac_send_info { char b_apasswd[64]; str s_apasswd; unsigned int onreply; + char b_callid[128]; + str s_callid; } uac_send_info_t; static struct _uac_send_info _uac_req; @@ -84,6 +86,7 @@ uac_send_info_t *uac_send_info_clone(uac_send_info_t *ur) tp->s_ouri.s = tp->b_ouri; tp->s_auser.s = tp->b_auser; tp->s_apasswd.s = tp->b_apasswd; + tp->s_callid.s = tp->b_callid; return tp; } @@ -134,6 +137,10 @@ int pv_get_uac_req(struct sip_msg *msg, pv_param_t *param, if(_uac_req.s_apasswd.len<=0) return pv_get_null(msg, param, res); return pv_get_strval(msg, param, res, &_uac_req.s_apasswd); + case 11: + if(_uac_req.s_callid.len<=0) + return pv_get_null(msg, param, res); + return pv_get_strval(msg, param, res, &_uac_req.s_callid); default: return pv_get_uintval(msg, param, res, _uac_req.flags); } @@ -160,6 +167,7 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, _uac_req.s_body.len = 0; _uac_req.s_method.len = 0; _uac_req.onreply = 0; + _uac_req.s_callid.len = 0; } break; case 1: @@ -360,6 +368,21 @@ int pv_set_uac_req(struct sip_msg* msg, pv_param_t *param, _uac_req.s_apasswd.s[val->rs.len] = '\0'; _uac_req.s_apasswd.len = val->rs.len; break; + case 11: + if(val==NULL) + { + _uac_req.s_callid.len = 0; + return 0; + } + if(!(val->flags&PV_VAL_STR)) + { + LM_ERR("Invalid value type\n"); + return -1; + } + memcpy(_uac_req.s_callid.s, val->rs.s, val->rs.len); + _uac_req.s_callid.s[val->rs.len] = '\0'; + _uac_req.s_callid.len = val->rs.len; + break; } return 0; } @@ -399,6 +422,8 @@ int pv_parse_uac_req_name(pv_spec_p sp, str *in) case 6: if(strncmp(in->s, "method", 6)==0) sp->pvp.pvn.u.isname.name.n = 7; + else if(strncmp(in->s, "callid", 6)==0) + sp->pvp.pvn.u.isname.name.n = 11; else goto error; break; case 7: @@ -439,6 +464,7 @@ void uac_req_init(void) _uac_req.s_method.s = _uac_req.b_method; _uac_req.s_auser.s = _uac_req.b_auser; _uac_req.s_apasswd.s = _uac_req.b_apasswd; + _uac_req.s_callid.s = _uac_req.b_callid; return; } @@ -612,6 +638,7 @@ int uac_req_send(struct sip_msg *msg, char *s1, char *s2) /* Callback parameter */ uac_r.cbp = (void*)tp; } + uac_r.callid = (_uac_req.s_callid.len <= 0) ? NULL : &_uac_req.s_callid; ret = tmb.t_request(&uac_r, /* UAC Req */ &_uac_req.s_ruri, /* Request-URI */ (_uac_req.s_turi.len<=0)?&_uac_req.s_ruri:&_uac_req.s_turi, /* To */

11 years, 3 months

git:ez/uac: modules/tm: added handling Call-Id change for uac

by Konstantin Mosesov

Module: sip-router Branch: ez/uac Commit: 41228074f548442cf69a39dcd84ba530189972df URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4122807… Author: Konstantin Mosesov <ez(a)voipgroup.org.ua> Committer: Konstantin Mosesov <ez(a)voipgroup.org.ua> Date: Sat May 11 21:50:10 2013 +0300 modules/tm: added handling Call-Id change for uac --- modules/tm/uac.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules/tm/uac.c b/modules/tm/uac.c index 38ead71..483495d 100644 --- a/modules/tm/uac.c +++ b/modules/tm/uac.c @@ -763,9 +763,13 @@ int request(uac_req_t *uac_r, str* ruri, str* to, str* from, str *next_hop) if (check_params(uac_r, to, from) < 0) goto err; if (uac_r->callid == NULL || uac_r->callid->len <= 0) + { generate_callid(&callid); + } else + { callid = *uac_r->callid; + } generate_fromtag(&fromtag, &callid); if (new_dlg_uac(&callid, &fromtag, DEFAULT_CSEQ, from, to, &dialog) < 0) {

11 years, 3 months

git:master: modules/websocket: Added ws_close() exported function

by Peter Dunkley

Module: sip-router Branch: master Commit: 9af456f292e25be2c5689212ed097177a5a16338 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9af456f… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri May 10 20:04:02 2013 +0100 modules/websocket: Added ws_close() exported function - Enables immediate closure of a WebSocket connection from the configuration file. --- modules/websocket/README | 36 ++++++++++++++-- modules/websocket/doc/websocket_admin.xml | 36 +++++++++++++++ modules/websocket/ws_frame.c | 67 +++++++++++++++++++++++++++++ modules/websocket/ws_frame.h | 3 + modules/websocket/ws_mod.c | 26 +++++++++++ 5 files changed, 164 insertions(+), 4 deletions(-) diff --git a/modules/websocket/README b/modules/websocket/README index ef1bbf0..5888d63 100644 --- a/modules/websocket/README +++ b/modules/websocket/README @@ -36,6 +36,7 @@ Peter Dunkley 5. Functions 5.1. ws_handle_handshake() + 5.2. ws_close([status, reason[, connection_id]]) 6. MI Commands @@ -62,7 +63,8 @@ Peter Dunkley 1.8. Set sub_protocols parameter 1.9. Set cors_mode parameter 1.10. ws_handle_handshake usage - 1.11. event_route[websocket:closed] usage + 1.11. ws_close usage + 1.12. event_route[websocket:closed] usage Chapter 1. Admin Guide @@ -93,6 +95,7 @@ Chapter 1. Admin Guide 5. Functions 5.1. ws_handle_handshake() + 5.2. ws_close([status, reason[, connection_id]]) 6. MI Commands @@ -239,8 +242,7 @@ request_route { fix_nated_register(); else { if (!add_contact_alias()) { - xlog("L_ERR", "Error aliasing contact <$ct>\n") -; + xlog("L_ERR", "Error aliasing contact <$ct>\n"); sl_send_reply("400", "Bad Request"); exit; } @@ -433,6 +435,7 @@ modparam("websocket", "cors_mode", 2) 5. Functions 5.1. ws_handle_handshake() + 5.2. ws_close([status, reason[, connection_id]]) 5.1. ws_handle_handshake() @@ -453,6 +456,31 @@ Note ws_handle_handshake(); ... +5.2. ws_close([status, reason[, connection_id]]) + + This function closes a WebSocket connection. + + The function returns -1 if there is an error and 1 if it succeeds. + + The meaning of the parameters is as follows: + * status - an integer indicating the reason for closure. + * reason - a string describing the reason for closure. + * connection_id - the connection to close. If not specified the + connection the current message arrived on will be closed. + +Note + + status and reason values SHOULD correspond to the definitions in + section 7.4 of RFC 6455. If these parameters are not used the defaults + of "1000" and "Normal closure" will be used. + + This function can be used from ANY_ROUTE. + + Example 1.11. ws_close usage +... +ws_close(4000, "Because I say so"); +... + 6. MI Commands 6.1. ws.dump @@ -560,7 +588,7 @@ Note connection closes. The connection may be identified using the the $si and $sp pseudo-variables. - Example 1.11. event_route[websocket:closed] usage + Example 1.12. event_route[websocket:closed] usage ... event_route[websocket:closed] { xlog("L_INFO", "WebSocket connection from $si:$sp has closed\n"); diff --git a/modules/websocket/doc/websocket_admin.xml b/modules/websocket/doc/websocket_admin.xml index bbdc62b..cdc3372 100644 --- a/modules/websocket/doc/websocket_admin.xml +++ b/modules/websocket/doc/websocket_admin.xml @@ -457,6 +457,42 @@ ws_handle_handshake(); </programlisting> </example> </section> + <section id="websocket.f.ws_close"> + <title> + <function moreinfo="none">ws_close([status, + reason[, connection_id]])</function> + </title> + <para>This function closes a WebSocket connection.</para> + <para>The function returns -1 if there is an error and 1 if + it succeeds.</para> + <para>The meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem><para><emphasis>status</emphasis> - an + integer indicating the reason for closure.</para> + </listitem> + <listitem><para><emphasis>reason</emphasis> - a + string describing the reason for closure.</para> + </listitem> + <listitem><para><emphasis>connection_id</emphasis> - the + connection to close. If not specified the connection the + current message arrived on will be closed.</para> + </listitem> + </itemizedlist> + <note><para><emphasis>status</emphasis> and + <emphasis>reason</emphasis> values SHOULD correspond to the + definitions in section 7.4 of RFC 6455. If these parameters are + not used the defaults of "1000" and "Normal + closure" will be used.</para></note> + <para>This function can be used from ANY_ROUTE.</para> + <example> + <title><function>ws_close</function> usage</title> + <programlisting format="linespecific"> +... +ws_close(4000, "Because I say so"); +... +</programlisting> + </example> + </section> </section> <section> diff --git a/modules/websocket/ws_frame.c b/modules/websocket/ws_frame.c index b6be135..7b76bac 100644 --- a/modules/websocket/ws_frame.c +++ b/modules/websocket/ws_frame.c @@ -831,3 +831,70 @@ void ws_keepalive(unsigned int ticks, void *param) } } + +int ws_close(sip_msg_t *msg) +{ + ws_connection_t *wsc; + + if ((wsc = wsconn_get(msg->rcv.proto_reserved1)) == NULL) { + LM_ERR("failed to retrieve WebSocket connection\n"); + return -1; + } + + return (close_connection(wsc, LOCAL_CLOSE, 1000, + str_status_normal_closure) == 0) ? 1: 0; +} + +int ws_close2(sip_msg_t *msg, char *_status, char *_reason) +{ + int status; + str reason; + ws_connection_t *wsc; + + if (get_int_fparam(&status, msg, (fparam_t *) _status) < 0) { + LM_ERR("failed to get status code\n"); + return -1; + } + + if (get_str_fparam(&reason, msg, (fparam_t *) _reason) < 0) { + LM_ERR("failed to get reason string\n"); + return -1; + } + + if ((wsc = wsconn_get(msg->rcv.proto_reserved1)) == NULL) { + LM_ERR("failed to retrieve WebSocket connection\n"); + return -1; + } + + return (close_connection(wsc, LOCAL_CLOSE, status, reason) == 0) ? 1: 0; +} + +int ws_close3(sip_msg_t *msg, char *_status, char *_reason, char *_con) +{ + int status; + str reason; + int con; + ws_connection_t *wsc; + + if (get_int_fparam(&status, msg, (fparam_t *) _status) < 0) { + LM_ERR("failed to get status code\n"); + return -1; + } + + if (get_str_fparam(&reason, msg, (fparam_t *) _reason) < 0) { + LM_ERR("failed to get reason string\n"); + return -1; + } + + if (get_int_fparam(&con, msg, (fparam_t *) _con) < 0) { + LM_ERR("failed to get connection ID\n"); + return -1; + } + + if ((wsc = wsconn_get(con)) == NULL) { + LM_ERR("failed to retrieve WebSocket connection\n"); + return -1; + } + + return (close_connection(wsc, LOCAL_CLOSE, status, reason) == 0) ? 1: 0; +} diff --git a/modules/websocket/ws_frame.h b/modules/websocket/ws_frame.h index e10d584..1210c6c 100644 --- a/modules/websocket/ws_frame.h +++ b/modules/websocket/ws_frame.h @@ -73,5 +73,8 @@ struct mi_root *ws_mi_close(struct mi_root *cmd, void *param); struct mi_root *ws_mi_ping(struct mi_root *cmd, void *param); struct mi_root *ws_mi_pong(struct mi_root *cmd, void *param); void ws_keepalive(unsigned int ticks, void *param); +int ws_close(sip_msg_t *msg); +int ws_close2(sip_msg_t *msg, char *_status, char *_reason); +int ws_close3(sip_msg_t *msg, char *_status, char *_reason, char *_con); #endif /* _WS_FRAME_H */ diff --git a/modules/websocket/ws_mod.c b/modules/websocket/ws_mod.c index 9a6ae66..9b82dea 100644 --- a/modules/websocket/ws_mod.c +++ b/modules/websocket/ws_mod.c @@ -32,6 +32,7 @@ #include "../../lib/kcore/kstats_wrapper.h" #include "../../lib/kmi/mi.h" #include "../../mem/mem.h" +#include "../../mod_fix.h" #include "../../parser/msg_parser.h" #include "ws_conn.h" #include "ws_handshake.h" @@ -47,6 +48,7 @@ MODULE_VERSION static int mod_init(void); static int child_init(int rank); static void destroy(void); +static int ws_close_fixup(void** param, int param_no); sl_api_t ws_slb; @@ -60,6 +62,17 @@ static int ws_keepalive_processes = DEFAULT_KEEPALIVE_PROCESSES; static cmd_export_t cmds[]= { + /* ws_frame.c */ + { "ws_close", (cmd_function) ws_close, + 0, 0, 0, + ANY_ROUTE }, + { "ws_close", (cmd_function) ws_close2, + 2, ws_close_fixup, 0, + ANY_ROUTE }, + { "ws_close", (cmd_function) ws_close3, + 3, ws_close_fixup, 0, + ANY_ROUTE }, + /* ws_handshake.c */ { "ws_handle_handshake", (cmd_function) ws_handle_handshake, 0, 0, 0, @@ -295,3 +308,16 @@ static void destroy(void) { wsconn_destroy(); } + +static int ws_close_fixup(void** param, int param_no) +{ + switch(param_no) { + case 1: + case 3: + return fixup_var_int_1(param, 1); + case 2: + return fixup_spve_null(param, 1); + default: + return 0; + } +}

11 years, 4 months

git:master: modules/pv: added new $conid PV

by Peter Dunkley

Module: sip-router Branch: master Commit: 399dd84d28da82d751e40488cda604a4e03fcbf3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=399dd84… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri May 10 20:02:51 2013 +0100 modules/pv: added new $conid PV - Returns the TCP connection ID that the current message arrived on (for TCP/TLS/WS/WSS) or $null (for UDP/SCTP) --- modules/pv/pv.c | 3 +++ modules/pv/pv_core.c | 15 +++++++++++++++ modules/pv/pv_core.h | 3 +++ 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/modules/pv/pv.c b/modules/pv/pv.c index 4ea5cc6..2c4d544 100644 --- a/modules/pv/pv.c +++ b/modules/pv/pv.c @@ -143,6 +143,9 @@ static pv_export_t mod_pvs[] = { {{"cnt", sizeof("cnt")-1}, PVT_OTHER, pv_get_cnt, 0, pv_parse_cnt_name, 0, 0, 0 }, + {{"conid", (sizeof("conid")-1)}, /* */ + PVT_OTHER, pv_get_tcpconn_id, 0, + 0, 0, 0, 0}, {{"cs", (sizeof("cs")-1)}, /* */ PVT_OTHER, pv_get_cseq, 0, 0, 0, 0, 0}, diff --git a/modules/pv/pv_core.c b/modules/pv/pv_core.c index 66ab63e..3dda6a2 100644 --- a/modules/pv/pv_core.c +++ b/modules/pv/pv_core.c @@ -32,6 +32,7 @@ #include "../../socket_info.h" #include "../../data_lump.h" #include "../../lib/kcore/cmpapi.h" +#include "../../tcp_conn.h" #include "../../parser/parse_from.h" #include "../../parser/parse_uri.h" @@ -1822,6 +1823,20 @@ int pv_get_ruid(struct sip_msg *msg, pv_param_t *param, return pv_get_strval(msg, param, res, &msg->ruid); } +int pv_get_tcpconn_id(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res) +{ + struct tcp_connection *con; + + if (msg == NULL) + return -1; + + if ((con = tcpconn_get(msg->rcv.proto_reserved1, 0, 0, 0, 0)) == NULL) + return pv_get_null(msg, param, res); + + return pv_get_sintval(msg, param, res, con->id); +} + /********* end PV get functions *********/ diff --git a/modules/pv/pv_core.h b/modules/pv/pv_core.h index a51349f..9b62d41 100644 --- a/modules/pv/pv_core.h +++ b/modules/pv/pv_core.h @@ -217,6 +217,9 @@ int pv_get_cnt(struct sip_msg *msg, pv_param_t *param, int pv_get_ruid(struct sip_msg *msg, pv_param_t *param, pv_value_t *res); +int pv_get_tcpconn_id(struct sip_msg *msg, pv_param_t *param, + pv_value_t *res); + /********* end PV get functions *********/ /********* start PV set functions *********/

11 years, 4 months

Siremis v4.0.0 Released

by Elena-Ramona Modroiu

Hi, a new release of Siremis is out - v4.0.0 - web management interface that is compatible out of the box with Kamailio v4.0.x series. More details, including link to install tutorial, are available at: - http://siremis.asipto.com/2013/05/08/siremis-v4-0-0-released/ Regards, Ramona

11 years, 4 months

[tracker] Task opened: UAC generates messages with a NULL body which failes in SANITY module check

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - oren avraham (orenav) Attached to Project - sip-router Summary - UAC generates messages with a NULL body which failes in SANITY module check Task Type - Bug Report Category - Modules kamailio Status - Unconfirmed Assigned To - Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - in UAC module when generating a message without a body (i.e: when not initializing the $uac_req(body) or even when doing $uac_req(body) = "";) the generated message contains a NULL body, which fails in the SANITY module check (due to null body instead of an empty one.) - the specific check that fails is 128 (content length) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=295 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 4 months

git:master: path: support SPVE in add_path*() and add second parameter

by Richard Fuchs

Module: sip-router Branch: master Commit: 994155161263dab7a7f7c01105ea474702cf7fee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9941551… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: Mon May 6 11:03:07 2013 -0400 path: support SPVE in add_path*() and add second parameter This includes a major rewrite and code cleanup of prepend_path(), which doesn't perform any other functional changes. --- modules/path/README | 81 ++++++++++++++--- modules/path/doc/path.xml | 7 ++ modules/path/doc/path_admin.xml | 74 +++++++++++++++- modules/path/path.c | 184 ++++++++++++++++----------------------- modules/path/path_mod.c | 8 ++- 5 files changed, 227 insertions(+), 127 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=994…

11 years, 4 months

sl_send_reply vs t_reply in async route

by Matthew Williams

GIven a route[] that might be called either directly from the request route (transaction does not exist) or asynchronously (transaction exists), a way is needed to rationally choose between sl_send_reply and t_reply. At the moment, I am using an intermediate async route and setting $var(async) = 1 and then testing that when a reply needs to be sent. It seems there could be a more elegant solution. One thought I had is a new tm function that will choose between t_reply and sl_send_reply depending on whether a transaction has been created. Any other ideas? Or am I missing an obvious solution? -- Matthew Williams Flowroute LLC *Important Notice: * This message is intended only for the person or entity to which it is addressed. The information provided is confidential. Accordingly, any review, retransmission, dissemination or other use of this information by, or disclosure of it to, anyone other than the intended recipient could have significant adverse effects and is prohibited. Opinions, conclusions and other information in this message that do not relate to official business of my company shall be understood as neither given nor endorsed by it.

11 years, 4 months

← Newer
1
...
23
24
25
26
27
28
29
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2013