sr-dev April 2013

sr-dev@lists.kamailio.org

38 participants
401 discussions

git:master: parser: safety check for max port length in URI

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 13fd48f89555f5421e8285669e303bcefe44f149 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=13fd48f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 9 00:18:35 2013 +0200 parser: safety check for max port length in URI - can't be longer than 5, a port being 16b value - reported by Kevin Wojtysiak --- parser/parse_uri.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/parser/parse_uri.c b/parser/parse_uri.c index e2e16f6..84f35c6 100644 --- a/parser/parse_uri.c +++ b/parser/parse_uri.c @@ -1222,6 +1222,10 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) goto error_bad_uri; break; /* do nothing, avoids a compilation warning */ } + + if(uri->port.len>5) + goto error_invalid_port; + #ifdef EXTRA_DEBUG /* do stuff */ DBG("parsed uri:\n type=%d user=<%.*s>(%d)\n passwd=<%.*s>(%d)\n" @@ -1285,6 +1289,10 @@ error_bad_port: *p, state, (int)(p-buf), ZSW(buf), (int)(p-buf), len, ZSW(buf), len); goto error_exit; +error_invalid_port: + DBG("parse_uri: bad port in uri: [%.*s] in <%.*s>\n", + uri->port.len, uri->port.s, len, ZSW(buf)); + goto error_exit; error_bad_uri: DBG("parse_uri: bad uri, state %d" " parsed: <%.*s> (%d) / <%.*s> (%d)\n",

11 years, 8 months

git:master: .gitignore: added protoshoot binary the ignore list of git

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: a177a33b9938a36cfaedbce61734a1525e5b1665 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a177a33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 9 00:21:44 2013 +0200 .gitignore: added protoshoot binary the ignore list of git --- .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 11e0e2c..9c26668 100644 --- a/.gitignore +++ b/.gitignore @@ -32,6 +32,7 @@ utils/sercmd/sercmd utils/sercmd/kamcmd utils/pdbt/pdb_server utils/pdbt/pdbt +utils/protoshoot/protoshoot # Emacs backup files *~ # Emacs file locks

11 years, 8 months

git:master: rr: use port. len to check for buffer overflow instead of max port len

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 28a8b87885e373bee8cc81985277ae718973fdfd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=28a8b87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Apr 9 00:15:47 2013 +0200 rr: use port.len to check for buffer overflow instead of max port len - reported by Kevin Wojtysiak --- modules/rr/loose.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/rr/loose.c b/modules/rr/loose.c index 5ea4aa3..64fb035 100644 --- a/modules/rr/loose.c +++ b/modules/rr/loose.c @@ -367,7 +367,7 @@ static inline int get_maddr_uri(str *uri, struct sip_uri *puri) return 0; /* sip: + maddr + : + port */ - if( (puri->maddr_val.len) > (127 - 10) ) + if( (puri->maddr_val.len) > (127 - 6 - puri->port.len) ) { LM_ERR( "Too long maddr parameter\n"); return RR_ERROR;

11 years, 8 months

pipelimit pl_set_pipe command makes kamailio crash or block

by Javi Gallart

Hi all I've been playing with the pipelimit module, and found several problems with the pl_set_pipe command. See the details below: VERSION 3.3.4 1.- If the command is sent with a wrong number of arguments kamailio crashes. For instance: kamctl fifo pl_set_pipe global RED (note the absence of the last argument) Core was generated by `./kamailio -f /usr/local/kamailio/etc/kamailio/kamailio.cfg -E -dddd -w /var/ru'. Program terminated with signal 11, Segmentation fault. #0 mi_set_pipe (cmd_tree=<value optimized out>, param=<value optimized out>) at pl_ht.c:554 554 if ( !node->value.s || !node->value.len || strno2int(&node->value,&limit)<0) (gdb) bt #0 mi_set_pipe (cmd_tree=<value optimized out>, param=<value optimized out>) at pl_ht.c:554 #1 0x00007f8b7cd00c72 in run_mi_cmd (fifo_stream=0x2843870) at ../../lib/kmi/mi.h:77 #2 mi_fifo_server (fifo_stream=0x2843870) at fifo_fnc.c:509 #3 0x00007f8b7cd02b10 in fifo_process (rank=<value optimized out>) at mi_fifo.c:247 #4 0x00007f8b7cd02eaf in mi_child_init (rank=0) at mi_fifo.c:211 #5 0x00000000004e23c9 in init_mod_child (m=0x7f8b7cf18d78, rank=0) at sr_module.c:893 #6 0x00000000004e233c in init_mod_child (m=0x7f8b7cf18f50, rank=0) at sr_module.c:890 #7 0x00000000004e233c in init_mod_child (m=0x7f8b7cf19100, rank=0) at sr_module.c:890 #8 0x00000000004e233c in init_mod_child (m=0x7f8b7cf19750, rank=0) at sr_module.c:890 #9 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1ac08, rank=0) at sr_module.c:890 #10 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1b230, rank=0) at sr_module.c:890 #11 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1b5a0, rank=0) at sr_module.c:890 #12 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1bb48, rank=0) at sr_module.c:890 #13 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1ecf0, rank=0) at sr_module.c:890 #14 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1f140, rank=0) at sr_module.c:890 #15 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1f3e8, rank=0) at sr_module.c:890 #16 0x00000000004e233c in init_mod_child (m=0x7f8b7cf1fe68, rank=0) at sr_module.c:890 #17 0x00000000004e233c in init_mod_child (m=0x7f8b7cf20130, rank=0) at sr_module.c:890 #18 0x00000000004e233c in init_mod_child (m=0x7f8b7cf20430, rank=0) at sr_module.c:890 #19 0x00000000004e233c in init_mod_child (m=0x7f8b7cf20b68, rank=0) at sr_module.c:890 #20 0x00000000004e233c in init_mod_child (m=0x7f8b7cf20fa0, rank=0) at sr_module.c:890 #21 0x00000000004e233c in init_mod_child (m=0x7f8b7cf211f8, rank=0) at sr_module.c:890 #22 0x00000000004e233c in init_mod_child (m=0x7f8b7cf215d8, rank=0) at sr_module.c:890 #23 0x00000000004e233c in init_mod_child (m=0x7f8b7cf21940, rank=0) at sr_module.c:890 #24 0x00000000004e233c in init_mod_child (m=0x7f8b7cf21fb8, rank=0) at sr_module.c:890 #25 0x00000000004e233c in init_mod_child (m=0x7f8b7cf222b8, rank=0) at sr_module.c:890 #26 0x00000000004e233c in init_mod_child (m=0x7f8b7cf22500, rank=0) at sr_module.c:890 #27 0x00000000004e233c in init_mod_child (m=0x7f8b7cf226e8, rank=0) at sr_module.c:890 #28 0x00000000004e233c in init_mod_child (m=0x7f8b7cf22bf8, rank=0) at sr_module.c:890 #29 0x00000000004e233c in init_mod_child (m=0x7f8b7cf230e8, rank=0) at sr_module.c:890 #30 0x00000000004e233c in init_mod_child (m=0x7f8b7cf236e0, rank=0) at sr_module.c:890 #31 0x00000000004e233c in init_mod_child (m=0x7f8b7cf23bd8, rank=0) at sr_module.c:890 #32 0x0000000000465db5 in main_loop () at main.c:1710 #33 0x0000000000467de6 in main (argc=0, argv=0xe) at main.c:2546 2.- If the number of arguments is correct kamailio gets blocked, from that point on, no other request is processed: 1(23742) DEBUG: mi_fifo [mi_parser.c:84]: end of fifo input tree DEBUG: mi_fifo [fifo_fnc.c:507]: done parsing the mi tree DEBUG: pipelimit [pl_ht.c:557]: set_pipe: global:1:30 Nothing happens after this message, kamailio blocks and no further request is processed. VERSION 4.0 1.- Same as in 3.3.4 2.- Same as in 3.3.4 3.- Using RPC commands. Kamalio correctly complains about the incorrect number of arguments, but still blocks when setting up new params in a pipe. 3.1 /kamcmd pl.set_pipe s:106433 RED error: 400 - error at parameter 2: expected integer type but end of packet encountered 3.2 kamcmd pl.set_pipe s:106433 RED 50 => kamailio blocks Regards Javi

11 years, 8 months

git:master: modules/sca: reduce verbosity of RPC sca. all_subscriptions output

by Andrew Mortensen

Module: sip-router Branch: master Commit: a9e555e6e41271e015c47d29ba85276673d3b7b6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a9e555e… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 8 15:01:41 2013 -0400 modules/sca: reduce verbosity of RPC sca.all_subscriptions output - accommodate more subscriptions without hitting kamcmd buffer limits. --- modules/sca/sca_rpc.c | 38 ++++++++++++++++++++++++++++++++------ 1 files changed, 32 insertions(+), 6 deletions(-) diff --git a/modules/sca/sca_rpc.c b/modules/sca/sca_rpc.c index f0ee345..58f5ae5 100644 --- a/modules/sca/sca_rpc.c +++ b/modules/sca/sca_rpc.c @@ -23,6 +23,9 @@ */ #include "sca_common.h" +#include <sys/types.h> +#include <time.h> + #include "sca_rpc.h" #include "sca.h" @@ -82,7 +85,9 @@ sca_rpc_show_all_subscriptions( rpc_t *rpc, void *ctx ) sca_hash_table *ht; sca_hash_entry *ent; sca_subscription *sub; + sip_uri_t aor_uri, sub_uri; str sub_state = STR_NULL; + time_t now; int i; int rc = 0; @@ -91,6 +96,8 @@ sca_rpc_show_all_subscriptions( rpc_t *rpc, void *ctx ) return; } + now = time( NULL ); + for ( i = 0; i < ht->size; i++ ) { sca_hash_table_lock_index( ht, i ); @@ -98,12 +105,31 @@ sca_rpc_show_all_subscriptions( rpc_t *rpc, void *ctx ) sub = (sca_subscription *)ent->value; sca_subscription_state_to_str( sub->state, &sub_state ); - rc = rpc->printf( ctx, "%d: %.*s %.*s %s %d %.*s", i, - STR_FMT( &sub->target_aor ), - STR_FMT( &sub->subscriber ), - sca_event_name_from_type( sub->event ), - sub->expires, - STR_FMT( &sub_state )); + rc = parse_uri( sub->target_aor.s, sub->target_aor.len, &aor_uri ); + if ( rc >= 0 ) { + rc = parse_uri( sub->subscriber.s, sub->subscriber.len, + &sub_uri ); + } + if ( rc >= 0 ) { + rc = rpc->printf( ctx, "%.*s %.*s%s%.*s %s %ld %.*s", + STR_FMT( &aor_uri.user ), + STR_FMT( &sub_uri.host ), + (sub_uri.port.len ? ":" : "" ), + STR_FMT( &sub_uri.port ), + sca_event_name_from_type( sub->event ), + (long)(sub->expires - now), + STR_FMT( &sub_state )); + } else { + LM_ERR( "sca_rpc_show_all_subscriptions: parse_uri %.*s " + "failed, dumping unparsed info", + STR_FMT( &sub->target_aor )); + rc = rpc->printf( ctx, "%.*s %.*s %s %ld %.*s", + STR_FMT( &sub->target_aor ), + STR_FMT( &sub->subscriber ), + sca_event_name_from_type( sub->event ), + (long)sub->expires, + STR_FMT( &sub_state )); + } if ( rc < 0 ) { /* make sure we unlock below */

11 years, 8 months

New commits on branch admorten/sca

by Andrew Mortensen

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=14622e4… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 8 15:01:41 2013 -0400 modules/sca: reduce verbosity of RPC sca.all_subscriptions output - accommodate more subscriptions without hitting kamcmd buffer limits. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7ee4ed8… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 12:13:54 2013 +0200 modules/ndb_redis: avoid warning unused next_rpl variable. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f4acf63… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 11:47:51 2013 +0200 modules/ndb_redis: b/f restore correctly last char in argument strings. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=39b1ae8… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 11:32:40 2013 +0200 modules/ndb_redis: follow section id guidelines. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5f0fa6b… Author: Torrey Searle <tsearle(a)gmail.com> Date: Mon Apr 8 11:18:44 2013 +0200 modules/sipt: adapt module to use SUBTYPE_ISUP URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e3ca9d0… Author: Torrey Searle <tsearle(a)gmail.com> Date: Mon Apr 8 11:17:04 2013 +0200 parser/parse_content: add support for the ISUP subtype URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3d3927b… Author: Juha Heinanen <jh(a)tutpro.com> Date: Sun Apr 7 20:07:23 2013 +0300 modules/textops: free spve params of in_list function URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5a8bb3a… Author: Juha Heinanen <jh(a)tutpro.com> Date: Sun Apr 7 18:01:19 2013 +0300 modules/registrar: b/f route param was passed uninitialized to parse_rr_body URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=89378b3… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sun Apr 7 10:03:12 2013 +0200 snmpstats Avoid compiler warnings with older versions of net-snmp Centos has an older version of net-snmp that has slightly different structure definitions than the current one. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9da8b16… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sun Apr 7 09:53:24 2013 +0200 snmpstats Final fixes for IPv6 support. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9622066… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sun Apr 7 09:45:21 2013 +0200 snmpstats minor typo fixes URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=697abb7… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 22:06:47 2013 +0200 snmpstats Add IPv6 support in list of active interfaces Output from SNMPwalk after this patch: KAMAILIO-SIP-COMMON-MIB::kamailioSIPTransportRcv.ipv6."20:01:DB:80:21:2e:00:00:00:00:00:00:00:00:00:22".5080 = BITS: 40 udp(1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1aeffa7… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 22:04:51 2013 +0200 snmpstats fix typo in Makefile. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bbfc9f2… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 22:02:48 2013 +0200 snmpstats Add disabled section in Makefile for compilation on Centos systems Net-SNMP and snmpd can be built with embedded perl and libwrap support. If that's the case on your system you need to enable the EMBEDDED_PERL section in the Makefile. Maybe this could be enabled automatically. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d829dd9… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 21:56:59 2013 +0200 lib/kcore Fix IPv6 support in interface list Added a new function that takes family as an argument. In order to list both IPv4 and IPv6 you need to call that function once per address family. Keep the old IPv4-only function for backwards compatibility. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=90f78f3… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 14:59:19 2013 +0200 pipelimit Add section IDs to xml documentation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ba20f4… Author: Olle E. Johansson <oej(a)edvina.net> Date: Sat Apr 6 14:51:59 2013 +0200 ipops Add section IDs to README xml files URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a6df37d… Author: Torrey Searle <tsearle(a)gmail.com> Date: Sat Apr 6 11:59:55 2013 +0200 modules/sipt/doc: add section headers & fix README file URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd0d5fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Apr 5 21:30:06 2013 +0200 rr: added missing s in sips for record route - reported by Sander van Grieken URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c1ac283… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: Fri Apr 5 21:21:33 2013 +0200 modules/sipcapture: added customization for X-CID header. thanks for the patch goes to Markus Monka <mmonka(a)gmail.com> URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6fc6ca7… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: Fri Apr 5 21:10:57 2013 +0200 modules/sipcapture: fixed ERR message for HEPv3, added table param for sip_capture() function URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d9a3dab… Author: Torrey Searle <tsearle(a)gmail.com> Date: Fri Apr 5 18:43:06 2013 +0200 modules/sipt: updated README URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=07cb4cf… Author: Torrey Searle <tsearle(a)gmail.com> Date: Fri Apr 5 18:38:36 2013 +0200 modules/sipt: added some additional getter methods new functions: sipt_get_cpc() sipt_get_calling_party_nai() sipt_get_called_party_nai() URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3277e5… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Fri Apr 5 14:12:22 2013 +0100 modules/websocket: Update README xml with section IDs URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a1d3d34… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Fri Apr 5 14:07:18 2013 +0100 modules/tm: Added branch_failure event route to tm documentation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=daefc7c… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri Apr 5 13:35:51 2013 +0100 modules/websocket: re-added declaration of ws_keepalive_mechanism to ws_frame.c - Accidentally removed when configuration framework stuff was added. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cddaeb4… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri Apr 5 13:33:19 2013 +0100 Revert "modules/websocket: b/f defined missing ws_keepalive_mechanism variable" This reverts commit caf4769ec0f243df71e79ee3c0781afbe5884bac. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4d7c214… Author: Juha Heinanen <jh(a)tutpro.com> Date: Fri Apr 5 15:17:07 2013 +0300 modules/websocket: b/f defined missing ws_keepalive_mechanism variable URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d55f8ed… Author: Jason Penton <jason.penton(a)smilecoms.com> Date: Fri Apr 5 09:09:00 2013 +0200 lib/ims: Added cscf_get_p_charging_vector to retrieve icid,term_ioi,orig_ioi URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=21a21f2… Author: Olle E. Johansson <oej(a)edvina.net> Date: Thu Apr 4 22:27:02 2013 +0200 snmpstats Add support for the new transports as well as new roles The edgeproxyServer is a SIP Outbound edge proxy that manages flows to NATted clients. The sipcaptureServer collects SIP messages for Homer SIP capture URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=334b7ce… Author: Olle E. Johansson <oej(a)edvina.net> Date: Thu Apr 4 21:57:31 2013 +0200 snmpstats Align transports to RFC 4780 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd705bb… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 22:17:27 2013 +0200 group Update README xml with section ID's URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f9af860… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 17:08:39 2013 +0200 modules/sipt: regenerate README URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=487ebb8… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 17:06:31 2013 +0200 modules/sipt/doc: fix typo in method name URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=32a29c6… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 15:43:29 2013 +0200 modules/sipt: resolve a compiler warning on osx URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f74d846… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Apr 4 12:06:37 2013 +0200 ims_auth: Log, which AVP could not be found. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1103f9b… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 11:56:03 2013 +0200 modules/sipt: Update README in separate commit per best practices URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d376934… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 11:40:26 2013 +0200 modules/sipt/doc: corrected documentation typos URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bf9edd9… Author: Torrey Searle <tsearle(a)gmail.com> Date: Thu Apr 4 10:20:08 2013 +0200 modules/sipt: initial import of module URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d2cdbf4… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:38:56 2013 +0100 doc/cfg_list: added stun to cfg docbook Makefile URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=50cbf44… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:38:25 2013 +0100 modules/stun: added read-only stun_active cfg value URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=549852e… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:38:01 2013 +0100 modules/websocket: removed some unnecessary includes URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b2bb1dd… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:37:22 2013 +0100 modules/outbound: a bit of tidying up URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=290998f… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:23:54 2013 +0100 doc/cfg_list: added outbound and websocket to cfg doc generation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=43d21bf… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:23:16 2013 +0100 modules/websocket: updated copyright year - also remove configuration framework stuff in preparation for putting it in separate files. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=09941ac… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:22:49 2013 +0100 modules/websocket: moved config framework stuff to separate files - To facilitate docbook URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fe665b0… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:22:15 2013 +0100 modules/outbound: updated year in copyright statement URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6fd9c83… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:21:47 2013 +0100 modules/outbound: fixed typo URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=71de9a7… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Apr 4 00:20:55 2013 +0100 modules/outbound: Removed extern for ds_ping_reply_codes_update URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=be1f83d… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 21:55:47 2013 +0200 pike Add counter for blocked IP addresses URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=432391e… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 21:27:45 2013 +0200 pike Update README with section ID's URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67a4081… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 21:22:47 2013 +0200 sst Update documentation and add reference to dialog_ng module URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d103c43… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 21:11:08 2013 +0200 snmpstats Documentation updates URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=359e817… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 20:56:49 2013 +0200 timer Documentation update (section IDs) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2092d89… Author: Olle E. Johansson <oej(a)edvina.net> Date: Wed Apr 3 20:53:49 2013 +0200 sipcapture Update to README xml files (section IDs) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e138fac… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 16:18:14 2013 +0100 modules/tm: Fix t_next_contact_flow return value - Return 1 if a new flow was found - Return -1 if not found URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4ba4aa8… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:55:47 2013 +0100 modules/tmx: Add $T_reply_ruid pv to return ruid for a branch reply - Can be run from a failure_route or branch_failure_route URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67a7b09… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:18:22 2013 +0100 modules/tm: Make ruid available in uac structure - ruid is stored per uac - ruid can be retrieved when a response to the branch is received URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cc5eca4… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:06:35 2013 +0100 modules/registrar: Allow unregister for ruids in branch_failure_route - unregister(domain, uri, ruid) is accepted in branch_failure_route - unregister(domain) is not. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e5ebd9f… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Apr 3 15:04:38 2013 +0100 modules/usrloc: Fix get_urecord_by_ruid to return static aor - Fixed a bug which returned a pointer to a stack variable - Fixed some potential (?) infinite loops URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f26c907… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Thu Mar 28 09:48:04 2013 +0000 modules/tm: Fix setting instance in uac branches URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=af3ae7f… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 14:36:59 2013 +0000 modules/tm: Enable retrieving of branch instance id from uac structure - Add instance to uac structure and populate when uac created - Add get_this_branch_instance function to retrieve instance in a branch failure route URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=998008a… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 14:25:32 2013 +0000 modules/xprint: Updated to use the new get_branch()/next_branch() functions URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=959e480… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 11:53:18 2013 +0000 modules/pv: Updated to use the new get_branch()/next_branch() functions - New instance parameter is currently not used URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=86b8ac2… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 11:52:15 2013 +0000 modules/permissions: Updated to use the new get_branch()/next_branch() functions URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ed4feea… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 11:46:45 2013 +0000 modules/domain: Updated to use the new get_branch()/next_branch() functions URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ed76be… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Mar 27 11:44:08 2013 +0000 core: Update get_branch() to return instance from appended branches - get_branch() and next_branch() updated - modified select_core.c to use new function definition URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c48d687… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 26 12:10:11 2013 +0000 modules/tm: Update t_next_contact_flows for use in branch_failure event_route - Rename to t_next_contact_flow as only one flow will be used - Selects and uses the next flow with the same instance_id as the failed branch URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=38fe839… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 26 11:43:35 2013 +0000 core: Add defines required for a new branch_failure_route type URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0c57802… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 26 11:40:38 2013 +0000 modules/tm: Create branch-failure event route URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0b67552… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 26 11:22:31 2013 +0000 Revert "core: Initial revision of branch_failure_route" Remove new branch_failure_route in favour of an event_route This reverts commit a5946574cb9917f0a9a90ea547c9357f3f6477bd. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=94328e9… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 19 15:43:46 2013 +0000 core: Initial revision of branch_failure_route - New branch_failure_route defined - cfg route is called but xlog() causes segfault URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=69922b7… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Tue Mar 19 15:41:55 2013 +0000 modules/tm: Initial revision of branch_failure_route - New branch_failure_route defined - cfg route is called but xlog() causes segfault

11 years, 8 months

Minor bug in modules/auth/auth_mod.c

by Jorj Bauer

[Apologies if this made it to the list last week; I got trapped in the return-email-address-doesnt-match moderation penalty box, and can't tell whether or not this was posted.] There's a mismatch in the logic between the way that authentication headers are parsed (and stuffed in ->authorized) and the logic in consume_credentials. In pre_auth (api.c), any ACK, CANCEL or PRACK bypasses the header parsing and setting of the ->authorized struct member: if (msg->REQ_METHOD & (METHOD_ACK|METHOD_CANCEL|METHOD_PRACK)) return AUTHENTICATED; but then in consume_credentials (auth_mod.c), an error is emitted if it's a PRACK: [auth_mod.c:370]: auth:consume_credentials: No authorized credentials found (error in scripts) which is because the error is explicitly suppressed for ACK or CANCEL, but not PRACK: if (msg->REQ_METHOD != METHOD_ACK && msg->REQ_METHOD != METHOD_CANCEL) { LOG(...) auth_mod should be amended. Also, since ACK, CANCEL and PRACK can never have these headers, the function should be probably skip calling get_authorized_cred multiple times for those types of messages: int consume_credentials(struct sip_msg* msg) { struct hdr_field* h; int len; // Credentials aren't parsed for ACK/CANCEL/PRACK, so ignore those types // and return that no processing has occurred. if (msg->REQ_METHOD & (METHOD_ACK|METHOD_CANCEL|METHOD_PRACK)) return -1; get_authorized_cred(msg->authorization, &h); if (!h) { get_authorized_cred(msg->proxy_auth, &h); if (!h) { LOG(L_ERR, "auth:consume_credentials: No authorized " "credentials found (error in scripts)\n"); } return -1; } } len = h->len; if (del_lump(msg, h->name.s - msg->buf, len, 0) == 0) { LOG(L_ERR, "auth:consume_credentials: Can't remove credentials\n"); return -1; } return 1; } Hope that's useful to someone. It would remove tens of thousands of error messages in our daily logs and avoid the hack we're staging in our proxy configuration, specifically for PRACKs, just to get rid of those messages. :) -- Jorj

11 years, 8 months

git:master: modules/ndb_redis: b/ f restore correctly last char in argument strings.

by Vicente Hernando

Module: sip-router Branch: master Commit: a43f2ebd4c952be55b2844f94d3a8b587a9e5202 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a43f2eb… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 11:47:51 2013 +0200 modules/ndb_redis: b/f restore correctly last char in argument strings. --- modules/ndb_redis/ndb_redis_mod.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/ndb_redis/ndb_redis_mod.c b/modules/ndb_redis/ndb_redis_mod.c index ecce4e9..2cca4dd 100644 --- a/modules/ndb_redis/ndb_redis_mod.c +++ b/modules/ndb_redis/ndb_redis_mod.c @@ -248,12 +248,12 @@ static int w_redis_cmd5(struct sip_msg* msg, char* ssrv, char* scmd, arg1.s[arg1.len] = '\0'; arg2.s[arg2.len] = '\0'; if(redisc_exec(&s[0], &s[2], &s[1], arg1.s, arg2.s)<0) { - c1 = arg1.s[arg1.len]; - c2 = arg2.s[arg2.len]; + arg1.s[arg1.len] = c1; + arg2.s[arg2.len] = c2; return -1; } - c1 = arg1.s[arg1.len]; - c2 = arg2.s[arg2.len]; + arg1.s[arg1.len] = c1; + arg2.s[arg2.len] = c2; return 1; } @@ -305,14 +305,14 @@ static int w_redis_cmd6(struct sip_msg* msg, char* ssrv, char* scmd, arg2.s[arg2.len] = '\0'; arg3.s[arg3.len] = '\0'; if(redisc_exec(&s[0], &s[2], &s[1], arg1.s, arg2.s, arg3.s)<0) { - c1 = arg1.s[arg1.len]; - c2 = arg2.s[arg2.len]; - c3 = arg3.s[arg3.len]; + arg1.s[arg1.len] = c1; + arg2.s[arg2.len] = c2; + arg3.s[arg3.len] = c3; return -1; } - c1 = arg1.s[arg1.len]; - c2 = arg2.s[arg2.len]; - c3 = arg3.s[arg3.len]; + arg1.s[arg1.len] = c1; + arg2.s[arg2.len] = c2; + arg3.s[arg3.len] = c3; return 1; }

11 years, 8 months

git:master: modules/ndb_redis: avoid warning unused next_rpl variable.

by Vicente Hernando

Module: sip-router Branch: master Commit: 7eaaf7ec7a3727ea38a330d51771b0446c58d8d6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7eaaf7e… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 12:13:54 2013 +0200 modules/ndb_redis: avoid warning unused next_rpl variable. --- modules/ndb_redis/redis_client.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 0d8f703..3cc7639 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -479,7 +479,7 @@ redisc_reply_t *redisc_get_reply(str *name) */ int redisc_free_reply(str *name) { - redisc_reply_t *rpl, *next_rpl; + redisc_reply_t *rpl; unsigned int hid; if(name==NULL || name->len==0) { @@ -494,7 +494,6 @@ int redisc_free_reply(str *name) if(rpl->hname==hid && rpl->rname.len==name->len && strncmp(rpl->rname.s, name->s, name->len)==0) { - next_rpl = rpl->next; if(rpl->rplRedis) { freeReplyObject(rpl->rplRedis); rpl->rplRedis = NULL;

11 years, 8 months

git:master: modules/ndb_redis: follow section id guidelines.

by Vicente Hernando

Module: sip-router Branch: master Commit: 4924d136c7fd1886e411436c8005945b41c08f74 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4924d13… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Apr 8 11:32:40 2013 +0200 modules/ndb_redis: follow section id guidelines. --- modules/ndb_redis/doc/ndb_redis_admin.xml | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ndb_redis/doc/ndb_redis_admin.xml b/modules/ndb_redis/doc/ndb_redis_admin.xml index 51d5706..1f4d6dd 100644 --- a/modules/ndb_redis/doc/ndb_redis_admin.xml +++ b/modules/ndb_redis/doc/ndb_redis_admin.xml @@ -59,7 +59,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="ndb_redis.p.server"> <title><varname>server</varname> (str)</title> <para> Specify the details to connect to REDIS server. It takes a list of @@ -98,7 +98,7 @@ modparam("ndb_redis", "server", "name=srvY;unix=/tmp/redis.sock;db=3") <section> <title>Functions</title> - <section> + <section id="ndb_redis.f.redis_cmd"> <title> <function moreinfo="none">redis_cmd(srvname, command, ..., replyid)</function> </title> @@ -178,7 +178,7 @@ if(redis_cmd("srvN", "HMGET foo_key field1 field3", "r")) { </programlisting> </example> </section> - <section> + <section id="ndb_redis.f.redis_free"> <title> <function moreinfo="none">redis_free(replyid)</function> </title>

11 years, 8 months

← Newer
1
...
26
27
28
29
30
31
32
...
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2013