sr-dev February 2013

sr-dev@lists.kamailio.org

45 participants
200 discussions

git:pd/msrp: lib/srdb1: while converting strings to int/ bigint check for invalid characters
by Peter Dunkley 06 Feb '13

06 Feb '13

Module: sip-router Branch: pd/msrp Commit: af7d4496febf95e56b604849a8f818e688b21f53 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=af7d449… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Mon Feb 4 10:59:10 2013 -0500 lib/srdb1: while converting strings to int/bigint check for invalid characters --- lib/srdb1/db_ut.c | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index c57ef4d..0fa4cf5 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -73,18 +73,23 @@ inline int db_str2int(const char* _s, int* _v) { long tmp; + char* p = NULL; if (!_s || !_v) { LM_ERR("Invalid parameter value\n"); return -1; } - tmp = strtoul(_s, 0, 10); + tmp = strtoul(_s, &p, 10); if ((tmp == ULONG_MAX && errno == ERANGE) || (tmp < INT_MIN) || (tmp > UINT_MAX)) { LM_ERR("Value out of range\n"); return -1; } + if (p && *p != '\0') { + LM_ERR("Unexpected characters: [%s]\n", p); + return -2; + } *_v = (int)tmp; return 0; @@ -94,17 +99,22 @@ inline int db_str2int(const char* _s, int* _v) inline int db_str2longlong(const char* _s, long long * _v) { long long tmp; + char* p = NULL; if (!_s || !_v) { LM_ERR("Invalid parameter value\n"); return -1; } - tmp = strtoll(_s, 0, 10); + tmp = strtoll(_s, &p, 10); if (errno == ERANGE) { LM_ERR("Value out of range\n"); return -1; } + if (p && *p != '\0') { + LM_ERR("Unexpected characters: [%s]\n", p); + return -2; + } *_v = tmp; return 0;

1 0

git:pd/msrp: ims_usrloc_scscf: remove unused variables
by Peter Dunkley 06 Feb '13

06 Feb '13

Module: sip-router Branch: pd/msrp Commit: 7d6d016c7556a3241d47801b0480c022ca2dd3c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7d6d016… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Feb 3 10:31:55 2013 -0500 ims_usrloc_scscf: remove unused variables --- modules/ims_usrloc_scscf/ul_rpc.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/modules/ims_usrloc_scscf/ul_rpc.c b/modules/ims_usrloc_scscf/ul_rpc.c index d5ce024..f0c29db 100644 --- a/modules/ims_usrloc_scscf/ul_rpc.c +++ b/modules/ims_usrloc_scscf/ul_rpc.c @@ -177,18 +177,11 @@ static void ul_rpc_show_impu(rpc_t* rpc, void* ctx) static void ul_rpc_dump(rpc_t* rpc, void* ctx) { - struct impurecord* r; dlist_t* dl; udomain_t* dom; time_t t; - ucontact_t* c; - str empty_str = { "[not set]", 9 }; void* th; - void* ah; - void* ih; - void* vh; void* sh; - void* dh; int max, n, i; t = time(0);

1 0

git:pd/msrp: xhttp_pi: new commands in the pi_framework_sample:
by Peter Dunkley 06 Feb '13

06 Feb '13

Module: sip-router Branch: pd/msrp Commit: 622b01719bb8a95c5995c8412cd040787f0cd0a6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=622b017… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Fri Feb 1 19:45:28 2013 -0500 xhttp_pi: new commands in the pi_framework_sample: - add - update - delete --- .../dbschema_k/xsl/pi_framework_mod.xsl | 87 +- utils/kamctl/xhttp_pi/acc-mod | 72 + utils/kamctl/xhttp_pi/alias_db-mod | 30 + utils/kamctl/xhttp_pi/auth_db-mod | 36 + utils/kamctl/xhttp_pi/avpops-mod | 36 + utils/kamctl/xhttp_pi/carrierroute-mod | 132 ++ utils/kamctl/xhttp_pi/cpl-mod | 30 + utils/kamctl/xhttp_pi/dialog-mod | 98 + utils/kamctl/xhttp_pi/dialplan-mod | 38 + utils/kamctl/xhttp_pi/dispatcher-mod | 34 + utils/kamctl/xhttp_pi/domain-mod | 60 + utils/kamctl/xhttp_pi/domainpolicy-mod | 32 + utils/kamctl/xhttp_pi/drouting-mod | 126 ++ utils/kamctl/xhttp_pi/group-mod | 56 + utils/kamctl/xhttp_pi/htable-mod | 32 + utils/kamctl/xhttp_pi/imc-mod | 58 + utils/kamctl/xhttp_pi/lcr-mod | 114 + utils/kamctl/xhttp_pi/matrix-mod | 9 + utils/kamctl/xhttp_pi/msilo-mod | 46 + utils/kamctl/xhttp_pi/mtree-mod | 54 + utils/kamctl/xhttp_pi/pdt-mod | 28 + utils/kamctl/xhttp_pi/permissions-mod | 62 + utils/kamctl/xhttp_pi/pi_framework.xml | 2337 +++++++++++++++++++- utils/kamctl/xhttp_pi/pipelimit-mod | 28 + utils/kamctl/xhttp_pi/presence-mod | 240 ++ utils/kamctl/xhttp_pi/purple-mod | 30 + utils/kamctl/xhttp_pi/registrar-mod | 58 + utils/kamctl/xhttp_pi/rls-mod | 106 + utils/kamctl/xhttp_pi/sca-mod | 46 + utils/kamctl/xhttp_pi/siptrace-mod | 44 + utils/kamctl/xhttp_pi/speeddial-mod | 38 + utils/kamctl/xhttp_pi/standard-mod | 8 + utils/kamctl/xhttp_pi/uac-mod | 42 + utils/kamctl/xhttp_pi/uid_auth_db-mod | 38 + utils/kamctl/xhttp_pi/uid_avp_db-mod | 32 + utils/kamctl/xhttp_pi/uid_domain-mod | 60 + utils/kamctl/xhttp_pi/uid_gflags-mod | 30 + utils/kamctl/xhttp_pi/uid_uri_db-mod | 68 + utils/kamctl/xhttp_pi/uri_db-mod | 30 + utils/kamctl/xhttp_pi/userblacklist-mod | 58 + utils/kamctl/xhttp_pi/usrloc-mod | 94 + 41 files changed, 4598 insertions(+), 59 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=622…

1 0

Re: [sr-dev] [SR-Users] Update existing module or create new?
by Henning Westerholt 06 Feb '13

06 Feb '13

Am Dienstag, 5. Februar 2013, 12:52:19 schrieb Charles Chance: > We are working on a memcached module which uses the libmemcached library, as > opposed to the (no longer under active development) libmemcache that the > existing module depends on. > > Am I correct in thinking that in this instance, it would be better to create > a brand new module (with a different name) rather than modify the existing > one? In addition to changing the dependency, we will also be exporting new > commands and potentially changing the format of the exported PVs. Hello Charles, as the original author of the module I'd think that changing or replacing the existing module would be the way to go. So far I'd not recieved that much of bug reports against the existing module. And as Alex Balashov also mentioned recently, there are some other issues with the current library. If existing users need to stay with the old module, its available in the git and the existing releases, for the new release we should go with a module which supports the newer library. It would be nice if you could stay with the existing PV API, which I modelled somehow after the htable module. If you need to change something, just announce it on the devel list and ask for feedback. Thanks and regards, Henning Westerholt

2 1

git:master: modules/msrp: Fixed typos in MSRP README and added extra event_route example
by Peter Dunkley 06 Feb '13

06 Feb '13

Module: sip-router Branch: master Commit: da298e85166b873f4825e4baa96db0d317771e20 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=da298e8… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Wed Feb 6 12:55:55 2013 +0000 modules/msrp: Fixed typos in MSRP README and added extra event_route example --- modules/msrp/README | 162 +++++++++++++++++++++++++++++++++++---- modules/msrp/doc/msrp_admin.xml | 142 +++++++++++++++++++++++++++++++++- 2 files changed, 283 insertions(+), 21 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=da2…

1 0

Testing of MSRP for 4.0.0 - cannot get msrp_cmap_ functions to work
by Peter Dunkley 06 Feb '13

06 Feb '13

Hello, I have the following configuration: MSRP Client 1 ---> MSRP Relay ---> MSRP Relay ---> MSRP Client 2 Note: There is only one MSRP Relay here but as each client AUTHs with the relay it appears twice in the To-Path for MSRP SENDs and REPORTs and the MSRP requests get hair-pinned as they are routed. Each MSRP client AUTHs against the MSRP Relay (authentication steps skipped for clarity): MSRP Client 1 Authenticates MSRP embt3epk AUTH To-Path: msrp://james@192.168.0.74 From-Path: msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws Authorization: Digest username="james", realm="example.com", nonce="URIsFlESKuoaIDis1UKPL0uU8e+IavWWW3aO/4A=", uri="msrp://james@192.168.0.74", response="8d6e1842dd2791f35772a0d8aa3d0237", qop=auth, cnonce="9he680vjcwdv", nc=00000001 -------embt3epk$ MSRP embt3epk 200 OK To-Path: msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws From-Path: msrp://james@192.168.0.74 Use-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp Expires: 360 -------embt3epk$ MSRP Client 2 Authenticates MSRP t1fm54qj AUTH To-Path: msrp://peter@192.168.0.74 From-Path: msrp://hegodxou.invalid:2855/hc3n26dpvd;ws Authorization: Digest username="peter", realm="example.com", nonce="URIsGVESKu3ejM4oZiRERc40yd1jeCbHW3aRAYA=", uri="msrp://peter@192.168.0.74", response="f230810364a0ea18afb451299a0be19c", qop=auth, cnonce="j5efxrn0mufs", nc=00000001 -------t1fm54qj$ MSRP t1fm54qj 200 OK To-Path: msrp://hegodxou.invalid:2855/hc3n26dpvd;ws From-Path: msrp://peter@192.168.0.74 Use-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp Expires: 360 -------t1fm54qj$ The MSRP module parses these correctly and saves the entry in the connection map: 12(2636) DEBUG: msrp [msrp_parser.c:173]: MSRP FLine: [1] [MSRP] [embt3epk] [AUTH] [2] [] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b97f0) [To-Path] [2] [msrp://james@192.168.0.74] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3570) [From-Path] [1] [msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b35f0) [Authorization] [9] [Digest username="james", realm="example.com", nonce="URIsFlESKuoaIDis1UKPL0uU8e+IavWWW3aO/4A=", uri="msrp://james@192.168.0.74", response="8d6e1842dd2791f35772a0d8aa3d0237", qop=auth, cnonce="9he680vjcwdv", nc=00000001] 12(2636) DEBUG: msrp [msrp_mod.c:459]: executing event_route[msrp:frame-in] (3) 12(2636) DEBUG: msrp [msrp_cmap.c:230]: saving connection info for [msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws] [msrp-51122ad5-a4c-1] (174/4060267182) 12(2636) DEBUG: msrp [msrp_cmap.c:232]: frame received from [msrp://192.168.0.158:49662] via [tcp:192.168.0.74:80] 11(2635) DEBUG: msrp [msrp_parser.c:173]: MSRP FLine: [1] [MSRP] [t1fm54qj] [AUTH] [2] [] 11(2635) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3570) [To-Path] [2] [msrp://peter@192.168.0.74] 11(2635) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b35f0) [From-Path] [1] [msrp://hegodxou.invalid:2855/hc3n26dpvd;ws] 11(2635) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3670) [Authorization] [9] [Digest username="peter", realm="example.com", nonce="URIsGVESKu3ejM4oZiRERc40yd1jeCbHW3aRAYA=", uri="msrp://peter@192.168.0.74", response="f230810364a0ea18afb451299a0be19c", qop=auth, cnonce="j5efxrn0mufs", nc=00000001] 11(2635) DEBUG: msrp [msrp_mod.c:459]: executing event_route[msrp:frame-in] (3) 11(2635) DEBUG: msrp [msrp_cmap.c:230]: saving connection info for [msrp://hegodxou.invalid:2855/hc3n26dpvd;ws] [msrp-51122ad5-a4b-1] (139/4060209803) 11(2635) DEBUG: msrp [msrp_cmap.c:232]: frame received from [msrp://192.168.0.158:49663] via [tcp:192.168.0.74:80] Then MSRP Client 1 sends an MSRP SEND to MSRP client 2: SEND from MSRP Client 1 to MSRP Relay SRP sis9mer0 SEND To-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp msrp://hegodxou.invalid:2855/hc3n26dpvd;ws From-Path: msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws Message-ID: 3569133935.vs42vpro Success-Report: yes Failure-Report: yes Byte-Range: 1-0/0 -------sis9mer0$ MSRP sis9mer0 200 OK To-Path: msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws From-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp Message-ID: 3569133935.vs42vpro -------sis9mer0$ SEND from MSRP Relay to MSRP Relay MSRP sis9mer0 SEND To-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp msrp://hegodxou.invalid:2855/hc3n26dpvd;ws From-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws Message-ID: 3569133935.vs42vpro Success-Report: yes Failure-Report: yes Byte-Range: 1-0/0 -------sis9mer0$ MSRP sis9mer0 481 Session-does-not-exist To-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp From-Path: msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp Message-ID: 3569133935.vs42vpro -------sis9mer0$ It looks like the MSRP module cannot find the entry in the connection map: 12(2636) DEBUG: msrp [msrp_parser.c:173]: MSRP FLine: [1] [MSRP] [sis9mer0] [SEND] [1] [] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b97f0) [To-Path] [2] [msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp msrp://hegodxou.invalid:2855/hc3n26dpvd;ws] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3570) [From-Path] [1] [msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b35f0) [Message-ID] [4] [3569133935.vs42vpro] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3670) [Success-Report] [7] [yes] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b36f0) [Failure-Report] [0] [yes] 12(2636) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b9940) [Byte-Range] [5] [1-0/0] 12(2636) DEBUG: msrp [msrp_mod.c:459]: executing event_route[msrp:frame-in] (3) 12(2636) ERROR: <script>: Relaying to next relay hop 12(2636) DEBUG: msrp [msrp_parser.c:536]: MSRP URI: [msrp] [] [192.168.0.74] [2855] [msrp-51122ad5-a4b-1] [tcp] [] 10(2634) DEBUG: msrp [msrp_parser.c:173]: MSRP FLine: [1] [MSRP] [sis9mer0] [SEND] [1] [] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9ac4d0) [To-Path] [2] [msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp msrp://hegodxou.invalid:2855/hc3n26dpvd;ws] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9ac550) [From-Path] [1] [msrp://192.168.0.74:2855/msrp-51122ad5-a4c-1;tcp msrp://4qc1y0p3.invalid:2855/pdbcph4zb2;ws] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9ac5d0) [Message-ID] [4] [3569133935.vs42vpro] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3570) [Success-Report] [7] [yes] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b35f0) [Failure-Report] [0] [yes] 10(2634) DEBUG: msrp [msrp_parser.c:296]: MSRP Header: (0x7f536e9b3670) [Byte-Range] [5] [1-0/0] 10(2634) DEBUG: msrp [msrp_mod.c:459]: executing event_route[msrp:frame-in] (3) 10(2634) ERROR: <script>: Relaying to destination 10(2634) ERROR: <script>: ... Current hop: msrp://192.168.0.74:2855/msrp-51122ad5-a4b-1;tcp, Next hop: msrp://hegodxou.invalid:2855/hc3n26dpvd;ws, Last hop: msrp://hegodxou.invalid:2855/hc3n26dpvd;ws 10(2634) DEBUG: msrp [msrp_parser.c:536]: MSRP URI: [msrp] [] [192.168.0.74] [2855] [msrp-51122ad5-a4b-1] [tcp] [] 10(2634) DEBUG: msrp [msrp_cmap.c:346]: searching for session [msrp-51122ad5-a4b-1] 10(2634) ERROR: <script>: ... destination not in map Here is my MSRP event route: event_route[msrp:frame-in] { msrp_reply_flags("1"); if ((($Rp == MY_WS_PORT || $Rp == MY_WSS_PORT) && !(proto == WS || proto == WSS)) && $Rp != MY_MSRP_PORT) { xlog("L_WARN", "MSRP request received on $Rp\n"); msrp_reply("403", "Action-not-allowed"); exit; } if (msrp_is_reply()) { msrp_relay(); } else if($msrp(method)=="AUTH") { if($msrp(nexthops)>0) { msrp_relay(); exit; } if (!www_authenticate("MY_DOMAIN", "subscriber", "$msrp(method)")) { if (auth_get_www_authenticate("MY_DOMAIN", "1", "$var(wauth)")) { msrp_reply("401", "Unauthorized", "$var(wauth)"); } else { msrp_reply("500", "Server Error"); } exit; } msrp_cmap_save(); } else if ($msrp(method)=="SEND" || $msrp(method)=="REPORT") { if ($msrp(nexthops)>1) { if ($msrp(method)!="REPORT") { msrp_reply("200", "OK"); } xlog("Relaying to next relay hop\n"); msrp_relay(); exit; } xlog("Relaying to destination\n"); xlog("... Current hop: $msrp(crthop), Next hop: $msrp(nexthop), Last hop: $msrp(lasthop)\n"); if (msrp_cmap_lookup()) { if ($msrp(method)!="REPORT") { msrp_reply("200", "OK"); } xlog("... found destination in map\n"); msrp_relay(); } else { xlog("... destination not in map\n"); msrp_reply("481", "Session-does-not-exist"); } } else { msrp_reply("501", "Request-method-not-understood"); } } Regards, Peter -- Peter Dunkley Technical Director Crocodile RCS Ltd

1 1

git:master: modules/msrp: Fixed error in msrp_cmap_lookup()
by Peter Dunkley 06 Feb '13

06 Feb '13

Module: sip-router Branch: master Commit: f56e82a286e00a17dbf02e9a5056ef73488b89b1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f56e82a… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Wed Feb 6 12:36:52 2013 +0000 modules/msrp: Fixed error in msrp_cmap_lookup() --- modules/msrp/msrp_cmap.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules/msrp/msrp_cmap.c b/modules/msrp/msrp_cmap.c index 23a216b..f558172 100644 --- a/modules/msrp/msrp_cmap.c +++ b/modules/msrp/msrp_cmap.c @@ -354,8 +354,7 @@ int msrp_cmap_lookup(msrp_frame_t *mf) { if(itb->citemid>hid) { break; - } - if(itb->citemid>hid) { + } else { if(itb->sessionid.len == sesid.len && memcmp(itb->sessionid.s, sesid.s, sesid.len)==0) { LM_DBG("found session [%.*s]\n", sesid.len, sesid.s);

1 0

git:master: modules/lcr: treat lcr_gw/ ip_addr empty string value same as null value
by Juha Heinanen 06 Feb '13

06 Feb '13

Module: sip-router Branch: master Commit: 1e16eb9c892358a972ae71f05ec138fbe0d23126 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1e16eb9… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Feb 6 11:21:11 2013 +0200 modules/lcr: treat lcr_gw/ip_addr empty string value same as null value --- modules/lcr/lcr_mod.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/lcr/lcr_mod.c b/modules/lcr/lcr_mod.c index 757734d..9c5ff3f 100644 --- a/modules/lcr/lcr_mod.c +++ b/modules/lcr/lcr_mod.c @@ -943,7 +943,8 @@ static int insert_gws(db1_res_t *res, struct gw_info *gws, i); return 0; } - if (VAL_NULL(ROW_VALUES(row) + 1)) { + if (VAL_NULL(ROW_VALUES(row) + 1) || + (strlen((char *)VAL_STRING(ROW_VALUES(row) + 1)) == 0)) { ip_string.s = (char *)0; ip_addr.af = 0; ip_addr.len = 0;

1 0

git:master: xhttp_pi: documentation updates
by Ovidiu Sas 05 Feb '13

05 Feb '13

Module: sip-router Branch: master Commit: 62cd05a469f657b5371ecd1538f9c9b224f7e589 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=62cd05a… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Tue Feb 5 10:06:47 2013 -0500 xhttp_pi: documentation updates --- modules/xhttp_pi/README | 4 +++- modules/xhttp_pi/doc/xhttp_pi_admin.xml | 10 ++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/modules/xhttp_pi/README b/modules/xhttp_pi/README index ed4a451..9381257 100644 --- a/modules/xhttp_pi/README +++ b/modules/xhttp_pi/README @@ -163,6 +163,8 @@ kamdbctl pframework create * DB1_STRING * DB1_STR * DB1_DATETIME + + Note: input field must be provided in 'YEAR-MM-DD HH:MM:SS' + format. * DB1_BLOB * DB1_BITMAP @@ -219,7 +221,7 @@ kamdbctl pframework create 4. To-do Features to be added in the future: - * full subscriber provisionning with automatic ha1/ha1b fields; + * full subscriber provisionning with automatic ha1/ha1b fields. 5. Dependencies diff --git a/modules/xhttp_pi/doc/xhttp_pi_admin.xml b/modules/xhttp_pi/doc/xhttp_pi_admin.xml index 45b03ed..4b7475e 100644 --- a/modules/xhttp_pi/doc/xhttp_pi_admin.xml +++ b/modules/xhttp_pi/doc/xhttp_pi_admin.xml @@ -130,7 +130,13 @@ kamdbctl pframework create <listitem><para>DB1_DOUBLE</para></listitem> <listitem><para>DB1_STRING</para></listitem> <listitem><para>DB1_STR</para></listitem> - <listitem><para>DB1_DATETIME</para></listitem> + <listitem><para>DB1_DATETIME</para> + <itemizedlist> + <listitem><para>Note: input field must be provided in + 'YEAR-MM-DD HH:MM:SS' format.</para> + </listitem> + </itemizedlist> + </listitem> <listitem><para>DB1_BLOB</para></listitem> <listitem><para>DB1_BITMAP</para></listitem> </itemizedlist> @@ -233,7 +239,7 @@ kamdbctl pframework create </para> <itemizedlist> <listitem><para> - full subscriber provisionning with automatic ha1/ha1b fields; + full subscriber provisionning with automatic ha1/ha1b fields. </para></listitem> </itemizedlist> </section>

1 0

Refreshing the list of submitted patches
by Daniel-Constantin Mierla 05 Feb '13

05 Feb '13

Hello, following some discussion over the weekend at Fosdem, it seems that some of submitted patches got forgotten in the mailing list archives and even on tracker. If any of you submitted patches was not accepted or rejected for a persistent reason, please write again to sr-dev mailing list referring to it. It is a short period still good for getting them in v4.0. In general, if there is no more activity regarding a patch for one or two weeks, come back and ask for an update. We don't mind reminders (especially because many of us do have a heavy loaded traveling schedule). Cheers and happy testing upcoming v4.0, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, April 16-17, 2013, Berlin - http://conference.kamailio.com -

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2013