sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
319 discussions

[tracker] Comment added: SegFault in parse_avp_db
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Kevin Scott Adams (TheGrandWazoo) ---------- Up and running. No system load at the moment but it's further then I have been. Thanks for being so prompt with the patch. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1224 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Abort occurs in tm when make mode=debug
by sip-router 11 Dec '13

11 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#379 - Abort occurs in tm when make mode=debug User who did this - Daniel-Constantin Mierla (miconda) ---------- Indeed it was only when EXTRA_DEBUG was enabled. I pushed a patch that should fix the issue in both master and 4.1 git branches. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=379#comment1223 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.1: tm: reset temporary linking of reply to transaction after branch failure route execution
by Daniel-Constantin Mierla 11 Dec '13

11 Dec '13

Module: sip-router Branch: 4.1 Commit: 5b869a7c1c584f2762610c5310e7281375c8103d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5b869a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:58:11 2013 +0100 tm: reset temporary linking of reply to transaction after branch failure route execution - reported by Robert Boisvert, FS#379 (cherry picked from commit 0ebc983a422cd5ee4baa39bb3ef3bdbeeefd4571) --- modules/tm/t_reply.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 562b583..4d9901d 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1093,7 +1093,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* failure_route for a local UAC? */ if (!shmem_msg) { - LOG(L_WARN,"Warning: run_branch_failure_handlers: no UAC support (%d, %d) \n", + LOG(L_WARN,"no UAC support (%d, %d) \n", on_branch_failure, t->tmcb_hl.reg_types); return 0; } @@ -1101,13 +1101,13 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* don't start faking anything if we don't have to */ if (unlikely((on_branch_failure < 0) && !has_tran_tmcbs( t, TMCB_ON_BRANCH_FAILURE))) { LOG(L_WARN, - "Warning: run_failure_handlers: no branch_failure handler (%d, %d)\n", + "no branch_failure handler (%d, %d)\n", on_branch_failure, t->tmcb_hl.reg_types); return 1; } if (!fake_req(&faked_req, shmem_msg, extra_flags, &t->uac[picked_branch])) { - LOG(L_ERR, "ERROR: run_branch_failure_handlers: fake_req failed\n"); + LOG(L_ERR, "fake_req failed\n"); return 0; } /* fake also the env. conforming to the fake msg */ @@ -1124,7 +1124,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, if (exec_pre_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE)>0) { /* run a branch_failure_route action if some was marked */ if (run_top_route(event_rt.rlist[on_branch_failure], &faked_req, 0)<0) - LOG(L_ERR, "ERROR: run_branch_failure_handlers: Error in run_top_route\n"); + LOG(L_ERR, "error in run_top_route\n"); exec_post_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE); } /* update message flags, if changed in branch_failure route */ @@ -1357,9 +1357,9 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, /* also append the current reply to the transaction to * make it available in failure routes - a kind of "fake" * save of the final reply per branch */ - Trans->uac[branch].reply = reply; if (unlikely(has_tran_tmcbs( Trans, TMCB_ON_BRANCH_FAILURE_RO|TMCB_ON_BRANCH_FAILURE) - || (Trans->uac[picked_branch].on_branch_failure) )) { + || (Trans->uac[branch].on_branch_failure) )) { + Trans->uac[branch].reply = reply; extra_flags= ((Trans->uac[branch].request.flags & F_RB_TIMEOUT)? FL_TIMEOUT:0) | @@ -1369,6 +1369,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, picked_branch = branch; run_branch_failure_handlers( Trans, Trans->uac[branch].reply, new_code, extra_flags); + Trans->uac[branch].reply = 0; }

1 0

git:master: tm: reset temporary linking of reply to transaction after branch failure route execution
by Daniel-Constantin Mierla 11 Dec '13

11 Dec '13

Module: sip-router Branch: master Commit: 0ebc983a422cd5ee4baa39bb3ef3bdbeeefd4571 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0ebc983… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:58:11 2013 +0100 tm: reset temporary linking of reply to transaction after branch failure route execution - reported by Robert Boisvert, FS#379 --- modules/tm/t_reply.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 562b583..4d9901d 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1093,7 +1093,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* failure_route for a local UAC? */ if (!shmem_msg) { - LOG(L_WARN,"Warning: run_branch_failure_handlers: no UAC support (%d, %d) \n", + LOG(L_WARN,"no UAC support (%d, %d) \n", on_branch_failure, t->tmcb_hl.reg_types); return 0; } @@ -1101,13 +1101,13 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* don't start faking anything if we don't have to */ if (unlikely((on_branch_failure < 0) && !has_tran_tmcbs( t, TMCB_ON_BRANCH_FAILURE))) { LOG(L_WARN, - "Warning: run_failure_handlers: no branch_failure handler (%d, %d)\n", + "no branch_failure handler (%d, %d)\n", on_branch_failure, t->tmcb_hl.reg_types); return 1; } if (!fake_req(&faked_req, shmem_msg, extra_flags, &t->uac[picked_branch])) { - LOG(L_ERR, "ERROR: run_branch_failure_handlers: fake_req failed\n"); + LOG(L_ERR, "fake_req failed\n"); return 0; } /* fake also the env. conforming to the fake msg */ @@ -1124,7 +1124,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, if (exec_pre_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE)>0) { /* run a branch_failure_route action if some was marked */ if (run_top_route(event_rt.rlist[on_branch_failure], &faked_req, 0)<0) - LOG(L_ERR, "ERROR: run_branch_failure_handlers: Error in run_top_route\n"); + LOG(L_ERR, "error in run_top_route\n"); exec_post_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE); } /* update message flags, if changed in branch_failure route */ @@ -1357,9 +1357,9 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, /* also append the current reply to the transaction to * make it available in failure routes - a kind of "fake" * save of the final reply per branch */ - Trans->uac[branch].reply = reply; if (unlikely(has_tran_tmcbs( Trans, TMCB_ON_BRANCH_FAILURE_RO|TMCB_ON_BRANCH_FAILURE) - || (Trans->uac[picked_branch].on_branch_failure) )) { + || (Trans->uac[branch].on_branch_failure) )) { + Trans->uac[branch].reply = reply; extra_flags= ((Trans->uac[branch].request.flags & F_RB_TIMEOUT)? FL_TIMEOUT:0) | @@ -1369,6 +1369,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, picked_branch = branch; run_branch_failure_handlers( Trans, Trans->uac[branch].reply, new_code, extra_flags); + Trans->uac[branch].reply = 0; }

1 0

[tracker] Comment added: SegFault in parse_avp_db
by sip-router 11 Dec '13

11 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Kevin Scott Adams (TheGrandWazoo) ---------- On the road. Will pull and create a new package when I get home. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1222 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: SegFault in parse_avp_db
by sip-router 11 Dec '13

11 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you try with latest git branch 4.1? I pushed a patch to fix it, report back here if works ok. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1221 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.1: avpops: create a local pv structure when parameter is only flags
by Daniel-Constantin Mierla 11 Dec '13

11 Dec '13

Module: sip-router Branch: 4.1 Commit: e96a8b80fd253777e1d001ad778c5a62473ba010 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e96a8b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:01:41 2013 +0100 avpops: create a local pv structure when parameter is only flags - flags details are stored inside it - fixes crash at startup reported by Kevin Scott Adams, FS#381 (cherry picked from commit 3c88f1de9d647db8a14bae45af1fa3b34f74d4e6) --- modules/avpops/avpops_parse.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/avpops/avpops_parse.c b/modules/avpops/avpops_parse.c index 3a16f18..3a6c5ec 100644 --- a/modules/avpops/avpops_parse.c +++ b/modules/avpops/avpops_parse.c @@ -129,6 +129,14 @@ int parse_avp_db(char *s, struct db_param *dbp, int allow_scheme) goto error; } } + /* no pv to lookup, create one to store flags details */ + dbp->a.u.sval = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); + if(dbp->a.u.sval==NULL) + { + LM_ERR("no more pkg\n"); + goto error; + } + memset(dbp->a.u.sval, 0, sizeof(pv_spec_t)); dbp->a.u.sval->pvp.pvn.u.isname.type |= (flags<<8)&0xff00; dbp->a.type = AVPOPS_VAL_NONE; } else {

1 0

git:master: avpops: create a local pv structure when parameter is only flags
by Daniel-Constantin Mierla 11 Dec '13

11 Dec '13

Module: sip-router Branch: master Commit: 3c88f1de9d647db8a14bae45af1fa3b34f74d4e6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c88f1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:01:41 2013 +0100 avpops: create a local pv structure when parameter is only flags - flags details are stored inside it - fixes crash at startup reported by Kevin Scott Adams, FS#381 --- modules/avpops/avpops_parse.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/avpops/avpops_parse.c b/modules/avpops/avpops_parse.c index 3a16f18..3a6c5ec 100644 --- a/modules/avpops/avpops_parse.c +++ b/modules/avpops/avpops_parse.c @@ -129,6 +129,14 @@ int parse_avp_db(char *s, struct db_param *dbp, int allow_scheme) goto error; } } + /* no pv to lookup, create one to store flags details */ + dbp->a.u.sval = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); + if(dbp->a.u.sval==NULL) + { + LM_ERR("no more pkg\n"); + goto error; + } + memset(dbp->a.u.sval, 0, sizeof(pv_spec_t)); dbp->a.u.sval->pvp.pvn.u.isname.type |= (flags<<8)&0xff00; dbp->a.type = AVPOPS_VAL_NONE; } else {

1 0

[tracker] Comment added: SegFault in parse_avp_db
by sip-router 11 Dec '13

11 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Daniel-Constantin Mierla (miconda) ---------- The issue was introduced when PV parsing was replaced by looking up PV in the cache, commit 5e775ff328b73b816e61a0a4718b194591a98251. It affects the case when second parameter is a flag, i, s, or *. Should work fine if second parameter is an avp. I am working to get a fix. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1220 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: SegFault in parse_avp_db
by sip-router 11 Dec '13

11 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Kevin Scott Adams (TheGrandWazoo) ---------- Created new package from git 4.1-branch and encountered the same thing. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1219 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013