sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
318 discussions

[tracker] Comment added: Abort occurs in tm when make mode=debug

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#379 - Abort occurs in tm when make mode=debug User who did this - Daniel-Constantin Mierla (miconda) ---------- Indeed it was only when EXTRA_DEBUG was enabled. I pushed a patch that should fix the issue in both master and 4.1 git branches. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=379#comment1223 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:4.1: tm: reset temporary linking of reply to transaction after branch failure route execution

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: 5b869a7c1c584f2762610c5310e7281375c8103d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5b869a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:58:11 2013 +0100 tm: reset temporary linking of reply to transaction after branch failure route execution - reported by Robert Boisvert, FS#379 (cherry picked from commit 0ebc983a422cd5ee4baa39bb3ef3bdbeeefd4571) --- modules/tm/t_reply.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 562b583..4d9901d 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1093,7 +1093,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* failure_route for a local UAC? */ if (!shmem_msg) { - LOG(L_WARN,"Warning: run_branch_failure_handlers: no UAC support (%d, %d) \n", + LOG(L_WARN,"no UAC support (%d, %d) \n", on_branch_failure, t->tmcb_hl.reg_types); return 0; } @@ -1101,13 +1101,13 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* don't start faking anything if we don't have to */ if (unlikely((on_branch_failure < 0) && !has_tran_tmcbs( t, TMCB_ON_BRANCH_FAILURE))) { LOG(L_WARN, - "Warning: run_failure_handlers: no branch_failure handler (%d, %d)\n", + "no branch_failure handler (%d, %d)\n", on_branch_failure, t->tmcb_hl.reg_types); return 1; } if (!fake_req(&faked_req, shmem_msg, extra_flags, &t->uac[picked_branch])) { - LOG(L_ERR, "ERROR: run_branch_failure_handlers: fake_req failed\n"); + LOG(L_ERR, "fake_req failed\n"); return 0; } /* fake also the env. conforming to the fake msg */ @@ -1124,7 +1124,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, if (exec_pre_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE)>0) { /* run a branch_failure_route action if some was marked */ if (run_top_route(event_rt.rlist[on_branch_failure], &faked_req, 0)<0) - LOG(L_ERR, "ERROR: run_branch_failure_handlers: Error in run_top_route\n"); + LOG(L_ERR, "error in run_top_route\n"); exec_post_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE); } /* update message flags, if changed in branch_failure route */ @@ -1357,9 +1357,9 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, /* also append the current reply to the transaction to * make it available in failure routes - a kind of "fake" * save of the final reply per branch */ - Trans->uac[branch].reply = reply; if (unlikely(has_tran_tmcbs( Trans, TMCB_ON_BRANCH_FAILURE_RO|TMCB_ON_BRANCH_FAILURE) - || (Trans->uac[picked_branch].on_branch_failure) )) { + || (Trans->uac[branch].on_branch_failure) )) { + Trans->uac[branch].reply = reply; extra_flags= ((Trans->uac[branch].request.flags & F_RB_TIMEOUT)? FL_TIMEOUT:0) | @@ -1369,6 +1369,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, picked_branch = branch; run_branch_failure_handlers( Trans, Trans->uac[branch].reply, new_code, extra_flags); + Trans->uac[branch].reply = 0; }

11 years

git:master: tm: reset temporary linking of reply to transaction after branch failure route execution

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 0ebc983a422cd5ee4baa39bb3ef3bdbeeefd4571 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0ebc983… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:58:11 2013 +0100 tm: reset temporary linking of reply to transaction after branch failure route execution - reported by Robert Boisvert, FS#379 --- modules/tm/t_reply.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index 562b583..4d9901d 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1093,7 +1093,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* failure_route for a local UAC? */ if (!shmem_msg) { - LOG(L_WARN,"Warning: run_branch_failure_handlers: no UAC support (%d, %d) \n", + LOG(L_WARN,"no UAC support (%d, %d) \n", on_branch_failure, t->tmcb_hl.reg_types); return 0; } @@ -1101,13 +1101,13 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, /* don't start faking anything if we don't have to */ if (unlikely((on_branch_failure < 0) && !has_tran_tmcbs( t, TMCB_ON_BRANCH_FAILURE))) { LOG(L_WARN, - "Warning: run_failure_handlers: no branch_failure handler (%d, %d)\n", + "no branch_failure handler (%d, %d)\n", on_branch_failure, t->tmcb_hl.reg_types); return 1; } if (!fake_req(&faked_req, shmem_msg, extra_flags, &t->uac[picked_branch])) { - LOG(L_ERR, "ERROR: run_branch_failure_handlers: fake_req failed\n"); + LOG(L_ERR, "fake_req failed\n"); return 0; } /* fake also the env. conforming to the fake msg */ @@ -1124,7 +1124,7 @@ int run_branch_failure_handlers(struct cell *t, struct sip_msg *rpl, if (exec_pre_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE)>0) { /* run a branch_failure_route action if some was marked */ if (run_top_route(event_rt.rlist[on_branch_failure], &faked_req, 0)<0) - LOG(L_ERR, "ERROR: run_branch_failure_handlers: Error in run_top_route\n"); + LOG(L_ERR, "error in run_top_route\n"); exec_post_script_cb(&faked_req, BRANCH_FAILURE_CB_TYPE); } /* update message flags, if changed in branch_failure route */ @@ -1357,9 +1357,9 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, /* also append the current reply to the transaction to * make it available in failure routes - a kind of "fake" * save of the final reply per branch */ - Trans->uac[branch].reply = reply; if (unlikely(has_tran_tmcbs( Trans, TMCB_ON_BRANCH_FAILURE_RO|TMCB_ON_BRANCH_FAILURE) - || (Trans->uac[picked_branch].on_branch_failure) )) { + || (Trans->uac[branch].on_branch_failure) )) { + Trans->uac[branch].reply = reply; extra_flags= ((Trans->uac[branch].request.flags & F_RB_TIMEOUT)? FL_TIMEOUT:0) | @@ -1369,6 +1369,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, picked_branch = branch; run_branch_failure_handlers( Trans, Trans->uac[branch].reply, new_code, extra_flags); + Trans->uac[branch].reply = 0; }

11 years

[tracker] Comment added: SegFault in parse_avp_db

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Kevin Scott Adams (TheGrandWazoo) ---------- On the road. Will pull and create a new package when I get home. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1222 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

[tracker] Comment added: SegFault in parse_avp_db

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you try with latest git branch 4.1? I pushed a patch to fix it, report back here if works ok. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1221 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:4.1: avpops: create a local pv structure when parameter is only flags

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.1 Commit: e96a8b80fd253777e1d001ad778c5a62473ba010 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e96a8b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:01:41 2013 +0100 avpops: create a local pv structure when parameter is only flags - flags details are stored inside it - fixes crash at startup reported by Kevin Scott Adams, FS#381 (cherry picked from commit 3c88f1de9d647db8a14bae45af1fa3b34f74d4e6) --- modules/avpops/avpops_parse.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/avpops/avpops_parse.c b/modules/avpops/avpops_parse.c index 3a16f18..3a6c5ec 100644 --- a/modules/avpops/avpops_parse.c +++ b/modules/avpops/avpops_parse.c @@ -129,6 +129,14 @@ int parse_avp_db(char *s, struct db_param *dbp, int allow_scheme) goto error; } } + /* no pv to lookup, create one to store flags details */ + dbp->a.u.sval = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); + if(dbp->a.u.sval==NULL) + { + LM_ERR("no more pkg\n"); + goto error; + } + memset(dbp->a.u.sval, 0, sizeof(pv_spec_t)); dbp->a.u.sval->pvp.pvn.u.isname.type |= (flags<<8)&0xff00; dbp->a.type = AVPOPS_VAL_NONE; } else {

11 years

git:master: avpops: create a local pv structure when parameter is only flags

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 3c88f1de9d647db8a14bae45af1fa3b34f74d4e6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c88f1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Dec 11 23:01:41 2013 +0100 avpops: create a local pv structure when parameter is only flags - flags details are stored inside it - fixes crash at startup reported by Kevin Scott Adams, FS#381 --- modules/avpops/avpops_parse.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/avpops/avpops_parse.c b/modules/avpops/avpops_parse.c index 3a16f18..3a6c5ec 100644 --- a/modules/avpops/avpops_parse.c +++ b/modules/avpops/avpops_parse.c @@ -129,6 +129,14 @@ int parse_avp_db(char *s, struct db_param *dbp, int allow_scheme) goto error; } } + /* no pv to lookup, create one to store flags details */ + dbp->a.u.sval = (pv_spec_t*)pkg_malloc(sizeof(pv_spec_t)); + if(dbp->a.u.sval==NULL) + { + LM_ERR("no more pkg\n"); + goto error; + } + memset(dbp->a.u.sval, 0, sizeof(pv_spec_t)); dbp->a.u.sval->pvp.pvn.u.isname.type |= (flags<<8)&0xff00; dbp->a.type = AVPOPS_VAL_NONE; } else {

11 years

[tracker] Comment added: SegFault in parse_avp_db

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Daniel-Constantin Mierla (miconda) ---------- The issue was introduced when PV parsing was replaced by looking up PV in the cache, commit 5e775ff328b73b816e61a0a4718b194591a98251. It affects the case when second parameter is a flag, i, s, or *. Should work fine if second parameter is an avp. I am working to get a fix. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1220 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

[tracker] Comment added: SegFault in parse_avp_db

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#381 - SegFault in parse_avp_db User who did this - Kevin Scott Adams (TheGrandWazoo) ---------- Created new package from git 4.1-branch and encountered the same thing. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381#comment1219 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

[tracker] Task changed: SegFault in parse_avp_db

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#381 - SegFault in parse_avp_db User who did this: Daniel-Constantin Mierla (miconda) Task details edited: ------- Upgraded to 4.1 to fix a SegFault with t_load_contacts and now have this SegFault on startup. <code> Core was generated by `kamailio'. Program terminated with signal 11, Segmentation fault. #0 0x00002b359c9b4d9d in parse_avp_db (s=0x2b35985f2788 "*", dbp=0x2b35986963c8, allow_scheme=1) at avpops_parse.c:132 132 dbp->a.u.sval->pvp.pvn.u.isname.type |= (flags<<8)&0xff00; (gdb) bt full #0 0x00002b359c9b4d9d in parse_avp_db (s=0x2b35985f2788 "*", dbp=0x2b35986963c8, allow_scheme=1) at avpops_parse.c:132 ul = 47509190304664 tmp = {s = 0x2b35985f2788 "*", len = -1739042800} s0 = {s = 0x2b359c9b9eea "fixup_db_avp", len = -1667522637} have_scheme = 0 '\000' p0 = 0x0 flags = 0 __FUNCTION__ = "parse_avp_db" #1 0x00002b359c99e731 in fixup_db_avp (param=0x2b35985f21b8, param_no=2, allow_scheme=1) at avpops.c:295 sp = 0x2b3598696348 dbp = 0x2b35986963c8 flags = 0 s = {s = 0x2b35985f2788 "*", len = 3} p = 0x0 __FUNCTION__ = "fixup_db_avp" #2 0x00002b359c99e8c0 in fixup_db_load_avp (param=0x2b35985f21b8, param_no=2) at avpops.c:309 No locals. #3 0x00000000004b1f0d in fix_actions (a=0x2b35985f2148) at route.c:975 t = 0x2b35985f2148 p = 0x5f8c59 tmp = 0x2b35985ec7c8 "SETPAI with fU as: $fU" tmp_p = 0x2b35985f2788 ret = 0 i = 1 cmd = 0x2b35985d5b98 s = {s = 0x2b3598696660 "\310\307^\230\065+", len = 0} he = 0x2b35985ec7c8 ip = {af = 48, len = 48, u = {addrl = {140733577136352, 140733577136144}, addr32 = {383748320, 32767, 383748112, 32767}, addr16 = {35040, 5855, 32767, 0, 34832, 5855, 32767, 0}, addr = "\340\210\337\026\377\177\000\000\020\210\337\026\377\177\000"}} si = 0x2b3500000016 lval = 0x2b359b6d853d rve = 0x2b3598693700 err_rve = 0x324b84cf08 rve_type = 32767 err_type = 383748352 expected_type = RV_NONE rv = 0x10 rve_param_no = 0 __FUNCTION__ = "fix_actions" #4 0x00000000004cc862 in fix_rval (rv=0x2b35985f2870) at rvalue.c:2883 __FUNCTION__ = "fix_rval" #5 0x00000000004d4c70 in fix_rval_expr (p=0x2b35985f2868) at rvalue.c:3804 rve = 0x2b35985f2868 ret = 32767 __FUNCTION__ = "fix_rval_expr" #6 0x00000000004aff2d in fix_actions (a=0x2b35985f1528) at route.c:750 t = 0x2b35985f3f08 p = 0x4cc862 tmp = 0x5f8c50 "fix_rval" tmp_p = 0x2b35985ec7c8 ret = 0 i = 2 cmd = 0x2b35985d1b90 ---Type <return> to continue, or q <return> to quit--- s = {s = 0x5d8e18 "DEBUG", len = 383750288} he = 0x2b359b6d853d ip = {af = 16, len = 0, u = {addrl = {6131224, 4294967300}, addr32 = {6131224, 0, 4, 1}, addr16 = {36376, 93, 0, 0, 4, 0, 1, 0}, addr = "\030\216]\000\000\000\000\000\004\000\000\000\001\000\000"}} si = 0x5d8e18 lval = 0x7fff16df8b90 rve = 0x2b35985f2868 err_rve = 0x0 rve_type = RV_INT err_type = 2607646013 expected_type = 11061 rv = 0x7fff16df8cf4 rve_param_no = 0 __FUNCTION__ = "fix_actions" #7 0x00000000004aff6c in fix_actions (a=0x2b35985f0598) at route.c:754 t = 0x2b35985f4048 p = 0x0 tmp = 0x7fff16df8fb0 "" tmp_p = 0x2b35985ec518 ret = 0 i = 2 cmd = 0x2b35985d1b90 s = {s = 0x2b35985e0b58 "Route", len = 5} he = 0x7fff16df8d80 ip = {af = 383749552, len = 32767, u = {addrl = {5533488, 17179869188}, addr32 = {5533488, 0, 4, 4}, addr16 = { 28464, 84, 0, 0, 4, 0, 4, 0}, addr = "0oT\000\000\000\000\000\004\000\000\000\004\000\000"}} si = 0x2b359dad3518 lval = 0x2b35985e25d0 rve = 0x2b35985f08e0 err_rve = 0x0 rve_type = RV_INT err_type = 2648027208 expected_type = RV_NONE rv = 0x2b35985e5a50 rve_param_no = 0 __FUNCTION__ = "fix_actions" #8 0x00000000004b9efb in fix_rl (rt=0x939b80) at route.c:2162 i = 1 ret = 0 #9 0x00000000004b9f39 in fix_rls () at route.c:2178 ret = 4985 #10 0x0000000000470507 in main (argc=1, argv=0x7fff16df9098) at main.c:2522 cfg_stream = 0xefc9010 c = -1 r = 50 tmp = 0x7fff16df8f87 "" tmp_len = 32767 port = 383750022 proto = 0 options = 0x5e2318 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:" ret = -1 seed = 3011491440 rfd = 4 debug_save = 0 ---Type <return> to continue, or q <return> to quit--- debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x0 p = 0x324b61cbc0 "" __FUNCTION__ = "main" </code> Thanks ------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=381 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

← Newer
1
...
11
12
13
14
15
16
17
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013