sr-dev November 2013

sr-dev@lists.kamailio.org

29 participants
220 discussions

git:tmp/ims_usrloc_pcscf_db_support: modules/ims_usrloc_pcscf: added mysql schema for DB storage

by Jason Penton

Module: sip-router Branch: tmp/ims_usrloc_pcscf_db_support Commit: 59b5752a7a610bff2d89f9c279386801946b91c2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=59b5752… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri Nov 29 11:08:37 2013 +0200 modules/ims_usrloc_pcscf: added mysql schema for DB storage --- modules/ims_usrloc_pcscf/doc/location_pcscf.sql | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/modules/ims_usrloc_pcscf/doc/location_pcscf.sql b/modules/ims_usrloc_pcscf/doc/location_pcscf.sql new file mode 100644 index 0000000..fa46d6c --- /dev/null +++ b/modules/ims_usrloc_pcscf/doc/location_pcscf.sql @@ -0,0 +1,20 @@ +CREATE TABLE `location` ( + `id` int(10) unsigned NOT NULL AUTO_INCREMENT, + `domain` varchar(64) DEFAULT NULL, + `aor` varchar(255) NOT NULL, + `contact` varchar(255) DEFAULT NULL, + `received` varchar(128) DEFAULT NULL, + `received_port` int(10) unsigned DEFAULT NULL, + `received_proto` int(10) unsigned DEFAULT NULL, + `path` varchar(512) DEFAULT NULL, + `rx_session_id` varchar(256) DEFAULT NULL, + `reg_state` tinyint(4) DEFAULT NULL, + `expires` datetime DEFAULT '2030-05-28 21:32:15', + `service_routes` varchar(2048) DEFAULT NULL, + `socket` varchar(64) DEFAULT NULL, + `public_ids` varchar(2048) DEFAULT NULL, + PRIMARY KEY (`id`), + KEY `expires_idx` (`expires`) +) ENGINE=InnoDB AUTO_INCREMENT=7 DEFAULT CHARSET=latin1; + +

11 years

git:tmp/ims_usrloc_pcscf_db_support: modules/ims_usrloc_pcscf: suport for preloading usrloc from DB on startup

by Jason Penton

Module: sip-router Branch: tmp/ims_usrloc_pcscf_db_support Commit: 7333bf3384f3df5ebe6c14c2cbd41ee7539901a7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7333bf3… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri Nov 29 11:05:50 2013 +0200 modules/ims_usrloc_pcscf: suport for preloading usrloc from DB on startup --- modules/ims_usrloc_pcscf/udomain.c | 260 ++++++++++++++++++++++++++++++++++ modules/ims_usrloc_pcscf/udomain.h | 2 + modules/ims_usrloc_pcscf/ul_mod.c | 15 +- modules/ims_usrloc_pcscf/usrloc.h | 1 + modules/ims_usrloc_pcscf/usrloc_db.c | 182 +++++++++++++++--------- modules/ims_usrloc_pcscf/usrloc_db.h | 32 ++++- 6 files changed, 417 insertions(+), 75 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=733…

11 years

git:4.1: modules/ims_registrar_pcscf: fix log

by Camille Oudot

Module: sip-router Branch: 4.1 Commit: a5f8d36ac011be12a9582999a8d6480541106439 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a5f8d36… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue Nov 26 16:08:35 2013 +0100 modules/ims_registrar_pcscf: fix log --- modules/ims_registrar_pcscf/service_routes.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c index 8af77e2..ab57cd6 100644 --- a/modules/ims_registrar_pcscf/service_routes.c +++ b/modules/ims_registrar_pcscf/service_routes.c @@ -349,7 +349,7 @@ int force_service_routes(struct sip_msg* _m, udomain_t* _d) { } LM_DBG("Setting dst_uri to <%.*s> \n", c->service_routes[0].len, - c->service_routes[i].s); + c->service_routes[0].s); if (set_dst_uri(_m, &c->service_routes[0]) !=0 ) { LM_ERR("Error setting new dst uri\n");

11 years

Re: [sr-dev] [Redis module] Kamailio crashes in case of connection lost to redis server

by Tuan Viet Nguyen

Hi Vicente, Thank you for your quick reply. I'm ready to retest the patch. Regards, On Thu, Nov 28, 2013 at 11:07 AM, Vicente Hernando < vhernando(a)systemonenoc.com> wrote: > Hello, > > I think you have discovered a bug I made using variadic functions. > > Very soon I gonna send a patch to correct it. > > > Thanks, > Vicente. > > > On 11/28/2013 10:14 AM, Tuan Viet Nguyen wrote: > > Hello Vicente, > > Thank you for your reply, you'll find my answer below > > On Thu, Nov 28, 2013 at 12:03 AM, Vicente Hernando < > vhernando(a)systemonenoc.com> wrote: > >> Hello, >> >> also full steps to crash kamailio and reproduce the error would be good. >> > > Here is the architecture > > A <--> Asterisk <--> Kamailio 1 <---> kamailio2 <--- ISP---> mobile > > Kamailio 1 & 2 are connected to a local redis server > 1/ I restarted the redis server > 2/ From the mobile I made a call to A then cancelled it. In the script > of kamailio1, if a call has missed or failed, it sends a message to the > redis. And in this case, it crashes > > > >> >> >> On 11/27/2013 11:35 PM, Daniel-Constantin Mierla wrote: >> >> Hello, >> >> can you give the full output for 'bt full' with gdb on the core file? You >> gave only partial list of the frames, not being enough to see the execution >> trace. >> >> Cheers, >> Daniel >> >> On 11/27/13 6:52 PM, Tuan Viet Nguyen wrote: >> >> Hello, >> >> I'll try to shut down the redis server to test the behavior of kamailio >> and it has crashed if a call is received and then cancelled. >> >> *1/The kamailio version is 4.0.4* >> >> *2/ Kamailio log * >> /usr/local/sbin/kamailio[25333]: ERROR: ndb_redis [redis_client.c:364]: >> redisc_exec(): Redis error: Server closed the connection >> /usr/local/sbin/kamailio[25361]: : <core> [pass_fd.c:293]: receive_fd(): >> ERROR: receive_fd: EOF on 13 >> /usr/local/sbin/kamailio[25328]: ALERT: <core> [main.c:788]: >> handle_sigs(): child process 25333 exited by a signal 11 >> /usr/local/sbin/kamailio[25328]: ALERT: <core> [main.c:791]: >> handle_sigs(): core was generated >> >> I assume you disconnect redis server and don't reconnect it. It is >> that correct? >> >> Then this line is an error but it should recover from that. I probably >> should set this as a warning instead an error. >> >> /usr/local/sbin/kamailio[25333]: ERROR: ndb_redis [redis_client.c:364]: >> redisc_exec(): Redis error: Server closed the connection >> > > Yes, it has been restarted > > >> *3/ Interesting information in the core* >> #3 0x00007fc79412893d in redisvCommand (c=0x64657461, format=0x9 >> <Address 0x9 out of bounds>, ap=0x30, ap@entry=0x7fff0ff56aa8) at >> hiredis.c:1304 >> No locals. >> #4 0x00007fc794341713 in redisc_exec (srv=srv@entry=0x7fff0ff56be0, >> res=res@entry=0x7fff0ff56c00, cmd=cmd@entry=0x7fff0ff56bf0) at >> redis_client.c:368 >> rsrv = 0x7fc794565150 >> rpl = 0x7fc7946fab70 >> c = 0 '\000' >> ap = {{gp_offset = 48, fp_offset = 48, overflow_arg_area = >> 0x7fff0ff56bb0, reg_save_area = 0x7fff0ff56ac0}} >> __FUNCTION__ = "redisc_exec" >> #5 0x00007fc79433b781 in w_redis_cmd5 (msg=<optimized out>, >> ssrv=<optimized out>, scmd=<optimized out>, sargv1=<optimized out>, >> sargv2=0x7fc7946f7bf0 "p\243_\224\307\177", sres=0x7fc7946f7c50 " >> \253_\224\307\177") at ndb_redis_mod.c:250 >> s = {{s = 0x7fc7945fb300 "kamailio_redis", len = 14}, {s = >> 0x7fc7945f5f50 "PUBLISH %s %s", len = 13}, {s = 0x7fc7945fab20 "r", len = >> 1}} >> arg1 = {s = 0x7fc7945f5f80 "notification", len = 12} >> arg2 = { >> s = 0x7fc794551c60 "info XXX"..., >> len = 212} >> c1 = 0 '\000' >> c2 = 0 '\000' >> __FUNCTION__ = "w_redis_cmd5" >> >> >> In the source code: >> >> rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap ); >> if(rpl->rplRedis == NULL) >> { >> /* null reply, reconnect and try again */ >> if(rsrv->ctxRedis->err) >> { >> LM_ERR("Redis error: %s\n", rsrv->ctxRedis->errstr); >> } >> if(redisc_reconnect_server(rsrv)==0) >> { >> rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap); >> } >> } >> >> First redisvCommand executes but returns nothing. Then it shows a redis >> error. >> >> It tries to reconnect and it manages to connect ?? because it shows no >> more errors. >> >> And then executes redisvCommand again and crashes. >> >> If server is down it should not be able to connect and so not to execute >> redisvCommand again. >> > > According to the core, we MUST be in this case > *if(redisc_reconnect_server(rsrv)==0) * > But I am wondering how the first redisvCommand can succeed before the > reconnection ? (the connection kamailio1 <-> redis has already been taken > down). Does all the redis context always there when we first call > redisvCommand? > > >> >> >> May be I would get more clues with more information. >> >> Regards, >> Vicente. >> > > Thank you > Regards, > > >> >> >> I've found one of post that this issue has been fixed but it seems >> that it's always the case .. >> >> http://www.mail-archive.com/search?l=sr-users@lists.sip-router.org&q=subjec… >> >> Do you have any idea? >> Thank you >> >> >> _______________________________________________ >> sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >> >> >> -- >> Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda >> >> >> >> _______________________________________________ >> sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >> >> >> > >

11 years

git:4.1: modules/ndb_redis: solved bug in second call to redisvCommand.

by Vicente Hernando

Module: sip-router Branch: 4.1 Commit: 424711ec889661a1212e63f9b0e9761a6e4ed069 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=424711e… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Thu Nov 28 12:16:05 2013 +0100 modules/ndb_redis: solved bug in second call to redisvCommand. (cherry picked from commit 52a34d269931f6f3a50b3fc532405624b9e38d23) --- modules/ndb_redis/redis_client.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 0ba083a..6cf7f6f 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -316,9 +316,10 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) redisc_server_t *rsrv=NULL; redisc_reply_t *rpl; char c; - va_list ap; + va_list ap, ap2; va_start(ap, cmd); + va_copy(ap2, ap); rsrv = redisc_get_server(srv); if(srv==NULL || cmd==NULL || res==NULL) @@ -365,7 +366,7 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } if(redisc_reconnect_server(rsrv)==0) { - rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap); + rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap2); } else { LM_ERR("unable to reconnect to redis server: %.*s\n", srv->len, srv->s); cmd->s[cmd->len] = c; @@ -374,10 +375,12 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } cmd->s[cmd->len] = c; va_end(ap); + va_end(ap2); return 0; error_exec: va_end(ap); + va_end(ap2); return -1; }

11 years

git:4.0: modules/ndb_redis: solved bug in second call to redisvCommand.

by Vicente Hernando

Module: sip-router Branch: 4.0 Commit: 5ae035c420a5f30d862878825fac5ae9dbda53c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ae035c… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Thu Nov 28 12:16:05 2013 +0100 modules/ndb_redis: solved bug in second call to redisvCommand. (cherry picked from commit 52a34d269931f6f3a50b3fc532405624b9e38d23) --- modules/ndb_redis/redis_client.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 322cabe..b3417a6 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -316,9 +316,10 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) redisc_server_t *rsrv=NULL; redisc_reply_t *rpl; char c; - va_list ap; + va_list ap, ap2; va_start(ap, cmd); + va_copy(ap2, ap); rsrv = redisc_get_server(srv); if(srv==NULL || cmd==NULL || res==NULL) @@ -365,7 +366,7 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } if(redisc_reconnect_server(rsrv)==0) { - rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap); + rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap2); } else { LM_ERR("unable to reconnect to redis server: %.*s\n", srv->len, srv->s); cmd->s[cmd->len] = c; @@ -374,10 +375,12 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } cmd->s[cmd->len] = c; va_end(ap); + va_end(ap2); return 0; error_exec: va_end(ap); + va_end(ap2); return -1; }

11 years

git:master: modules/ndb_redis: solved bug in second call to redisvCommand.

by Vicente Hernando

Module: sip-router Branch: master Commit: 52a34d269931f6f3a50b3fc532405624b9e38d23 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=52a34d2… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Thu Nov 28 12:16:05 2013 +0100 modules/ndb_redis: solved bug in second call to redisvCommand. --- modules/ndb_redis/redis_client.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 0ba083a..6cf7f6f 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -316,9 +316,10 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) redisc_server_t *rsrv=NULL; redisc_reply_t *rpl; char c; - va_list ap; + va_list ap, ap2; va_start(ap, cmd); + va_copy(ap2, ap); rsrv = redisc_get_server(srv); if(srv==NULL || cmd==NULL || res==NULL) @@ -365,7 +366,7 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } if(redisc_reconnect_server(rsrv)==0) { - rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap); + rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap2); } else { LM_ERR("unable to reconnect to redis server: %.*s\n", srv->len, srv->s); cmd->s[cmd->len] = c; @@ -374,10 +375,12 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) } cmd->s[cmd->len] = c; va_end(ap); + va_end(ap2); return 0; error_exec: va_end(ap); + va_end(ap2); return -1; }

11 years

[tracker] Comment added: Crash in TCP Read on Kamailio 4.0.1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#364 - Crash in TCP Read on Kamailio 4.0.1 User who did this - Vitaliy Aleksandrov (Vitaliy) ---------- Done. Now my kamailio is built with MEMDBG=1. Should I enable memlog or memdbg log levels to get error messages about memory ? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=364#comment1182 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

[Redis module] Kamailio crashes in case of connection lost to redis server

by Tuan Viet Nguyen

Hello, I'll try to shut down the redis server to test the behavior of kamailio and it has crashed if a call is received and then cancelled. *1/The kamailio version is 4.0.4* *2/ Kamailio log * /usr/local/sbin/kamailio[25333]: ERROR: ndb_redis [redis_client.c:364]: redisc_exec(): Redis error: Server closed the connection /usr/local/sbin/kamailio[25361]: : <core> [pass_fd.c:293]: receive_fd(): ERROR: receive_fd: EOF on 13 /usr/local/sbin/kamailio[25328]: ALERT: <core> [main.c:788]: handle_sigs(): child process 25333 exited by a signal 11 /usr/local/sbin/kamailio[25328]: ALERT: <core> [main.c:791]: handle_sigs(): core was generated *3/ Interesting information in the core* #3 0x00007fc79412893d in redisvCommand (c=0x64657461, format=0x9 <Address 0x9 out of bounds>, ap=0x30, ap@entry=0x7fff0ff56aa8) at hiredis.c:1304 No locals. #4 0x00007fc794341713 in redisc_exec (srv=srv@entry=0x7fff0ff56be0, res=res@entry=0x7fff0ff56c00, cmd=cmd@entry=0x7fff0ff56bf0) at redis_client.c:368 rsrv = 0x7fc794565150 rpl = 0x7fc7946fab70 c = 0 '\000' ap = {{gp_offset = 48, fp_offset = 48, overflow_arg_area = 0x7fff0ff56bb0, reg_save_area = 0x7fff0ff56ac0}} __FUNCTION__ = "redisc_exec" #5 0x00007fc79433b781 in w_redis_cmd5 (msg=<optimized out>, ssrv=<optimized out>, scmd=<optimized out>, sargv1=<optimized out>, sargv2=0x7fc7946f7bf0 "p\243_\224\307\177", sres=0x7fc7946f7c50 " \253_\224\307\177") at ndb_redis_mod.c:250 s = {{s = 0x7fc7945fb300 "kamailio_redis", len = 14}, {s = 0x7fc7945f5f50 "PUBLISH %s %s", len = 13}, {s = 0x7fc7945fab20 "r", len = 1}} arg1 = {s = 0x7fc7945f5f80 "notification", len = 12} arg2 = { s = 0x7fc794551c60 "info XXX"..., len = 212} c1 = 0 '\000' c2 = 0 '\000' __FUNCTION__ = "w_redis_cmd5" I've found one of post that this issue has been fixed but it seems that it's always the case .. http://www.mail-archive.com/search?l=sr-users@lists.sip-router.org&q=subjec… Do you have any idea? Thank you

11 years

[tracker] Comment added: Crash in TCP Read on Kamailio 4.0.1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#364 - Crash in TCP Read on Kamailio 4.0.1 User who did this - Vitaliy Aleksandrov (Vitaliy) ---------- Done. Now my kamailio is built with MEMDBG=1. Should I enable memlog or memdbg log levels to get error messages about memory ? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=364#comment1181 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

← Newer
1
2
3
4
5
6
7
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2013