sr-dev October 2013

sr-dev@lists.kamailio.org

33 participants
254 discussions

git:master: modules/ims_charging: fixed failed reservation bug

by Richard Good

Module: sip-router Branch: master Commit: 328350a0d718990f8a87f25f8c12f1c85d61220f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=328350a… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Oct 30 12:50:04 2013 +0200 modules/ims_charging: fixed failed reservation bug - Reservation checks dialog integrity with h_entry < 0 - The hash that creates h_entry can return 0 - this check should be <= 0 --- modules/ims_charging/ro_timer.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c index 797b696..248e4db 100644 --- a/modules/ims_charging/ro_timer.c +++ b/modules/ims_charging/ro_timer.c @@ -402,7 +402,7 @@ void ro_session_ontimeout(struct ro_tl *tl) { update_stat(billed_secs, used_secs); if (ro_session->callid.s != NULL - && ro_session->dlg_h_entry > 0 + && ro_session->dlg_h_entry >= 0 && ro_session->dlg_h_id > 0 && ro_session->ro_session_id.s != NULL) {

10 years, 5 months

git:master: modules/ims_charging: code clean up, removed duplicate timer init and dlg bind

by Richard Good

Module: sip-router Branch: master Commit: a7037aad9963678347bf2b1c15c4994e95570f86 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a7037aa… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Oct 30 12:49:26 2013 +0200 modules/ims_charging: code clean up, removed duplicate timer init and dlg bind --- modules/ims_charging/mod.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/modules/ims_charging/mod.c b/modules/ims_charging/mod.c index 7c118e5..9e60c7d 100644 --- a/modules/ims_charging/mod.c +++ b/modules/ims_charging/mod.c @@ -241,22 +241,6 @@ static int mod_init(void) { return -1; } - /* init timer lists*/ - if (init_ro_timer(ro_session_ontimeout) != 0) { - LM_ERR("cannot init timer list\n"); - return -1; - } - - - /* bind to dialog module */ - if (!(load_dlg = (load_dlg_f) find_export("load_dlg", 0, 0))) { - LM_ERR("mod_init: can not import load_dlg. This module requires Kamailio dialog moduile.\n"); - } - - if (load_dlg(&dlgb) == -1) { - goto error; - } - /* register statistics */ if (register_module_stats(exports.name, charging_stats) != 0) { LM_ERR("failed to register core statistics\n");

10 years, 5 months

Upgrade v4.0.x to 4.1.0 guidelines

by Daniel-Constantin Mierla

Hello, this is a call for developers and community users to update the page collecting upgrade guidelines from current stable (4.0.x) to upcoming major release (4.1.0): - https://www.kamailio.org/wiki/install/upgrade/4.0.x-to-4.1.0 If you are aware of a change in the behaviour for some parameters, functions or statements, list them there. I added the sql statements for MySQL that will allow to get to the new database structure. Would be good to have the same for other popular sql servers (maybe postgres, sqlite ...). Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28 - more details about Kamailio trainings at http://www.asipto.com -

10 years, 5 months

git:master: modules/tm: code cleanup removed unused method faked_resp and free_faked_resp

by Richard Good

Module: sip-router Branch: master Commit: a3db949272db7dbda4fa5fd1ad68d23d56deacc0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3db949… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Wed Oct 30 09:15:51 2013 +0200 modules/tm: code cleanup removed unused method faked_resp and free_faked_resp --- modules/tm/t_reply.c | 53 -------------------------------------------------- modules/tm/t_reply.h | 3 -- 2 files changed, 0 insertions(+), 56 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index cac9ab4..562b583 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -806,59 +806,6 @@ static int _reply( struct cell *trans, struct sip_msg* p_msg, } } -int fake_resp(struct sip_msg *faked_resp, - struct sip_msg *shmem_msg, int extra_flags, struct ua_client *uac) -{ - /* on_failure_reply faked msg now copied from shmem msg (as opposed - * to zero-ing) -- more "read-only" actions (exec in particular) will - * work from reply_route as they will see msg->from, etc.; caution, - * rw actions may append some pkg stuff to msg, which will possibly be - * never released (shmem is released in a single block) */ - memcpy( faked_resp, shmem_msg, sizeof(struct sip_msg)); - - /* if we set msg_id to something different from current's message - * id, the first t_fork will properly clean new branch URIs */ - faked_resp->id=shmem_msg->id-1; - /* msg->parsed_uri_ok must be reset since msg_parsed_uri is - * not cloned (and cannot be cloned) */ - faked_resp->parsed_uri_ok = 0; - - faked_resp->msg_flags|=extra_flags; /* set the extra tm flags */ - - if(uac) setbflagsval(0, uac->branch_flags); - else setbflagsval(0, 0); - - return 1; -} - -void free_faked_resp(struct sip_msg *faked_resp, struct cell *t, int branch) -{ - struct hdr_field *hdr; - - /* free all types of lump that were added */ - del_nonshm_lump( &(faked_resp->add_rm) ); - del_nonshm_lump( &(faked_resp->body_lumps) ); - del_nonshm_lump_rpl( &(faked_resp->reply_lump) ); - - /* free header's parsed structures that were added */ - for( hdr=faked_resp->headers ; hdr ; hdr=hdr->next ) { - if ( hdr->parsed && hdr_allocs_parse(hdr) && - (hdr->parsed<(void*)t->uac[branch].reply)) { - DBG("DBG:free_faked_resp: removing hdr->parsed %d\n", - hdr->type); - - clean_hdr_field(hdr); - hdr->parsed = 0; - } - } - /* free parsed body added by failure handlers */ - if (faked_resp->body) { - if(faked_resp->body->free) - faked_resp->body->free(&faked_resp->body); - faked_resp->body = 0; - } -} - /** create or restore a "fake environment" for running a failure_route, * OR an "async environment" depending on is_async_value (0=std failure-faked, 1=async) * if msg is set -> it will fake the env. vars conforming with the msg; if NULL diff --git a/modules/tm/t_reply.h b/modules/tm/t_reply.h index b4d2b0f..a98473f 100644 --- a/modules/tm/t_reply.h +++ b/modules/tm/t_reply.h @@ -238,11 +238,8 @@ void rpc_reply(rpc_t* rpc, void* c); void faked_env( struct cell *t,struct sip_msg *msg, int is_async_env); int fake_req(struct sip_msg *faked_req, struct sip_msg *shmem_msg, int extra_flags, struct ua_client *uac); -int fake_resp(struct sip_msg *faked_req, - struct sip_msg *shmem_msg, int extra_flags, struct ua_client *uac); void free_faked_req(struct sip_msg *faked_req, struct cell *t); -void free_faked_resp(struct sip_msg *faked_req, struct cell *t, int branch); typedef int (*tget_picked_f)(void); int t_get_picked_branch(void);

10 years, 5 months

definition of mohqcalls table

by Daniel-Constantin Mierla

Hello, while trying to create mohqcalls it gives an error: ERROR 1064 (42000) at line 2: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'yyyy-mm-dd hh24:mi:ss')' NOT NULL, CONSTRAINT mohqcalls_idx UNIQUE (call_id)' at line 8 ERROR: Creating extra tables failed at mohqueue! The sqlscript is: CREATE TABLE mohqcalls ( id INT(10) UNSIGNED AUTO_INCREMENT PRIMARY KEY NOT NULL, mohq_id INT(10) UNSIGNED NOT NULL, call_id VARCHAR(100) NOT NULL, call_status INT UNSIGNED NOT NULL, call_from VARCHAR(100) NOT NULL, call_contact VARCHAR(100), call_time DATETIME DEFAULT 'to_date('','yyyy-mm-dd hh24:mi:ss')' NOT NULL, CONSTRAINT mohqcalls_idx UNIQUE (call_id) ); The problem is that the only very recent mysql versions support functions as default value. Another rather strange for my eye is the hh24 specifier for the hour, but that can be valid, I haven't checked the manual as I didn't get that far. Is the code relying on mysql populating the value with current date? If yes, it should be changed so that the value is given from the c code -- it is not a big coding effort and it will make it compatible with most of stable OS distributions out there. The the column definition can be just to constrain not to be a null value. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28 - more details about Kamailio trainings at http://www.asipto.com -

10 years, 5 months

git:master: kamctl: added new db tables in kamdbctl lists

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 15a14440f07f787501e116ab4901ab5a53668f4a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=15a1444… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 29 22:00:18 2013 +0100 kamctl: added new db tables in kamdbctl lists --- utils/kamctl/kamdbctl.base | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/utils/kamctl/kamdbctl.base b/utils/kamctl/kamdbctl.base index 364e4c2..c4e0307 100644 --- a/utils/kamctl/kamdbctl.base +++ b/utils/kamctl/kamdbctl.base @@ -36,11 +36,12 @@ INSTALL_DBUID_TABLES=${INSTALL_DBUID_TABLES:-ask} STANDARD_TABLES=${STANDARD_TABLES:-version acc dbaliases domain domain_attrs grp uri speed_dial lcr_gw lcr_rule lcr_rule_target pdt subscriber location location_attrs re_grp trusted address missed_calls - usr_preferences aliases silo dialog dialog_vars dispatcher dialplan} + usr_preferences aliases silo dialog dialog_vars dispatcher dialplan + acc_cdrs} EXTRA_TABLES=${EXTRA_TABLES:-imc_members imc_rooms cpl sip_trace domainpolicy carrierroute carrier_name domain_name carrierfailureroute userblacklist globalblacklist htable purplemap uacreg pl_pipes mtree mtrees - sca_subscriptions} + sca_subscriptions mohqcalls mohqueues} PRESENCE_TABLES=${PRESENCE_TABLES:-presentity active_watchers watchers xcap pua rls_presentity rls_watchers} DBUID_TABLES=${UID_TABLES:-uid_credentials uid_domain uid_domain_attrs @@ -80,7 +81,7 @@ STANDARD_MODULES=${STANDARD_MODULES:-standard acc lcr domain group PRESENCE_MODULES=${PRESENCE_MODULES:-presence rls} EXTRA_MODULES=${EXTRA_MODULES:-imc cpl siptrace domainpolicy carrierroute - userblacklist htable purple uac pipelimit mtree sca} + userblacklist htable purple uac pipelimit mtree sca mohqueue} DBUID_MODULES=${UID_MODULES:-uid_auth_db uid_avp_db uid_domain uid_gflags uid_uri_db}

10 years, 5 months

git:master: rtpproxy-ng: fix extraction of multipart SDP body

by Richard Fuchs

Module: sip-router Branch: master Commit: 2e033c85d2c66c47de15f355298012f012adb15c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2e033c8… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: Tue Oct 29 15:30:36 2013 -0400 rtpproxy-ng: fix extraction of multipart SDP body reported by: Jasmin Schnatterbeck --- modules/rtpproxy-ng/rtpproxy_funcs.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/rtpproxy-ng/rtpproxy_funcs.c b/modules/rtpproxy-ng/rtpproxy_funcs.c index b0d872b..1c283e5 100644 --- a/modules/rtpproxy-ng/rtpproxy_funcs.c +++ b/modules/rtpproxy-ng/rtpproxy_funcs.c @@ -257,6 +257,7 @@ int extract_body(struct sip_msg *msg, str *body ) } /* end of while */ if(c==1) { + while(rest && (*rest=='\r' || *rest=='\n')) rest++; body->s = rest; body->len = p2-rest; goto done;

10 years, 5 months

Kamailio Tech Admin Group

by Daniel-Constantin Mierla

Hello, being discussed during last Devel IRC Meeting, we are planing to build a Kamailio Project Technical Administration Group: https://www.kamailio.org/wiki/devel/irc-meetings/2013blog#technical_adminis… Its goal is to get a bunch of people that volunteer to do administration tasks for the project, such as: - helping with releases (e.g., patch backports, packaging, uploading files for download, etc) - doing sysadmin tasks for our servers (e.g., performing upgrades to wiki, web site, etc) - preparing technical decisions and doing them (e.g., what applications to use to make operations easier, cloning git repository to github, ...) From the devel meeting, so far we have Victor Seva, Fred Posner, Peter Dunkley and Olle Johansson. Existing people doing admin tasks will probably stay in (if they don't opt out): me, Elena-Ramona Modroiu, Henning Westerholt (owner of devel.kamailio.org hardware), Jan Janak (owner of sip-router.org hardware), Jesus Rodriguez and Oriol Capsada (owners of kamailio.org hardware). Requirements for candidates and other details: - volunteer to do the work, it is not a paid job - an existing record of activity within the project is a plus (e.g., developer, active mailing list member) - reply to the lists detailing where and how you can help - possibility to spend 1-4 hours a week for project administration (more is welcome, sometime is not necessary at all) Rewards: - you will be listed as part of project administration on the website - get to interact more with the project and the nice guys around it ;-) - more spam - admin list address will be public and the list open so everyone can send in case of critical situations (content/archive will be kept private) Note that we will try to build a group of an adequate size, thus not everyone willing to participate may get in (at least on the first phase). One criteria is to have skills that complement existing team knowledge. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28 - more details about Kamailio trainings at http://www.asipto.com -

10 years, 5 months

mediaproxy-ng: error generating SRTP session keys

by Juha Heinanen

i made a test call from rtp/avp baresip to rtp/savppf jjsip. at invite, i made offer Oct 29 16:45:28 rautu /usr/sbin/sip-proxy[24964]: INFO: ===== making rtpproxy_offer(co1SP+r) and at 200 ok i made answer: Oct 29 16:45:36 rautu /usr/sbin/sip-proxy[24959]: INFO: ===== making rtpproxy_answer(co2sp+r) when handling the answer, mediaproxy-ng wrote to syslog: Oct 29 16:45:36 rautu mediaproxy-ng[25548]: Error generating SRTP session keys still the call worked fine and thus generation of the session keys must have succeeded. why the error message? -- juha

10 years, 5 months

[tracker] Task opened: Dialog callback on pua_dialoginfo after restart

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Kristian Høgh (kfhdk) Attached to Project - sip-router Summary - Dialog callback on pua_dialoginfo after restart Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - After restarting kamailio, pua_dialoginfo doesn't get updated when active dialogs change status. I see the dialogs are read from the database, but when they receive eg. BYE the callback are not called. I use db_mode 0 in pua, but tried mode 2 with no luck. Should pua_dialoginfo register DLGCB_LOADED? More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2013